Re: Review Request 129294: Removed unwanted clear button while having inline clear option.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129294/ --- (Updated Oct. 31, 2016, 9:57 p.m.) Status -- This change has been

Re: Review Request 129294: Removed unwanted clear button while having inline clear option.

> On Oct. 31, 2016, 1:36 p.m., Marco Martin wrote: > > src/widgets/kurlrequesterdialog.cpp, line 51 > > > > > > remove whitespace > > Aniketh Girish wrote: > Hope the error was solved. I request someone to

Re: Review Request 129298: RFC: supporting dependencies on KPackage

> On Oct. 31, 2016, 6:19 p.m., Marco Martin wrote: > > autotests/data/testpackagesdep/metadata.json, line 14 > > > > > > if kns ends up using ids, maybe the server should be specified as well, > > as the id

[Differential] [Updated, 177 lines] D3188: Modified distance function to keep aspect ratio as close as possible

antlarr updated this revision to Diff 7764. antlarr added a comment. - Adjust the distance method to work with QUAD HD resolutions REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3188?vs=7737=7764 BRANCH Plasma/5.8 REVISION DETAIL

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 09:27:13 + Build duration: 2 min 16 sec CHANGE SET Revision

[konsole] [Bug 371068] yakuke / konsole with breeze color schema htop has some part unreadable

https://bugs.kde.org/show_bug.cgi?id=371068 Harald Sitter changed: What|Removed |Added Component|general |general CC|

[Differential] [Commented On] D3191: guard against dataengine missing

davidedmundson added a comment. So then checking isValid() is useless. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3191 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: davidedmundson,

[Differential] [Closed] D3175: Install desktop file name on X11 windows

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONd7b9319e8ba0: Install desktop file name on X11 windows (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3175?vs=7697=7771#toc REPOSITORY

[Differential] [Closed] D3114: [Session Model] Show new session entry only if we actually can

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf0e27ed71bcf: [Session Model] Show new session entry only if we actually can (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Review Request 129294: Removed unwanted clear button while having inline clear option.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129294/ --- Review request for Plasma. Bugs: 369377

[Differential] [Closed] D3177: Add support for desktopFileName provided by NETWinInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINb7bd5f9a09cb: Add support for desktopFileName provided by NETWinInfo (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3177?vs=7699=7776#toc REPOSITORY rKWIN KWin

Review Request 129296: Drop unused KConfig dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129296/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 528 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/528/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 12:49:40 + Build duration: 7 min 43 sec CHANGE SET Revision

Re: Review Request 129296: Drop unused KConfig dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129296/#review100435 --- Ship it! Ship It! - Marco Martin On Oct. 31, 2016,

[Differential] [Changed Subscribers] D3212: Support drags from Widget Explorer onto System Tray

broulik added inline comments. INLINE COMMENTS > main.qml:241 > +onDragEnter: { > +if (event.mimeData.formats.indexOf("text/x-plasmoidservicename") > < 0) { > +event.ignore(); Can you split that into a function so we then have onDragEnter: { if

Re: Review Request 129294: Removed unwanted clear button while having inline clear option.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129294/ --- (Updated Oct. 31, 2016, 1:13 p.m.) Review request for Plasma, David

Re: Review Request 129294: Removed unwanted clear button while having inline clear option.

> On Oct. 31, 2016, 12:36 p.m., Marco Martin wrote: > > src/widgets/kurlrequesterdialog.cpp, line 51 > > > > > > remove whitespace Hope the error was solved. I request someone to push the changes on my behalf.

[Differential] [Closed] D3131: Show full scrollbar only on mouse over

This revision was automatically updated to reflect the committed changes. mart marked 4 inline comments as done. Closed by commit rBREEZEe33206e4f74f: Show full scrollbar only on mouse over (authored by mart). REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE

Re: Review Request 129294: Removed unwanted clear button while having inline clear option.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129294/#review100436 --- Ship it! Ship It! - Aniketh Girish On Oct. 31, 2016,

Re: Review Request 129296: Drop unused KConfig dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129296/ --- (Updated Oct. 31, 2016, 1:02 p.m.) Status -- This change has been

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 09:27:13 + Build duration: 2 min 16 sec CHANGE SET Revision

[Differential] [Request, 47 lines] D3212: Support drags from Widget Explorer onto System Tray

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some users complain that applets do not behave like applets in the system tray, this is

[Differential] [Commented On] D3191: guard against dataengine missing

mart added a comment. In https://phabricator.kde.org/D3191#59338, @davidedmundson wrote: > So why is PluginLoader::loadDataEngine returning something? from https://bugs.kde.org/show_bug.cgi?id=371779 it looks like it's not? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION

Re: Review Request 129276: Make sure we're looking both for json and desktop metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129276/ --- (Updated Oct. 31, 2016, 11:06 a.m.) Status -- This change has been

Re: Review Request 129279: Make sure we're looking both for json and desktop metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129279/ --- (Updated Oct. 31, 2016, 12:08 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 527 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/527/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 11:07:08 + Build duration: 17 min CHANGE SET Revision

Re: Review Request 129294: Removed unwanted clear button while having inline clear option.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129294/#review100433 --- Fix it, then Ship it!

[Differential] [Request, 99 lines] D3211: Ensure that all Effects honour the grab roles correctly

graesslin created this revision. graesslin added reviewers: KWin, Plasma, broulik. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY When windows get added some effects grab the window and want to be the only one

[Differential] [Closed] D3119: Add way to hide/show cursor in Platform

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINe90e596864e8: Add way to hide/show cursor in Platform (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3119?vs=7561=7769 REVISION DETAIL

Re: Review Request 129276: Make sure we're looking both for json and desktop metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129276/#review100427 --- Ship it! Ship It! - Marco Martin On Oct. 28, 2016,

Re: Review Request 129278: Don't reparse the metadata file if it's already loaded

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129278/#review100426 --- Fix it, then Ship it! src/plasma/package.h (line 350)

[Differential] [Closed] D3120: [kwineffects] Add hide/show cursor to EffectsHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINbedc01b10868: [kwineffects] Add hide/show cursor to EffectsHandler (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3120?vs=7562=7770

Re: Review Request 129278: Don't reparse the metadata file if it's already loaded

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129278/ --- (Updated Oct. 31, 2016, 12:05 p.m.) Status -- This change has been

Re: Review Request 129279: Make sure we're looking both for json and desktop metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129279/#review100429 --- Ship it! Ship It! - Marco Martin On Oct. 28, 2016,

Re: Review Request 129103: Generate metadata.json file at build time

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129103/ --- (Updated Oct. 31, 2016, 11:10 a.m.) Status -- This change has been

[Differential] [Closed] D3154: Send a pointer leave when triggering a move resize

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN82054a406a64: Send a pointer leave when triggering a move resize (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3154?vs=7643=7768 REVISION

Minutes Monday Plasma Meeting

Plasma meeting (IRC), 31-10-2016 Present: notmart, kbroulik, d_ed, mgraesslin, apol, Sho_ notmart: last week was away a couple of days, so done a bit less, but: * working on an issue on js config of enabled context menu entries https://phabricator.kde.org/D3166 no consensus on that, *but* i

[Differential] [Commented On] D2962: [Breeze Window Decoration] Disable size grip for windows without border

broulik added a comment. Wtf phab REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2962 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta Cc:

[Differential] [Updated, 2,678 lines] D3086: Clean up KAppMenu

broulik retitled this revision from "RFC: Clean up KAppMenu" to "Clean up KAppMenu". broulik updated the test plan for this revision. broulik updated this revision to Diff 7784. broulik added a comment. - Cache atom to avoid roundtrip to the x server - Add "reconfigured" signal so

[Differential] [Updated] D2962: [Breeze Window Decoration] Disable size grip for windows without border

broulik added a reviewer: hpereiradacosta. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D2962 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta Cc: plasma-devel,

[Differential] [Commented On] D2962: [Breeze Window Decoration] Disable size grip for windows without border

broulik added a comment. Ping REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D2962 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #breeze, #plasma:_design, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Reopened] D2962: [Breeze Window Decoration] Disable size grip for windows without border

broulik reopened this revision. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D2962 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta Cc: plasma-devel, lesliezhai,

[Differential] [Closed] D2965: [Logout Greeter] Add QtQuickSettings

broulik closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2965 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, graesslin Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Closed] D2959: [KAccess] Set componentDisplayName

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPaad0a3e51d8e: [KAccess] Set componentDisplayName (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2959?vs=7142=7781

[Differential] [Closed] D2962: [Breeze Window Decoration] Disable size grip for windows without border

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf12a62830e81: [Logout Greeter] Add QtQuickSettings (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2962?vs=7151=7779#toc REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Updated] D2962: [Breeze Window Decoration] Disable size grip for windows without border

hpereiradacosta added a comment. -1 Since window border and the sizegrip are set in two different windows, disabling the sizegrip by default makes it completely undiscoverable. Also, though I agree that you can resize the windows from the borderless borders, 1/ as far as I remember

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

hpereiradacosta added a comment. Hi Marco, Two problems with the commit: 1/ it does not compile under kde4 (and we are still maintaining a kde4 and a kf5 version) breezestyle.cpp:6652:26: error: ‘const class QStyleOptionSlider’ has no member named ‘styleObject’ else if(

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

hpereiradacosta added a comment. In https://phabricator.kde.org/D3131#59715, @hpereiradacosta wrote: > Hi Marco, > Two problems with the commit: > 1/ it does not compile under kde4 (and we are still maintaining a kde4 and a kf5 version) > > breezestyle.cpp:6652:26: error:

[Differential] [Updated, 440 lines] D3089: Restore global menu support

broulik updated this revision to Diff 7785. broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Rebase on master - Honor global menu setting (only show button if is "in window decoration") and listen to kappmenu reconfigured signal REPOSITORY

[Differential] [Updated, 2 lines] D2962: [Breeze Window Decoration] Disable size grip for windows without border

broulik changed the repository for this revision from rPLASMAWORKSPACE Plasma Workspace to rBREEZE Breeze. broulik updated this revision to Diff 7780. broulik added a comment. Restore original diff... REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE

[Differential] [Request, 339 lines] D3216: WIP: Restore Menubar style config in application style

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This restores

[Differential] [Updated, 136 lines] D3210: make scrollbar size configurable

mart updated this revision to Diff 7783. mart added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. - Merge branch 'master' into arcpatch-D3210 REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE

[Differential] [Request, 12 lines] D3215: Simplify the window title passed in from the window system

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far KWin used the window title provided from the window directly without any sanitizing.

[Differential] [Commented On] D2962: [Breeze Window Decoration] Disable size grip for windows without border

hpereiradacosta added a comment. PS: I recal that "no borders" is not the default for the window decorations borders, so that the resize handle is indeed not visible by default. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D2962 EMAIL PREFERENCES

[Differential] [Commented On] D2962: [Breeze Window Decoration] Disable size grip for windows without border

broulik added a comment. Thanks, Hugo. I just checked and resizing outside of windows works when I disable compositing. On Wayland there were some changes/fixes going on there but I need to check.{quote}I recal that "no borders" is not the default for the window decorations borders, so

[Differential] [Closed] D3192: The combobox needs to be 2 pixels wider for contents to fit

antlarr closed this revision. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3192 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, #plasma:_design, hpereiradacosta Cc: hpereiradacosta, davidedmundson,

Re: Review Request 129298: RFC: supporting dependencies on KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/#review100442 --- yep, that's pretty much what i had in mind. it's early

[Differential] [Commented On] D3210: make scrollbar size configurable

alex-l added a comment. I'd like to have the options if possible. I don't think we will lose consistency. Other parts of Breeze provide options like buttons in title bar size, order etc. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3210 EMAIL PREFERENCES

[Differential] [Commented On] D3192: The combobox needs to be 2 pixels wider for contents to fit

hpereiradacosta added a comment. Hi, I am fine with the commit (especially since it fixes a bug which I have had no time to reproduce) Now since indeed 2 more pixels are needed on top of the ones from the MenuButton_IndicatorWidth, I would be inclided to just change size.rwidth() +=

Review Request 129298: RFC: supporting dependencies on KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

[Differential] [Accepted] D3191: guard against dataengine missing

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH arcpatch-D3191_1 REVISION DETAIL https://phabricator.kde.org/D3191 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D3192: The combobox needs to be 2 pixels wider for contents to fit

davidedmundson added inline comments. INLINE COMMENTS > breezestyle.cpp:2507 > // make sure there is enough height for the button > size.setHeight( qMax( size.height(), > int(Metrics::MenuButton_IndicatorWidth) ) ); > you're still basing the height off the

[Differential] [Updated, 442 lines] D3089: Restore global menu support

broulik updated this revision to Diff 7787. broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Don't blindly connect applicationMenu*Enabled*Changed to hasApplicationMenuChanged because the former is just the setting but a client doesn't

[Differential] [Updated, 2 lines] D3192: The combobox needs to be 2 pixels wider for contents to fit

antlarr updated this revision to Diff 7788. antlarr added a comment. - Increase width by MenuButton_IndicatorWidth+2 instead of adding a new enum entry REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3192?vs=7735=7788 BRANCH master REVISION DETAIL

[Differential] [Accepted] D3192: The combobox needs to be 2 pixels wider for contents to fit

hpereiradacosta accepted this revision. hpereiradacosta added a reviewer: hpereiradacosta. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks ! REPOSITORY rBREEZE Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D3192 EMAIL

[Differential] [Updated, 46 lines] D3191: guard against dataengine missing

mart updated this revision to Diff 7790. mart added a comment. - remove unneeded isValid() calls REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3191?vs=7733=7790 BRANCH arcpatch-D3191_1 REVISION DETAIL

[Differential] [Commented On] D3192: The combobox needs to be 2 pixels wider for contents to fit

antlarr added a comment. @hpereiradacosta thanks for reviewing this. Can you cherry-pick the commit for Plasma/5.8? REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3192 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr,

[Differential] [Updated] D3210: make scrollbar size configurable

hpereiradacosta added a comment. Hello Marco, Thanks for the patch. 1/ On the implementation side: I have tried so far to keep all the magic numbers for breeze (and oxygen) in Breeze::Metrics, because it makes maintainability much easier. I think it should stays so, and not become split

[Differential] [Abandoned] D2962: [Breeze Window Decoration] Disable size grip for windows without border

broulik abandoned this revision. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D2962 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta Cc: plasma-devel, lesliezhai,

[Differential] [Commented On] D3192: The combobox needs to be 2 pixels wider for contents to fit

antlarr added inline comments. INLINE COMMENTS > davidedmundson wrote in breezestyle.cpp:2507 > you're still basing the height off the MenuButton_IndicatorWidth which you're > otherwise not using > > Is that intentional? Good point, I didn't notice that it was using MenuButton_IndicatorWidth

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 529 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/529/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 31 Oct 2016 17:51:48 + Build duration: 7 min 29 sec CHANGE SET Revision