[Differential] [Commented On] D4153: Network manager configuration model is unreadable

jgrulich added a comment. Icons problem solved F2049814: kcm.patch . Can you please test this patch? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D4153 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 06:53:35 + Build duration: 8 min 50 sec CHANGE SET Revision

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/#review102056 --- The current/old version uses "connectSource(source)" to add

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

jsalatas added a comment. BTW: I don't know how I did it but while testing it, at some point configuration didn't open at all and plasma produced the following error "kcmshell5 with modules ' "org.kde.kcmshell_kcm_networkmanagement.desktop" ' is already running." I cannot reproduce

Re: Plasma Sprint discussion planning

On Sunday 15 January 2017 21:36:32 Martin Gräßlin wrote: > Just giving an idea: Some parts where KWin is responsible for on > Wayland, it could also become responsible on X11 and take over the part > of whatever component provided it before. E.g. KWin could manage the > keyboard layout on X11 as

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

jsalatas added a comment. In https://phabricator.kde.org/D4153#77549, @jgrulich wrote: > Icons problem solved F2049814: kcm.patch . Can you please test this patch? Perfect :) REPOSITORY R116 Plasma Network Management Applet REVISION

[Differential] [Abandoned] D4153: Network manager configuration model is unreadable

jsalatas abandoned this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D4153 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #plasma, #plasma:_design, jgrulich Cc: plasma-devel,

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

jgrulich added a comment. Here F2049744: kcm.patch is patch using my approach, but there is still problem with icons. Given that icons are only available from plasma theme and we don't use colors from plasma theme anymore, then icons won't be visible

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 06:54:06 + Build duration: 8 min 29 sec CHANGE SET Revision

[Differential] [Accepted] D4143: Follow theme in taskmanager tooltip media controls background

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4143 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 110 lines] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

broulik created this revision. broulik added reviewers: Plasma, dfaure. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Files in desktop:/ are local

Re: remember to merge Plasma/5.8 into Plasma/5.9 and master

On 01/16/2017 09:40 PM, Marco Martin wrote: > On Monday 16 January 2017 12:25:33 Jonathan Riddell wrote: >> At the meeting today we discussed merging. Please remember to merge fixes >> in Plasma/5.8 into Plasma/5.9 branches and into master. >> >> I've now scheduled in doing this the day before

Re: remember to merge Plasma/5.8 into Plasma/5.9 and master

On Monday 16 January 2017 12:25:33 Jonathan Riddell wrote: > At the meeting today we discussed merging. Please remember to merge fixes > in Plasma/5.8 into Plasma/5.9 branches and into master. > > I've now scheduled in doing this the day before 5.9.x releases but obviously > it's much less error

[Differential] [Abandoned] D4093: Initialise array variable

davidedmundson abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4093 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, hein Cc: hein, plasma-devel, lesliezhai, ali-mohamed,

Re: Requirement of SSE2

On zaterdag 14 januari 2017 09:39:10 CET Martin Gräßlin wrote: > lately I got a few crash reports indicating that QtQuick requires SSE2: > "This program requires an X86 processor that supports SSE2 extension, at > least a Pentium 4 or newer" > > (e.g. 374023). > > Should we add this as a minimum

[Differential] [Commented On] D4140: Rework playing of volume feedback

broulik added a comment. Aren't there applications like Skype that mess with volume settings, wouldn't that cause annoying sounds everytime? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4140 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 10:48:26 + Build duration: 5 min 56 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 10:49:35 + Build duration: 20 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 559 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/559/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 11:53:01 + Build duration: 23 min CHANGE SET Revision

[Differential] [Closed] D4143: Follow theme in taskmanager tooltip media controls background

This revision was automatically updated to reflect the committed changes. Closed by commit R119:39537d10fa69: Follow theme in taskmanager tooltip media controls background (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4145: Fix calling KWindowSystem::windowType without fetching the type

This revision was automatically updated to reflect the committed changes. Closed by commit R120:375ce8932ad3: Fix calling KWindowSystem::windowType without fetching the type (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 11 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 11:27:09 + Build duration: 2 min 50 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 558 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/558/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 11:31:44 + Build duration: 9 min 17 sec CHANGE SET Revision

Minutes Monday Plasma Meeting

The minutes of today's meeting. -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 16-01-2017 Present: Sho, d_ed, notmart, bshah, kbroulik, sebas Sho: * [General] Was able to clean out my fixes-and-polish queue neatly in 5.9 freeze week, will now spend more time on

[Differential] [Request, 6 lines] D4156: sort alphabetically category list

mart created this revision. mart added reviewers: Plasma, leinir. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY sort the category list by their visible name prefer sorting by displayName if

remember to merge Plasma/5.8 into Plasma/5.9 and master

At the meeting today we discussed merging. Please remember to merge fixes in Plasma/5.8 into Plasma/5.9 branches and into master. I've now scheduled in doing this the day before 5.9.x releases but obviously it's much less error prone if you do it when you first commit. Jonathan

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 13 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 12:05:01 + Build duration: 7 min 52 sec CHANGE SET Revision

Re: Requirement of SSE2

On Saturday 14 January 2017 09:39:10 Martin Gräßlin wrote: > Should we add this as a minimum requirement to our release announcement > and also inform distributions about it? SSE2 Got introduced with Intel > Pentium 4 (2001). AMD added support for it in 2003. This means hardware > older than 13-14

[Differential] [Closed] D3992: Sync kicker tooltip icon to config setting

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f37c2ea93dd0: Sync kicker tooltip icon to config setting (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3992?vs=9801=10219

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 12 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 11:37:36 + Build duration: 18 min CHANGE SET Revision

[Differential] [Request, 3 lines] D4158: Don't load menu when switching window focus to the desktop

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes the appmenu plasmoid applet on the desktop work. REPOSITORY R120 Plasma

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 560 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/560/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 13:01:09 + Build duration: 2 min 23 sec CHANGE SET Revision

[Differential] [Accepted] D4159: Don't hide applet when it needs configuring

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4159 EMAIL PREFERENCES

[Differential] [Updated, 4 lines] D4159: Don't hide applet when it needs configuring

davidedmundson updated this revision to Diff 10234. davidedmundson added a comment. change logic REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4159?vs=10230=10234 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4159 AFFECTED

[Differential] [Closed] D4158: Don't load menu when switching window focus to the desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R120:44d6302f7159: Don't load menu when switching window focus to the desktop (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4159: Don't hide applet when it needs configuring

This revision was automatically updated to reflect the committed changes. Closed by commit R120:68abbe669342: Don't hide applet when it needs configuring (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4159?vs=10234=10236

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 13:30:33 + Build duration: 3 min 47 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 13:35:51 + Build duration: 3 min 12 sec CHANGE SET Revision

[Differential] [Request, 4 lines] D4160: [User Switcher] Just use Row's implicitWidth instead of calculating it manually

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I don't know what I was thinking when I

[Differential] [Updated] D4103: Support spring-loading on drag hover and drops into preview popups.

broulik added a comment. In list view mode I now get glitched out popups appearing (probably shouldn't do anything in list view mode, or navigate to the folder like Dolphin, but not spawn popups that span the entire screen width) and the index is off by one there, too. Icon mode is

[Differential] [Updated, 4 lines] D4158: Don't load menu when switching window focus to the desktop

davidedmundson updated this revision to Diff 10229. davidedmundson added a comment. Correct diff REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4158?vs=10228=10229 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4158 AFFECTED

[Differential] [Request, 3 lines] D4159: Don't hide applet when it needs configuring

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4159

[Differential] [Accepted] D4158: Don't load menu when switching window focus to the desktop

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4158 EMAIL PREFERENCES

[Differential] [Closed] D4160: [User Switcher] Just use Row's implicitWidth instead of calculating it manually

This revision was automatically updated to reflect the committed changes. Closed by commit R114:dc6948230f1f: [User Switcher] Just use Row's implicitWidth instead of calculating it manually (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 14 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 12:43:12 + Build duration: 19 min CHANGE SET Revision

[Differential] [Accepted] D4160: [User Switcher] Just use Row's implicitWidth instead of calculating it manually

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D4160 EMAIL PREFERENCES

[Differential] [Request, 40 lines] D4161: Signal which menu has updated in libdbusmenu-qt

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Then update appet, SNI, and appmenu appropriately which are only care about the root menu.

[Differential] [Request, 8 lines] D4163: pre-load the first layer of sub menus

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We still call aboutToShow on them inside libdbusmenu-qt and update the menu whilst it's

[Differential] [Accepted] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4157 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

dfaure added inline comments. INLINE COMMENTS > iconapplet.cpp:159 > > -// TODO use kio stat job which also works for remote stuff > -QMimeDatabase db; > -const QMimeType mimeType = db.mimeTypeForUrl(m_url); > +// TODO use kio stat job which also works for remote stuff > +

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

dfaure added inline comments. INLINE COMMENTS > iconapplet.cpp:189 > +}); > +statJob->start(); > } You don't need to start() KIO jobs, they start automatically. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4157 EMAIL PREFERENCES

[Differential] [Accepted] D4161: Signal which menu has updated in libdbusmenu-qt

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Hilft's nix, schad's nix REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4161 EMAIL PREFERENCES

[Differential] [Updated] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

dfaure added a comment. Much nicer indeed. +2 on the KIO part. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4157 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart, dfaure Cc: plasma-devel,

[Differential] [Changed Subscribers] D4156: sort alphabetically category list

broulik added inline comments. INLINE COMMENTS > atticaprovider.cpp:137 > } > +std::sort(categoryMetadataList.begin(), categoryMetadataList.end(), > [](const AtticaProvider::CategoryMetadata , const > AtticaProvider::CategoryMetadata ) -> bool { > +const QString

Re: Plasma Sprint discussion planning

Am 2017-01-16 10:48, schrieb Marco Martin: On Sunday 15 January 2017 21:36:32 Martin Gräßlin wrote: Just giving an idea: Some parts where KWin is responsible for on Wayland, it could also become responsible on X11 and take over the part of whatever component provided it before. E.g. KWin

[Differential] [Updated, 159 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

broulik updated this revision to Diff 10253. broulik added a comment. - Don't bail out just because stat job failed, otherwise when user manually changes Link to a non-existing file it locks him out of the icon applet so he can never correct this mistake - Clean up a bit It will now

[Differential] [Request, 62 lines] D4168: Move X11 specific KGlobalAccel handling into the x11-standalone platform

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY InputRedirection has a workaround to add a connect on a QAction which is used for a global

[Differential] [Request, 43 lines] D4165: Drop KWin's internal global shortcut handling

graesslin created this revision. graesslin added reviewers: Plasma, KWin. Restricted Application added a project: KWin. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY During the Wayland porting a KWin internal global shortcut handling got implemented prior to the

[Differential] [Accepted] D4166: Fix pixel alignment and non-standard height in QuickShare delegate

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4166 EMAIL PREFERENCES

[Differential] [Closed] D4166: Fix pixel alignment and non-standard height in QuickShare delegate

This revision was automatically updated to reflect the committed changes. Closed by commit R114:407168327b93: Fix pixel alignment and non-standard height in QuickShare delegate (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

[Differential] [Request, 4 lines] D4166: Fix pixel alignment and non-standard height in QuickShare delegate

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The current code had height: button.height * 1.2 then centered the button within it, which

Plasma 5.9 voice over text

Hi, Here is a script/voice over text for Plasma 5.9 video. It is heavily based on Plasma 5.9 beta announcement. Please check it for grammar, typos etc. https://notes.kde.org/p/Plasma_5.9_script Cheers, Łukasz Sawicki

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 15 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 16:35:27 + Build duration: 10 min CHANGE SET Revision

[Differential] [Updated, 170 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

broulik retitled this revision from "[Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile" to "[Icon Applet] Use KIO::statJob to work with remote URLs". broulik updated the summary for this revision. broulik updated the test plan for this revision. broulik updated this

[Differential] [Updated] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4157 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 561 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/561/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 16:37:17 + Build duration: 21 min CHANGE SET Revision

[Differential] [Updated] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4157 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated, 146 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

broulik updated this revision to Diff 10247. broulik added a comment. - Just use setBusy() in the Plasma::Applet we inherit from REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4157?vs=10246=10247 REVISION DETAIL

[Differential] [Accepted] D4163: pre-load the first layer of sub menus

broulik accepted this revision. broulik added a reviewer: broulik. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > appmenumodel.cpp:238 > +//cache first layer of sub menus, which we'll be popping up > +for(QAction *a:

[Differential] [Commented On] D4163: pre-load the first layer of sub menus

broulik added a comment. Same could be done in decoration appmenu REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4163 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma,