D6164: Make shadows work for windows 100% width or height

2017-06-16 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > mart wrote in utils.h:205 > not sure about calling a local function qMax3, it would suggest it comes from > qt. > > maybe utilsMax3 or something without q make it a variadic template function and call it maxOfAll REPOSITORY R108 KWin

D6215: Make sure size is final after showEvent

2017-06-16 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6215#116837, @mart wrote: > with patch applied on plasma-framework and notifications applet from master all seems to still work ok. > > so, if i understand correctly, to try with notifiaction applet with your

D6215: Make sure size is final after showEvent

2017-06-16 Thread Marco Martin
mart added a comment. with patch applied on plasma-framework and notifications applet from master all seems to still work ok. so, if i understand correctly, to try with notifiaction applet with your https://phabricator.kde.org/D6237 on top, and this patch that keeps updating the

[Powerdevil] [Bug 381271] Music started on suspend

2017-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=381271 Nate Graham changed: What|Removed |Added CC||k...@privat.broulik.de,

D6246: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it no longer does in Qt 5.8+)

2017-06-16 Thread Eike Hein
hein created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY QQuickWindow::sendEvent in Qt 5.7 and older had the following code to deliver QEvent::UngrabMouse by calling

[kio-extras] [Bug 371278] Dolphin crashed when opening smb location

2017-06-16 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=371278 Elvis Angelaccio changed: What|Removed |Added CC|

D6247: Fix clicking outside of preview popups to dismiss them corrupting mouse state

2017-06-16 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY As a result of refactorings in 5.10, hoveredItem may not reflect the true cursor position when preview popups become involved. When inter- acting with an item's associated preview popup, it's still

[Powerdevil] [Bug 381271] New: Music started on suspend

2017-06-16 Thread Arthur Schiwon
https://bugs.kde.org/show_bug.cgi?id=381271 Bug ID: 381271 Summary: Music started on suspend Product: Powerdevil Version: 5.10.2 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

Re: kdereview: qqc2-desktop-style

2017-06-16 Thread Marco Martin
On Thu, May 18, 2017 at 11:08 AM, Marco Martin wrote: > Hi all, > I'm anouncing the QtQuickControls2 desktop style in kdereview, repo name is > qqc2-desktop-style > > It is intended to be a small style written in QML for QtQuickControls2 that is > intended to be used by default

[Powerdevil] [Bug 381199] Broken brightness control with kernel module (ex. nvidia-bl)

2017-06-16 Thread Jan Kundrát
https://bugs.kde.org/show_bug.cgi?id=381199 --- Comment #5 from Jan Kundrát --- Just FYI and as a random data point, my T460s with intel_backlight which once again has a type = raw contains "enabled" in its device/enabled property. Despite that, I was too hitting this bug.

D6237: Avoid resize on showing notificaton item

2017-06-16 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The notification dialog height is based on the implicit height of mainLayout. Main layout would shift depending on whether we were

D6237: Avoid resize on showing notificaton item

2017-06-16 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6237 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D6215: Make sure size is final after showEvent

2017-06-16 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Ok so in summary there's two changes here: - updating our window geometry regardless of whether we're visible or not Makes total sense, there's no

D6215: Make sure size is final after showEvent

2017-06-16 Thread David Edmundson
davidedmundson added a comment. Relavent follow up to the unanswer question from yesterday: why does the implicit height change when we show it It's from some code in NotificationItem.qml ColumnLayout { id: mainLayout anchors { left:

[Breeze] [Bug 381288] Breeze could use higher-contrast text by default (tweaked color scheme attached)

2017-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=381288 --- Comment #2 from Nate Graham --- Created attachment 106128 --> https://bugs.kde.org/attachment.cgi?id=106128=edit Breeze with higher-contrast text -- You are receiving this mail because: You are the assignee for the bug.

D5961: PoC: Generic adoption of KUserFeedback for Discover

2017-06-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 15498. apol added a comment. - Expose the applicationSourceName to KUserFeedback REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=15366=15498 BRANCH kuserfeedback REVISION DETAIL

D5961: PoC: Generic adoption of KUserFeedback for Discover

2017-06-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 15500. apol added a comment. - Include a KUserFeedback schema file REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=15498=15500 BRANCH kuserfeedback REVISION DETAIL

[Breeze] [Bug 381288] New: Breeze could use higher-contrast text by default (tweaked color scheme attached)

2017-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=381288 Bug ID: 381288 Summary: Breeze could use higher-contrast text by default (tweaked color scheme attached) Product: Breeze Version: 5.9.95 Platform: Other OS: Linux

[Breeze] [Bug 381288] Breeze could use higher-contrast text by default (tweaked color scheme attached)

2017-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=381288 --- Comment #1 from Nate Graham --- Created attachment 106127 --> https://bugs.kde.org/attachment.cgi?id=106127=edit Breeze original low-contrast text -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 381288] Breeze could use higher-contrast text by default (tweaked color scheme attached)

2017-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=381288 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com ---