Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130163/ --- (Updated June 20, 2017, 5:58 a.m.) Status -- This change has been

D6274: Use AbstractClient instead of Client in placement

This revision was automatically updated to reflect the committed changes. Closed by commit R108:92207be904aa: Use AbstractClient instead of Client in placement (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6274?vs=15587=15619 REVISION

D6275: Make Workspace::switchWindow operate on AbstractClient

This revision was automatically updated to reflect the committed changes. Closed by commit R108:763fbf5fafd0: Make Workspace::switchWindow operate on AbstractClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6275?vs=15588=15620

D6257: Fix switch desktop through edge when moving window

This revision was automatically updated to reflect the committed changes. Closed by commit R108:c45e165514ec: Fix switch desktop through edge when moving window (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6257?vs=15543=15616 REVISION

D6264: Fix switch desktop on screenedge while resizing a Wayland window

This revision was automatically updated to reflect the committed changes. Closed by commit R108:7a3c29261226: Fix switch desktop on screenedge while resizing a Wayland window (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6260: Better handle cases when the xkb keymap fails to be created

This revision was automatically updated to reflect the committed changes. Closed by commit R108:0df09a8cbbb1: Better handle cases when the xkb keymap fails to be created (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6260?vs=15551=15614

D6258: Workaround Qt regression of no longer delivering events for the root window

This revision was automatically updated to reflect the committed changes. Closed by commit R108:a6dee74ee455: Workaround Qt regression of no longer delivering events for the root window (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6273: [tabbox] Fix casts to Client where it should be AbstractClient

This revision was automatically updated to reflect the committed changes. Closed by commit R108:3b9ccc65a3a8: [tabbox] Fix casts to Client where it should be AbstractClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6215: Make sure size is final after showEvent

mart added a comment. In https://phabricator.kde.org/D6215#117498, @davidedmundson wrote: > > this will work only when the Dialog' version of setvisible is called, > > So this will break released Plasma? no, it just means that who calls show() or the wrong setVisible() would

Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130163/#review103347 --- We are currently in the process of fading out reviewboard.

D6216: simplify positioning code

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > NotificationItem.qml:33 > width: parent.width > -implicitHeight: Math.max(appIconItem.visible || imageItem.visible ? >

D6216: simplify positioning code

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in NotificationItem.qml:33 > If in https://phabricator.kde.org/D6215 you've got a mainItem->setVisible() > before the showEvent because that fixes what this is doing. > > If that's the case, why do we still need these

D6215: Make sure size is final after showEvent

davidedmundson added a comment. > this will work only when the Dialog' version of setvisible is called, So this will break released Plasma? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas,

D6273: [tabbox] Fix casts to Client where it should be AbstractClient

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY A few areas in TabBox perform casts from Toplevel to Client. By casting to Client instead of AbstractClient the Wayland windows are

Minutes Monday Plasma Meeting

Salut, Meeting minutes of today, attached! Cheers, -- sebas http://vizZzion.org ⦿http://www.kde.org Plasma Weekly Meeting 19-7-2017 Present: Sho, mart, d_ed, kbroulik Sho: * I'm currently focused on fixing various 5.10 regressions which will probably take another few days this

D6275: Make Workspace::switchWindow operate on AbstractClient

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH switch-window-wayland REVISION DETAIL https://phabricator.kde.org/D6275 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff,

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

https://bugs.kde.org/show_bug.cgi?id=379680 --- Comment #6 from Germano Massullo --- A few logs, while trying to browse a Samsung Galaxy S5 Note: VID and PID have been edited to avoid any privacy problem $ Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models

D6274: Use AbstractClient instead of Client in placement

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There were a few places where we still used Client instead of AbstractClient. By changing this the placement also works for Wayland

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added a comment. What behaviour should the folder widget use: 1. Old behaviour: https://streamable.com/5gk5p 2. Current behaviour with the patch: https://streamable.com/qs4s4 3. Combination of the two, when "arranged in rows", it should stretch to fill the width, but keep a

D6267: Use appstream-qt insted of glib based one

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! Please merge to master when the new API is available. REPOSITORY R134 Discover Software Store BRANCH appstream-qt REVISION DETAIL https://phabricator.kde.org/D6267 To:

D6273: [tabbox] Fix casts to Client where it should be AbstractClient

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH fix-tabbox-wayland-client-5.10 REVISION DETAIL https://phabricator.kde.org/D6273 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, spstarr,

D6275: Make Workspace::switchWindow operate on AbstractClient

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY By using AbstractClient instead of Client the method works also for Wayland windows. REPOSITORY R108 KWin BRANCH

D6274: Use AbstractClient instead of Client in placement

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH placement-fix-abstract-client-casts REVISION DETAIL https://phabricator.kde.org/D6274 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot,

D6274: Use AbstractClient instead of Client in placement

mart accepted this revision. REPOSITORY R108 KWin BRANCH placement-fix-abstract-client-casts REVISION DETAIL https://phabricator.kde.org/D6274 To: graesslin, #kwin, #plasma, davidedmundson, mart Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening,

D6260: Better handle cases when the xkb keymap fails to be created

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH safety-checks-xkbcommon-5.10 REVISION DETAIL https://phabricator.kde.org/D6260 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai,

D6264: Fix switch desktop on screenedge while resizing a Wayland window

mart accepted this revision. This revision is now accepted and ready to land. BRANCH fix-screenedge-wayland-window-resize-5.10 REVISION DETAIL https://phabricator.kde.org/D6264 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

[Breeze] [Bug 381407] New: SDDM's Breeze theme should have a prettier background than just a flat blue color

https://bugs.kde.org/show_bug.cgi?id=381407 Bug ID: 381407 Summary: SDDM's Breeze theme should have a prettier background than just a flat blue color Product: Breeze Version: 5.9.4 Platform: Ubuntu Packages

[Breeze] [Bug 381407] SDDM's Breeze theme should have a prettier background than just a flat blue color

https://bugs.kde.org/show_bug.cgi?id=381407 --- Comment #1 from Nate Graham --- By chance, I happened to stumble on a similar comment made by a KDE-using Redditor today (not me): https://www.reddit.com/r/kde/comments/6i4uf0/has_anyone_tried_kde_on_new_debian_9/dj40lw3/

[Powerdevil] [Bug 381387] display brightness is increased when come back from closed lid

https://bugs.kde.org/show_bug.cgi?id=381387 Christoph Feck changed: What|Removed |Added Component|general |general

Re: [Kirigami] Support for stacked page rows (a proposal)

On Sunday 18 June 2017 21:39:36 kelvin.atomblen...@riseup.net wrote: > I hope this idea will somehow be introduced into Kirigami, if not the > way I proposed (activities) then some other. It doesn't change > Kirigami's design principles but rather extends it and makes it more > flexible. Hi, I

D6282: Context: Return early from connectToDaemon when already connected

This revision was automatically updated to reflect the committed changes. Closed by commit R115:70f090314296: Context: Return early from connectToDaemon when already connected (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

https://bugs.kde.org/show_bug.cgi?id=379680 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org

D6282: Context: Return early from connectToDaemon when already connected

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY connectToDaemon is called after 1 second delay when PulseAudio context becomes invalid, but it is also called when PulseAudio service

D6282: Context: Return early from connectToDaemon when already connected

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6282 To: drosca, #plasma, apol, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff,

D6133: Make --test mode run without spawning kactivitymanagerd or restarting

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6133 To: davidedmundson, #plasma, hein Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,

D6216: simplify positioning code

mart updated this revision to Diff 15568. mart added a comment. - don't depend from visibility REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6216?vs=15464=15568 BRANCH arcpatch-D6216 REVISION DETAIL https://phabricator.kde.org/D6216

D6237: Avoid resize on showing notificaton item

davidedmundson abandoned this revision. davidedmundson added a comment. Code is now in https://phabricator.kde.org/D6216 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6237 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff,

D6247: Fix clicking outside of preview popups to dismiss them corrupting mouse state

hein added inline comments. INLINE COMMENTS > broulik wrote in FolderItemDelegate.qml:119 > This check is now superfluous as it's also done in `closePopup()` Yeah, but it's minutely faster to check this than do a function call (and the dialog not being open is the common case), it's a little

D6215: Make sure size is final after showEvent

mart added a comment. this is how it looks under wayland, keeping the visibility change of the mainitem in plasma-framework and your patch in the notifications applet F3787256: Spectacle.Vd3087.png REPOSITORY R242 Plasma Framework (Library) REVISION

D6215: Make sure size is final after showEvent

mart added a comment. with this, that removes most of the properties depending from visible, i usually get properly sized notifications, tough every now and then the size still fails and a reposition is always visible right after the notification appears https://pastebin.com/ia8nLGiw

D6267: Use appstream-qt insted of glib based one

jgrulich created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently appstream-qt doesn't provide all necessary stuff we need to use and that's why we used for part of the code glib based appstream

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D6231 To: hein, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,

D6133: Make --test mode run without spawning kactivitymanagerd or restarting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5bd54084cf41: Make --test mode run without spawning kactivitymanagerd (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130163/ --- Review request for Plasma. Repository: kwin Description ---

D6215: Make sure size is final after showEvent

mart added a comment. it's maybe due to the layout of actions buttons that changes (in the notification applet, populatepopup) but this (columnLayout computed height) doesn't really have effect until it's visible. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D6215: Make sure size is final after showEvent

mart added a comment. In https://phabricator.kde.org/D6215#117370, @mart wrote: > it's maybe due to the layout of actions buttons that changes (in the notification applet, populatepopup) but this (columnLayout computed height) doesn't really have effect until it's visible. in

D6186: Implement software cursor in OpenGL backend

Kanedias added inline comments. INLINE COMMENTS > luebking wrote in scene_opengl.cpp:713 > You still update the cursor texture with every paint() - there should be no > need to hook this signal. > Actually, the patch got much worse: > > a) you're fetching the image and reset the texture with

D1231: Add Remote Access interface to KWayland

davidedmundson added a comment. We don't want or need to go via the QPA on the server side. The wayland specific output management is in the DRM plugin, your code is in the DRM plugin. It should be simple. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To:

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

This revision was automatically updated to reflect the committed changes. Closed by commit R119:84300b516b79: Fix DND onto Task Manager for groups, group dialog scrollbar (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6231?vs=15485=15572#toc REPOSITORY R119 Plasma

D6186: Implement software cursor in OpenGL backend

luebking added inline comments. INLINE COMMENTS > Kanedias wrote in scene_opengl.cpp:713 > How come! There's a condition on !m_cursorTexture for that, no? Or is > Cursor::cursorChanged itself called on every paint? Sorry, I missed that the "if (!m_cursorTexture) {" condition still covers these

D6246: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it no longer does in Qt 5.8+)

This revision was automatically updated to reflect the committed changes. Closed by commit R296:fd4d41bd65fd: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it… (authored by hein). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D6247: Fix clicking outside of preview popups to dismiss them corrupting mouse state

broulik added a comment. Hover state is reset fine but now the action buttons don't reappear after the popup is closed unless I start dragging the folder. Just selecting and unselecting does not help, I really need to start a drag (perhaps you break some binding in the delegate?) 1.)

D5961: PoC: Generic adoption of KUserFeedback for Discover

vkrause added inline comments. INLINE COMMENTS > CMakeLists.txt:30 > > +find_package(UserFeedback) > + Hm, looks like I forgot to rename this to KUserFeedback... Should probably done to be consistent with naming elsewhere. I'll look into it, and sorry for yet another SC change. >

D6216: simplify positioning code

mart updated this revision to Diff 15578. mart added a comment. - make sure Dialog::setHeight is used disable height binding when notifications are repopulated REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6216?vs=15568=15578 BRANCH

D6215: Make sure size is final after showEvent

mart updated this revision to Diff 15579. mart added a comment. hide again mainitem when not visible show it in setVisible, that is before show. this will work only when the Dialog' version of setvisible is called, so must be paid attention when using dialog directly from C++, but