Notes from Guadec Wayland BOF

I went to Guadec last week, wearing my Gnome hoodie to slip in undiscovered. I made some notes from their wayland BOF. Everyone was super helpful and awesome, some of these comments aren't necessarily directly relevant to us, some are pre-warnings about some changes that might be coming. --- The

D7177: Do not refresh appstream metadata everytime

jgrulich created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Refresh appstream metadata only in case they have never been refreshed or when the cache is older than 6 hours. REPOSITORY R134 Discove

D7177: Do not refresh appstream metadata everytime

jgrulich added a reviewer: apol. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7177 To: jgrulich, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7086: [Wallpaper Configuration] Hide Get New Stuff if disabled by KIOSK

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bd468dced14e: [Wallpaper Configuration] Hide Get New Stuff if disabled by KIOSK (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7086?

D7073: [Wallpaper Configuration] Make Get New Stuff dialog modal to config window

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3558afa9579e: [Wallpaper Configuration] Make Get New Stuff dialog modal to config window (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7073?vs=17567&id=17811#toc REPOSI

D6047: Support XDG v6

davidedmundson updated this revision to Diff 17813. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Unbind global Add a test for transientFor REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D7178: Fallback for cached icons

jgrulich created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Apparently some appstream metadata might have icon information in form of org.gnome.gedit instead of 128x128/org.gnome.gedit which lea

D7092: Keep fallback icon updated

This revision was automatically updated to reflect the committed changes. Closed by commit R120:75b7f5c2fa63: Keep fallback icon updated (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7092?vs=17739&id=17818 REVISION DETAIL https

D7139: Fix QSortFilterProxyModelPrivate::updateChildrenMapping crash in libtaskmanager

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3990ec235810: Fix QSortFilterProxyModelPrivate::updateChildrenMapping crash in libtaskmanager (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kd

D7178: Fallback for cached icons

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH appstream-icons REVISION DETAIL https://phabricator.kde.org/D7178 To: jgrulich, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7177: Do not refresh appstream metadata everytime

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH appstream-refreshing REVISION DETAIL https://phabricator.kde.org/D7177 To: jgrulich, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterb

D7177: Do not refresh appstream metadata everytime

apol added inline comments. INLINE COMMENTS > FlatpakBackend.cpp:509 > FlatpakRemote *remote = FLATPAK_REMOTE(g_ptr_array_index(remotes, > i)); > +fileTimestamp = flatpak_remote_get_appstream_timestamp(remote, > nullptr); > Can you declare and set in the same line? No need t

Re: Notes from Guadec Wayland BOF

On Monday 07 August 2017 09:23:56 David Edmundson wrote: > I went to Guadec last week, wearing my Gnome hoodie to slip in > undiscovered. I made some notes from their wayland BOF. Thanks for taking care of this! > They also have a problem with menus and lacking correct transient parents - > they

D7178: Fallback for cached icons

This revision was automatically updated to reflect the committed changes. Closed by commit R134:852973152c6c: Fallback for cached icons (authored by jgrulich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7178?vs=17815&id=17820 REVISION DETA

D7127: ignore spurious resize events to empty sizes

mart marked an inline comment as done. mart added a comment. not sure how to proceed in debugging this, as all i have is a resize event handler being called, which a backtrace there is useless to figure out who is resizing it REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL ht

D7177: Do not refresh appstream metadata everytime

This revision was automatically updated to reflect the committed changes. Closed by commit R134:64ad5fc8d6c7: Do not refresh appstream metadata everytime (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7177?vs=17806&id=17821#toc REPOSITORY R134 Discover Software

D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano, davidedmundson Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7173: Guard every remaining access to rootInfo

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH rootinfo-guard REVISION DETAIL https://phabricator.kde.org/D7173 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, j

D7181: [Task Manager] Elide context menu entries

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QMenu doesn't really support maximumWidth. The window's size would be limited but its content just cut off rather than nicely elided. Instea

D7127: ignore spurious resize events to empty sizes

mart added a comment. finally figured out where this event is generated: it's a spontaneous event generated in qguiapplication.cpp QGuiApplicationPrivate::processWindowScreenChangedEvent around line 2209 QWindowSystemInterfacePrivate::GeometryChangeEvent gce(window, QHighDpi::fromNativePi

D7184: [Color Picker] Add drag pixmap for color

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN F3833606: Screenshot_20170807_153644.png - Verified that the blob pixmap is grabbed only once - Verifie

D7185: Set a default font DPI if not set

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently X and Xwayland (unless set otherwise) defaults to a DPI of 96. GTK on wayland (unless set otherwise) defaults to a DPI of

D7127: ignore spurious resize events to empty sizes

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. thanks! add some code comments. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D7127 REVISION DETAIL https://phabricator.kde.org/D7127 To: mart, #plas

D7127: ignore spurious resize events to empty sizes

mart updated this revision to Diff 17832. mart added a comment. more comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7127?vs=17712&id=17832 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7127 AFFECTED FILES sr

D7188: Use Qt scaling in Plamsa

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I've done this only when on Wayland because: On X, our own scaling to font generally works well. There are bugs on older Qt, espe

D7127: ignore spurious resize events to empty sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0c27df529d80: ignore spurious resize events to empty sizes (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7127?vs=17832&id=17

D7046: Use xcb-icccm to read the name property

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7046 To: graesslin, #kwin, #plasma Cc: anthonyfieroni, fvogt, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart,

D7046: Use xcb-icccm to read the name property

fvogt added a comment. In https://phabricator.kde.org/D7046#133383, @graesslin wrote: > ping Still works fine here, but I can't really comment on the sanity of the code changes. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7046 To: graesslin, #kwin, #pl

D7188: Use Qt scaling in Plamsa

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. making fractional scalings work correctly will be fun... sounds fun :) btw, the final plan is using QT_SCREEN_SCALE_FACTORS with potentially different scalings per screen, right? REPOSITOR

D7185: Set a default font DPI if not set

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH python REVISION DETAIL https://phabricator.kde.org/D7185 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7185: Set a default font DPI if not set

mart added a comment. hopefully with this gui elements on plasma mobile should stop being so comically big REPOSITORY R120 Plasma Workspace BRANCH python REVISION DETAIL https://phabricator.kde.org/D7185 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezh

D7046: Use xcb-icccm to read the name property

cfeck added inline comments. INLINE COMMENTS > graesslin wrote in client.cpp:1428 > I'll keep the second copy nevertheless. After all this mess with Qt 5 > transition I don't trust Qt in the area of QString from char array. > > I rather have here a copy too much, which won't matter, then a pote

D7188: Use Qt scaling in Plamsa

davidedmundson added a comment. Effectively. The scale factor is part of the wl_output protocol, which is set by kwin and read by the QtQPA. This all mostly works already. No need for env vars. . REPOSITORY R120 Plasma Workspace BRANCH python REVISION DETAIL https://phabricator.

D7193: Move the X11 specific OverlayWindow into the platform/x11

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The overlay window is only needed for the X11 based compositors. Given that it is better suited in the X11 platform. Unfortunately it is

D7046: Use xcb-icccm to read the name property

graesslin added inline comments. INLINE COMMENTS > cfeck wrote in client.cpp:1428 > If Qt6 would introduce UTF-8 encoded QString (so that QString::fromUtf8() > would no longer need to create a new array), then you can expect all Qt > software to break. QString::fromUtf8() is used nearly everywh

Re: Splash screen translation

"Créé par" est très bien. Ikslawok -- Envoyé de mon Nexus 6P avec K-9 Mail. Le 3 août 2017 21:00:26 GMT+02:00, Olivier Churlaud a écrit : >[English below, for plasma people] > >Bonjour, > >J'ai vu que récemment la string "Plasma, made by KDE" a été traduit en >"Plasma, fait par KDE". > >Mon a

Re: Retirement of SVN Commitfilter and Legacy Get Hot New Stuff systems

Ben Cooksley: >I've checked and it appears that only a small handful of applications >still use newstuff.kde.org: >- KBlocks >- KDiamond >- KGoldRunner >- Kigo >- KSirk >- KSnakeDuel >- KSysguard > >These applications should all be ported to use store.kde.org. How long will it take for users to ge

D7184: [Color Picker] Add drag pixmap for color

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7184 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D7046: Use xcb-icccm to read the name property

cfeck added inline comments. INLINE COMMENTS > graesslin wrote in client.cpp:1428 > Just to add a little bit of context here: we are discussing two memcopies > here in a code path which performs a roundtrip to the X server. This thing is > going to be slow and the memcopy does not matter at all

D7188: Use Qt scaling in Plamsa

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bbf7aaf34485: Use Qt scaling in Plamsa (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7188?vs=17833&id=17851 REVISION DETAIL

D1772: Port custom collasablebutton to KWidgetAddons::KCollapsibleGroupBox

davidedmundson abandoned this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D1772 To: davidedmundson, #plasma Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7077: Drop Client::cap_deco as it's nowhere used

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ddf3536f19a4: Drop Client::cap_deco as it's nowhere used (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7077?vs=17626&id=17853 REVISION DETAI

D7173: Guard every remaining access to rootInfo

This revision was automatically updated to reflect the committed changes. Closed by commit R108:8794fe548a0b: Guard every remaining access to rootInfo (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7173?vs=17797&id=17854 REVISION DETAIL

D7188: Use Qt scaling in Plamsa

cfeck added a comment. Add some #include KWindowSystem, otherwise the symbol is not defined. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7188 To: davidedmundson, #plasma, mart Cc: cfeck, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, j

D7188: Use Qt scaling in Plamsa

davidedmundson added a comment. How embarassing, fixed. Thanks REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7188 To: davidedmundson, #plasma, mart Cc: cfeck, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D7188: Use Qt scaling in Plamsa

davidedmundson added a comment. Oh bother. There's something majorly wrong with that check, which I added in at the last minute. Ironically to reduce potential breakages. KWindowSystem::platform() can only be called after qApp is made ; otherwise the result is...weird. QCoreApplicati

D7188: Use Qt scaling in Plamsa

graesslin added a comment. You could check for env variable QT_QPA_PLATFORM REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7188 To: davidedmundson, #plasma, mart Cc: graesslin, cfeck, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

D7197: Move event filtering for overlay window into an X11EventFilter

graesslin added a dependency: D7193: Move the X11 specific OverlayWindow into the platform/x11. REVISION DETAIL https://phabricator.kde.org/D7197 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7197: Move event filtering for overlay window into an X11EventFilter

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The OverlayWindowX11 also inherits from X11EventFilter and performs the filtering itself. TEST PLAN Compiles, not yet tested as I'm on W

D7193: Move the X11 specific OverlayWindow into the platform/x11

graesslin added a dependent revision: D7197: Move event filtering for overlay window into an X11EventFilter. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7193 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,