D7607: ARGB buffers are premultipliedD7460 in kwayland assumes all WL_SHM_FORMAT_ARGB8888 buffers arepremultipied RGB values.Kwin tests need updating to do the same.Rendering code did not need changin

2017-08-29 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D7607 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,

Re: Plasma Mobile on the Librem 5

2017-08-29 Thread Martin Flöser
Am 2017-08-29 15:28, schrieb Matthias Klumpp: What we would be interested in is knowing about the future plans for Plasma Mobile, especially in the area of design and performance improvements. I didn't have the opportunity yet to test Plasma Mobile on one of our development boards, but I hope I

D7567: Support edit and appstream actions also for application search results

2017-08-29 Thread Eike Hein
hein added inline comments. INLINE COMMENTS > mak wrote in actionlist.cpp:380 > I know, that's why I didn't flag this as change request (just a general > observation). Aye, just gut reaction to avoid bike shedding etc :) Thanks for the note, it's important REPOSITORY R119 Plasma Desktop

Re: Review Request 126322: [ToolTip] Dismiss tooltip when item becomes invisible

2017-08-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126322/ --- (Updated Aug. 29, 2017, 8:58 nachm.) Status -- This change has been

D7599: [KRunner] Remove copy of dialog.h

2017-08-29 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead use PlasmaQuick/Dialog TEST PLAN Compiles and KRunner still positions correctly. REPOSITORY R120 Plasma Workspace REVISION

[Breeze] [Bug 384129] Rename colors from British to American English

2017-08-29 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=384129 Christoph Feck changed: What|Removed |Added Product|systemsettings |Breeze

D7596: Register objectPath before service

2017-08-29 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When the service is regsitered we want to have all the internal routing pre-configured. Otherwise pending calls (such as pending DBus

Fwd: Change in qt/qtbase[dev]: Make QPlatformServices as a separated plugin

2017-08-29 Thread David Faure
This might be of interest to some of you. -- Forwarded Message -- Subject: Change in qt/qtbase[dev]: Make QPlatformServices as a separated plugin Date: mardi 29 août 2017, 10:59:02 CEST From: Jan Grulich (Code Review) To: David Faure

D7582: [FrameSvgItem] Create margins/fixedMargins object on demand

2017-08-29 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:a8ce2e85ecf5: [FrameSvgItem] Create margins/fixedMargins object on demand (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results

2017-08-29 Thread Kai Uwe Broulik
broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7583 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7567: Support edit and appstream actions also for application search results

2017-08-29 Thread Kai Uwe Broulik
broulik added a comment. Minor nitpicks, then it's good to go. INLINE COMMENTS > actionlist.cpp:322 > + > +bool canEdit(const QString ) > +{ canEditApplication > actionlist.cpp:327 > + > +void edit(const QString , const QString ) > +{ editApplication > runnermatchesmodel.cpp:128 > +

D7598: [Folder Model] Introduce status enum

2017-08-29 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows to use bindings for properties like plasmoid.busy TEST PLAN Will update https://phabricator.kde.org/D7586 based on this once

D7587: kfileaudiopreview: don't autoplay media files by default

2017-08-29 Thread Kai Uwe Broulik
broulik added a comment. +1 from me also REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7587 To: elvisangelaccio, #plasma Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7590: Don't search for and link to libcln when using libqalculate>=2.0

2017-08-29 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b915e5b4bab1: Don't search for and link to libcln when using libqalculate>=2.0 (authored by arojas). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D7587: kfileaudiopreview: don't autoplay media files by default

2017-08-29 Thread Bhushan Shah
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D7587 To: elvisangelaccio, #plasma, bshah Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai,

D7561: Avoid absolute paths to .desktop files in launcher URLs.

2017-08-29 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. hein marked 2 inline comments as done. Closed by commit R120:a47d1f19e1e0: Avoid absolute paths to .desktop files in launcher URLs. (authored by hein). CHANGED PRIOR TO COMMIT

D7567: Support edit and appstream actions also for application search results

2017-08-29 Thread Eike Hein
hein updated this revision to Diff 18943. hein marked 4 inline comments as done. hein added a comment. - Address Kai's review comments - Don't double-add edit action in AppEntry - Also perform system immutability checks in RunnerMatchesModel REPOSITORY R119 Plasma Desktop CHANGES SINCE

D7611: Port Appmenu model to QDBusServiceWatcher

2017-08-29 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QDBusConnection::serviceOwnerChanged is deprecated, with the intended replacement being QDBusServiceWatcher. QDBusServiceWatcher only

D7601: [EventPluginsManager] Expose pluginPath in model

2017-08-29 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY That's what digital clock stores in its config, allows us to do matching. REPOSITORY R242 Plasma Framework (Library)

D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory

2017-08-29 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7602 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7601: [EventPluginsManager] Expose pluginPath in model

2017-08-29 Thread Kai Uwe Broulik
broulik added a dependent revision: D7603: [Digital Clock] Show event plugin configurations only if enabled. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7601 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

[Breeze] [Bug 384129] Rename colors from British to American English

2017-08-29 Thread Jonathan Riddell
https://bugs.kde.org/show_bug.cgi?id=384129 Jonathan Riddell changed: What|Removed |Added CC||j...@jriddell.org ---

D7555: Add basic example for adjusting column width draggable handle

2017-08-29 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R169:fbe9e84b4bd8: Add basic example for adjusting column width draggable handle (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7555?vs=18878=18923

Re: Plasma Mobile on the Librem 5

2017-08-29 Thread Eike Hein
On 08/29/2017 10:28 PM, Matthias Klumpp wrote: > As some of you might already know, we at Purism are planning to > develop a mobile phone that uses only free software and Matrix[2] for > communication. We are currently running a crowdfunding campaign[1] in > order to be able to make the phone a

[Breeze] [Bug 384129] Rename colors from British to American English

2017-08-29 Thread Heiko Tietze
https://bugs.kde.org/show_bug.cgi?id=384129 --- Comment #3 from Heiko Tietze --- Not my idea, but LibreOffice translates color names and KDE could do that too with Breeze_EN-GB.col. -- You are receiving this mail because: You are the assignee for the bug.

D7598: [Folder Model] Introduce status enum

2017-08-29 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7598 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Plasma Mobile on the Librem 5

2017-08-29 Thread Matthias Klumpp
[ Please keep the CC list intact for replies ] Hi! As some of you might already know, we at Purism are planning to develop a mobile phone that uses only free software and Matrix[2] for communication. We are currently running a crowdfunding campaign[1] in order to be able to make the phone a

[Breeze] [Bug 384129] Rename colors from British to American English

2017-08-29 Thread Jens Reuterberg
https://bugs.kde.org/show_bug.cgi?id=384129 Jens Reuterberg changed: What|Removed |Added CC||jens...@kolabnow.com

D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory

2017-08-29 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The appendCategory(ConfigCategory*) allows to add a category created by e.g. an Instantiator that can use bindings

D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory

2017-08-29 Thread Kai Uwe Broulik
broulik added a dependent revision: D7603: [Digital Clock] Show event plugin configurations only if enabled. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7602 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D7603: [Digital Clock] Show event plugin configurations only if enabled

2017-08-29 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This replaces the loop with fixed values by an Instantiator creating bindings on the model. CCBUG: 372090 TEST PLAN Depends on

D7587: kfileaudiopreview: don't autoplay media files by default

2017-08-29 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R320:c1a7f07d4629: kfileaudiopreview: don't autoplay media files by default (authored by elvisangelaccio). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

Re: Plasma Mobile on the Librem 5

2017-08-29 Thread Sebastian Kügler
Hi Matthias, et al! On Tue, 29 Aug 2017 15:28:36 +0200 Matthias Klumpp wrote: > [ Please keep the CC list intact for replies ] > > Hi! > > As some of you might already know, we at Purism are planning to > develop a mobile phone that uses only free software and Matrix[2]

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

2017-08-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126061/ --- (Updated Aug. 29, 2017, 8:57 nachm.) Status -- This change has been