Re: 5.12 release: congratulations and post-mortem

2018-02-06 Thread Luigi Toscano
On Tuesday, 6 February 2018 18:34:34 CET Paul Brown wrote: > - Establish strict deadlines for suggested changes to media (texts and > videos) and strictly stick to said deadlines. > > [EDIT: Ivana has also suggested this, but here are my thoughts too.] > > So when the next-to-last draft of the

D10170: Added optional transparency/blur to menu frames

2018-02-06 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In https://phabricator.kde.org/D10170#202023, @anemeth wrote: > KDE4 Breeze has no trasnparency and blur anymore > @hpereiradacosta can you point me to some KDE4 apps that are still in use? I'm just curious what hasn't been ported yet. Amarok

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 26665. apol added a comment. Also expose numlock, somewhat REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10337?vs=26638=26665 BRANCH arcpatch-D10337 REVISION DETAIL https://phabricator.kde.org/D10337

Re: 5.12 release: congratulations and post-mortem

2018-02-06 Thread Paul Brown
On Tuesday, 6 February 2018 16:54:19 CET Nate Graham wrote: > Congrats on a fantastic release of Plasma 5.12 everybody! People are > really gonna love it. > > The release process was a bit rockier than expected, and I thought I > might do a post-mortem to see how we can make the next one

D10272: Fix crash when searching

2018-02-06 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10272 To: aacid, mart Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

Re: Plasma 5.8.9

2018-02-06 Thread Marco Martin
On martedì 6 febbraio 2018 14:41:15 CET David Edmundson wrote: > We decided last meeting that from now onwards Plasma 5.8 releases should be > on-demand when we fix major issues. > (though 5.8.9 is in the calendar to be released in April) > > We have three changes in p-w that are worth releasing,

D10184: Port mediawiki runner to Plasma5/Qt5

2018-02-06 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 26662. kossebau added a comment. keep also ampersand with varname, not type, in method signature REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10184?vs=26661=26662 BRANCH portmediawiki REVISION DETAIL

D10346: check for EGL_KHR_platform_gbm extension as well

2018-02-06 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > egl_gbm_backend.cpp:107 > > display =

D10346: check for EGL_KHR_platform_gbm extension as well

2018-02-06 Thread Marco Martin
mart updated this revision to Diff 26664. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. - wock which extension we're usingrks both as qwidget and with the qstyle-based qqc2-desktop-style REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Martin Flöser
graesslin added a comment. Please be aware that this will not work on Wayland. The modifier state is only available to the window which currently has keyboard focus. We either need a dedicated Wayland protocol to send all modifier changes to Plasma or some other way to have KWin feed in the

D10170: Added optional transparency/blur to menu frames

2018-02-06 Thread Alex Nemeth
anemeth updated this revision to Diff 26658. anemeth added a comment. Implemented the changes suggested by @hpereiradacosta Only KDE5 Breeze has transparency and blur now REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26407=26658 BRANCH master

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D10337#202007, @apol wrote: > In https://phabricator.kde.org/D10337#201998, @graesslin wrote: > > > Please be aware that this will not work on Wayland. The modifier state is only available to the window which currently has

Re: 5.12 release: congratulations and post-mortem

2018-02-06 Thread Paul Brown
On Tuesday, 6 February 2018 18:49:41 CET Luigi Toscano wrote: > On Tuesday, 6 February 2018 18:34:34 CET Paul Brown wrote: > > - Establish strict deadlines for suggested changes to media (texts and > > videos) and strictly stick to said deadlines. > > > > [EDIT: Ivana has also suggested this, but

D10272: Fix crash when searching

2018-02-06 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10272 To: aacid, mart Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Aleix Pol Gonzalez
apol added a comment. F5695536: VID_20180206_195933.mp4 this is a very clunky video of what it looks like. Hope this helps. Design input very welcome. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10337 To: apol,

D10346: check for EGL_KHR_platform_gbm extension as well

2018-02-06 Thread Marco Martin
mart created this revision. mart added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. mart requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY

D10197: Fix krunner's alt+f2 on wayland

2018-02-06 Thread Martin Flöser
graesslin added a comment. To ensure we don't forget about it I created: https://bugs.kde.org/show_bug.cgi?id=389964 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: graesslin, broulik, ngraham, davidedmundson,

Re: Compiling and deploying plasma-desktop

2018-02-06 Thread Harald Sitter
sudo apt-get build-dep plasma-desktop git clone kde:plasma-desktop mkdir plasma-desktop-build cd plasma-desktop-build cmake ../plasma-desktop -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Debian make sudo make install As the others indicated, this isn't usually

D10024: Add supportedSchemes feature

2018-02-06 Thread Milian Wolff
mwolff added a comment. I've committed this now. If someone tells me how to add KIOSK support, I can add that later on as needed REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure, mart Cc: ngraham, mart, apol,

D10025: Use KFileWidget::setSupportedSchemes when available

2018-02-06 Thread Milian Wolff
This revision was automatically updated to reflect the committed changes. Closed by commit R135:a7d62a329994: Use KFileWidget::setSupportedSchemes when available (authored by mwolff). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

KDE CI: Plasma plasma-integration kf5-qt5 SUSEQt5.9 - Build # 38 - Failure!

2018-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20SUSEQt5.9/38/ Project: Plasma plasma-integration kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Feb 2018 09:49:23 + Build duration: 4 min 22 sec and counting CONSOLE

D10263: Fix being unable to close the toolbox menu by clicking outside

2018-02-06 Thread Marco Martin
mart added a comment. opening the toolbox enables an "edit mode" which opens all applet handles, they should continue to be interactible, so hideOnWindowDeactivate is probably not going to be enough, but would need more complex interaction (ie the desktop containment itself closing it when

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

2018-02-06 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. for after 5.12.0 but good for backport REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10253 To: hein, #plasma, mart Cc: mart,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

2018-02-06 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. I think it's about time to merge this in master REPOSITORY R119 Plasma Desktop BRANCH fixthediff REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc:

D10263: Fix being unable to close the toolbox menu by clicking outside

2018-02-06 Thread Marco Martin
mart added a comment. update: for me on master the toolbox menu is already closed both when clicking on an empty desktop area or another window, but not the applet handles or borders, as it should REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To:

D10024: Add supportedSchemes feature

2018-02-06 Thread Milian Wolff
This revision was automatically updated to reflect the committed changes. Closed by commit R241:6ab218dba91f: Add supportedSchemes feature (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10024?vs=25891=26632#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Plasma plasma-integration kf5-qt5 FreeBSDQt5.9 - Build # 13 - Failure!

2018-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Plasma plasma-integration kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Feb 2018 09:49:23 + Build duration: 14 min and counting CONSOLE

D9207: Don't load KDE platform module in kglobalaccel5

2018-02-06 Thread Marco Martin
mart added a comment. can this be resurrected? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed,

D10325: RFC: [KFileWidget] Hide places frame and header

2018-02-06 Thread Marco Martin
mart accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks, ngraham, mart Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10321: [Notifications] Let clear entry also clear history

2018-02-06 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a3664acb6054: [Notifications] Let clear entry also clear history (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D9207: Don't load KDE platform module in kglobalaccel5

2018-02-06 Thread Eike Hein
hein added a comment. Well, the maintainer spoke out against it, so not much I can do. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff,

D10263: Fix being unable to close the toolbox menu by clicking outside

2018-02-06 Thread Eike Hein
hein added a comment. Empty desktop doesn't close it for me without this patch. This was based on a user bug report. It was almost the first thing they saw / struggled with when using Plasma for the first time. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

2018-02-06 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7abd8d0da447: Fix dupe handling in requestAddLauncherToActivities; improve unit test (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10170: Added optional transparency/blur to menu frames

2018-02-06 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. Hello, Thanks for the updated patch and for the work on BlurHelper. Couple more comments below. Hugo INLINE COMMENTS > breezeblurhelper.cpp:144 > +if (!blurRegion.isEmpty()) { > +#if !BREEZE_USE_KDE4 > +

D10321: [Notifications] Let clear entry also clear history

2018-02-06 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10321 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

2018-02-06 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:25c30932961e: Port launch feedback KCM to Qt Quick and implement VDG redesign (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8911?vs=23327=26636#toc REPOSITORY R119

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, jriddell. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL

D10334: RFC: Make KRunner a Dock window

2018-02-06 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. In https://phabricator.kde.org/D10334#201753, @graesslin wrote: > There is the panel behavior thing missing which used to be in the old code. A panel does not get keyboard focus. With the panel behavior that can be changed. The

D10232: Include a pixel more in the dirty area

2018-02-06 Thread Marco Martin
mart updated this revision to Diff 26640. mart added a comment. - fix cursor painting REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10232?vs=26606=26640 BRANCH phab/dirty REVISION DETAIL https://phabricator.kde.org/D10232 AFFECTED FILES

D10325: RFC: [KFileWidget] Hide places frame and header

2018-02-06 Thread Kai Uwe Broulik
broulik added a comment. > Would it be possible to show it as if it were locked? That would solve all the issues with it, right? I don't get it. That "lock" feature is entirely a Dolphin invention. It does exactly what I do here: void DolphinDockWidget::setLocked(bool lock) {

D10197: Fix krunner's alt+f2 on wayland

2018-02-06 Thread Aleix Pol Gonzalez
apol added a comment. Feel free to revert and reopen the bug: https://bugs.kde.org/show_bug.cgi?id=385693 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: graesslin, broulik, ngraham, davidedmundson,

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-06 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: Plasma: Workspaces. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY store the const iterator returned, not the address.

D10344: Create panel on current screen

2018-02-06 Thread Robert Hoffmann
hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY In multi-monitor environments panels are always created on screen number 0. There

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-06 Thread Jaime Torres Amate
jtamate edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10184: Port mediawiki runner to Plasma5/Qt5

2018-02-06 Thread Friedrich W . H . Kossebau
kossebau marked 2 inline comments as done. kossebau added a comment. Thanks for first round of review :) INLINE COMMENTS > broulik wrote in mediawiki.cpp:134 > Categorized logging, perhaps? Yes, though I plan to do this later in one concentrated go for all of kdeplasma-addons, so things

Plasma 5.13 Kickoff Meeting

2018-02-06 Thread Jonathan Riddell
5.12 LTS is nearly out the door so here's a poll for a kickoff meeting for 5.13, let us know when you can make it https://doodle.com/poll/8wwrt59dt8prz6pf Jonathan

D10197: Fix krunner's alt+f2 on wayland

2018-02-06 Thread David Edmundson
davidedmundson added a comment. The old code is clearly wrong. It calls Dialog::event(event); that will set up a shellsurface in the expose event Then we process further and set up a shell surface in the expose event PlasmaShellSurfaces are shared, but you still have two

D10344: Create panel on current screen

2018-02-06 Thread Robert Hoffmann
hoffmannrobert edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10344 To: hoffmannrobert Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Plasma 5.12.0 is released

2018-02-06 Thread Bhushan Shah
Plasma 5.12.0 is now released https://www.kde.org/announcements/plasma-5.12.0.php Please made bugfixes to Plasma/5.12 branch and new features to master branches -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-06 Thread Jaime Torres Amate
jtamate added a comment. In https://phabricator.kde.org/D10342#201979, @broulik wrote: > Interesting. I'm curious as to why it calls those functions that often in the first place while copying files. My guess is that it is used to fill the task completion in the task bar, but is

D10325: [KFileWidget] Hide places frame and header

2018-02-06 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kfilewidget.cpp:1351 > placesDock = new QDockWidget(i18nc("@title:window", "Places"), q); > -placesDock->setFeatures(QDockWidget::DockWidgetClosable); > +placesDock->setFeatures(QDockWidget::NoDockWidgetFeatures); > +

5.12 release: congratulations and post-mortem

2018-02-06 Thread Nate Graham
Congrats on a fantastic release of Plasma 5.12 everybody! People are really gonna love it. The release process was a bit rockier than expected, and I thought I might do a post-mortem to see how we can make the next one smoother: Problem: Initial request for release notes was not seen by

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D10337#201998, @graesslin wrote: > Please be aware that this will not work on Wayland. The modifier state is only available to the window which currently has keyboard focus. We either need a dedicated Wayland protocol to send all

D10170: Added optional transparency/blur to menu frames

2018-02-06 Thread Alex Nemeth
anemeth marked 2 inline comments as done. anemeth added a comment. KDE4 Breeze has no trasnparency and blur anymore REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar,

D10197: Fix krunner's alt+f2 on wayland

2018-02-06 Thread Martin Flöser
graesslin added a comment. As the commit went into the 5.12 branch we cannot build up on any functionality not yet available in Dialog. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: graesslin, broulik, ngraham,

D9207: Don't load KDE platform module in kglobalaccel5

2018-02-06 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D9207#201848, @hein wrote: > Well, the maintainer spoke out against it, so not much I can do. Please be aware that I am no longer the maintainer of kglobalaccel. Nevertheless I recommend against it as the risk of breakage

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Andres Betts
abetts added a comment. Does this have a look yet? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10337 To: apol, #plasma, jriddell Cc: abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10334: RFC: Make KRunner a Dock window

2018-02-06 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D10334#201879, @apol wrote: > In https://phabricator.kde.org/D10334#201753, @graesslin wrote: > > > There is the panel behavior thing missing which used to be in the old code. A panel does not get keyboard focus. With the

D10184: Port mediawiki runner to Plasma5/Qt5

2018-02-06 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 26661. kossebau marked an inline comment as done. kossebau added a comment. update to kai's feedback REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10184?vs=26208=26661 BRANCH portmediawiki REVISION DETAIL

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-06 Thread Kai Uwe Broulik
broulik added a comment. Interesting. I'm curious as to why it calls those functions that often in the first place while copying files. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces Cc: broulik, plasma-devel,

D10197: Fix krunner's alt+f2 on wayland

2018-02-06 Thread Martin Flöser
graesslin added a comment. I really think this needs to be reverted. Krunner must be a dock, it must be set to windows go below and it must take focus. This is all functionality not provided by Plasma::Dialog. Just removing the code doesn't work unfortunately. I have a hard time

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2018-02-06 Thread andreas
https://bugs.kde.org/show_bug.cgi?id=346972 Bug 346972 depends on bug 339863, which changed state. Bug 339863 Summary: Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon https://bugs.kde.org/show_bug.cgi?id=339863

D10357: Show high-resolution and vector logos properly in HighDPI mode

2018-02-06 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 388633 Take the device pixel ratio into consideration

D10357: Show high-resolution and vector logos properly in HighDPI mode

2018-02-06 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9207: Don't load KDE platform module in kglobalaccel5

2018-02-06 Thread Eike Hein
hein abandoned this revision. hein added a comment. As mentioned, I'm OK with abandoning it. I think the change is hygienic, but it's also a micro-optimization. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart,

D10327: [LauncherTasksModel] Support applications: URLs in requestOpenUrls

2018-02-06 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:eff4bc7c3cf3: [LauncherTasksModel] Support applications: URLs in requestOpenUrls (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Compiling and deploying plasma-desktop

2018-02-06 Thread Roman Gilg
kdesrc-build: https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source#kdesrc-build And you can do this on a real machine with Neon dev unstable. Or at least I do it... On Mon, Feb 5, 2018 at 10:30 PM, pointedstick wrote: > Howdy folks, > > What's the best way

D10328: [Task Manager] Use KFilePlacesModel::isHidden

2018-02-06 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:51a927375c90: [Task Manager] Use KFilePlacesModel::isHidden (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10328?vs=26594=26626

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still unstable!

2018-02-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/34/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Feb 2018 08:09:27 + Build duration: 7 min 41 sec and counting

D10325: [KFileWidget] Hide places frame and header

2018-02-06 Thread Kai Uwe Broulik
broulik updated this revision to Diff 26642. broulik retitled this revision from "RFC: [KFileWidget] Hide places frame and header" to "[KFileWidget] Hide places frame and header". broulik edited the test plan for this revision. broulik added a comment. - Add custom widget for added spacing,

D10325: [KFileWidget] Hide places frame and header

2018-02-06 Thread Mark Gaiser
markg added a comment. In https://phabricator.kde.org/D10325#201884, @broulik wrote: > > Would it be possible to show it as if it were locked? That would solve all the issues with it, right? > > I don't get it. That "lock" feature is entirely a Dolphin invention. It does exactly

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.qml:29 > + > +Plasmoid.onActivated: toggle() > + I don't see a `toggle()` function > main.qml:34 > +engine: "keystate" > +connectedSources: "Caps Lock" > +} I know QML does this magically but I'd prefer explicit

Plasma 5.8.9

2018-02-06 Thread David Edmundson
We decided last meeting that from now onwards Plasma 5.8 releases should be on-demand when we fix major issues. (though 5.8.9 is in the calendar to be released in April) We have three changes in p-w that are worth releasing, two security related from this week. I propose we make a release later

D10338: Don't show tooltips for inactive windows

2018-02-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, graesslin, McPain. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY You don't get any tooltips for controls within

D10232: Include a pixel more in the dirty area

2018-02-06 Thread Kurt Hindenburg
hindenburg added a comment. I now get all kinds of extra vertical lines on right side of screen and some horizontal ones near cursor using 1.3 scaling - I didn't see these before the latest patch My zsh prompt is: kurthindenburg:~/ $