D10499: [spellcheck runner] Make each suggestion copyable as separate item

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. > and then copy the correct or suggested into the clipboard for further usage? Calculator runner does `setText` on `QClipboard` in `run`, so I guess this is the way.

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

acrouthamel added a comment. Super nice, thanks! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10557: [Clipboard plasmoid] Split delegate into separate files

broulik updated this revision to Diff 27647. broulik added a comment. Remove debug REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10557?vs=27298=27647 REVISION DETAIL https://phabricator.kde.org/D10557 AFFECTED FILES

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Well, in a library that 99% relies on a database, having no database is not something that can be gracefully handled (the returned nullptr is asserted on as well in the function that

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

akrutzler edited the summary of this revision. akrutzler added reviewers: apol, ngraham. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10697: Make the badge text readable on dark color schemes

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! I assume you tested it with a light color scheme also. 5.12 branch pls REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10697 To:

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

akrutzler created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. akrutzler requested review of this revision. REVISION SUMMARY If you're using Breeze Dark or probably any other dark theme, the screenshot shadow-gradient

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

davidedmundson added a comment. Do you have commit access? REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

akrutzler added a comment. Not yet, @ngraham did all the commits for me so far. Just in case, my email is andreas.krutz...@gmx.net :) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

akrutzler added a comment. The gifs were the hardest part :) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai,

D10692: parent full representation to the proper window at start

broulik added inline comments. INLINE COMMENTS > Menu.qml:36 > +//which makes quite a visual difference when this plasmoid gets > preloaded (ensures it actually gets preloaded fully) > +Component.onCompleted: menuListView.forceLayout() > ListView { Would that also help Kickoff's

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan added a comment. @hein This is not really as simple as 'accept without a comment'. I don't mind this patch to be merged, but keep in mind that it just turns users for which plasma crashes (for which we get an explicit message as to why) into users who do not have certain parts

Plasma 5.12.2

A week's worth of bugfixes is now available for packaging https://www.kde.org/announcements/plasma-5.12.2.php

D10681: preload the expander (the dialog) too

broulik added inline comments. INLINE COMMENTS > appletquickitem.cpp:295 > +qint64 time = 0; > +if (QLoggingCategory::defaultCategory()->isInfoEnabled()) { > +time = QDateTime::currentMSecsSinceEpoch(); You should check the PlasmaQuick category, not the default one REPOSITORY

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

hein added a comment. @ivan So you wrote a method that can return null, but the call sites aren't actually prepared to handle that gracefully? :) But I was waiting for your review for that context. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL

Re: What does LTS mean again?

On Tue, Feb 20, 2018 at 09:13:42PM +0100, Sebastian Kügler wrote: > Hi, > > I know we talked about it extensively and even put it into writing, but I > can't find it anymore. What does our LTS promise for 5.12 entail? Bugfix releases happen over a longer term.

D10591: forcefully activate popup windows when they open

broulik added a comment. If we were to do this, we need to first make Device Notifier not freak out when you have a wonky USB cable. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10591 To: mart, #plasma Cc: broulik, davidedmundson,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

ngraham added a reviewer: Discover Software Store. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Beautiful! Lovely gif too. Thanks for that. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL

D10512: try to preload certain applets in a smart way

anthonyfieroni added inline comments. INLINE COMMENTS > mart wrote in appletquickitem.cpp:57-68 > > So Adaptive can a default even environment variable is not setted? > > yes, adaptive is the default > > > Furthermore you can make a static function to access value > > it's done anyways only

Re: Plasma 5.13 dependencies

Hi Ben I think we could upgrade the CI to 5.10 "sans webengine" -- which is the one part we are missing. mfg Tobias On 19 February 2018 at 20:17, Ben Cooksley wrote: > On 20/02/2018 12:23 AM, "Jonathan Riddell" wrote: > > Hi Jonathan, > > Plasma 5.13,

D10668: Fix PowerDevil shortcuts migration

fvogt added inline comments. INLINE COMMENTS > davidedmundson wrote in powerdevilapp.cpp:177 > You'd think so, but no. > > setShortcut(QAction, sequence, KGlobalAccel::NoAutoloading) > would do exactly that > > setShortcut(QAction, sequence, KGlobalAccel::Autoloading) > (which this

D10652: [Run Command] Add history drop down button

mbele added a comment. Wonderful! The famous arrow has come back! It should not have been removed in the first place! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10652 To: broulik, #plasma, #vdg Cc: mbele, ngraham, plasma-devel, ZrenBot, lesliezhai,

D10659: [AppletConfiguration] Let applet override Return closing the dialog

broulik added a comment. > Can this property become something more official, with real documentation Sure. If you tell me where the other features of the config dialog (e.g. the `saveConfig()` function ) is documented, I'd happily add it there. REPOSITORY R119 Plasma Desktop REVISION

D10594: Disable window rule configuration for Wayland

mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. window rules is a feature which would "just" require the kcm reimplementation or as a principle is something which can't work on wayland? REPOSITORY R108 KWin REVISION DETAIL

D10669: Reduce plasmashell frozen time

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10669 To: jtamate, #plasma, #frameworks, mart Cc: plasma-devel, davidedmundson, michaelh,

D10512: try to preload certain applets in a smart way

mart added inline comments. INLINE COMMENTS > anthonyfieroni wrote in appletquickitem.cpp:57-68 > So Adaptive can a default even environment variable is not setted? > Furthermore you can make a static function to access value > > AppletQuickItemPrivate::PreloadPolicy

D10604: Show the text by the page action tool buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R169:38a9dec73179: Show the text by the page action tool buttons (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10604?vs=27401=27611 REVISION

D10197: Fix krunner's alt+f2 on wayland

apol closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10610: Fix favicons in firefox bookmarks runner

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH D10610 REVISION DETAIL https://phabricator.kde.org/D10610 To: z3ntu, #plasma, broulik, davidedmundson Cc: ngraham, elvisangelaccio, davidedmundson,

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

jriddell added a comment. https://phabricator.kde.org/T7948 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10681: preload the expander (the dialog) too

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8346b3e76ab8: preload the expander (the dialog) too (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10681?vs=27605=27606#toc REPOSITORY R242 Plasma Framework (Library)

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

hein added a comment. I'll look into it, this week probably REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma Cc: hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10613: Make it possible for actions to show submenus

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D10613 To: apol, #kirigami, mart Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10613: Make it possible for actions to show submenus

This revision was automatically updated to reflect the committed changes. Closed by commit R169:dd2886259168: Make it possible for actions to show submenus (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10613?vs=27547=27608 REVISION

D10679: Add recipes feature delegates

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:20de58c09c82: Add recipes feature delegates (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES

D10681: preload the expander (the dialog) too

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY when preloading, preload the expander as well, and

D10586: [Task Manager] Limit badge label to a sane size

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10586 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10684: [Drop Job] Create proper trash file on linking

broulik created this revision. broulik added reviewers: Frameworks, Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Plasma wants to remove the default trash

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

broulik added a comment. See D10684 to make it easy for users to bring it back REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma Cc: broulik, hein, mart, zzag, plasma-devel, ZrenBot,

D10668: Fix PowerDevil shortcuts migration

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. lgtm shipit once you addressed the other comments REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D10668 To: davidedmundson, #plasma,

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #11 from Navid Zamani --- (In reply to Rog131 from comment #10) > The Breeze text color can be set from the KDE system settings > Colors > > Complementary > Normal text. That doesn’t actually work. I just

D10475: Make it possible to show the title despite having ctx actions

apol added a comment. Now that we have a menu, we definitely need to look into this. Without patch: odd F5720319: Screenshot_20180220_154236.png With patch: still odd F5720335: Screenshot_20180220_155606.png

D10668: Fix PowerDevil shortcuts migration

This revision was automatically updated to reflect the committed changes. Closed by commit R122:4ae36aee: Fix PowerDevil shortcuts migration (authored by davidedmundson). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10668?vs=27594=27596 REVISION

D10679: Add recipes feature delegates

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Ref T8032 Added recipe cards and delegates for Food-Wizard Mycroft Recipes

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

jriddell added a comment. In D10588#207890 , @zzag wrote: > Why? As discussed at 5.13 Kickoff meeting REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma Cc: zzag, plasma-devel,

D10681: preload the expander (the dialog) too

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > appletquickitem.cpp:294 > +{ > +qint64 time = QDateTime::currentMSecsSinceEpoch(); > +createFullRepresentationItem(); wrap this line in

D10668: Fix PowerDevil shortcuts migration

davidedmundson updated this revision to Diff 27594. davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Changes REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10668?vs=27574=27594 BRANCH master REVISION DETAIL

D10610: Fix favicons in firefox bookmarks runner

This revision was automatically updated to reflect the committed changes. Closed by commit R120:93f0f5ee2c27: Fix favicons in firefox bookmarks runner (authored by z3ntu, committed by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10610?vs=27421=27595#toc REPOSITORY

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

mart added a comment. +1 from me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma Cc: mart, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10589: Make it possible to tweak the sorting of a resources list

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:cd998c2e125a: Make it possible to tweak the sorting of a resources list (authored by apol). REPOSITORY R134

D10589: Make it possible to tweak the sorting of a resources list

apol updated this revision to Diff 27609. apol added a comment. Addressed Nate's comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10589?vs=27363=27609 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10589 AFFECTED

D10337: First approach to a plasmoid that can display the state of caps lock

kossebau added a comment. Quick note before I forget again: doesn't this need some Messages.sh? There are some i18n calls in the QML. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10337 To: apol, #plasma, jriddell Cc: kossebau, graesslin, abetts, broulik,

D10684: [Drop Job] Create proper trash file on linking

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10684 To: broulik, #frameworks, #plasma, hein Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

zzag added a comment. > This isn't about disabling support for icons (we just turned that back on in 5.10 ...), it's about not creating the Home and Trash icons by default on first login. I'm talking about not creating home and trash icons by default.(not disabling folder view)

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

zzag added a comment. In D10588#210276 , @hein wrote: > No, you weren't: "What's the point of the desktop if it is not possible to place folder, pictures, music, etc on it?" That was a rhetorical question, which apparently, causes

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

ngraham added a comment. Memes aside, I have to agree. This seems like the sort of things that developers prefer for "cleanliness", at the expense of messy ordinary users who putting junk all over their desktop. REPOSITORY R120 Plasma Workspace REVISION DETAIL

Re: QtWayland decoration improvement

On lunedì 19 febbraio 2018 16:37:55 CET Martin Bříza wrote: > And even less complicated way would be to just do my own thing in > QGnomePlatform and support only the decorations I wrote myself. > > Which one is the best one, according to you, please? I'm open to every > suggestion. using

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

ngraham added a comment. In D10588#210246 , @zzag wrote: > > This seems like the sort of things that developers prefer for "cleanliness", at the expense of messy ordinary users who like putting junk all over their desktop. > > What's the

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

zzag added a comment. > This seems like the sort of things that developers prefer for "cleanliness", at the expense of messy ordinary users who like putting junk all over their desktop. What's the point of the desktop if it is not possible to place folder, pictures, music, etc on it?

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

hein added a comment. No, you weren't: "What's the point of the desktop if it is not possible to place folder, pictures, music, etc on it?" REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma Cc: ngraham, broulik, hein, mart, zzag,

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

zzag added a comment. > As discussed at 5.13 Kickoff meeting I asked as an ordinary user. Could you please explain why Home and Trash icons should not be on the desktop by default? These icons are very useful, especially trash icon. I don't have to open dolphin just to empty trash

D10686: [DesktopNotifier] Notify change for any link to trash:/

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY With removal of default Trash and D10684

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

hein added a comment. This isn't about disabling support for icons (we just turned that back on in 5.10 ...), it's about not creating the Home and Trash icons by default on first login. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell,

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

hein added a comment. This is just following up on a public promise we already made. When we turned Folder View into the default desktop containment, we told everyone (and got a lot of positive feedback from the users for it) that this means the desktop surface now supports icons by default

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks, hein Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

ngraham added a comment. Heh, okay. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 27623. apol added a comment. Rebase on master REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=27167=27623 BRANCH arcpatch-D10475 REVISION DETAIL https://phabricator.kde.org/D10475 AFFECTED FILES

D10691: Fix plasmashell crash when database is broken

ngraham added reviewers: Plasma, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks Cc:

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

kpiwowarski retitled this revision from "Fix plasmashell crash when database is broken" to "[kactivities-stats] Fix plasmashell crash when database is broken". REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks

D10628: Optional barcodes in libprison

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10628 To: svuorela, graesslin, vkrause, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10490: Add a method to dbus interface to query information about a window

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10490 To: graesslin, #kwin, #plasma Cc: davidedmundson, broulik, plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10594: Disable window rule configuration for Wayland

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In D10594#209972 , @mart wrote: > window rules is a feature which would "just" require the kcm reimplementation or as a principle is something which

D10692: parent full representation to the proper window at start

mart updated this revision to Diff 27633. mart added a comment. - forces delegates creation in the item view REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27627=27633 BRANCH phab/preloadsystray REVISION DETAIL

D10695: dont initialize app menu index in every hiding

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY - hiding a menu shouldnt initialize the currentIndex to

D10692: parent full representation to the proper window at start

davidedmundson added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:29 > > +//set width/height to avoid an useless Dialog resize > +width: Layout.minimumWidth How does this avoid a useless Dialog resize? > systemtray.cpp:346 > > +void

D10692: parent full representation to the proper window at start

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ExpandedRepresentation.qml:29 > How does this avoid a useless Dialog resize? otherwise mainItem starts being sized 0x0, then on Dialog showevent, it searches for its Layout property and resizes it based on that, this makes

D10692: parent full representation to the proper window at start

hein added a comment. It does use it btw, just not for subdialogs. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma Cc: hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10692: parent full representation to the proper window at start

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY this avoids some unwanted scene changes and speeds up the first open a

D10594: Disable window rule configuration for Wayland

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH disable-rules-5.12 REVISION DETAIL https://phabricator.kde.org/D10594 To: graesslin, #kwin, #plasma,

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #12 from Rog131 --- (In reply to Navid Zamani from comment #11) > (In reply to Rog131 from comment #10) > > The Breeze text color can be set from the KDE system settings > Colors > > > Complementary > Normal text. >

What does LTS mean again?

Hi, I know we talked about it extensively and even put it into writing, but I can't find it anymore. What does our LTS promise for 5.12 entail? Cheers, -- sebas http://www.kde.org | http://vizZzion.org

D10697: Make the badge text readable on dark color schemes

mwolff created this revision. mwolff added reviewers: broulik, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mwolff requested review of this revision. REVISION SUMMARY The background color should not be used for the foreground

D10697: Make the badge text readable on dark color schemes

mwolff added a comment. using breeze high contrast here, before: F5720670: Screenshot_20180220_211956.png after: F5720669: Screenshot_20180220_212030.png REPOSITORY R119 Plasma Desktop REVISION