D11026: [taskmanager applet] Mark some caching QML Item properties readonly

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH markshortcutpropertiesreadonly REVISION DETAIL https://phabricator.kde.org/D11026 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10890: Don't skip certain recent documents in kicker and taskmanager

broulik added a comment. lgtm INLINE COMMENTS > actionlist.cpp:312 > +if (storageId.startsWith("org.kde.")) { > +query = query | Agent(storageId.right(storageId.length() - 8)); > +} I would prefer `mid(8)` REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11021: [Media controller] Add simple volume control

broulik added a comment. Thanks for your patch! I thought about doing that for a long time, actually. You can add `BUG: 386588` to your commit message (on its own line) to indiate that it fixes this bug. Can you please also implement a volume OSD? We have a mediaPlayerVolumeChanged in

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

broulik added inline comments. INLINE COMMENTS > ToolTipInstance.qml:349 > +if (canPause) { > +mpris2Source.playPause(mprisSourceName); > +} else if (playing) { Same as with media controller, please do not

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

broulik added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11025 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11026: [taskmanager applet] Mark some caching QML Item properties readonly

broulik added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11026 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11028: [media controller applet] Fix JS error on no xesam:url data set

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. My approach would have been var xesamUrl = (metadata["xesam:url"] || "").toString(); but this is fine and more understandable for non-JS developers :) REPOSITORY R120 Plasma

D11045: Use QQuickWidget instead of QQuickView for the main view in the kcm

fvogt created this revision. fvogt added reviewers: Plasma, sebas, dvratil. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY This makes it usable on wayland. The Qt Wayland support for subsurfaces is broken in many ways, producing

D11047: Fix typo in config group name

This revision was automatically updated to reflect the committed changes. Closed by commit R108:b1bffa445823: Fix typo in config group name (authored by fvogt). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11047?vs=28686=28698 REVISION DETAIL

D11047: Fix typo in config group name

fvogt created this revision. fvogt added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin. fvogt requested review of this revision. REVISION SUMMARY Quickly fix it before anyone relies on this typo. TEST PLAN

D11047: Fix typo in config group name

fvogt updated this revision to Diff 28686. fvogt added a comment. Remove blank line at EOF. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11047?vs=28685=28686 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D11047 AFFECTED FILES

D11021: [Media controller] Add simple volume control

Pitel edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10890: Don't skip certain recent documents in kicker and taskmanager

aleksejshilin updated this revision to Diff 28681. aleksejshilin marked an inline comment as done. aleksejshilin added a comment. - Use QString::mid() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28639=28681 BRANCH

D11047: Fix typo in config group name

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D11047 To: fvogt, #plasma, graesslin, davidedmundson Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot,

D10890: Don't skip certain recent documents in kicker and taskmanager

aleksejshilin edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9141: Setup QQmlEngine only once in QmlObject

broulik updated this revision to Diff 28691. broulik edited the test plan for this revision. broulik added a comment. - Use protected constructor with pseudo argument instead of flags REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9141?vs=23360=28691

D11045: Use QQuickWidget instead of QQuickView for the main view in the kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R104:47521b011d33: Use QQuickWidget instead of QQuickView for the main view in the kcm (authored by fvogt). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D10571: [AppletAppearance] Remove d QtObject

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10571 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11046: Fix position of output identifier popup for screen scaling

broulik created this revision. broulik added reviewers: Plasma, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Tested with QT_SCREEN_SCALE_FACTORS=1 kcmshell5 kcm_kscreen

D11045: Use QQuickWidget instead of QQuickView for the main view in the kcm

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks for finding a simple fix for this, it was super annoying. REPOSITORY R104 KScreen BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D11045 To:

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

kossebau updated this revision to Diff 28716. kossebau added a comment. use play() & pause() instead of playpause() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11025?vs=28616=28716 BRANCH fixtaskmanagertooltipformpris REVISION DETAIL

D11059: Add convenience method to get a persistent model index from TasksModel

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Used in the minimizeAll plasmoid (see D10019

D10571: [AppletAppearance] Remove d QtObject

apol added a comment. In D10571#219016 , @mart wrote: > the concern is that now applets have a codepath to access it by going to see their parents... > but is something they should never ever do, so good to go for me If this is a

D11028: [media controller applet] Fix JS error on no xesam:url data set

kossebau added a comment. In D11028#218774 , @broulik wrote: > My approach would have been > > var xesamUrl = (metadata["xesam:url"] || "").toString(); > > > but this is fine and more understandable for non-JS developers :) It

D11021: [Media controller] Add simple volume control

Pitel added a reviewer: broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma, broulik Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

mart added a comment. did you try if after removing it, repeatedly showing and hiding, the dialog does not appear in the taskbar, even for an instant? (if so, good to go for me) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10769 To: broulik,

D10858: [Solid Device Engine] Connect device signals initially

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10858 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

Pitel edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma, broulik Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10769 To: broulik, #plasma, mart Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed,

D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 28726. apol added a comment. Odd, they both look rather small to me, probably a high dpi issue to look into... REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=28723=28726 BRANCH arcpatch-D10475_1 REVISION

D11026: [taskmanager applet] Mark some caching QML Item properties readonly

This revision was automatically updated to reflect the committed changes. Closed by commit R119:de5ab396f277: [taskmanager applet] Mark some caching QML Item properties readonly (authored by kossebau). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11021: [Media controller] Add simple volume control

Pitel updated this revision to Diff 28701. Pitel added a comment. - Added OSD support. - Refactored osd & volume bounding logic into helper `MultiplexedService::changeVolume`. Is there any way to get player name & icon without adding `PlayerControl::container`? REPOSITORY R120

D10973: [media controller applet] Support MPRIS services where CanPause==false

kossebau updated this revision to Diff 28709. kossebau added a comment. use play() & pause() everywhere instead of playpause() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10973?vs=28619=28709 BRANCH mpriscontrollersupportnocanpause REVISION

D11061: Migration request from IBusConfig to GSettings

lbeltrame added reviewers: Plasma, hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11028: [media controller applet] Fix JS error on no xesam:url data set

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c7f2d8e7331a: [media controller applet] Fix JS error on no xesam:url data set (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11028?vs=28621=28702#toc REPOSITORY R120

D10686: [DesktopNotifier] Notify change for any link to trash:/

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10686 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10571: [AppletAppearance] Remove d QtObject

mart accepted this revision. mart added a comment. the concern is that now applets have a codepath to access it by going to see their parents... but is something they should never ever do, so good to go for me REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11056: [mediacontroller applet] Use media playback status icons

romangg added a dependency: D11054: Add media status icons. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Instead of using the action icons to indicate the current state

D11057: Add a custom default avatar to the sddm-breeze theme.

pstefan created this revision. pstefan added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. pstefan requested review of this revision. REVISION SUMMARY With commit 945a95d908b4544f7c5dea6caacffdc0f44cffcb SDDM

D11061: Migration request from IBusConfig to GSettings

fujiwara created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. fujiwara requested review of this revision. REVISION SUMMARY kimpanel-ibus-panel uses IBusConfig and I'd ask to migrate it to GSettings and delete

D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 28723. apol added a comment. Address Nate's comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=28393=28723 BRANCH arcpatch-D10475_1 REVISION DETAIL https://phabricator.kde.org/D10475 AFFECTED FILES

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. Hmm, now there's too much side padding! F5741687: Now there's too much.png Can we make the padding identical on the top, bottom, and right side? Also, as you can see in the above screenshot, the menu items without

D9141: Setup QQmlEngine only once in QmlObject

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. i like it now REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9141 To: broulik, #plasma, mart Cc: davidedmundson, hein, mart, plasma-devel, #frameworks,

D11056: [mediacontroller applet] Use media playback status icons

romangg edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11057: Add a custom default avatar to the sddm-breeze theme.

pstefan edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11057 To: pstefan, #plasma, #vdg Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good now! With your latest update, the right padding issue now actually resolved. The follow-up patch only needs to fix the left padding for the menu items that don't have

D11063: [mediacontroller applet] Reorder elements

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Improve overall look according to bug report and mockup.

Minutes Monday Plasma Hangout

Today's minutes! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 05-03-2018 Present: notmart, kbroulik, romangg, Sho_, psifidotos, bshah, d_ed notmart: * more bugfixes connected to preloading * more work on card component, taken a lot of time due to funny qqc2 bugs, most

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. The problems persist with `QT_SCALE_FACTOR=1.5`, and additionally the titles get inappropriately elided: F5741717: Persists.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10475 To: apol,

D9141: Setup QQmlEngine only once in QmlObject

This revision was automatically updated to reflect the committed changes. Closed by commit R296:0ecea38b5998: Setup QQmlEngine only once in QmlObject (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9141?vs=28691=28728#toc REPOSITORY R296 KDeclarative CHANGES

D11063: [mediacontroller applet] Reorder elements

romangg added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:269 > +width: parent.width > +spacing: -units.smallSpacing > + Pls tell me a way to use Headings without huge margins all around. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 28727. apol added a comment. Improve how we calculate the header title. Let's fix the right spacing issue in a separate review REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=28726=28727 BRANCH

D11056: [mediacontroller applet] Use media playback status icons

romangg added a dependency: D11063: [mediacontroller applet] Reorder elements. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

romangg added a dependent revision: D11056: [mediacontroller applet] Use media playback status icons. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11063 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11021: [Media controller] Add simple volume control

Pitel updated this revision to Diff 28729. Pitel added a comment. The `changeVolume` helper must be in `PlayerControl` class and `MultiplexedService` must only forward calls to it in order to volume change by mouse wheel also work for other sources than only mutliplex one. REPOSITORY R120

D11063: [mediacontroller applet] Reorder elements

romangg edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11063 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

progwolff edited the summary of this revision. progwolff edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11064: add preview images to fonts kcm

abetts added a comment. Thanks so much for your work! As I am not a developer, as you progress with the patch, can you also please post screenshots? Just so I get where your work is going. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28735. progwolff added a comment. - cleanup - add license REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28734=28735 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064 AFFECTED

D11063: [mediacontroller applet] Reorder elements

broulik added a comment. Cool! INLINE COMMENTS > ExpandedRepresentation.qml:123 > +id: playerCombo > +width: 0.6 * parent.width > +height: visible ? undefined : 0 `Math.round` > ExpandedRepresentation.qml:124 > +width: 0.6 * parent.width > +height:

D11064: add preview images to fonts kcm

broulik added a comment. Thanks a lot for your patch! This makes the effect of those settings a lot easier to understand. I have a couple of nitpicks below. INLINE COMMENTS > main.qml:22 > import QtQuick.Layouts 1.1 > -import QtQuick.Controls 2.0 as QtControls > +import QtQuick.Controls

D11064: add preview images to fonts kcm

abetts added a comment. Thank you for this. This is what I thought was best. It is a method that many applications use. It is straightforward and quick. Is there a way that the list width can be dynamic so as to accommodate the name of the font family? Sometimes font families are very long.

D10762: Fix the build on armhf/aarch64

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH arcpatch-D10762 REVISION DETAIL https://phabricator.kde.org/D10762 To: bshah, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, lesliezhai,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28740. progwolff added a comment. - fix face number REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28737=28740 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064 AFFECTED FILES

D11065: [Active Window Control] Slightly fix vertical alignment of window name

Pitel created this revision. Pitel added reviewers: Plasma, martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY On my setup the window label was 1px lower than global

D11064: add preview images to fonts kcm

progwolff created this revision. progwolff added reviewers: Plasma, harmathy, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY The fonts kcm offers different font

D11064: add preview images to fonts kcm

progwolff added a comment. Thanks for your feedback! This patch was ment to provide the functionality we need for the UI redesign, but you are probably right that I should fix the mentioned problems before we land this. I will see what I can do about the popup width, the preview text

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28737. progwolff marked 7 inline comments as done. progwolff edited the summary of this revision. progwolff added a comment. - revert QtQuick.Controls version - coding style, unneccessary defaults, Label instead of Text - split only once, add range

D10762: Fix the build on armhf/aarch64

graesslin added a comment. btw. please push to 5.12 branch REPOSITORY R108 KWin BRANCH arcpatch-D10762 REVISION DETAIL https://phabricator.kde.org/D10762 To: bshah, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening,

D11066: Convert EffectView to a QQuickWidget

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D11066 To: fvogt, #plasma, graesslin, davidedmundson Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot,

D11066: Convert EffectView to a QQuickWidget

fvogt created this revision. fvogt added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin. fvogt requested review of this revision. REVISION SUMMARY The Qt Wayland support for subsurfaces is broken in many ways,

D11065: [Active Window Control] Slightly fix vertical alignment of window name

Pitel added a comment. Would it be better to move global menu 1px down instead? PlasmaComponents.Label { id: appmenuButtonTitle -anchors.centerIn: appmenuButtonBackground +anchors.top:

D11065: [Active Window Control] Slightly fix vertical alignment of window name

broulik added a comment. This disregards any descenders text might have, the previous approach was more technically correct. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11065 To: Pitel, #plasma, martinkostolny Cc: broulik,

D11066: Convert EffectView to a QQuickWidget

fvogt added a comment. I won't land this now to give @graesslin a chance to review this as well. REPOSITORY R108 KWin BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D11066 To: fvogt, #plasma, graesslin, davidedmundson Cc: kwin, plasma-devel, #kwin, iodelay, bwowk,

D11056: [mediacontroller applet] Use media playback status icons

romangg edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10032: Swap play/pause icons in mediacontroller plasmoid

nicolasfella abandoned this revision. nicolasfella added a comment. Abandoning in favor of D11056 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10032 To: nicolasfella, #plasma, #vdg Cc: rizzitello, abetts,

D11056: [mediacontroller applet] Use media playback status icons

romangg added a comment. Should we add a fallback mechanism in case the icon pack does not contain the media playback state icons? I mean as a fallback the normal media-playback-start and pause icons again as it is now. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D11059: Add convenience method to get a persistent model index from TasksModel

Zren added a comment. Typo. You only have 1 "s" in persistent there. makePeristentModelndex QPersistentModelIndex clients.push(tasksModel.makePersistentModelIndex(i)); // minimizeall REPOSITORY R120 Plasma Workspace REVISION

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28767. progwolff added a comment. - fix preview scale on high dpi screens REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28740=28767 BRANCH master REVISION DETAIL

D11069: [WIP] refine decoration shadows

zzag added a comment. In D11069#219426 , @hpereiradacosta wrote: > Hello, > Thanks for the patch. > > - As we discussed already in telegram, I am not convinced you absolutely need fast fourier transform nor blur, and could probably

D11069: [WIP] refine decoration shadows

zzag added a comment. About KStyle: I suggest to use gradients in order to approximate decoration shadows. It doesn't have big shadows so we don't need too much of precision. Also, I suggest to make them lighter. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069

D11069: [WIP] refine decoration shadows

zzag added a comment. None F5742456: none.png Small F5742458: small.png Medium F5742460: medium.png Large F5742462: large.png

D11064: add preview images to fonts kcm

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:187 > +transform: Scale { > +xScale: 1. / QtWindow.Screen.devicePixelRatio; > +

D11069: [WIP] refine decoration shadows

zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

hpereiradacosta added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

hpereiradacosta added a comment. Hello, Thanks for the patch. - As we discussed already in telegram, I am not convinced you absolutely need fast fourier transform nor blur, and could probably handled thing with "simple" QGradients. If you do not have time to try implement such a

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

Pitel created this revision. Pitel added reviewers: Plasma, martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY Currently global menu is always aligned on the other

D11069: [WIP] refine decoration shadows

zzag created this revision. zzag added reviewers: Breeze, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY 5.12 release introduced new decoration shadows. These new shadows are

D11069: [WIP] refine decoration shadows

zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

zzag added a comment. TODOs: - separate shadow strength settings - improve performance - do not delete cached shadow when last decoration is destroyed? - or, use a faster blur algorithm(i.e. approximate gaussian blur), like exponential blur? - create shadow on startup(e.g.

D11066: Convert EffectView to a QQuickWidget

graesslin accepted this revision. REPOSITORY R108 KWin BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D11066 To: fvogt, #plasma, graesslin, davidedmundson Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts,

D11072: [Active Window Control] Show window title when app name is missing

Pitel created this revision. Pitel added reviewers: Plasma, martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY Some apps do not have application name (e.g. Android

D11066: Convert EffectView to a QQuickWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R108:68a2ec5d6365: Convert EffectView to a QQuickWidget (authored by fvogt). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11066?vs=28743=28765 REVISION DETAIL

D11073: [RFC] [Active Window Control] Elide appmenu when it is too long

Pitel created this revision. Pitel added reviewers: Plasma, martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY When appmenu is too large to fit in and "»" button

D10973: [media controller applet] Support MPRIS services where CanPause==false

kossebau updated this revision to Diff 28777. kossebau added a comment. - remove Stop state again - simply disable Pause button if CanPause==false - still use media-playback-stop button as status when neither paused nor playing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D10762: Fix the build on armhf/aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit R108:3fa287280b04: Fix the build on armhf/aarch64 (authored by bshah). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10762?vs=28659=28781 REVISION DETAIL

Re: Fwd: Re: kwin display issue on librem5

On 03/04/2018 11:38 PM, Bhushan Shah wrote: > Hello, > > On Fri, Mar 02, 2018 at 10:43:28AM -0700, Heather Ellsworth wrote: >>> So my questions for you are: >>> * Do you have any idea what could be missing or causing the >>> display_issue.jpg that could be fixed by exporting KWIN_COMPOSE? > >

D10475: Make it possible to show the title despite having ctx actions

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9665afb2a594: Make it possible to show the title despite having ctx actions (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D11061: Migration request from IBusConfig to GSettings

cfeck added a reviewer: xuetianweng. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

  1   2   >