Re: Look N' Feel and Latte Dock

2018-04-03 14:11 GMT+03:00 Marco Martin : > what do you mean with look and feel support? > do you mean to put latte dock settings in a look and feel package or > to have a look and feel package that requires latte dock (and which > will put it in autostart, which is already

D11852: [colors] add corresponding CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit R31:cf95cfb9528e: [colors] add corresponding CMakeLists.txt (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11852?vs=31076=31210 REVISION DETAIL

D11860: [kstyle] use Q_FALLTHROUGH in breezesplitterproxy

This revision was automatically updated to reflect the committed changes. Closed by commit R31:2983e63983cd: [kstyle] use Q_FALLTHROUGH in breezesplitterproxy (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11860?vs=31090=31212 REVISION

D11722: If GL context creation fails fall back to the software renderer

mart added a comment. anyways, +1 rom me.. tough it would probably be needed some ui somewhere for trying to reenable opengl, maybe visible at all only when disabled. the desktop config dialog may be quite random, tough i don't know where else it could be REPOSITORY R120 Plasma

D11847: [kdecoration] delete unused m_buttons field

This revision was automatically updated to reflect the committed changes. Closed by commit R31:7821b4789593: [kdecoration] delete unused m_buttons field (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11847?vs=31067=31211 REVISION DETAIL

D11021: [Media controller] Add simple volume control

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R120 Plasma Workspace BRANCH mediacontroller REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma, broulik Cc: broulik, nicolasfella,

Re: Look N' Feel and Latte Dock

what do you mean with look and feel support? do you mean to put latte dock settings in a look and feel package or to have a look and feel package that requires latte dock (and which will put it in autostart, which is already supported) On Sun, Apr 1, 2018 at 5:45 PM, Michail Vourlakos

D11801: remove m_desktopContainments

mart updated this revision to Diff 31201. mart added a comment. - setting activity is base corona's job REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11801?vs=30916=31201 BRANCH arcpatch-D11801 REVISION DETAIL

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 31197. broulik added a comment. - Rebase - Address Christoph's comments (4x scale and indentation) REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=29668=31197 REVISION DETAIL

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added a comment. > The only reason why the symbolic line-art versions exist is because the prettier icons look bad at small sizes on low-dpi screens. Note that the physical size of the icon is the same for 1x on low dpi and 2x on high dpi so the icon will be hard to tell which

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

Pitel added a comment. >> show on: mouse out | mouse in | always (and possibly never show unless it is covered by other options, show on mouse out not available for buttons and appmenu) > > This one I don't fully understand. Why show on: mouse_out|mouse_in for all items is not enough

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham accepted this revision as: VDG. ngraham added a comment. OK, +1 then! If we can safely implement this part of the spec without causing any unexpected visual changes, then I don't see a problem with it. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. Okay I've deployed the patch, and without applying the change specified in the "For testing..." sentence, I was unable to find any visual changes from the status quo resulting from this patch. Is that intentional? For example `QT_SCREEN_SCALE_FACTORS=3 kate` does

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added a comment. > Okay I've deployed the patch, and without applying the change specified in the "For testing..." sentence, I was unable to find any visual changes from the status quo resulting from this patch. Is that intentional? Yes, as Breeze currently does not offer any

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. @ngraham, in the initial description @broulik forced a @2x folder via symlink to test. Otherwise no change will be observed. :) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg

D6313: Support Icon Scale from Icon naming specification 0.13

davidedmundson added a comment. RE: QT_SCALE_FACTOR vs QT_SCREEN_SCALE_FACTORS See: https://paste.kde.org/p0y4ze6dg REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, ngraham,

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. Thanks David! HiDPI turns out to be complicated... ;-) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck,

[kio-extras] [Bug 359636] SMB and SFTP (probably others) cannot be configured to not append ".part" extension from GUI

https://bugs.kde.org/show_bug.cgi?id=359636 Christoph changed: What|Removed |Added CC||ilove...@mojo.cc Ever

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added a comment. In other words, the icon theme designer can now decide if he makes HiDPI only bigger or more detailed by symlinking to either the less detailed or the more detailed svg, without duplicating the icon files? REPOSITORY R302 KIconThemes REVISION DETAIL

D11866: Fix install target for kgamma

This revision was automatically updated to reflect the committed changes. Closed by commit R100:ac7becc0c8eb: Fix install target for kgamma (authored by lueck). REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11866?vs=31105=31228 REVISION DETAIL

D11746: Assign notification area category

wsdfhjxc added a comment. All of them seem to be accepted, but I can't land anything by myself. Feel free to do it on your own. REPOSITORY R116 Plasma Network Management Applet BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11746 To: wsdfhjxc, #plasma, broulik Cc:

D11746: Assign notification area category

Pitel added a comment. @wsdfhjxc can you land it yourself or should I do it? I would like to land this, D11748 , D11749 , D11750 , and D11751 , so

D11021: [Media controller] Add simple volume control

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bd5619e0155a: [Media controller] Add simple volume control (authored by Pitel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11021?vs=30963=31231

D11909: properly use kpackage_install_package

zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY NO_DEPRECATED_WARNING passed as the fifth arg to

D11909: properly use kpackage_install_package

zzag added a subscriber: davidedmundson. zzag added a comment. @davidedmundson in https://github.com/KDE/plasma-workspace/commit/450ef5884d9e93e6f0a2df48aae82f9ed239b394 you said: > Concept is fine, but currently we have severe CMake issues ... I've tried

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added inline comments. INLINE COMMENTS > kiconloader.h:279 > + */ > +QPixmap loadIcon(const QString , KIconLoader::Group group, qreal > scale, int size = 0, > + int state = KIconLoader::DefaultState, const > QStringList = QStringList(), loadIcon("test",

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. In D6313#239212 , @cfeck wrote: > In other words, the icon theme designer can now decide if he makes HiDPI only bigger or more detailed by symlinking to either the less detailed or the more detailed svg, without