D12102: Port Language KCM to Qt Quick

rkflx added a comment. In D12102#250725 , @abetts wrote: > Here are additional mockups for thought.F5815917: Screen Shot 2018-04-20 at 10.54.07 PM.png Quite nice (the helpful text label in

D12311: Align lock icon with bold message text; reduce overall size of dialog

stikonas added a comment. In D12311#250688 , @bruns wrote: > Gnome-disks does, and so do other programs. Gnome-disks uses UDisks to do everything and can't do anything on its own. So available features are very limited (not even resizing

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. > Docs say QT_SCREEN_SCALE_FACTORS doesn't affect the logical DPI. which means you have a 1x scale on one screen 2x on another..they both have the same font size which will just be really wrong. Exactly that is not the case. Let me give you an example for

D12102: Port Language KCM to Qt Quick

hein added a comment. Another issue I have with SwipeListItem: In addition to the hover effect, there's always a fancy flashing effect on clicks, even though it doesn't do anything in my list. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein,

D12102: Port Language KCM to Qt Quick

hein added a comment. With the right text and disabling the default action for the first item: F5816462: Screenshot_20180421_234449.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami,

D12102: Port Language KCM to Qt Quick

ngraham added a comment. Lookin' pretty sharp! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12102: Port Language KCM to Qt Quick

hein added a comment. So, how are we gonna approach this drag thing? Three dots? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen,

D12102: Port Language KCM to Qt Quick

ngraham added a comment. > Pick your default language by moving topmost. To add more languages, click on the right. How about this? > The language at the top of this list is the one you want to see and use most often. To add more languages, click the "Add Languages..." button.

D12102: Port Language KCM to Qt Quick

ngraham added a comment. For this list, where the items themselves don't do anything on click, I think it's sane to allow the whole list item to be a drag area. There's more of a challenge to allow re-ordering items that do something when you click on them, but we don't have that issue

D12102: Port Language KCM to Qt Quick

hein added a comment. In D12102#251048 , @ngraham wrote: > For this list, where the items themselves don't do anything on click, I think it's sane to allow the whole list item to be a drag area. There's more of a challenge to allow re-ordering

D12102: Port Language KCM to Qt Quick

hein added a comment. I like the mockup, but yeah, still need to figure out ordering. As for the top text label, let's go with "Preferred languages" over "Installed languages" (also what the old KCM used). REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein added a comment. Turns out tooltip support is there already: F5816427: Screenshot_20180421_233951.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev,

D12102: Port Language KCM to Qt Quick

hein added a comment. https://www.youtube.com/watch?v=gdnuOa7tDco REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

davidedmundson added a comment. I can't imagine this working. It didn't when I've tried the same thing. Docs say QT_SCREEN_SCALE_FACTORS doesn't affect the logical DPI. which means you have a 1x scale on one screen 2x on another..they both have the same font size which will just be really

D12102: Port Language KCM to Qt Quick

hein added a comment. An early attempt at implementing @abetts new mockup: F5816409: Screenshot_20180421_232025.png F5816411: Screenshot_20180421_232046.png I didn't do the icons because: (a) I

D12102: Port Language KCM to Qt Quick

ngraham added a comment. In D12102#251008 , @hein wrote: > Yeah, I think duplicating the button text is goofy. I'm OK with the first sentence. > > Otherwise, personally I would like the list to be like this: > > (a) Have a drag handle

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey updated this revision to Diff 32758. sharvey added a comment. - Merge branch 'master' into align-lock-icon - Undo manual resizing of ser combo box & password error box REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Qt computes the scale factor relative to the primary screen. This means we can support per-screen DPI on X11 by setting

D12102: Port Language KCM to Qt Quick

hein added a comment. Yeah, I think duplicating the button text is goofy. I'm OK with the first sentence. Otherwise, personally I would like the list to be like this: (a) Have a drag handle and be drag-reorderable (missing in Kirigami (b) On hover, show icon-based "Move to top"

D12102: Port Language KCM to Qt Quick

hein added a comment. BTW: I think SwipeListItem actions should have support for tooltips, so those actions can have "Make default" and "Remove" tooltips. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev,

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. Okay, this patch is back to where we started, with nothing changed except centering the icon. Hopefully we can commit it now. I'll move the discussion over how to redesign the dialog itself to a separate task. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. FYI: I undid the wonky manual UI sizing that @broulik objected to. In hindsight, not the best approach. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey,

D12102: Port Language KCM to Qt Quick

rkflx added a comment. Looking better now ;) One more note: Users read the dialog from the top. Having "Default" added to the topmost entry like in @abetts' mockup would be great, if possible at all, because most users won't really get to the text at the bottom. As for the handle,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. > I'm pointing out that I'm in general against any risky changes on X11. If users want to use this features: Wayland is there. KWin is feature frozen on X11 and I highly suggest to the Plasma community to decide the same at the sprint. We will have less maintenance

D12278: WIP: [Colors KCM] Port to new design

ngraham added a comment. -1 for "current" here too. I also don't like "Default" either. What does that even mean to a regular user? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg Cc: mart, abetts, ngraham,

D12278: WIP: [Colors KCM] Port to new design

mart added a comment. In D12278#248160 , @ngraham wrote: > It would be really cool if the delegates would show a little preview of a window actually using these colors, instead of the current grid of colored squares. it's probably not

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

hein added a comment. In principle I'm inclined to side with Martin here. At this point, I no longer want the extra burden/distraction of working on newly-introduced X11-related bugs. It's frustrating to spend manhours on code you know will be obsolete, and that delays getting work done to

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

graesslin added a comment. I also cannot imagine this to work due to the fact how X11 works. There is just no mapping from window to screen. No window can know on which screen it is. Not even KWin knows that as the window manager (screen is not a constant property, but evaluated every time

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

graesslin added a comment. I'm pointing out that I'm in general against any risky changes on X11. If users want to use this features: Wayland is there. KWin is feature frozen on X11 and I highly suggest to the Plasma community to decide the same at the sprint. We will have less maintenance

D12278: WIP: [Colors KCM] Port to new design

ngraham added a comment. In D12278#251210 , @mart wrote: > In D12278#248160 , @ngraham wrote: > > > It would be really cool if the delegates would show a little preview of a window actually using

D12373: Klipper: Remove first history item on clipboard clear

graesslin added a comment. Sorry, but I'm against this. The options keepass provides are just bullshit (sorry to be that direct). That cannot work and will not work. One cannot remove anything from the clipboard, trying to do so is insane. What would make most sense for things like

D12102: Port Language KCM to Qt Quick

ngraham added a comment. +1 for putting the text on the top rather than the bottom. Once we make the list draggable, it might be nice to incorporate that into the text too, e.g "drag languages into your preferred order" or something like that. Unfortunately, our use of the hamburger

D12102: Port Language KCM to Qt Quick

hein added a comment. Adding 'Default' is pretty easy, no problem. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. > So I wouldn't trust this thing in Qt to work due to the pain we have in KWin especially with these problems. Yes, it might not be perfect. It works well enough that not exposing this in the settings is a wasted opportunity though. I used this extensively for

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

ngraham added a comment. +1 for not letting the perfect be the enemy of the good here. Multi-monitor support is a pain point for many of our users. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: ngraham, graesslin, davidedmundson,

D12102: Port Language KCM to Qt Quick

mart added a comment. In D12102#251163 , @ngraham wrote: > +1 for putting the text on the top rather than the > Unfortunately, our use of the hamburger button precludes use of that elsewhere-fairly-universal "three bar" symbol to mean "this

D12069: Implement a keyboard selector plasmoid

graesslin added a comment. I don't think that there's any reason to discard this. It's a start and improvement over the current situation and a fallback is needed anyway. So we start with the fallback instead of adding it later on. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D12102: Port Language KCM to Qt Quick

mart added a comment. In D12102#251163 , @ngraham wrote: > +1 for putting the text on the top rather than the bottom. Once we make the list draggable, it might be nice to incorporate that into the text too, e.g "drag languages into your

D12278: WIP: [Colors KCM] Port to new design

mart added a comment. In D12278#248109 , @davidedmundson wrote: > > Not too fond of this "Current" > > me neither, if it was up to me, I'd just show a prompt asking for a name when you click "edit" on a system scheme. Would be nice and