D14024: Move KCM to UI file

gladhorn updated this revision to Diff 37501. gladhorn added a comment. Fixed stretch for unified outputs REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14024?vs=37496=37501 BRANCH gladhorn/ui REVISION DETAIL https://phabricator.kde.org/D14024

D14023: Make Primary Combo a regular QComboBox

gladhorn updated this revision to Diff 37502. gladhorn added a comment. Removed left over debug statements REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14023?vs=37495=37502 REVISION DETAIL https://phabricator.kde.org/D14023 AFFECTED FILES

D14026: [Pager] Don't show a window list on hover if there is only one window

nicolasfella updated this revision to Diff 37504. nicolasfella added a comment. - Unrelated change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14026?vs=37503=37504 BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026

D14026: [Pager] Don't show a window list on hover if there is only one window

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, makes sense to me. Wait for @hein or @broulik's approval too though. REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 To:

D14026: [Pager] Don't show a window list on hover if there is only one window

mart added a comment. but would still make sense to know how that one window is called? REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 To: nicolasfella, hein, broulik, ngraham Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot,

D14024: Move KCM to UI file

ngraham added a comment. If we're going to do any UI porting, how about to QML instead? That's the future. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14024 To: gladhorn, #plasma, sebas Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14026: [Pager] Don't show a window list on hover if there is only one window

nicolasfella created this revision. nicolasfella added reviewers: hein, broulik, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY If there is only one visible window

D14024: Move KCM to UI file

ngraham added a comment. OK, no problem. :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14024 To: gladhorn, #plasma, sebas Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14024: Move KCM to UI file

gladhorn added a comment. Sure, but let's get there step by step. In general this needs some un-tangling of functionality and UI first. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14024 To: gladhorn, #plasma, sebas Cc: ngraham, plasma-devel, ragreen, Pitel,

Plasma 5.13.3 released

Hello people, Plasma team is happy to announce Plasma 5.13.3 Announcement at : https://www.kde.org/announcements/plasma-5.13.3.php Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc

D14025: Move scale and unify button to the top, next to primary combo

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 In D14025#289826 , @gladhorn wrote: > depends on https://phabricator.kde.org/D14024 The correct way to express this is:

D14026: [Pager] Don't show a window list on hover if there is only one window

nicolasfella added a comment. In D14026#289890 , @mart wrote: > but would still make sense to know how that one window is called? The name is still there. Just some cruft around is removed REPOSITORY R119 Plasma Desktop BRANCH

D14007: doc: Delete info about removed checkbox "Place in system tray"

This revision was automatically updated to reflect the committed changes. Closed by commit R103:c8d7e854738a: doc: Delete info about removed checkbox Place in system tray (authored by aspotashev). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE

D14023: Make Primary Combo a regular QComboBox

gladhorn added a comment. Need to remove debug statements. INLINE COMMENTS > widget.cpp:171 > + > +qDebug() << Q_FUNC_INFO; > +Q_FOREACH (const KScreen::OutputPtr , mConfig->outputs()) { Left over debug statement. Remove. > widget.cpp:508 > +{ > +qDebug() << Q_FUNC_INFO <<

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/19/ Project: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Jul 2018 09:39:59 + Build duration: 24 min and counting CONSOLE OUTPUT

KDE CI: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/22/ Project: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Jul 2018 09:40:04 + Build duration: 29 min and counting CONSOLE

D14023: Make Primary Combo a regular QComboBox

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This will make it easier to re-design the UI. Also it centralizes all updates, before a bunch

D14024: Move KCM to UI file

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This fixes the size policy, the only element we want expanding is the preview area on top,

D14025: Move scale and unify button to the top, next to primary combo

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH gladhorn/ui REVISION DETAIL https://phabricator.kde.org/D14025 AFFECTED

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. The diff is confusing. It actually moves the buttons into the other layout :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14025: Move scale and unify button to the top, next to primary combo

broulik added a comment. Please add a screenshot when you do UI changes REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. before: F6067872: kscreen_kcm_before.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. after: F6067891: kscreen_kcm_after.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D14024: Move KCM to UI file

gladhorn added a comment. depends on https://phabricator.kde.org/D14023 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14024 To: gladhorn, #plasma, sebas Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. depends on https://phabricator.kde.org/D14024 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn, #vdg, #plasma, sebas Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. This is at least a first step in making the UI a bit nicer. And imho it's a low-hanging fruit. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/10/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 10 Jul 2018 09:38:51 + Build duration: 3 min 41 sec and counting

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/12/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Jul 2018 09:38:51 + Build duration: 6 min 28 sec and counting

D13752: Build solidautoeject only on FreeBSD

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:edd5e889f583: Build solidautoeject only on FreeBSD (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES

D13776: Move remaining salt file operations into unprivileged processes

fvogt added a comment. In D13776#289669 , @aacid wrote: > In D13776#289490 , @fvogt wrote: > > > > Are you saying that there are files that root can't read but the user can? > > > > Exactly. >

D14029: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Fixes timeline and search URLs in "Computer" tab BUG:

D14030: [Kickoff] Use KFilePlacesModel groups

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This groups entries in Places under the same categories

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/20/ Project: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Jul 2018 14:16:57 + Build duration: 10 min and counting JUnit Tests

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 13 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/13/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Jul 2018 14:16:58 + Build duration: 10 min and counting JUnit

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added inline comments. INLINE COMMENTS > gladhorn wrote in outputconfig.cpp:145 > Why not use QScopedPointer here? I just moved the code from kcm/src/widget.cpp. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: gladhorn, mart, hein,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

gladhorn added a comment. I've been running with QT_SCREEN_SCALE_FACTORS set manually for at least half a year and it works for me. Except for suspending, so that seems to be a wide spread issue, maybe even in Qt. I'm strongly in favor of this, it is the only thing that works sensibly on

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

gladhorn added inline comments. INLINE COMMENTS > outputconfig.cpp:145 > +connect(scaleDialogButton, ::released, [this] { > +QPointer dialog = new ScalingConfig(mOutput, > this); > +dialog->exec(); Why not use QScopedPointer here? REPOSITORY R104 KScreen

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

kossebau resigned from this revision. kossebau added a comment. Looks like proper work from a quick reading glance at the patch, thanks for providing the patch, Again, not the maintainer and no time to properly review. Needs someone from the active Plasma team to get this in. If no-one

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

mart added a comment. in principle i agree, I would love to be able to use this in qguiapplications, but are we sure qstyles won't access qapplication? doesn't this risk to just move the crash? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D13981: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R169:7dd3aa0b2a4b: Honor BUILD_TESTING (authored by arojas). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13981?vs=37355=37516 REVISION DETAIL

D14031: Move ECM & Co. macro includes before finding Qt & KF

kossebau created this revision. kossebau added reviewers: gladhorn, sebas, romangg. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY For consistency with other Plasma repos, but

D13998: [Logout Greeter] Remove KDM cruft

This revision was automatically updated to reflect the committed changes. Closed by commit R120:485193ebcaf0: [Logout Greeter] Remove KDM cruft (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13998?vs=37432=37519#toc REPOSITORY R120 Plasma Workspace CHANGES

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > this has been fixed in QtQuick.Controls 2.0 Not technically true. It's worked round in our qqc2 desktop theme. I don't generally approve workarounds, but as

D13932: Show icons for actions that have an icon source rather than an icon name

This revision was automatically updated to reflect the committed changes. Closed by commit R169:1454366a2e33: Show icons for actions that have an icon source rather than an icon name (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

bosimonsen updated this revision to Diff 37517. bosimonsen retitled this revision from "Use PlasmaComponents for Label" to "Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM". bosimonsen edited the summary of this revision. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D14031: Move ECM & Co. macro includes before finding Qt & KF

kossebau added a comment. That unconditional reset of ECM_GLOBAL_FIND_VERSION is IMHO a flaw which should see some general fix. But no idea yet, so for now change on "our" side. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14031 To: kossebau, gladhorn, sebas,

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

ngraham added a comment. Does this really resolve all of https://bugs.kde.org/show_bug.cgi?id=366451? I see several issues described in there... REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14011 To: bosimonsen, davidedmundson Cc: davidedmundson, ngraham,

D14023: Make Primary Combo a regular QComboBox

gladhorn updated this revision to Diff 37530. gladhorn added a comment. Make diff slightly smaller (newlines) and remove a qDebug that was stil left over. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14023?vs=37502=37530 BRANCH master REVISION

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham added a comment. In D13593#282711 , @mart wrote: > if as native speaker you think antialias isn't nearly common enough, go for it :) Yes, that's my position. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

bosimonsen added a comment. In D14011#290076 , @ngraham wrote: > Does this really resolve all of https://bugs.kde.org/show_bug.cgi?id=366451? I see several issues described in there... I believe, most issues are resolved (the splash

D13745: Implement support for virtual desktops on Wayland

hein updated this revision to Diff 37527. hein added a comment. Drop the population loop, it's as unnecessary as it should be. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13745?vs=37206=37527 BRANCH master REVISION DETAIL

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham added a comment. I ran into an issue with the QtQuick tooltips, unfortunately: they don't wrap, and instead overflow the bounds of the window: F6073151: overflows.png I couldn't figure out a way to limit the width to avoid overflowing.

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham updated this revision to Diff 37525. ngraham added a comment. Add technical tooltips REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13593?vs=36288=37525 BRANCH more-user-friendly-strings-in-fonts-KCM (branched from master) REVISION

D14031: Move ECM & Co. macro includes before finding Qt & KF

This revision was automatically updated to reflect the committed changes. Closed by commit R104:615b0353f294: Move ECM Co. macro includes before finding Qt KF (authored by kossebau). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14031?vs=37518=37526

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37534. nicolasfella marked 2 inline comments as done. nicolasfella edited the summary of this revision. nicolasfella added a comment. - Fix indentation in QML - Add i18n calls - Use QLatin1String - Coding style - Switch statement indentation

D14035: Unbreak SSH agent support for SSH VPN tunnels.

catherinez created this revision. catherinez added a reviewer: Plasma. catherinez added a project: Plasma. Restricted Application added a subscriber: plasma-devel. catherinez requested review of this revision. REVISION SUMMARY Right now selecting SSH agent as authentication method for SSH VPNs

D14031: Move ECM & Co. macro includes before finding Qt & KF

gladhorn added a comment. Seems OK to me. REPOSITORY R104 KScreen BRANCH movemoduleincludestofront REVISION DETAIL https://phabricator.kde.org/D14031 To: kossebau, gladhorn, sebas, romangg, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D14029: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel

hein added a comment. Yeah, I think this isn't very pretty unfortunately. Does KIO have a way to give a human-readable description of an URL or something? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14029 To: broulik, #plasma, hein Cc: ngraham,

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham updated this revision to Diff 37533. ngraham added a comment. Revert unintentional changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13593?vs=37525=37533 REVISION DETAIL https://phabricator.kde.org/D13593 AFFECTED FILES

D14029: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel

ngraham added a comment. Verified that this fixes the bug. Sadly this does make the subtitle somewhat ugly for the Search For entries in particular: F6072507: Screenshot_20180710_163530.png Is there nothing we can do about that? REPOSITORY

D13931: [KCM] Add speaker placement test

nicolasfella added a comment. The ComboBox part is a little hacky because I couldn't figure out a nice way to access the model data from outside a delegate REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13931 To: nicolasfella, drosca Cc:

D14030: [Kickoff] Use KFilePlacesModel groups

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14030 To: broulik, #plasma, hein, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D14029: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. In the meantime this is a necessary bugfix though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14029 To: broulik, #plasma, hein Cc: ngraham, plasma-devel,

D13776: Move remaining salt file operations into unprivileged processes

aacid added a comment. Ok, looks good on paper, i have not had time to test this and i don't think i'll have until at least next week since i'm going away on holiday in 24h. If you are confident you have tried this and doesn't break the regular use cases (i.e. file is already there and