D14364: Test configId in TestSerializer

gladhorn updated this revision to Diff 38518. gladhorn edited the summary of this revision. gladhorn added a comment. Add more explanations REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14364?vs=38408=38518 BRANCH arcpatch-D14364 REVISION DETAIL

D14405: Use short pnp id as fallback when the DB file is not found

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY At least on arch linux pnp.ids does not even exist (while usb.ids and pci.ids do). There seem

D14359: Use inintializers and only create m_saveTimer when needed

gladhorn updated this revision to Diff 38516. gladhorn added a comment. Initialize m_changeCompressor to nullptr REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14359?vs=38400=38516 BRANCH arcpatch-D14359 REVISION DETAIL

D14359: Create m_saveTimer lazily

gladhorn updated this revision to Diff 38517. gladhorn retitled this revision from "Use inintializers and only create m_saveTimer when needed" to "Create m_saveTimer lazily". gladhorn added a comment. Only touch saveTimer REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D14410: EDID parsing: strings are up to 13 bytes

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The descriptor blocks with strings come every 18 bytes, 5

D14326: Fix layout of resolution selection

This revision was automatically updated to reflect the committed changes. Closed by commit R104:5b6e9767a73e: Fix layout of resolution selection (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14326?vs=38515=38543 REVISION DETAIL

D14392: Don't consider filtered out tasks siblings when sorting in new tasks

hein created this revision. hein added a reviewer: davidedmundson. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY BUG:396792 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D14392

D14389: Invert shade button by same logic as keep-above button

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, the issue here is that unlike the Keep Above button, the Shade button actually changes its icon when used. So it's not so much a "shade enabled/shade disabled" button, as

D14381: Wayland: be consistent about screen name

This revision was automatically updated to reflect the committed changes. Closed by commit R110:d7cef1a5a987: Wayland: be consistent about screen name (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14381?vs=38457=38485

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. In D14339#297849 , @ngraham wrote: > Looks nice! > > I would approve of using radio buttons or four actual inline buttons instead of a combobox. > > Also +1 on "No Rotation" instead of "Normal", and for doing

D14398: [dict applet] Fix translation catalog name to match pluginid

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY BUG 396793 FIXED-IN: 5.12.7 REPOSITORY R114 Plasma Addons

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. And I see that arc just threw away my updated commit message :(, that's just weird. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D14398: [dict applet] Fix translation catalog name to match pluginid

This revision was automatically updated to reflect the committed changes. Closed by commit R114:076539340f5f: [dict applet] Fix translation catalog name to match pluginid (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D14339: Remove confusing icons from rotation combobox

gladhorn updated this revision to Diff 38486. gladhorn added a comment. Updated message hopefully REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38382=38486 BRANCH arcpatch-D14339 REVISION DETAIL https://phabricator.kde.org/D14339 AFFECTED

D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

kossebau updated this revision to Diff 38504. kossebau added a comment. Complete the indentation Other sketched changes like splitting out into own test case methods not continued here, needs bigger work with more understanding of the tested stuff REPOSITORY R110 KScreen Library

D14340: [Multimedia KCM] Kill PulseAudio device setup

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land.  Awesome work on the plasma-pa side too! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14340 To: broulik, #plasma, sitter Cc: nicolasfella,

D14359: Use inintializers and only create m_saveTimer when needed

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. What @broulik says. It should be fine with the `m_changeCompressor` being startet in `init`, but the git message should note this. Also the git message could be a bit more

D14353: Improve alignment of types

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Why push id down? It should stay at the top imo (or alphabetically). Rest is fine. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14353 To:

D14368: Let edidDecodeFraction return float

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. You use the `result` var of type float in an addition 10 times. Now the calculation is done with less precision. The git message should state why it's no problem. REPOSITORY

D14371: Simplify Edid::Private::parse gamma

romangg added a comment. > I do wonder if the division by 100 is right though - and where does the +1 come from? In regards to EDID 1.4 data format Wikipedia says: > 23 | Display gamma, factory default (range 1.00–3.54), datavalue = (gamma×100)-100 = (gamma−1)×100. If 225, gamma

D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

gladhorn added a comment. Looks good, please finish up cleanup/indentation and I'll accept. INLINE COMMENTS > testinprocess.cpp:142 > +if (m_backendServiceInstalled) { > qDebug() << "TT xrandr out-of-process"; > // Load the xrandr backend out-of-process Please indent.

D14364: Test configId in TestSerializer

romangg requested changes to this revision. romangg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > serializertest.cpp:127 > QCOMPARE(screen->currentSize(), QSize(1920, 1280)); > +QCOMPARE(Serializer::configId(config), >

D14370: Simplify Edid::Private::edidParseString

This revision was automatically updated to reflect the committed changes. Closed by commit R110:2dfbe8d8a6cc: Simplify Edid::Private::edidParseString (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14370?vs=38423=38501 REVISION

D14353: Improve alignment of types

gladhorn added a comment. In D14353#298417 , @romangg wrote: > Why push id down? It should stay at the top imo (or alphabetically). Rest is fine. Because of padding. On 64 bit when int is usually 4 bit, there will be a hole of 4 bits in

D14361: Remove unused function

gladhorn added inline comments. INLINE COMMENTS > broulik wrote in daemon.h:38 > Can this cause trouble with ABI since this class is exported? But it's > probably just exported as an entry point for KDED and not for use as a library Well, the header is not installed, so the export seems pretty

D14347: Fix blocky text on splash screen when using non-integer scale factor

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. > Add the right import (this somehow works without it, so there must be an implicit import somewhere...) More like it fails to `assign [undefined] to int` and then it never changes

D14347: Fix blocky text on splash screen when using non-integer scale factor

ngraham added a comment. In D14347#298510 , @broulik wrote: > > Add the right import (this somehow works without it, so there must be an implicit import somewhere...) > > More like it fails to `assign [undefined] to int` and then it never

D14403: Change screen orientation label from Normal to No Rotation

This revision was automatically updated to reflect the committed changes. Closed by commit R104:6dd05a592d48: Change screen orientation label from Normal to No Rotation (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D14326: Fix layout of resolution selection

gladhorn added a comment. The alignment previous to this commit is also not given, it just happens to look a hint better. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg, ngraham Cc: andreaska, abetts, ngraham, broulik, zzag,

D14353: Improve alignment of types

gladhorn added a comment. Of course it's questionable if this is worth it, it's unlikely that we'll have so many instances of it that it'll ever make a difference. INLINE COMMENTS > output.cpp:89 > +int id; > qreal scale; > +Type type; Actually scale should move up maybe,

D14403: Change screen orientation label from Normal to No Rotation

gladhorn created this revision. gladhorn added reviewers: VDG, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL

D14339: Change rotation icons to be a rotated preview icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great, works great! REPOSITORY R104 KScreen BRANCH arcpatch-D14339 REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham, romangg Cc:

D14339: Change rotation icons to be a rotated preview icon

This revision was automatically updated to reflect the committed changes. Closed by commit R104:200cdd782e5f: Change rotation icons to be a rotated preview icon (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38486=38505

D14347: Fix blocky text on splash screen when using non-integer scale factor

davidedmundson accepted this revision. davidedmundson added a comment. Anyway, ship it REPOSITORY R120 Plasma Workspace BRANCH fix-blocky-splash-screen-text (branched from Plasma/5.12) REVISION DETAIL https://phabricator.kde.org/D14347 To: ngraham, #plasma, davidedmundson, broulik

D14347: Fix blocky text on splash screen when using non-integer scale factor

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1467427b6569: Fix blocky text on splash screen when using non-integer scale factor (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D14347: Fix blocky text on splash screen when using non-integer scale factor

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14347 To: ngraham, #plasma, davidedmundson, broulik Cc: abetts, broulik, svenmauch, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14339: Change rotation icons to be a rotated preview icon

abetts added a comment. +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham, romangg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14340: [Multimedia KCM] Kill PulseAudio device setup

This revision was automatically updated to reflect the committed changes. Closed by commit R119:06c8b9bade76: [Multimedia KCM] Kill PulseAudio device setup (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14340?vs=38351=38514#toc REPOSITORY R119 Plasma Desktop

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 - Build # 141 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.10/141/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 26 Jul 2018 15:03:27 + Build duration: 4 min 19 sec and counting CONSOLE

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 152 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/152/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Thu, 26 Jul 2018 15:03:27 + Build duration: 8 min 29 sec and counting JUnit Tests

D14326: Fix layout of resolution selection

gladhorn updated this revision to Diff 38515. gladhorn added a comment. Fix the layout REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14326?vs=38317=38515 BRANCH arcpatch-D14326_1 REVISION DETAIL https://phabricator.kde.org/D14326 AFFECTED FILES