D14806: [AppStream Runner] Reduce verbosity of log output

bruns added a comment. @apol Still waiting for review ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14806 To: bruns, #plasma, apol, ngraham Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8d945c2e5547: [AppStream Runner] Reduce verbosity of log output (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14806?vs=41126=41542

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added a comment. Ping! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

Hi all, Please see below. If someone could please take a look and fix this failure that would be appreciated. On another note, the Marble build recently broke with a similar error - has something been changed in Frameworks to remove a dependency on DBus by any chance? Cheers, Ben --

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/44/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 13 Sep 2018 22:27:48 + Build duration: 6 min 19 sec and counting

D15491: [Bookmarks Runner] Remove BuildQuery Functor class

This revision was automatically updated to reflect the committed changes. Closed by commit R120:531d7d2c9068: [Bookmarks Runner] Remove BuildQuery Functor class (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15491?vs=41585=41592

D15490: [Bookmarks Runner] Remove unused database parameter from query

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The query is no longer initialized for each query, just once, thus there no longer is a need for

D15488: [Bookmarks Runner] Expose list of tables from FetchSqlite

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fetchsqlite.cpp:104 > + > +QStringList FetchSqlite::tables(QSql::TableType type) > +{ please guard this with the mutex > fetchsqlite.cpp:106

D15491: [Bookmarks Runner] Remove BuildQuery Functor class

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Instead of constructing the query string on each favicon fetch just use the (fixed) sql query

D15488: [Bookmarks Runner] Expose list of tables from FetchSqlite

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY This is a preparatory patch required for further rework TEST PLAN make REPOSITORY R120 Plasma

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/43/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 13 Sep 2018 21:52:18 + Build duration: 2 min 0 sec and counting CONSOLE OUTPUT

Plasma/5.14 branches made

stable branches are now Plasma/5.14, please fix bugs for next 3 weeks until release

D15488: [Bookmarks Runner] Expose list of tables from FetchSqlite

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0ac6c595389c: [Bookmarks Runner] Expose list of tables from FetchSqlite (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15489: [Bookmarks Runner] Initialize Chrome favicon query only once per profile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:984b283272f2: [Bookmarks Runner] Initialize Chrome favicon query only once per profile (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15488: [Bookmarks Runner] Expose list of tables from FetchSqlite

bruns updated this revision to Diff 41588. bruns added a comment. scrap spurious line lock mutex REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15488?vs=41582=41588 REVISION DETAIL https://phabricator.kde.org/D15488 AFFECTED FILES

D15490: [Bookmarks Runner] Remove unused database parameter from query

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c7e6b584de6d: [Bookmarks Runner] Remove unused database parameter from query (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15489: [Bookmarks Runner] Initialize Chrome favicon query only once per profile

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The db scheme will not change during the FetchSqlite livetime. Query the scheme just once per

D15440: Translated into Russian

aspotashev added a comment. Translation committed into SVN: https://websvn.kde.org/?view=revision=1524686 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15440 To: sheykhnurlatipov, pino Cc: aspotashev, pino, plasma-devel, ragreen, Pitel,

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Sep 2018 16:30:37 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated 93.36

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/9/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Sep 2018 17:26:09 + Build duration: 21 min and counting CONSOLE OUTPUT [...truncated 91.39

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. @davidedmundson Ping! This just missed the 5.14 window. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: acrouthamel, fabianr, huftis, rooty, sharvey, romangg, broulik,

Plasma 5.14 beta

Plasma 5.13.90 is now released https://www.kde.org/announcements/plasma-5.13.90.php

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Sep 2018 16:32:59 + Build duration: 19 min and counting CONSOLE OUTPUT [...truncated 89.96

D15418: Dim application icon when it is not playing anything

broulik added a comment. All of that is reserved for being "Muted". Just because it doesn't play something doesn't mean it couldn't start producing sound any moment. We shouldn't use anything that could be confused as "muted" ("can never make any sound") for "not playing //currently//"

D15418: Dim application icon when it is not playing anything

abetts added a comment. In D15418#325344 , @broulik wrote: > All of that is reserved for being "Muted". Just because it doesn't play something doesn't mean it couldn't start producing sound any moment. > We shouldn't use anything that could

D15315: Set gtk-modules to auto-load appmenu-gtk-module

hein added a comment. I'm super sorry, arc patch changed authorship somehow :( It randomly sometimes does and doesn't do this and I forgot to check REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15315 To: broulik, #plasma, davidedmundson, fvogt, hein Cc:

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Sep 2018 17:23:16 + Build duration: 3 min 8 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/6/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Sep 2018 16:42:39 + Build duration: 35 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.11 - Build # 37 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.11/37/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 13 Sep 2018 17:24:18 + Build duration: 5 min 0 sec and counting CONSOLE OUTPUT [...truncated

D15418: Dim application icon when it is not playing anything

acrouthamel added a comment. In D15418#325344 , @broulik wrote: > All of that is reserved for being "Muted". Just because it doesn't play something doesn't mean it couldn't start producing sound any moment. > We shouldn't use anything that

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.11 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/4/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 13 Sep 2018 16:32:59 + Build duration: 7 min 56 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/7/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Sep 2018 16:30:30 + Build duration: 11 min and counting CONSOLE OUTPUT [...truncated 91.38

D15115: fix translations kcm to be usable on new users/installations

This revision was automatically updated to reflect the committed changes. Closed by commit R119:991bcf7d0d90: fix translations kcm to be usable on new users/installations (authored by sitter, committed by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15418: Dim application icon when it is not playing anything

abetts added a comment. In D15418#325340 , @acrouthamel wrote: > How about changing the volume icon for the non-playing application to `audio-volume-muted.svg`? Then, when it is playing audio, it reverts to low/high icons as usual, based on

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/8/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Sep 2018 16:41:36 + Build duration: 27 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/7/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 13 Sep 2018 17:26:20 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/5/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 13 Sep 2018 16:30:37 + Build duration: 7 min 21 sec and counting CONSOLE OUTPUT

D15418: Dim application icon when it is not playing anything

ngraham added a comment. Basically +1 on the concept, but I think we need to make the appearance a bit more distinct between playing vs non-playing. I've thrown out some ideas, and I'm open to others. Reducing the opacity even further would work. Adding a little tiny piece of text that says

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/6/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 13 Sep 2018 16:38:03 + Build duration: 15 min and counting

D15418: Dim application icon when it is not playing anything

ngraham added a comment. In D15418#325341 , @abetts wrote: > In D15418#325340 , @acrouthamel wrote: > > > How about changing the volume icon for the non-playing application to

D15115: fix translations kcm to be usable on new users/installations

hein updated this revision to Diff 41560. hein added a comment. Simplify patch to only what's actually needed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15115?vs=40541=41560 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15115

D15315: Set gtk-modules to auto-load appmenu-gtk-module

hein added a comment. Since we're in the middle of doing tarballs and I know @broulik was anxious to get this in I'm going to be proactive and land it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15315 To: broulik, #plasma, davidedmundson, fvogt, hein

D15418: Dim application icon when it is not playing anything

acrouthamel added a comment. How about changing the volume icon for the non-playing application to `audio-volume-muted.svg`? Then, when it is playing audio, it reverts to low/high icons as usual, based on slider location. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D15115: fix translations kcm to be usable on new users/installations

hein commandeered this revision. hein edited reviewers, added: sitter; removed: hein. hein added a comment. I'll commandeer this rev to fix up the patch. Sorry @sitter, but then we can get this into beta still. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D15115: fix translations kcm to be usable on new users/installations

hein added a comment. This makes sense. In theory this is done by this code: `connect(m_selectedTranslationsModel, ::selectedLanguagesChanged, m_availableTranslationsModel, ::setSelectedLanguages);` However `SelectedTranslationsModel` only emits the signal when the list

D15315: Set gtk-modules to auto-load appmenu-gtk-module

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3954e7e07c9c: Set gtk-modules to auto-load appmenu-gtk-module (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15315?vs=41316=41565

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.11 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/5/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 13 Sep 2018 17:23:16 + Build duration: 1 min 34 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/7/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Sep 2018 17:26:20 + Build duration: 22 min and counting CONSOLE OUTPUT [...truncated 93.36