D16843: Add output and connected outputs config API

apol added a comment. Don't we already have a hash per config? INLINE COMMENTS > config.h:126 > + * @return sorted hash combination of all connected outputs > + * @since 5.X.0 > + */ X=53 :) REPOSITORY R110 KScreen Library BRANCH hashApi REVISION DETAIL

D16715: make global menu minimize state aware

mart added inline comments. INLINE COMMENTS > appmenumodel.h:62 > > +bool menuHidden() const; > + maybe the opposite looks more consistent with usual Qt api, just a bool visible REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16715 To: mvourlakos,

[Powerdevil] [Bug 340153] Battery monitor does not see the charger cable

https://bugs.kde.org/show_bug.cgi?id=340153 leon pollak changed: What|Removed |Added Resolution|WAITINGFORINFO |FIXED Status|NEEDSINFO

D13178: Compress calls to configuration slots upon new connections

mart added a comment. still needs this parameter then is good to go REVISION DETAIL https://phabricator.kde.org/D13178 To: jacopods, PHID-PROJ-gqbvozptxawndyihp3hs, hein, broulik, drosca Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13186: Use HiddenStatus when keyboard indicator is inactive

mart added a comment. maybe should be added a way to configure the applets from the entries tab of the config dialog as well? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13186 To: arojas, apol Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot,

D16842: [clipboard] Limit length of clipboard text item visualisation

This revision was automatically updated to reflect the committed changes. anthonyfieroni marked an inline comment as done. Closed by commit R120:d53622d7d9e0: [clipboard] Limit length of clipboard text item visualisation (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT

D16856: [comicproviderwrapper] Always finish on last request in pageRetrieved

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY Otherwise provider can be marked as failed REPOSITORY R114

D16776: Better error handling in KNewStuff backend

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D16776 To: leinir, #discover_software_store, apol Cc: plasma-devel, masilva, ragreen, ixoos,

Monday meeting notes from 12/10/2018

Roman: What I did: --- * Updated touch / input patches: D15464 D15595 > Diff 15464 "[server] Touch drag support" [Accepted] > https://phabricator.kde.org/D15464 > Diff 15595 "Rework InputDeviceHandler focus tracking" [Needs Review] > https://phabricator.kde.org/D15595 * text-input v3

D16776: Better error handling in KNewStuff backend

leinir marked 2 inline comments as done. leinir added a comment. In D16776#356741 , @apol wrote: > Where will the `All categories are missing` error fall right now? That is a configuration file error (which is the case, unless there's a

D16812: Avoid potential race condtion with QFutureWatcher in FWUPD backend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:bd6f08ada8e3: Avoid potential race condtion with QFutureWatcher in FWUPD backend (authored by davidedmundson). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D16811: Load KDE QtQuickSettings in Discover

This revision was automatically updated to reflect the committed changes. Closed by commit R134:d783ebd003c9: Load KDE QtQuickSettings in Discover (authored by davidedmundson). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D16776: Better error handling in KNewStuff backend

leinir updated this revision to Diff 45355. leinir marked 2 inline comments as done. leinir added a comment. Address @apol's comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16776?vs=45166=45355 REVISION DETAIL

D16715: make global menu minimize state aware

mvourlakos added inline comments. INLINE COMMENTS > mart wrote in appmenumodel.h:62 > maybe the opposite looks more consistent with usual Qt api, > just a bool visible no problem, so do we have an agreement to rename menuHidden -> visible? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16405: Add debug category for bookmarks runner

This revision was automatically updated to reflect the committed changes. Closed by commit R120:62804f6becb9: Add debug category for bookmarks runner (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16405?vs=44164=45352 REVISION

D16404: [Bookmarks Runner] Cleanup tests CMakeList

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5ba0a08b8312: [Bookmarks Runner] Cleanup tests CMakeList (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16404?vs=44161=45351

D16842: [clipboard] Limit length of clipboard text item visualisation

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY Applying regex to long text item (> 5000 symbols) is

D16843: Add output and connected outputs config API

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY In order to support writing and retrieving config data by API consumers introduce two API

D16844: [comic] Correct usage of DataEngineConsumer

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY Comic applet is DataEngineConsumer which take care of loading

D16842: [clipboard] Limit length of clipboard text item visualisation

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > TextItemDelegate.qml:33 > > -var text = DisplayRole > +var text = DisplayRole.slice(0, 64) > I think 100 is better since it can wrap to up to

D16845: Make use of libkscreen hash API

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Replace kscreen's own calculations with libkscreen API. TEST PLAN Compiles. REPOSITORY R104

D16844: [comic] Correct usage of DataEngineConsumer

anthonyfieroni updated this revision to Diff 45370. anthonyfieroni added a comment. Fix diff REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16844?vs=45369=45370 REVISION DETAIL https://phabricator.kde.org/D16844 AFFECTED FILES

D16611: Fix build with libc++

ktatunov added a comment. Could you commit this for me please? I don't have a developer account. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D16611 To: ktatunov, #plasma, #kwin, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,