Re: KDE file dialog column resize no longer possible?

Yes, this was an intentional change: https://cgit.kde.org/kio.git/commit/?id=e504bc1fd56412ee7e9748a0dfafa537977ec1b5 Check out the listed bugs that it fixed! However I understand that it did cause some fallout: https://bugs.kde.org/show_bug.cgi?id=401506 I tried to fix that in

D18362: [build] Search for kirigami as a runtime dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R120:129dfcfd69d6: [build] Search for kirigami as a runtime dependency (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18363: [build] Search for kirigami as a runtime dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R115:89992d14d696: [build] Search for kirigami as a runtime dependency (authored by heikobecker). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

KDE file dialog column resize no longer possible?

Hi, Sorry for cross-posting (initially), I'm not certain which list is the most appropriate. It's often been tricky to trigger column resize mode in the KDE file dialog (when in one of the detailed view modes) but I realise I haven't been able to do this at all for a little while now. I just

D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail

davidedmundson added a comment. I put debug in Qt, in qmlscene it works as you'd expect. In the system settings case QQuickImage thinks the DPR is always 1. The relevant window is QQuickWindow(0x55f9aee446d0, visibility=QWindow::Windowed, flags=QFlags(Window),

Re: KDE file dialog column resize no longer possible?

Yes, this was an intentional change: https://cgit.kde.org/kio.git/commit/?id=e504bc1fd56412ee7e9748a0dfafa537977ec1b5 Check out the listed bugs that it fixed! However I understand that it did cause some fallout: https://bugs.kde.org/show_bug.cgi?id=401506 I tried to fix that in

D18343: [wallpapers/image] Port wallpaper plugins (mostly) to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7e6d0c0b0eeb: [wallpapers/image] Port wallpaper plugins (mostly) to QQC2 (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18318: Prettify and search enable the error page

ngraham added a comment. +1 for always showing the search field. But that icon looks a bit big. I might make it smaller and lose the opacity. Also, while we're prettifying the error page, how about vertically centering everything too? REPOSITORY R134 Discover Software Store REVISION

D18320: Search-enable the application page

ngraham added a comment. Cherry-picked onto the `Plasma/5.15` branch since it's a bugfix that doesn't introduce any string changes. Let's try to land future patches that meet those criteria on the `Plasma/5.15` branch during the 5.15 beta period. We need to polish Discover to a mirror

D18360: [build] Search for kirigami as a runtime dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R119:779854fa6431: [build] Search for kirigami as a runtime dependency (authored by heikobecker). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17773: Copy to Clipboard in English

ngraham added a comment. BTW I just discovered that this caused a regression: https://bugs.kde.org/show_bug.cgi?id=402104 It's currently publicly visible at https://blog.neon.kde.org/index.php/2019/01/17/test-kde-plasma-5-15-beta-with-neon/ :p REPOSITORY R102 KInfoCenter REVISION

D18364: [build] Search for kirigami as a runtime dependency

heikobecker created this revision. heikobecker added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN cmake lists kirigami as a found dependency REPOSITORY R116 Plasma Network Management

D18362: [build] Search for kirigami as a runtime dependency

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN cmake lists kirigami as a found dependency REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.15 REVISION DETAIL

D18363: [build] Search for kirigami as a runtime dependency

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN cmake lists kirigami as a found dependency REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.15 REVISION DETAIL

D18361: libkworkspace: Allow standalone build

asturmlechner added a comment. For the record, I would have been in support of this. ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18361 To: heikobecker Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18361: libkworkspace: Allow standalone build

heikobecker abandoned this revision. heikobecker added a comment. Sorry, accidentally uploaded. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18361 To: heikobecker Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18357: [applets/mediaframe] Resize combobox to contents

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Copies the bodge currently present in plasma-workspace wallpaper config.

D18360: [build] Search for kirigami as a runtime dependency

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN cmake lists kirigami as a found dependency REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.15 REVISION DETAIL

D18361: libkworkspace: Allow standalone build

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY [build] Search for kirigami as a runtime dependency REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.15 REVISION

D18364: [build] Search for kirigami as a runtime dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R116:7793c31e0132: [build] Search for kirigami as a runtime dependency (authored by heikobecker). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

ngraham accepted this revision. ngraham added a comment. Yeah, I was probably doing something dumb. Confirmed that this works with your test plan. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16093 To: Zren, davidedmundson, ngraham Cc: ngraham,

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

This revision was automatically updated to reflect the committed changes. Closed by commit R114:80bd32b12a01: Consistent arrow key handling in the Informative Alt+Tab skin (authored by Zren). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D18370: Set libkworkspace minimum version

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY CCBUG: 403367 REPOSITORY R119 Plasma Desktop BRANCH master REVISION

D17773: Copy to Clipboard in English

ngraham added a comment. Oops, wrong bug. Too many tabs open... Correcting the original comment now. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17773 To: guoyunhe, #plasma, ngraham Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18357: [applets/mediaframe] Resize combobox to contents

ngraham added a comment. Works, but feels like a workaround. Shouldn't we add a comment indicating what bug we're working around? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D18357 To: davidedmundson, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2,

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

ngraham added a comment. Yay! Now onto https://bugs.kde.org/show_bug.cgi?id=308331! I tried with D16897 but ran into some trouble. It works, but the keys are hardcoded rather than reading the key from the global shortcuts. What's tricky is that only the

D17773: Copy to Clipboard in English

davidedmundson added a comment. How can this affect discover? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17773 To: guoyunhe, #plasma, ngraham Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

Zren added a comment. I forgot to merge this after david's patch was merged. I just tested this in the Neon Beta ISO to confirm the fix still works. In D16093#359639 , @ngraham wrote: > Hmm, this does not actually work for me. Seems like it

D18378: Fix bug 402077 for 5.14.x

ngraham added a comment. Unfortunately there aren't any more 5.14.x released scheduled. But you could target this for the 5.12 LTS branch maybe? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D18378 To: bero Cc: ngraham,

D18378: Fix bug 402077 for 5.14.x

ngraham added inline comments. INLINE COMMENTS > filechooser.cpp:298 > +if(currentUrl.scheme().isEmpty()) > +currentUrl=QUrl::fromLocalFile(currentFolder); > +fileDialog->setDirectoryUrl(currentUrl); KDE coding style: if (thing) { do stuff; } Spaces

D18378: Fix bug 402077 for 5.14.x

bero created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bero requested review of this revision. REVISION SUMMARY This fixes preselecting a filename and directory in xdg-desktop-portal-kde on the 5.14.x branch. This bug is already fixed on master by

D15304: [WIP] [KCM] Port to QQC2

ngraham updated this revision to Diff 49859. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15304?vs=49855=49859 REVISION DETAIL https://phabricator.kde.org/D15304 AFFECTED FILES src/kcm/package/contents/ui/Advanced.qml

D18299: ComboBox: fix default delegate

apol added inline comments. INLINE COMMENTS > broulik wrote in ComboBox.qml:58 > Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a > `ComboBox` is recommended as: > "This ensures that the interaction works as expected, and the popup will > automatically close when

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 18 Jan 2019 21:40:22 + Build duration: 1 min 48 sec and counting JUnit Tests Name:

D18375: Adjust Latte Dock to libtaskmanager API changes for Wayland

mvourlakos added a comment. looks ok, do you think that VirtualDesktop changes should go to another commit? based on https://github.com/KDE/plasma-desktop/commit/b0d6eab4a698809ff9f5b7244a975ac467222508 ? REPOSITORY R878 Latte Dock REVISION DETAIL

D18370: Set libkworkspace minimum version

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Would this string get automatically updated by the release scripts in the future? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18370

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/20/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 18 Jan 2019 21:40:29 + Build duration: 2 min 49 sec and counting BUILD ARTIFACTS

D18375: Adjust Latte Dock to libtaskmanager API changes for Wayland

scoenen created this revision. scoenen added a reviewer: mvourlakos. scoenen added a project: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. scoenen requested review of this revision. REVISION SUMMARY Changes in libtaskmanager in Plasma 5.15 currently break

D15304: [KCM] Port (almost) entirely to QQC2

ngraham updated this revision to Diff 49855. ngraham added a comment. Port entirely away from QQC1 by adopting the QQC2 TabBar REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15304?vs=42512=49855 BRANCH arcpatch-D15304 REVISION DETAIL

D18318: Prettify and search enable the error page

leinir added a comment. Yes, quite, of course :D Was going to post one and got sidetracked ;) The shot is identical to the previous state, except for two largeish and contained bits (hence only the one shot): There is a search field shown here where one was missing previously, and there

D18320: Search-enable the application page

leinir added a comment. In D18320#395251 , @ngraham wrote: > Thanks for the copious code comments. Definitely makes things easier to understand in the future. i do prefer to overcomment rather than undercomment... i've come back to

D18320: Search-enable the application page

This revision was automatically updated to reflect the committed changes. Closed by commit R134:9aa0a7df1395: Search-enable the application page (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18320?vs=49719=49791

D17751: Add shadow to Hour's hand

This revision was automatically updated to reflect the committed changes. Closed by commit R120:975df8f8930c: Add shadow to Hours hand (authored by shubham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17751?vs=49728=49796 REVISION DETAIL

D18341: Support icons from local files in buttons

nicolasfella added a comment. In D18341#395692 , @broulik wrote: > `/foo/bar` is not a local URL? `file:///foo/bar` would be. I think you now broke the `QString` case? qDebug() << icon.value(); gives QUrl("file:///foo/bar"), even when

D18276: Fix KDE Connect volume control

This revision was automatically updated to reflect the committed changes. Closed by commit R994:91b3f5114a81: Fix KDE Connect volume control (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18276?vs=49563=49789