KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 120 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/120/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 11:31:02 + Build duration: 28 sec and counting CONSOLE OUTPUT [...truncated 309

Doxygen code style

Commit https://phabricator.kde.org/R108:7b20e1f66f83657591001f473d31555c295e5569 changes Doxygen comments style in KWin to the uniform pattern /** * **/ with two stars at the end. Looking at upstream examples http://www.doxygen.nl/manual/docblocks.html#cppblock online examples

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. Thanks for the feedback, I'll look into it asap. In the meantime, could I ask the VDG to create a Breeze icon for Thunderbolt? @abetts, maybe? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc:

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 119 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/119/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 11:27:38 + Build duration: 1 min 42 sec and counting CONSOLE OUTPUT [...truncated

D19038: Make Appearance KCM tooltip texts consistent

broulik added a comment. I would have prefered nobody touching the color KCM until D18646 was merged.. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19038 To: GB_2, #plasma, #vdg, ngraham Cc: broulik, #vdg,

D18646: [Colors KCM] Add search and filter

broulik planned changes to this revision. broulik added a comment. The `selectedSchemeIndex` stuff doesn't take into account the filtering, so the highlight is wrong when filtering and also when marking a theme for deletion the index changes to the next one but might end up applying a

D19118: Add (and use) a LinkLabel component

This revision was automatically updated to reflect the committed changes. Closed by commit R134:917819ac26f3: Add (and use) a LinkLabel component (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19118?vs=51956=52041

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/41/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 09:54:25 + Build duration: 35 sec and counting CONSOLE OUTPUT [...truncated 253

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/6/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Feb 2019 10:26:31 + Build duration: 2 min 24 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.12 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.12/12/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 10:29:57 + Build duration: 55 min and counting CONSOLE OUTPUT

D19011: Thunderbolt KCM and KDED module

ngraham added subscribers: trickyricky26, ndavis, andreask. ngraham added a comment. In D19011#415228 , @dvratil wrote: > Thanks for the feedback, I'll look into it asap. In the meantime, could I ask the VDG to create a Breeze icon for

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 118 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/118/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 11:11:07 + Build duration: 16 min and counting CONSOLE OUTPUT [...truncated 311

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/9/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 10:26:31 + Build duration: 10 min and counting CONSOLE OUTPUT

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/5/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Feb 2019 10:29:47 + Build duration: 21 min and counting CONSOLE OUTPUT

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. In D19044#414530 , @ngraham wrote: > In D19044#414479 , @mart wrote: > > > -1 > > this has to be done at most for the desktop style and the desktop style only > > >

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

ngraham added a comment. I kind of agree. I like the new size for Medium, and I think the default should maybe be a bit smaller (halfway between the current medium and the current large) but I also don't see the great value in adding more sizes. I think we can probably accomplish the visual

D19160: [about-distro] update osrelease parser for latest values in spec

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY + and add a simple unit test so one can refactor without fear of regressing something :(( - osrelease now takes an

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 121 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/121/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 11:59:33 + Build duration: 39 sec and counting CONSOLE OUTPUT [...truncated 309

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#414995 , @davidedmundson wrote: > > For example if the user has set different scale factors between its screens is it going to work? > > It will not, but there is no UI option for that. one more

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#415295 , @davidedmundson wrote: > The problem does not exist in wayland. nice, in that case I think that your proposal with a small comment why this is needed is good. I will update shortly.

D19126: block screen filtering for global menu applet

davidedmundson added a comment. > I heard that under Wayland, Plasma is enabling PLASMA_USE_QT_SCALING is that true? Yes. > OR the issue does not exist in wayland because the compositor solves it? The problem does not exist in wayland. Wayland uses normalised geometry for

D19154: remove hint state

matthieugras created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. matthieugras requested review of this revision. REVISION SUMMARY BUG 404338 REPOSITORY R119 Plasma Desktop BRANCH local (branched from master) REVISION DETAIL

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#415295 , @davidedmundson wrote: > > I tried to adjust to your proposal David but there is no qApp->scale() . What I found is, **QScreen::devicePixelRatio()** so we need to know first the

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 123 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/123/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 12:17:28 + Build duration: 37 sec and counting CONSOLE OUTPUT [...truncated 309

D15907: Compare float values in DecorationButton contains check

zzag added a comment. Could you please rebase it on master? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D15907 To: romangg, #kwin, zzag, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15907: Compare float values in DecorationButton contains check

zzag added a comment. Sorry, I applied the change to the wrong repo REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D15907 To: romangg, #kwin, zzag, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19157: Don't show entries with NoDisplay=true with the applauncher containmentaction

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Currently NoDisplay services are shown, which doesn't make much sense. TEST PLAN Installed and looked through the menu, no excessive or

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 124 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/124/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 12:24:38 + Build duration: 27 sec and counting CONSOLE OUTPUT [...truncated 309

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

zzag added a comment. I'm not convinced that we need yet another shadow size, we already have too many. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze Cc: zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D15907: Compare float values in DecorationButton contains check

romangg added a comment. ping REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D15907 To: romangg, #kwin, zzag, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D15907: Compare float values in DecorationButton contains check

zzag added a comment. Looks good to me. I think the test is too much complicated. Would it be simpler to have something like QTest::addColumn("geometry"); QTest::addColumn("pos"); QTest::addColumn("contains"); ? INLINE COMMENTS > decorationbutton.cpp:455 > +//

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

davidedmundson added a comment. The SVG issue is only relevant in QIcon::fromTheme(name, fallback) because it detects if (icon.isNull() || icon.availableSizes().isEmpty()) return fallback; and availableSizes is problematic for the SVG QIcon backend. You're not using

D19154: [Kickoff] remove hint state

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me. Probably a candidate for the `Plasma/5.15` branch. @hein? REPOSITORY R119 Plasma Desktop BRANCH local (branched from master) REVISION DETAIL

D19162: Add KAboutData

This revision was automatically updated to reflect the committed changes. Closed by commit R122:972eb26d0558: Add KAboutData (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19162?vs=52077=52083#toc REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D19162: Add KAboutData

broulik created this revision. broulik added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures correct app info is set, for example when crashing TEST PLAN send a SIGSEGV,

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

This revision was automatically updated to reflect the committed changes. Closed by commit R102:e7e44a7af825: [about-distro] run absolute paths through qicon intead of qpixmap (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D19162: Add KAboutData

ngraham added inline comments. INLINE COMMENTS > powerdevilapp.cpp:69 > + i18nc("@info:credit", "(c) 2015-2019 Kai Uwe > Broulik")); > +aboutData.addAuthor(i18nc("@info:credit", "Kai Uwe Broulik Angelaccio"), > +i18nc("@info:credit",

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

ngraham added a comment. Sorry, we had discussed this with @zzag in the #VDG room and I (perhaps erroneously?) left with the impression that this was set at its previous value to preserve a certain look-and-feel, and was therefore something we could

D19162: Add KAboutData

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM And FWIW I agree that following PROJECT_VERSION would be nicer. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D19162 To: broulik, #plasma, sitter

D19148: Make shadow sizes linear

ngraham added a comment. ...Looks better on my non-cheap display, too. :) REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh,

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 52130. trmdi added a comment. Fix tooltip's height. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52097=52130 REVISION DETAIL https://phabricator.kde.org/D19096 AFFECTED FILES

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 108 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/108/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Feb 2019 04:58:43 + Build duration: 6 min 45 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 105 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/105/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Feb 2019 04:59:04 + Build duration: 7 min 19 sec and counting JUnit Tests Name:

D19148: Make shadow sizes linear

filipf added a comment. All of the new versions look better to me. +1 REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2,

D18975: [PotD] Port mostly to QQC2

ngraham added a comment. Friendly ping! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D18975 To: ngraham, #plasma, davidedmundson, kossebau Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 52129. tuxxi added a comment. - Use logicalLength for non-latin characters - Fix ptr style REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51565=52129 BRANCH search-bar REVISION DETAIL

D18939: KMenuEdit: add search/filter bar

tuxxi marked 2 inline comments as done. tuxxi added a comment. Good point about CJK, I had not considered that. REPOSITORY R103 KMenu Editor BRANCH search-bar REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: ognarb, mlaurent, ngraham,

D19173: [InlineMessage] Tint icon and text color

ngraham added a subscriber: mart. ngraham added a comment. Also as @mart pointed out in D19044 , it might make sense to do all the styling in the qqc2 desktop style theme for this control, rather than here in Kirigami itself. Finally, I'm requiring

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Thanks, untested by me, but seems correct by quick read. Yes, 5.12 => 5.14 => 5.15 => master might still make sense, given that Debian usage, how insane that even is. REPOSITORY

D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. Don't fully understand the next course of action yet so if anyone wants to commandeer the revision for a speedier resolution, go ahead! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg, #kirigami, ngraham, mart Cc:

D19173: [InlineMessage] Tint icon and text color

filipf added a comment. You're right, let's not pursue this further at this point. Bit of more than I could chew anyway! But if anyone would be interested in doing something like this in the future, feel free to commandeer the revision. REPOSITORY R169 Kirigami REVISION DETAIL

D19173: [InlineMessage] Tint icon and text color

abetts added a comment. Love the color change. More harmonious. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19173 To: filipf, #kirigami, #vdg, ngraham Cc: abetts, mart, plasma-devel, dkardarakos, apol, davidedmundson, hein

D19077: WIP: Fix long labels not being wrapped

filipf planned changes to this revision. filipf added inline comments. INLINE COMMENTS > main.qml:27 > color: palette.base > -width: 360 > -height:320 > +height: previewImage.height + column.height + units.largeSpacing > childrenRect.height can be used here, but the problem

D19174: [weather] envcan: Document urls for example data + list all warnings

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I can place this in the `ion_envcan.h` or the `ion_envcan.cpp`. It's not worth backporting so it'll get merged to master. REPOSITORY

D19173: [InlineMessage] Tint icon and text color

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I'm not in favor of this at all in its current form. Any tinting of the text with the background color under it reduces legibility. I'm as in favor of aesthetically appealing

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

Zren created this revision. Zren added reviewers: Plasma, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY The capital `S` breaks the icon match. It was broken in Plasma 5.6

D18716: Add a TextField component

ognarb updated this revision to Diff 52125. ognarb marked 2 inline comments as done. ognarb added a comment. - use Controls namespace - use ActionTextField instead of TextField REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=51215=52125 BRANCH

D19148: Make shadow sizes linear

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is much better. I think this is a visual improvement. Please make sure @zzag is good with the code before landing, and also let's maybe wait for a few more #VDG

D18975: [PotD] Port mostly to QQC2

filipf added a comment. Looks the same here with 1.2 scaling (verified it was the right file edited). Before: F6624971: Screenshot_20190220_012827.png After: F6624973: Screenshot_20190220_012850.png

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52127. ognarb added a comment. WIP: use repeater and list of actions REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52125=52127 BRANCH arcpatch-D18716 REVISION DETAIL https://phabricator.kde.org/D18716

D19173: [InlineMessage] Tint icon and text color

filipf created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch tints both the icon and text colors of inline messages in order to achieve more appealing visuals. REPOSITORY R169

D19044: [InlineMessage] Do not draw shadows around the message

rooty added a comment. In D19044#412934 , @abetts wrote: > In fact, long ago, when we first launched the current version, I also suggested making them flatter and all the way across the window. That way it didn't seem like it was floating. >

KDE CI: Plasma » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 17:44:36 + Build duration: 1 hr 6 min and counting JUnit Tests Name:

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

ndavis updated this revision to Diff 52107. ndavis added a comment. Remove ShadowVerySmall REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19148?vs=52036=52107 BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148

D19148: Make shadow sizes linear

ndavis added a comment. Small and Medium are the same sizes they originally were, Large is 1.5x Medium and Very large is now the same size that Large was. I've also adjusted the starting opacity of the shadows a bit more. REPOSITORY R31 Breeze REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 122 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/122/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 12:09:43 + Build duration: 51 sec and counting CONSOLE OUTPUT [...truncated 309

D19118: Add (and use) a LinkLabel component

apol added a comment. We already have UrlButton for that. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19118 To: leinir, apol, ngraham, #discover_software_store Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James,

D19166: Add application path as valid path for debuggers

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R871 DrKonqi BRANCH update_path REVISION DETAIL

D19166: Add application path as valid path for debuggers

patrickelectric updated this revision to Diff 52099. patrickelectric added a comment.  - Add application path as valid path for debuggers REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19166?vs=52098=52099 BRANCH update_path REVISION DETAIL

D19126: block screen filtering for global menu applet

davidedmundson added a comment. There's a QGuiApplication::devicePixelRation() I gave the wrong method name, sorry. > I suppose that in multi screen environments with different scales it would also work ok for all screens I'm afraid it's not that simple. REPOSITORY R120

D19096: Improvements for long label items

trmdi updated this revision to Diff 52097. trmdi retitled this revision from "Increase the label's area to display 2 lines of text when needed" to "Improvements for long label items". trmdi edited the summary of this revision. trmdi edited the test plan for this revision. REPOSITORY R119

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 52087. rooty added a comment. Even padding with bodyText.lineCount > 1 (account for close button) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=51858=52087 BRANCH lift-up-noto (branched from master)

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 52088. rooty added a comment. Edit comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=52087=52088 BRANCH lift-up-noto (branched from master) REVISION DETAIL https://phabricator.kde.org/D19036

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/6/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Feb 2019 17:47:30 + Build duration: 8 min 7 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » user-manager » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/user-manager/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 17:44:24 + Build duration: 58 min and counting

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.12 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.12/13/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 17:44:26 + Build duration: 59 min and counting

D19036: [notifications] Lift up notification content if one line of body text droops

rooty added a comment. I just realized that there was more padding above than below with bodyText.lineCount > 1 because the closeButton takes up another 0.5 units above the text that I didn't take into account in my previous padding patch. So, why not add it here :D Sorry, you were

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 7 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/7/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Feb 2019 17:47:28 + Build duration: 3 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » sddm-kcm » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/sddm-kcm/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 17:44:34 + Build duration: 1 hr 0 min and counting

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/10/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 17:44:39 + Build duration: 1 hr 7 min and counting JUnit Tests

D19135: DelegateRecycler: Fix translation using the wrong domain

aacid closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19135 To: aacid, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein