D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis added a comment. In D19605#427037 , @zzag wrote: > This patch makes buttons sharp only for one particular button size and font size. You're right, but this makes it sharper at the default button+font size. Smaller sizes suffer,

D19454: Fix errors in kirigami example files

ognarb added inline comments. INLINE COMMENTS > apol wrote in AbstractApplicationWindow.qml:105 > Why's that? Without I get the errror: TypeError: Property 'goBack' of object QQuickStackView_QML_91(0x55ea59443ee0) is not a function REPOSITORY R169 Kirigami REVISION DETAIL

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

This revision was automatically updated to reflect the committed changes. Closed by commit R120:408c6d6319ee: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty updated this revision to Diff 53452. rooty added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19468?vs=53451=53452 BRANCH arcpatch-D19468 REVISION DETAIL https://phabricator.kde.org/D19468 AFFECTED FILES

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty updated this revision to Diff 53451. rooty added a comment. Refresh REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19468?vs=53402=53451 BRANCH arcpatch-D19468 REVISION DETAIL https://phabricator.kde.org/D19468 AFFECTED FILES

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

ognarb created this revision. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Some part were copied from kcontrol icons. Need proofreading REPOSITORY R119 Plasma Desktop BRANCH

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53462. ngraham marked 5 inline comments as done. ngraham added a comment. Address all review comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53409=53462 BRANCH

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

yurchor requested changes to this revision. yurchor added a comment. This revision now requires changes to proceed. Thanks in advance for fixing this. INLINE COMMENTS > index.docbook:34 > + > + comes with multiple theme. The plasma theme define how the > different > + components of are

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

This revision was automatically updated to reflect the committed changes. Closed by commit R119:245677bfb31a: Update documentation for kcontrol desktop theme (now plasma theme) (authored by ognarb). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch improves the appearance of the sddm theme and the lock screen with software rendering in place (QT_QUICK_BACKEND=software)

D19596: color monochrome icons to tooltip colors

mart added a comment. In D19596#427074 , @sitter wrote: > Following Kai's question... wouldn't KIconLoader::global make the entire static obsolete? we need a second one, not the one used by the app, because we are altering how it

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

abetts added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19548: [Media frame] Modernize and improve settings window

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. In D19548#426961 , @ngraham wrote: > We kinda sorta have a convention to use the app/widget's own icon for its "general" category, so I think

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. In D19606#426997 , @broulik wrote: > Overall I must say I'm quite a fan. > > I don't like the Settings and Alternatives entries at the top, they draw most attention to them for actions that should rather be least

D19548: [Media frame] Modernize and improve settings window

This revision was automatically updated to reflect the committed changes. Closed by commit R114:d0c5e541d767: [Media frame] Modernize and improve settings window (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19548?vs=53408=53459

D19612: RFC port to bugzilla REST API

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY I'd love some feedback on the lib api especially. this is the first REST wrapper I wrote using cpp, so it feels all a bit clunky to

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

abetts added a comment. Can it be more descriptive? Using two words might help it be extra clear what the button is about. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19472 To: ngraham, #plasma, hein, davidedmundson, rooty Cc: abetts, broulik, rooty,

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. In D19606#427269 , @abetts wrote: > Would it be possible for the header labels to be a bit different? Not sure what would look best, bold, italics, a lighter shade of gray > > F6674017: Screen Shot 2019-03-08 at

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

ognarb updated this revision to Diff 53465. ognarb marked 4 inline comments as done. ognarb added a comment. Fix typos and use entites Thanks yuri :D REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19618?vs=53463=53465 BRANCH master REVISION

D19607: Remove unused dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit R994:58beeb4837da: Remove unused dependencies (authored by arojas). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19607?vs=53418=53443 REVISION DETAIL

D19606: [Task Manager] Reorganize and improve presentation of context menu

abetts added a comment. Would it be possible for the header labels to be a bit different? Not sure what would look best, bold, italics, a lighter shade of gray F6674017: Screen Shot 2019-03-08 at 8.49.54 AM.png REPOSITORY R119 Plasma Desktop

D19096: Improvements for long label items in Application Dashboard

hein added a comment. I'm sorry, but I can't accept this patch as-is - the hoverArea-related changes are just wrong, it's not OK to couple a delegate to the view by making it set tons of property on an item i its parent. I'll need to set some time aside to analyze what you're trying to

D19096: Improvements for long label items in Application Dashboard

trmdi abandoned this revision. trmdi added a comment. In D19096#427329 , @hein wrote: > I'm sorry, but I can't accept this patch as-is - the hoverArea-related changes are just wrong, it's not OK to couple a delegate to the view by making it set

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All good! REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19468 REVISION DETAIL https://phabricator.kde.org/D19468 To: rooty, #vdg, ngraham, filipf Cc: filipf, plasma-devel,

D19603: Fix colours of header bar for active and inactive windows

ngraham accepted this revision. ngraham added a comment. +1 for adding the focused state to KWin so this works on X11! REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D19603 To: davidedmundson, #breeze, zzag, #vdg, ngraham Cc: ngraham,

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham accepted this revision. ngraham added a comment. Finally, this latest version works for me! #plasma folks? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham, davidedmundson

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

This revision was automatically updated to reflect the committed changes. Closed by commit R120:28a6ef22350d: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when… (authored by rooty, committed by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

filipf accepted this revision. filipf added a comment. Everything appears to be in order. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19468 To: rooty, #vdg, ngraham, filipf Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19096: Improvements for long label items in Application Dashboard

hein added a comment. I'm concerned that having title labels on everything could be overdoing it a bit? It makes the context menu very large and have a lot of dead space, and adds to the noise. Isn't that rather a detriment to utility on repeated use? It's sometimes important to remember

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

ngraham added inline comments. INLINE COMMENTS > ActionButton.qml:85 > top: icon.bottom > -topMargin: units.smallSpacing > +topMargin: (softwareRendering ? 2 : 1) * units.smallSpacing > left: parent.left Why do we need to change this when using

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Good stuff! I'm hoping we see more of your commits in the future INLINE COMMENTS > slidemodel.cpp:41 > +{ > +Q_FOREACH (QString file, paths) { > +

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

filipf added a comment. First and foremost I thank you as a user for giving this bit of code much needed love. If you'll have more interest in the slideshow in the future, implementing this might also be useful: https://bugs.kde.org/show_bug.cgi?id=186181 REPOSITORY R120 Plasma

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. In D18809#427602 , @filipf wrote: > First and foremost I thank you as a user for giving this bit of code much needed love. > > If you'll have more interest in the slideshow in the future, implementing this might

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

rooty marked 3 inline comments as done. rooty added a comment. I know it sounds strange but no value other than undefined causes the D19577 error... we could technically put "red" there because there's no outline to begin with and it'd look the same haha

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

This revision was automatically updated to reflect the committed changes. Closed by commit R120:aca7fd387307: [sddm-theme/lock screen] Improve appearance in software rendering mode… (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, makes sense and looks good! REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19609 REVISION DETAIL https://phabricator.kde.org/D19609 To: rooty, #plasma, #vdg,

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

rooty updated this revision to Diff 53490. rooty marked 2 inline comments as done and an inline comment as not done. rooty added a comment. Use less of a margin, rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19609?vs=53436=53490 BRANCH

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

rooty marked 3 inline comments as done. rooty added inline comments. INLINE COMMENTS > ngraham wrote in ActionButton.qml:85 > Why do we need to change this when using software rendering? Because I feel that the icon looks too stuck-on if the margin's too great. > ngraham wrote in

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

ngraham added a comment. In D19472#427046 , @broulik wrote: > This suffers from the same bug as the action in the D17410 . The action doesn't show up unless the real applet context menu was opened once.

D19603: Fix colours of header bar for acitve and inactive windows

zzag added a comment. What's the reason for removing the linear gradient? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19603 To: davidedmundson, #breeze, zzag, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19603: Fix colours of header bar for acitve and inactive windows

zzag added a comment. (also, it would be enough just to add a group reviewer) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19603 To: davidedmundson, #breeze, zzag, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19607: Remove unused dependencies

arojas created this revision. arojas added a reviewer: nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY These seem to be leftovers from plasma-pa TEST PLAN Builds REPOSITORY R994 Pulseaudio Qt

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag added a comment. This patch makes buttons sharp only for one particular button size and font size. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19572: [kcolorschemeditor] Don't re-add existing tab

This revision was automatically updated to reflect the committed changes. Closed by commit R119:45f10322b8f3: [kcolorschemeditor] Dont re-add existing tab (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19572?vs=53306=53419#toc REPOSITORY R119 Plasma Desktop

D18640: Reset tooltip delegate label height to defaults

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ef06af7c01a9: Reset tooltip delegate label height to defaults (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18640?vs=50635=53420

D18646: [Colors KCM] Add search and filter

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a1fbeb96dc6c: [Colors KCM] Add search and filter (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18646?vs=53304=53422#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

broulik added a comment. This suffers from the same bug as the action in the D17410 . The action doesn't show up unless the real applet context menu was opened once. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19472

D19596: color monochrome icons to tooltip colors

broulik added a comment. What's the need for this wrapper class rather than just making the `KIconLoader` global static? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen,

D19580: Use high dpi pixmaps

This revision was automatically updated to reflect the committed changes. Closed by commit R838:90f655a146d1: Use high dpi pixmaps (authored by broulik). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19580?vs=53334=53414

D19606: [Task Manager] Reorganize and improve presentation of context menu

broulik added a comment. Overall I must say I'm quite a fan. I don't like the Settings and Alternatives entries at the top, they draw most attention to them for actions that should rather be least intrusive. I would prefer the jump list actions stuff at the top but grouping them with

D19596: color monochrome icons to tooltip colors

sitter added a comment. Following Kai's question... wouldn't KIconLoader::global make the entire static obsolete? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19603: Fix colours of header bar for acitve and inactive windows

davidedmundson added a comment. > What's the reason for removing the linear gradient? In the old code it was a gradient between $WindowBackgroundNormal and $WindowBackgroundNormal which obviously did nothing so I removed it. But I think you're right that breeze technically should

D19603: Fix colours of header bar for acitve and inactive windows

zzag added a comment. > On X11, gtk isn't selecting the backdrop class. Probably because kwin doesn't support one of their new activation flags which would be a GTK bug for not following their fallback correctly. If this is the case, then it's a bit awkward because GTK doesn't follow

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

filipf added a comment. Now that the other patch is done, I come offering 2 solutions. **Solution 1: Mimic the action button circles' appearance** F6673176: Screenshot_20190308_122953.png F6673180: Screenshot_20190308_122851.png

D19603: Fix colours of header bar for acitve and inactive windows

davidedmundson added a comment. > Are GTK developers aware of this problem? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19603 To: davidedmundson, #breeze, zzag, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

rooty added a comment. i vote for no 2 / current diff REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19478 To: filipf, ngraham, #vdg, #plasma, rooty Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19603: Fix colours of header bar for acitve and inactive windows

zzag added inline comments. INLINE COMMENTS > zzag wrote in _headerbar.scss:14 > This is probably redundant. Argh, please ignore this comment. It looks like background-image: none, background-color: ..., is used throughout the theme. REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D19603: Fix colours of header bar for acitve and inactive windows

davidedmundson added a comment. > Are GTK developers aware of this problem? There's an old bug report, I've just added some info to it. https://gitlab.gnome.org/GNOME/gtk/issues/499 I'm not 100% against adding the focus state in kwin. REPOSITORY R98 Breeze for Gtk REVISION

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

rooty accepted this revision. rooty added a comment. There doesn't seem to be anything else to be done here REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19478 To: filipf, ngraham, #vdg, #plasma, rooty Cc: abetts, plasma-devel, jraleigh,

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

filipf updated this revision to Diff 53434. filipf added a comment. Subtract 2 from width so we don't get fringing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19478?vs=52994=53434 BRANCH master REVISION DETAIL