D22451: Unsplash POTD: filter out banner image and pick random photo from latest

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22451 AFFECTED FILES

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

guoyunhe updated this revision to Diff 61727. guoyunhe added a comment. Enable smoothing for POTD wallpaper REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22451?vs=61726=61727 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22451

D22452: Fix text color in non-selected tabs in Firefox

mthw created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mthw requested review of this revision. REVISION SUMMARY Currently labels on tabs in firefox that are not selected are hard to read (black text on dark background). This fixes it. TEST PLAN

D22452: Fix text color in non-selected tabs in Firefox

zzag added a comment. I'm not a Breeze GTK maintainer or developer, but perhaps you need to create separate folder for application specific styles, e.g. src/XXX/apps and put Firefox styles in a corresponding file, e.g. src/XXX/apps/_firefox.scss INLINE COMMENTS >

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61729. mthw added a comment. Separate file and avoid hard-conding color. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61728=61729 BRANCH fix-firefox-tab-text-color (branched from master) REVISION

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61730. mthw added a comment. Fixed duplicate. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61729=61730 BRANCH fix-firefox-tab-text-color (branched from master) REVISION DETAIL

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61731. mthw added a comment. Formatting REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61730=61731 BRANCH fix-firefox-tab-text-color (branched from master) REVISION DETAIL

D22452: Fix text color in non-selected tabs in Firefox

ndavis added a comment. Can you post a picture of what this change is supposed to do? I see that you are hardcoding a color here. Have you tested the change with Breeze Dark? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze Cc:

D22452: Fix text color in non-selected tabs in Firefox

ndavis added inline comments. INLINE COMMENTS > _firefox.scss:4 > +color: theme_bg_color; > +background-color: #475057; > +} I see that you are hardcoding a color here. Have you tested the change with Breeze Dark? REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. In D22452#495240 , @ndavis wrote: > Can you post a picture of what this change is supposed to do? Before: https://imgur.com/a/MqqgUQm After: https://imgur.com/a/gu5RV6M REPOSITORY R98 Breeze for Gtk REVISION

D22452: Fix text color in non-selected tabs in Firefox

mthw marked an inline comment as done. mthw added a comment. Yes I have tried with Breeze Dark, it works correctly. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22452: Fix text color in non-selected tabs in Firefox

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R98 Breeze for Gtk BRANCH fix-firefox-tab-text-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze,

D22452: Fix text color in non-selected tabs in Firefox

mthw planned changes to this revision. mthw added a comment. I seem to have some problems building this, I guess I need to change something in build files. Could you help me find it, I am new at this? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To:

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

guoyunhe added a comment. In D22451#495272 , @ngraham wrote: > Instead of `smooth: true` doing this may achieve the same result with less memory usage: > > sourceSize.width: parent.width > sourceSize.height: parent.height > I

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

ngraham added a comment. Ah right, that's a property of `Image`, not `QImageItem`. https://doc.qt.io/qt-5/qml-qtquick-image.html#sourceSize-prop Can you use `Image` instead? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22451 To: guoyunhe, #plasma

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61733. mthw added a comment. Fixed wrong color name. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61731=61733 BRANCH fix-firefox-tab-text-color (branched from master) REVISION DETAIL

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. > ... it seems to do nothing ... The problem was that I tried to use a color name instead of a hex code and put a wrong name there (still don't know the correct one). REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To:

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

guoyunhe added a comment. In D22451#495279 , @ngraham wrote: > Ah right, that's a property of `Image`, not `QImageItem`. > > https://doc.qt.io/qt-5/qml-qtquick-image.html#sourceSize-prop > > Can you use `Image` instead? I got a

D22452: Fix text color in non-selected tabs in Firefox

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. This causes a problem with Breeze and Breeze Dark when the titlebar is enabled. With Patch == Breeze: F7021382: Screenshot_20190714_080027.png

D22452: Fix text color in non-selected tabs in Firefox

ndavis added a comment. In D22452#495224 , @zzag wrote: > I'm not a Breeze GTK maintainer or developer There is currently no maintainer of breeze-gtk In D22452#495265 , @mthw wrote: > I

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

ngraham added a comment. Instead of `smooth: true` doing this may achieve the same result with less memory usage: sourceSize.width: parent.width sourceSize.height: parent.height REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22451 To: guoyunhe,

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. In D22452#495286 , @ndavis wrote: > This causes a problem with Breeze and Breeze Dark when the titlebar is enabled. > > With Patch > == > Breeze: F7021382: Screenshot_20190714_080027.png

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

ngraham created this revision. ngraham added reviewers: Plasma, VDG, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY "Capture Devices" sounds like some kind of kidnapping tool to people who aren't

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, let's not poke the bear too much then. :) REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22451 To: guoyunhe, #plasma, ngraham

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

This revision was automatically updated to reflect the committed changes. Closed by commit R114:4352cf848d30: Unsplash POTD: filter out banner image and pick random photo from latest (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. Yes, I see it is different, but isn't it better now (after the patch)? https://imgur.com/a/aauVgPp REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: ndavis, zzag, plasma-devel, LeGast00n,

D22452: Fix text color in non-selected tabs in Firefox

ngraham added a comment. Whether or not it's better is not relevant for this patch, which right now is only about fixing the text color. It's best not to mix multiple changes like this, unless you want to expand the patch in scope, in which case it should be re-titled accordingly.

D22452: Fix text color in non-selected tabs in Firefox

cblack added a comment. I would probably replace `color: #eff0f1;` -> `color: t_color(text);` `background-color: #475057;` -> `background-color: t_color(background);` in `_firefox.scss` to not hardcode the colors REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61740. mthw added a comment. Replace hardcoding REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61733=61740 BRANCH fix-firefox-tab-text-color (branched from master) REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 66 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/66/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 14 Jul 2019 14:35:16 + Build duration: 2 min 20 sec and counting CONSOLE OUTPUT

Re: RFC: Running clang-format across all Plasma (and more?) repos

El dijous, 11 de juliol de 2019, a les 16:18:08 CEST, David Edmundson va escriure: > One topic discussed at the recent Plasma sprint was that we should run > a code formatting tool (clang-format) over all our repos to ease all > future review comments about whitespace. > > All new contributions

D22467: Make captive portal notification persistent but low priority

ngraham created this revision. ngraham added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY The captive portal notification is

D22457: Make it possible to show the QR of a network connection

ngraham added a comment. The more things we put into the context menu, the more important I think it becomes to port the delegates to use a Krigami basiclistitem and make the items in the context menu show up on hover, with some of the more esoteric ones being in an overflow menu. We should

D22457: Make it possible to show the QR of a network connection

apol added a comment. In D22457#495406 , @ngraham wrote: > The more things we put into the context menu, the more important I think it becomes to port the delegates to use a Krigami basiclistitem and make the items in the context menu show up

D22457: Make it possible to show the QR of a network connection

apol updated this revision to Diff 61767. apol marked an inline comment as done. apol added a comment. Address Nate's comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22457?vs=61752=61767 BRANCH master REVISION DETAIL

D22457: Make it possible to show the QR of a network connection

apol updated this revision to Diff 61773. apol added a comment. Removed unnecessary things REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22457?vs=61767=61773 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22457

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

https://bugs.kde.org/show_bug.cgi?id=357288 Andrew changed: What|Removed |Added CC||andrewdba...@gmail.com --- Comment #12 from Andrew

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61756. cblack added a comment. This is why you shouldn't forget to test - default logo is now no longer pitifully small REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61755=61756 BRANCH

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack added a comment. In D22458#495455 , @ngraham wrote: > An interesting idea. Are you in contact with any distros that have requested this or would make use of it? This was created directly because an LCP (artwork dude) at openSUSE

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61761. cblack added a comment. Logo has text now REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61756=61761 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22467: Make captive portal notification persistent but low priority

apol added a comment. +1 Makes sense to me. I added a similar feature to work around the disappearing notification few weeks ago. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D22467 To: ngraham, #plasma, jgrulich Cc: apol,

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61774. cblack added a comment. Use units.longDuration REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61761=61774 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22463: data/kde32b1.khotkeys: Write in US English: anticlockwise -> counterclockwise

aspotashev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R101 KHotKeys BRANCH ccw REVISION DETAIL https://phabricator.kde.org/D22463 AFFECTED FILES

D22426: Add Unsplash POTD Provider

filipf added a comment. In D22426#495465 , @ognarb wrote: > In D22426#494745 , @guoyunhe wrote: > > > Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues.

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

ngraham added inline comments. INLINE COMMENTS > Main.qml:424 > +NumberAnimation { > +duration: 500 > +easing.type: Easing.InOutQuad Match the duration for other opacity animation effects (i.e. use `units.longDuration`) > Main.qml:444 >

D22457: Make it possible to show the QR of a network connection

ngraham added a comment. Yeah maybe. Here's what happens on X11: F7024605: Screenshot_20190714_215130.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D22457 To: apol, #plasma, jgrulich Cc:

D22457: Make it possible to show the QR of a network connection

ngraham added inline comments. INLINE COMMENTS > ShowQR.qml:53 > +Layout.fillWidth: true > +Layout.fillHeight: true > +content: "don't look at my wifi" These won't do anything because it's not in a Layout anymore REPOSITORY R116 Plasma Network Management

D22452: Fix text color in non-selected tabs in Firefox

zzag added a comment. We should not style server-side decorated Firefox windows. They are fine. The problem you're trying to solve only affects client-side decorated Firefox windows F7022851: Screenshot_20190714_221415.png F7022853:

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The Breeze SDDM theme now shows a logo that can be configured by distro vendors or curious users.

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

ngraham added a reviewer: Plasma. ngraham added a comment. An interesting idea. Are you in contact with any distros that have requested this or would make use of it? I wouldn't mind adding some text to the default logo so for any distros that opt to turn it on and not override the

D22426: Add Unsplash POTD Provider

ognarb added a comment. In D22426#494745 , @guoyunhe wrote: > Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues. > > I do think it is good to show photographers' credits. But that will require

D22460: DrKonqi: improved lldb integration

rjvbb created this revision. rjvbb added reviewers: kde-frameworks-devel, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rjvbb requested review of this revision. REVISION SUMMARY Since a few versions lldb has had a tendency to remain stuck after the initial

D22464: kcms/phonon: Remove trailing space from an i18n string

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2f21504c080f: kcms/phonon: Remove trailing space from an i18n string (authored by aspotashev). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22457: Make it possible to show the QR of a network connection

apol marked 3 inline comments as done. apol added inline comments. INLINE COMMENTS > ngraham wrote in ShowQR.qml:45 > I don't think you need to use a ColumnLayout if it'll have only one item in > it. You can just add margins to the Prison item itself. Yes, good catch. I had something there and

D22457: Make it possible to show the QR of a network connection

ngraham added a comment. One thing I noticed when trying this out is that when the full-screen window showing the QR code appears, plasma-nm's system tray popup doesn't close, and the QR code window is drawn underneath it. On my 16x9 screen, the system tray popup just barely doesn't overlap

D22457: Make it possible to show the QR of a network connection

apol added a comment. F7022898: Screenshot_20190714_213236.png F7022913: Screenshot_20190714_213624.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D22457

D22464: kcms/phonon: Remove trailing space from an i18n string

aspotashev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R119 Plasma Desktop BRANCH i18n-space REVISION DETAIL https://phabricator.kde.org/D22464 AFFECTED FILES

D22463: data/kde32b1.khotkeys: Write in US English: anticlockwise -> counterclockwise

This revision was automatically updated to reflect the committed changes. Closed by commit R101:e498b3aaa70d: data/kde32b1.khotkeys: Write in US English: anticlockwise - counterclockwise (authored by aspotashev). REPOSITORY R101 KHotKeys CHANGES SINCE LAST UPDATE

D22457: Make it possible to show the QR of a network connection

apol added a comment. In D22457#495614 , @ngraham wrote: > One thing I noticed when trying this out is that when the full-screen window showing the QR code appears, plasma-nm's system tray popup doesn't close, and the QR code window is drawn

D22457: Make it possible to show the QR of a network connection

apol created this revision. apol added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. apol requested review of this revision. REVISION SUMMARY It's useful to be able to share a network

D21905: [Digital Clock] Open KOrganizer with event details on click

apol added inline comments. INLINE COMMENTS > CalendarView.qml:196 > +onClicked: { > +monthView.daysModel.showEventDetails(modelData.uid) > +} Maybe it should only be enabled if there's events to show? REPOSITORY R120 Plasma

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg created this revision. romangg added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY The KScreen KCM was still partly Qt Widgets based. Also it did not use a model for the

D22457: Make it possible to show the QR of a network connection

jgrulich added inline comments. INLINE COMMENTS > ConnectionItem.qml:171 > +text: i18n("Show network's QR code") > +visible: ConnectionState !== PlasmaNM.Enums.Deactivated > +onClicked: { I think this should be limited to wireless connections only (Type ==