D22589: Embrace X-KDE-Wayland-Interfaces

apol updated this revision to Diff 62771. apol added a comment. include keystates REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22589?vs=62130=62771 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22589 AFFECTED FILES

D22533: [KCM] Slightly imptove tab bar's integration with frame

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Looks better. I would also add the bug no. to the comment so all instances of workarounds can be easily grepped when the bug is closed. REPOSITORY R115 Plasma Audio Volume Applet BRANCH

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

filipf added a comment. I don't feel too wise regarding this, pinging #plasma in case someone has advice. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22359 To: ndavis, #vdg, #plasma Cc: filipf, plasma-devel,

D22817: Port KRunner to Plasma Components 3

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Using the new, stable components. Biggest change is that now we don't have a clear button and we need to

D22762: Take in consideration flat() for the All Applications menu

davidedmundson added a comment. m_flat currently behaves a bit specially. It doesn't affect the toplevel, it only affects sub models created within it. If we used AppsModel directly to fix the original bug, we would need to fix AppsModel to follow m_flat when showing an empty

D22493: [Notifications] Move history items' icons over to the left a bit

filipf requested changes to this revision. filipf added a comment. This revision now requires changes to proceed. Yeah this affects popups as well Before: F7115595: image.png After: F7115590: image.png

D20972: [sidebar] Make search field not glued to the separator

filipf added a comment. So Discover seems to have greater issues, but the added margin looks better than no added margin in system settings. F7115662: image.png @davidedmundson I can't find a better solution.. REPOSITORY R124 System Settings

D22818: Avoid crash if kicker plugin is used outside plasma context

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Code currently gets the applet interface object passed in explicitly, from

D22316: Avoid garbling the sound if the volume slider is moved fast

filipf added a comment. Removed VDG as the reviewer, seems like a technical issue all together. Also wanted to contribute, but I don't really perceive any issues when moving the slider fast :/ REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22316

D22176: Rework system tray settings

filipf added a comment. In D22176#489327 , @ngraham wrote: > Honestly I would support staying with the QQC1 TableView for now. Trying to move to QQC2 without a replacement for it just means we're rolling our own table view, which seems even

Re: Renaming appdata and desktop file for GCompris

Hi, Do note that the appstream file name and the desktop file name do not need to be the same. An appstream file tags a specific desktop file as [1]. So technically you do not need to rename it, you only need to change the desktop file and the provides entry. If you want to rename it do note

D20093: Show a context menu on pressAndHold

apol abandoned this revision. apol added a comment. Will need a better solution REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20093 To: apol, #plasma, mart Cc: GB_2, davidedmundson, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel,

D22804: [System Tray] Do not send ContextMenu signal twice

kmaterka created this revision. kmaterka added a reviewer: Plasma: Workspaces. kmaterka added a project: Plasma: Workspaces. Herald edited projects, added Plasma; removed Plasma: Workspaces. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY

D22804: [System Tray] Do not send ContextMenu signal twice

broulik added a comment. Maybe the behavior must be split between `PlasmoidItem` and `StatusNotifierItem`. Ideally, all menus opened on press but that has shown to be problematic for XembedSniProxy REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22804 To:

D22540: Port ResultDelegate to use PlasmaComponents 3.0

apol added a comment. Ping? This is blocking D22514 REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D22540 To: apol, #plasma Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

Re: Renaming appdata and desktop file for GCompris

Hi, thanks for the explanation. We'll go with the QGuiApplication::setDesktopFileName solution as we don't use KF5 and it seems the easiest way to do it. Johnny Le lun. 29 juil. 2019 à 08:03, Harald Sitter a écrit : > > Hi, > > Do note that the appstream file name and the desktop file name do

D22738: Remove some uses on QDesktopWidget

apol updated this revision to Diff 62725. apol added a comment. Add eike's braces REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22738?vs=62582=62725 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22738 AFFECTED FILES

D17464: [Timer applet] Minor fixes for the applet

davidedmundson added a comment. I still can't accept a patch with an unexplained magic number. If the rationale is that it's to match the clock, then it has to match the clock. If there's something else, please can the comment say what. REPOSITORY R114 Plasma Addons REVISION DETAIL

D17464: [Timer applet] Minor fixes for the applet

gepardo added a comment. The rationale is to make the clock font size and the timer font size identical. Setting 0.84 as timer height multiplier indeed reaches this goal. But two other problems remain: - the fonts are different itself, as clock uses the real font, and timer uses SVGs

D22804: [System Tray] Do not send ContextMenu signal twice

kmaterka added a comment. This fixes 27b1030756002e91b60ba51483efe9c2c477d16e , which reverts b9af99140365c8c8cf4e3744af7e13b35c35fa18

D22767: Calculate first clickable point, from the top-left

kmaterka updated this revision to Diff 62723. kmaterka marked 3 inline comments as done. kmaterka added a comment. Review changes. Call to the calculateClickPoint is local and on only on mouse click, not on every icon update. CHANGES SINCE LAST UPDATE

notes for 29/7/2019 monday meeting

Kai Uwe: * Wrote a new model backing Milou/KRunner which avoids resetting the entire list every time results change * Improves performance, especially when dealing with results that hardly change (e.g. calculator) * Keeps the selection steady as results come in delayed and shift the

D22803: Improved OSD behavior

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Don't ask the user for a screen configuration on login, instead, apply a sane default.

D22804: [System Tray] Do not send ContextMenu signal twice

apol added a comment. How will non-plasmoids (e.g. SNI) get contextMenu calls then? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22804 To: kmaterka, #plasma_workspaces Cc: apol, plasma-devel, #plasma_workspaces, LeGast00n, jraleigh, fbampaloukas, GB_2,

D17464: [Timer applet] Minor fixes for the applet

gepardo updated this revision to Diff 62730. gepardo added a comment. Minor change in the comment for the "magic" value 0.84 REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17464?vs=62660=62730 BRANCH arcpatch-D17464 REVISION DETAIL

D22767: Calculate first clickable point, from the top-left

davidedmundson added a comment. Thanks for doing some work on xembedsniproxy! INLINE COMMENTS > sniproxy.cpp:239 > > +calculateClickPoint(image); > + This is quite expensive to do every frame (some animate), I think we can do something else, see below. > sniproxy.cpp:530 >

D22767: Calculate first clickable point, from the top-left

davidedmundson added inline comments. INLINE COMMENTS > sniproxy.cpp:576 > event->root = QX11Info::appRootWindow(); > event->root_x = x; > event->root_y = y; This point was marked as closed, but not changed. Probably my fault for not expanding. We move the window

Addendum to 29/07/2019 meeting

Hi, I landed https://phabricator.kde.org/D22121 which allows sorting the wallpaper slideshow in a specific order. This is managed by a QSortFilterProxyModel. This model is now also used for the actual slideshow and the config dialog (No more QStringlist of the images that we want to show/are

D22804: [System Tray] Do not send ContextMenu signal twice

kmaterka added a comment. In D22804#503733 , @broulik wrote: > > Yes, probably onPressed should be handled in PasmoidItem, not in the AbstractItem to avoid this kind of problems. > > Indeed, that would be the best solution. Should

D22804: [System Tray] Do not send ContextMenu signal twice

kmaterka updated this revision to Diff 62738. kmaterka added a comment. I simplified the patch. It moves handling of onPressed to PlasmoidItem. This way we can have context menu when mouse is pressed for plasmoids and on click for SNI. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D19947: systray: show a small animation on the icons when activated

apol added a comment. Ping? I still miss this... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19947 To: apol, #plasma Cc: anthonyfieroni, davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D17464: [Timer applet] Minor fixes for the applet

davidedmundson added a comment. > The rationale is to make the clock font size and the timer font size identical. Setting 0.84 as timer height multiplier indeed reaches this goal. But two other problems remain: I don't follow how it makes them the same when the other number is

D22804: [System Tray] Do not send ContextMenu signal twice

kmaterka added a comment. @apol SNI applications (including XembedSniProxy) are using StatusNotifierItem.qml, which already has onClick handled for right button. That why we had ContextMenu event's duplicated. @broulik Yes, probably onPressed should be handled in PasmoidItem, not in the

D22804: [System Tray] Do not send ContextMenu signal twice

broulik added a comment. > Yes, probably onPressed should be handled in PasmoidItem, not in the AbstractItem to avoid this kind of problems. Indeed, that would be the best solution. > I would personally opt for consistency, though. As far as I know GTK is showing context menu on

D6313: Support Icon Scale from Icon naming specification 0.13

volkov added inline comments. INLINE COMMENTS > kiconloader.cpp:1368 > > -if (group >= 0 && group < KIconLoader::LastGroup) { > +if (group >= 0) { > img = d->mpEffect.apply(img, group, state); Why this line reverts D12002 ? REPOSITORY

D6313: Support Icon Scale from Icon naming specification 0.13

volkov added inline comments. INLINE COMMENTS > broulik wrote in kiconloader.cpp:1368 > Dunno, probably oversight or forgotten to rebase.. Looks like a rebase: https://phabricator.kde.org/D6313?vs=31197=34779=ignore-most#toc REPOSITORY R302 KIconThemes REVISION DETAIL

D19947: systray: show a small animation on the icons when activated

davidedmundson added a comment. Code wise, it's fine. Personally I like it. If VDG approve, go for it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19947 To: apol, #plasma Cc: anthonyfieroni, davidedmundson, ngraham, plasma-devel, LeGast00n,

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added inline comments. INLINE COMMENTS > volkov wrote in kiconloader.cpp:1368 > Why this line reverts D12002 ? Dunno, probably oversight or forgotten to rebase.. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To:

D22540: Port ResultDelegate to use PlasmaComponents 3.0

apol updated this revision to Diff 62752. apol added a comment. Rebase on top of kai's patch REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22540?vs=62517=62752 BRANCH pc3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D22540

D22540: Port ResultDelegate to use PlasmaComponents 3.0

apol updated this revision to Diff 62753. apol added a comment. forgot opacity REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22540?vs=62752=62753 BRANCH pc3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D22540 AFFECTED FILES

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added inline comments. INLINE COMMENTS > volkov wrote in kiconloader.cpp:1368 > Looks like a rebase: > https://phabricator.kde.org/D6313?vs=31197=34779=ignore-most#toc Feel free to submit a patch to restore this REPOSITORY R302 KIconThemes REVISION DETAIL

D17464: [Timer applet] Minor fixes for the applet

gepardo added a comment. Here is how it looks on tall panels: F7114427: clock2.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17464 To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma Cc: ngraham,

D17464: [Timer applet] Minor fixes for the applet

gepardo updated this revision to Diff 62751. gepardo added a comment. Now the widget doesn't become too wide if the panel is tall. The size formula now looks similar to the size formula of the clock widget. Expanatory comment is updated. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST

D17464: [Timer applet] Minor fixes for the applet

gepardo updated this revision to Diff 62750. gepardo added a comment. Change magic value to 0.86, as it looks nearer to the clock font size REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17464?vs=62730=62750 BRANCH arcpatch-D17464 REVISION DETAIL

D17464: [Timer applet] Minor fixes for the applet

gepardo added a comment. > I don't follow how it makes them the same when the other number is different. Timer applet is rendered using SVGs, clock applet is rendered using text. So, as the SVGs and font glyphs have different sizes, we need different coefficients. The coefficient 0.86

D22813: Don't give up if no results arrive after 500 ms, again.

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Port the fix added by D21605 to the new model and add

D22813: Don't give up if no results arrive after 500 ms, again.

broulik updated this revision to Diff 62765. broulik added a comment. - `doppelthältbesser--` REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22813?vs=62762=62765 REVISION DETAIL https://phabricator.kde.org/D22813 AFFECTED FILES

D22813: Don't give up if no results arrive after 500 ms, again.

This revision was automatically updated to reflect the committed changes. Closed by commit R112:82b1ed82848c: Dont give up if no results arrive after 500 ms, again. (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22813?vs=62765=62766

D22813: Don't give up if no results arrive after 500 ms, again.

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > runnerresultsmodel.cpp:56 > + > +m_hasMatches = false; > } Redundant REPOSITORY R112 Milou REVISION DETAIL

D22814: Remove colon (:) prefix when looking up dictionary word

broulik created this revision. broulik added reviewers: Plasma, mart, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The dictionary engine lets us specify a server and dictionary but we don't need