D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#518001 , @dfaure wrote: > What I mean is: > > 1. improve KFileItem::isSlow to use this Solid code > 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true Sorry I

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 105 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/105/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 24 Aug 2019 18:09:25 + Build duration: 2 min 27 sec and counting JUnit Tests Name: (root)

D23241: Show application window icon on AboutPage

caspermeijn marked an inline comment as done. caspermeijn added inline comments. INLINE COMMENTS > apol wrote in settings.h:81 > It could make sense to include the REVISION part: > https://doc.qt.io/qt-5/properties.html I have no idea what the value would be for that and Kirigami doesn't have

D23413: [System Tray] Unified data model for System Tray items

kmaterka added a comment. I spent some time testing it and I hope it is now bug free. I understand it is a big change that brings little value (now), but I'm working on further improvements and wanted to slip work into smaller patches. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23414: Remove font configuration from GTK KCM

gikari added inline comments. INLINE COMMENTS > ngraham wrote in gui.ui:460 > Looks unrelated Hm strange, I only deleted font widgets from Qt Creator. I will fix that manually. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D23414 To: gikari, apol,

D23389: Use "Make default" buttons to switch the default device

ndavis added a comment. I think this looks pretty good, but why are the margins on the first item different from the second item? F7277492: Screenshot_20190824_194152.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D21860: Set a font for gtk applications in the fonts kcm

gikari updated this revision to Diff 64517. gikari added a comment. Create a Gtk Config kded module To actually apply settings to gtk applications DBus call should have a reciever. This creates it as kded module. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. Good question. Let me check it out. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca, #plasma, #vdg Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23414: Remove font configuration from GTK KCM

ngraham added reviewers: apol, Plasma. ngraham added inline comments. INLINE COMMENTS > gui.ui:460 > + > + .. > Looks unrelated REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D23414 To: gikari, apol, #plasma Cc: ngraham,

D23389: Use "Make default" buttons to switch the default device

ndavis added a comment. In D23389#518275 , @ngraham wrote: > In D23389#518269 , @ndavis wrote: > > > Maybe we can add another line to the device item for the button to go on? Seems like it might

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. No, the margins are messed up. I can fix them in this patch since it becomes more obvious. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca, #plasma, #vdg Cc: alexde, ndavis, anthonyfieroni,

D23389: Use "Make default" buttons to switch the default device

ngraham updated this revision to Diff 64527. ngraham added a comment. - Fix margins and alignment - Put the button on a new row in the applet - Use the button to also show which device is currently the default, rather than implying it REPOSITORY R115 Plasma Audio Volume Applet CHANGES

D23414: Remove font configuration from GTK KCM

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since gtk font settings is now set from Fonts KCM, there is no need to configure font separately in GTK Configuration KCM.

D23413: [System Tray] Unified data model for System Tray items

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Currently there are two different sources of SystemTray items: -

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

kossebau created this revision. kossebau added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also drop checking if the suffix exists, the code is only reached because this condition has

D23414: Remove font configuration from GTK KCM

gikari updated this revision to Diff 64524. gikari added a comment. Fix REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23414?vs=64522=64524 BRANCH remove-font-config (branched from master) REVISION DETAIL

D22176: Rework system tray settings

kmaterka added a comment. @nicolasfella Correct me if I'm wrong. EntryModel is created on the first use and it is populated in the constructor. If user runs application that uses StatusNotifier (for example Skype, Dropbox, Electron apps, any Windows app via Wine, etc) later, it won't be

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#517980 , @dfaure wrote: > Why not do this in KFileItem::isSlow() itself? > (and enable SkipMimeTypeFromContent when isSlow is true) First because KFileItem::isSlow is a member function of KFileItem and

D23401: Fix scroll control (add -P option)

srenaud created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. srenaud requested review of this revision. REVISION SUMMARY I find out that the screen gets darker every time I'm using the scroll control, no matter the direction. It has been mentionned

D23389: Use "Make default" buttons to switch the default device

alexde added a comment. > for various technical reasons that are not yet fixable Can you please point me to those? Is there ongoing work? I'm curious. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca, #plasma, #vdg

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

ndavis added a comment. In D23389#517826 , @anthonyfieroni wrote: > Why not it's a checkbox ? Make default looks big. You can only have 1 default, but there are multiple devices, so the check box would have to be a radio button instead.

D23198: Skip mime type check only for files on network mounts

dfaure added a comment. What I mean is: 1. improve KFileItem::isSlow to use this Solid code 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true However maybe we don't want that in dolphin? Not sure. (In that case a new enum value can be added,

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

anthonyfieroni added a comment. But in settings is radio button F7276400: Screenshot_20190824_185610.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca, #plasma, #vdg Cc: ndavis,

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. Well, we're at an impasse then. 1. When the button is on the top row, if it's really long, it intrudes on and elides the device name 2. When the button is on the bottom row, it shortens the volume slider 3. If the button has no text, it's not clear what it

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. In D23389#518269 , @ndavis wrote: > Maybe we can add another line to the device item for the button to go on? Seems like it might just add visual bloat, but I can't actually think of a concrete reason why it would be

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham added a comment. @davidedmundson ping. I fixed one issue but may need a bit of help for the one about the weird sizing for the button grid component. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson,

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

ndavis added inline comments. INLINE COMMENTS > ListItemBase.qml:120 > +PlasmaComponents.Button { > +text: i18n("Make default") > +onClicked: PulseObject.default = true; According to the HIG, this should have title style

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

ngraham updated this revision to Diff 64478. ngraham marked an inline comment as done. ngraham added a comment. Use Title Case for button text REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23389?vs=64450=64478 BRANCH master REVISION

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

ngraham added a comment. Should be changed there too; that's an inappropriate use of radio buttons. One doesn't even have a label so you have no idea what it does. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca,

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

ngraham updated this revision to Diff 64489. ngraham added a comment. Do the same thing for the KCM REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23389?vs=64478=64489 BRANCH master REVISION DETAIL

D22832: Fix build with pango 1.44

arojas added a comment. Ping, can this go in for 5.16.5? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D22832 To: arojas, #plasma Cc: apol, sitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23389: Use "Make default" buttons to switch the default device

alexde added a comment. > DnD is not very intuitive for things that don't look inherently draggable That's why I draw a frame around the entries and also the mouse pointer could change to a hand. Otherwise I neither really like 1) or 2). How do other systems handle this? REPOSITORY

D23241: Show application window icon on AboutPage

caspermeijn updated this revision to Diff 64512. caspermeijn added a comment. Fixed since version number REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23241?vs=63975=64512 BRANCH about_icon (branched from master) REVISION DETAIL

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

ngraham added a comment. FWIW we implemented the same UI in Discover to solve the same problem (people didn't know how to set/change the default backend when multiple were present) and since then, we haven't had any user complaints at all. F7276043: Screenshot_20190824_065332.png

D21524: Keep existing configurations' strings               

This revision was automatically updated to reflect the committed changes. Closed by commit R99:a9f3a3ddcb0b: Keep existing configurations strings    (authored by gikari, committed by ngraham). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D23389: Use "Make default" buttons to switch the default device

anthonyfieroni added a comment. My big concern is that translated text is mainly not too big in English but in other lang. Even we change it to "Default Out" (since it has a label "Outputs"). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389

D22832: Fix build with pango 1.44

This revision was automatically updated to reflect the committed changes. Closed by commit R99:cf8db4ebe5ef: Fix build with pango 1.44 (authored by arojas). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22832?vs=62800=64505 REVISION DETAIL

D23389: Use "Make default" buttons to switch the default device

ndavis added a comment. In D23389#518211 , @ngraham wrote: > I'm also not a fan of icons-only buttons, because their meaning is ambiguous unless the icon is //perfect//. And we don't have a perfect icon here. We could try moving the button down

D23389: Use "Make default" buttons to switch the default device

ngraham updated this revision to Diff 64506. ngraham added a comment. Move button to second row where it won't be so obtrusive for languages where the text is really long REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. I'm not using an icons-only button here. It wouldn't be clear; we need text. I understand with with certain languages, the text could be long. But without text there's no point to this feature, because it no longer solves the problem. If the UI becomes too

D23401: Fix scroll control (add -P option)

ngraham added a comment. There's an already-submitted patch to fix that includes backwards compatibility: D23330 REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D23401 To: srenaud, martinkostolny Cc: ngraham,

D22832: Fix build with pango 1.44

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Just ran into the same issue today and prepared a similar patch right before getting a notification email about this! Let's do it for the stable branch for sure. REPOSITORY R99 KDE

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#518001 , @dfaure wrote: > What I mean is: > > 1. improve KFileItem::isSlow to use this Solid code > 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true Sorry I

D23389: Use "Make default" buttons to switch the default device

ndavis added a comment. Maybe we should just keep the "Make Default" button in the hamburger menu? It's less visible, but we don't have much space and it's usually not as important as the device name and volume slider. We can keep the "Make Default" button in the audio KCM. REPOSITORY

D23198: Skip mime type check only for files on network mounts

dfaure added a comment. Why not do this in KFileItem::isSlow() itself? (and enable SkipMimeTypeFromContent when isSlow is true) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaure Cc: davidedmundson, ngraham, broulik,

D23389: Use "Make default" buttons to switch the default device

ndavis added a comment. Not a fan of icon only buttons for uncommon tasks, but if saving space ever becomes absolutely necessary, we could use the star icon for "Make Default" instead of having text. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. In D23389#518259 , @ndavis wrote: > Maybe we should just keep the "Make Default" button in the hamburger menu? It's less visible, but we don't have much space and it's usually not as important as the device name and

D21470: Properly read stderr when data is ready from the daemon.

luc4 added a comment. Ping. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D21470 To: luc4, davidedmundson, mlaurent, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23389: Use "Make default" buttons to switch the default device

anthonyfieroni added a comment. In D23389#518211 , @ngraham wrote: > I can add a note for translators that this string should be kept as short as possible. Furthermore in bulgarian is even longer, there is no short word that fits

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. We already have a drag-and-drop UI for determining the default and nobody has ever figured it out. :) DnD is not very intuitive for things that don't look inherently draggable, or that people have become accustomed to dragging (like files and folders in a file

D23389: Use "Make default" buttons to switch the default device

ndavis added a comment. Maybe we can add another line to the device item for the button to go on? Seems like it might just add visual bloat, but I can't actually think of a concrete reason why it would be bad. It could contain some small amount of useful info too. REPOSITORY R115 Plasma

D23389: Use "Make default" buttons to switch the default device

ngraham updated this revision to Diff 64490. ngraham added a comment. Make one more ToolButton into a button, just like in the Applet REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23389?vs=64489=64490 BRANCH master REVISION DETAIL

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. I'm also not a fan of icons-only buttons, because their meaning is ambiguous unless the icon is //perfect//. And we don't have a perfect icon here. We could try moving the button down to the next row: F7276552: Screenshot_20190824_112852.png

D23389: Use "Make default" buttons to switch the default device

alexde added a comment. Just brainstorming: What about two sections, 1) "default" with a single entry and 2) "others". The user could drag and drop the speaker to default place and the current default one would move downwards with an animation.F7276701: Screenshot_20190824_201127.png

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. In D23389#518270 , @alexde wrote: > > for various technical reasons that are not yet fixable > > Can you please point me to those? Is there ongoing work? I'm curious. Basically, we need to delete the Phonon

D23392: [energy KCM] Add battery Technology

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Depends on D23157 TEST PLAN Compiles Need to be

D21524: Keep existing configurations' strings               

gikari added a comment. In D21524#517780 , @apol wrote: > Do you have push powers? No, I don't have. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH arcpatch-D21524 REVISION DETAIL https://phabricator.kde.org/D21524 To: gikari,

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

luc4 added a comment. Anyone? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22774 To: luc4, davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

KDE CI: Plasma » plasma-nm » stable-kf5-qt5 SUSEQt5.12 - Build # 52 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/stable-kf5-qt5%20SUSEQt5.12/52/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 24 Aug 2019 08:51:25 + Build duration: 3 min 7 sec and counting JUnit Tests Name:

D23391: Clean up not needed Q_INVOKABLE

meven created this revision. meven added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY As suggested by https://phabricator.kde.org/D23152#inline-132069 TEST PLAN It runs fine REPOSITORY

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

anthonyfieroni added a comment. Why not it's a checkbox ? Make default looks big. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca, #plasma, #vdg Cc: anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev,