D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Heiko Becker
heikobecker added a comment. Admittedly to solve a problem, which originates from our downstream packaging. kde-cli-tools is a dependency of some applications and frameworks, which might be interesting to non Plasma users but depends on libkworkspace. As a a source based distro we cannot eas

D23878: Use QTEST_GUILESS_MAIN for systeminformationtest

2019-09-12 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R871:0f346886dc48: Use QTEST_GUILESS_MAIN for systeminformationtest (authored by heikobecker). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23878?vs=65853&id=65897 RE

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 8 - Still Failing!

2019-09-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/8/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 12 Sep 2019 07:09:39 + Build duration: 2 min 45 sec and counting CONSOLE OUTPUT [...tru

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Andreas Sturmlechner
asturmlechner added a comment. copy that for Gentoo. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker, #plasma Cc: davidedmundson, asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Z

D23852: Show connectivity status in tooltip

2019-09-12 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R116 Plasma Network Management Applet BRANCH tooltip-connectivity-status REVISION DETAIL https://phabricator.kde.org/D23852 To: jgrulich, broulik Cc: plasma-dev

Re: Plasma 5.12.9 LTS

2019-09-12 Thread Jonathan Riddell
KWin has been updated to 5.12.9.1 to fix compile with Qt 5.9 http://embra.edinburghlinux.co.uk/~jr/tmp/pkgdiff_reports/kwin/5.12.9_to_5.12.9.1/changes_report.html sha256sum b4dd8e54c99c1c8b6e68a3624724d8a4ea0a4f23ab7a6d2f767188efcfc88929 On Tue, 10 Sep 2019 at 22:29, Jonathan Riddell wrote: >

Re: Plasma 5.12.9 LTS

2019-09-12 Thread Jonathan Riddell
Having a CI would be better as others have said. I wonder if opensuse can do this with their open build service. Jonathan On Wed, 11 Sep 2019 at 19:40, Christoph Feck wrote: > On 09/11/19 19:35, Rik Mills wrote: > > On 10/09/2019 17:21, Jonathan Riddell wrote: > >> Plasma 5.12.9 LTS > >> is n

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread David Edmundson
davidedmundson added a comment. Happy to help, but I don't understand yet. kde-cli-tools doesn't use sessionmanagementbackend.h? The only user is inside plasma-workspace source. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker,

D23897: Port mobile_wifi kcm to newer APIs

2019-09-12 Thread Jonah Brüchert
jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. jbbgameich requested review of this revision. REVISION SUMMARY - Controls.Button can display icons on its own now - Use kcm.push() and kcm.pop() - Use

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Heiko Becker
heikobecker added a comment. In D23883#529898 , @davidedmundson wrote: > Happy to help, but I don't understand yet. > > kde-cli-tools doesn't use sessionmanagementbackend.h? > > The only user is inside plasma-workspace source. I o

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-12 Thread Carson Black
cblack updated this revision to Diff 65929. cblack added a comment. Substitute cuttlefish.close() for Qt.quit() REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65895&id=65929 BRANCH modernization (branched from master) REVISION DETAIL https

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-12 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > ngraham wrote in Tools.qml:36 > Set the same thing for the right margin too Not done yet REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2, trickyricky26, davidre, ndavis, filip

D23910: startplasma: Respect KDEWM again

2019-09-12 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY It got lost during the porting to native executables TEST PLAN

D23854: Fix wrong title of the Drawers page

2019-09-12 Thread Dimitris Kardarakos
This revision was automatically updated to reflect the committed changes. Closed by commit R1014:21c571099542: Fix the wrong title of the Drawers page (authored by dkardarakos). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23854?vs=65798&id=65933

D23910: startplasma: Respect KDEWM again

2019-09-12 Thread Björn Feber
GB_2 added a comment. BTW, I wonder if we can rename it to `PLASMAWM` in Plasma 6/the future. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23910 To: heikobecker, #plasma, apol, davidedmundson Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23910: startplasma: Respect KDEWM again

2019-09-12 Thread Nicolas Fella
nicolasfella added a comment. In D23910#530206 , @GB_2 wrote: > BTW, I wonder if we can rename it to `PLASMAWM` in Plasma 6/the future. Add a //TODO KF6 comment REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde

D23910: startplasma: Respect KDEWM again

2019-09-12 Thread Kai Uwe Broulik
broulik added a comment. I don't see a reason to rename it other than annoy sysadmins and making the documentation outdated REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23910 To: heikobecker, #plasma, apol, davidedmundson Cc: broulik, nicolasfella, GB_2,