Re: New Plasma Desktop website

On 09/14/19 14:38, Carl Schwan wrote: I finalized the first version of the new plasma-desktop webpage, a preview is available at https://kde.carlschwan.eu/plasma-desktop. There are still two parts missing (p-b-i and privacy) and some possible improvement that I would like to add later. Can I

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Ctrl+Q still doesn't work. Found one more thing: the search field is no longer focused by default like it is with the current/old version. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2,

D19337: Fixed some undefined properties runtime errors.

aacid closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19337 To: malteveerman, #kirigami, mart, aacid Cc: aacid, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein

D23578: Before requesting a scan, check the time threshold

meven updated this revision to Diff 66060. meven added a comment. Add a timer per interface allowing to scan devices as soon as technically possible, rescheduling wifi scan for when it will be possible REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D23520: Add time line to X axis

alexde updated this revision to Diff 66062. alexde added a comment. Fix offset calculation for the one hour graph REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66055=66062 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66064. cblack added a comment. Padding and focus fixes REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65929=66064 BRANCH modernization (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde updated this revision to Diff 66031. alexde added a comment. Use a switch statement for xTicksAt REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65457=66031 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23941: Compensate smaller icon sizes on mobile in the ActionButton

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY They became smaller since D22572 . This should restore the intended state. REPOSITORY

D23520: Add time line to X axis

alexde updated this revision to Diff 66044. alexde added a comment. The former scaling of the x-Positions of the data points did not fit to the time axis. Now the x-values of the points, i. e. their timestamps, are correctly aligned. For some unknown reasons, all data points, which

D23520: Add time line to X axis

alexde updated this revision to Diff 66034. alexde added a comment. Remove redundant semicolons and move comment about unit (ms) to the declaration of the var REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66031=66034 BRANCH

D23520: Add time line to X axis

ngraham added a comment. Thanks, that's fixed now. However the "Last hour" graph still looks a little odd... F7350933: Screenshot_20190914_084935.png REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23520 To: alexde,

D23578: Before requesting a scan, check the time threshold

meven added a comment. @jgrulich if you could have a second look, I improved this because my previous code could have prevented requestScan to be fired. REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D23578 REVISION DETAIL https://phabricator.kde.org/D23578 To:

D23520: Add time line to X axis

alexde updated this revision to Diff 66063. alexde added a comment. Remove redundant and now wrong comment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66062=66063 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde added a comment. In D23520#531168 , @ngraham wrote: > Thanks, that's fixed now. However the "Last hour" graph still looks a little odd... > > F7350933: Screenshot_20190914_084935.png Mm,

New Plasma Desktop website

Hello Plasma team, It was nice to meet you all to the Akademy, I hope you had all a safe travel back home and see you all next year. :p I finalized the first version of the new plasma-desktop webpage, a preview is available at https://kde.carlschwan.eu/plasma-desktop. There are still two

Re: New Plasma Desktop website

Maybe combine the first two images, then? Put the current release's wallpaper in the laptop background and add that "Latest release" window on top of it? Or do the opposite and remove the first image with the laptop. But having both seems a bit redundant. Nate On 9/14/19 7:48 AM, Carl

D23520: Add time line to X axis

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, now the X axis labels have disappeared for "Last hour", "Last 2 hours" and "Last 12 hours". REPOSITORY R102 KInfoCenter REVISION DETAIL

D23941: Compensate smaller icon sizes on mobile in the ActionButton

jbbgameich added a comment. I believe the new icon sizes were intentional for the drawer and own uses of Kirigami.Icon, but they influence the size of the whole ActionButton as well making it rather hard to click on a touch screen. Probably Camilo tested his changes only with mauikit which

Re: New Plasma Desktop website

On 9/14/19 7:10 AM, Christoph Feck wrote: On 09/14/19 14:38, Carl Schwan wrote: I finalized the first version of the new plasma-desktop webpage, a preview is available at https://kde.carlschwan.eu/plasma-desktop. There are still two parts missing (p-b-i and privacy) and some possible

D23941: Compensate smaller icon sizes on mobile in the ActionButton

ngraham added a comment. I thought the smaller sizes now were intentional? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23941 To: jbbgameich, mart, #kirigami Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein

Re: New Plasma Desktop website

Hi, I don't think that removing the two first images is a good idea. The second image is used to link to the latest announcement and if I only remove the first image, the user when landing on the page will not see a screenshot of Plasma without scrolling. I now changed the Plasma wallpaper

D23520: Add time line to X axis

alexde updated this revision to Diff 66055. alexde added a comment. Fix typo in variable and by that make all X axis labels appear again. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66044=66055 BRANCH energy-timeline (branched from

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Oh another thing: now the window size doesn't get remembered across launches, which is super annoying due to the excessively small default size (worth fixing here IMO) that results in the sidebar taking up like 40% of the view. REPOSITORY R118 Plasma SDK REVISION

D23712: [Cuttlefish] Overhaul program, use Kirigami

GB_2 added inline comments. INLINE COMMENTS > Tools.qml:108 > +QQC2.Label { > +text: i18n("Colorscheme:") > } "Color scheme" REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2, trickyricky26,

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66092. cblack added a comment. Wrap text, add custom message handler to get rid of Qt SVG renderer spam REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66089=66092 BRANCH modernization (branched from

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66093. cblack added a comment. Clean up commented code, colorscheme -> color scheme REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66092=66093 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66070. cblack added a comment. Add global menu bar for users with a global menu bar. REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66064=66070 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Whoa, I just noticed someehing really weird happening: when I click on any of the comboboxes in the toolbar, the whole UI now darkens except for the combobox's popup. This effect isn't done anywhere else and should be removed. REPOSITORY R118 Plasma SDK REVISION

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack added a comment. In D23712#531076 , @ngraham wrote: > Ctrl+Q still doesn't work. QML shortcut type seems to not be firing regardless of where it's placed in the program. REPOSITORY R118 Plasma SDK REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Sweet, once the Ctrl+Q shortcut is fixed (Maybe that's an upstream issue too?), the UI will get a thumbs-up from me! REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2, trickyricky26, davidre,

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Definitely should be fixed upstream. Feel free to send a patch for that! REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham,

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Awesome, so close! We're just at little nitpick territory now. INLINE COMMENTS > IconGridDelegate.qml:69 > > -PlasmaComponents.Label { > +QQC2.Label { > font.pointSize: iconSize > 96 ? theme.defaultFont.pointSize : > theme.smallestFont.pointSize

D6764: Use a smaller font size for digital clock plasmoid

guoyunhe added a comment. I think we can make another applet called Small Digital Clock, which can be an alternative of Digital Clock. Just like we have different alternatives for launcher and task bar. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6764

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Either use a ToolButton for the filter feature, or turn "Scan for duplicate fonts" into a PushButton, so they match one way or another. REPOSITORY R119 Plasma Desktop

D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY See M144 and T10047 . This

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66088. cblack added a comment. Shortcut fixemups REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66087=66088 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66089. cblack added a comment. Add a space REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66088=66089 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe added a comment. I changed it to QToolButton, but it still look different: F7352361: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe, #plasma, ngraham Cc: ngraham, plasma-devel,

D23868: kfontinst HiDPI icons

guoyunhe updated this revision to Diff 66074. guoyunhe added a comment. Change icon name. To match patch D23942 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=65841=66074 BRANCH master REVISION

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66087. cblack added a comment. Begone, modality and hello remembering sizes REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66070=66087 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack added a comment. In D23712#531391 , @ngraham wrote: > Whoa, I just noticed someehing really weird happening: when I click on any of the comboboxes in the toolbar, the whole UI now darkens except for the combobox's popup. This effect

D23712: [Cuttlefish] Overhaul program, use Kirigami

GB_2 added inline comments. INLINE COMMENTS > Preview.qml:82 > > -Item { height: units.gridUnit / 2 } > - > -PlasmaExtras.Heading { > -level: 3 > -elide: Text.ElideRight > +Kirigami.Heading { > +level: 1 Maybe add `wrapMode:

D23520: Add time line to X axis

meven added inline comments. INLINE COMMENTS > Graph.qml:165 > + > +if (xTicksAt == xTicksAtTwelveOClock) { > +diff = ((hours - 12) * 60 * 60 + minutes * 60 + seconds) * 1000 > // ms A switch statement should be clearer here. REPOSITORY R102 KInfoCenter REVISION DETAIL