KDE CI: Plasma » plasma-browser-integration » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/kf5-qt5%20FreeBSDQt5.13/77/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Sep 2019 08:38:27 + Build duration: 6 min 48 sec and counting CONSOLE OUTPUT

D23853: Add api urls into the information sheet

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:876324b565cc: Add api urls into the information sheet (authored by dkardarakos). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23853?vs=65797=66367

D23578: Before requesting a scan, check the time threshold

jgrulich added inline comments. INLINE COMMENTS > jgrulich wrote in main.qml:77 > I wonder whether the timer in the applet itself should be running if we fail > to scan, I think it should be stopped when we fail and resumed again when a > successful scan was done. If I do get it correctly and

D23843: Add template for Kirigami application development

This revision was automatically updated to reflect the committed changes. Closed by commit R169:150acfd8820b: Add template for Kirigami application development (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23843?vs=65786=66366

D23151: Implement Web Share API through Purpose

This revision was automatically updated to reflect the committed changes. Closed by commit R856:9c16dbae9f6c: Implement Web Share API through Purpose (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23151?vs=66236=66363

D23712: [Cuttlefish] Overhaul program, use Kirigami

ndavis accepted this revision. ndavis added a comment. It would be nice to have this in the stable release. REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham, ndavis Cc: GB_2,

KDE CI: Plasma » plasma-browser-integration » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Sep 2019 08:34:12 + Build duration: 4 min 11 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-browser-integration » kf5-qt5 SUSEQt5.12 - Build # 166 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/kf5-qt5%20SUSEQt5.12/166/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Sep 2019 08:34:12 + Build duration: 3 min 39 sec and counting CONSOLE OUTPUT

D23980: [Folder View] Don't explicitly initialize fontMetrics

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eb9c5f32edbc: [Folder View] Dont explicitly initialize fontMetrics (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-browser-integration » kf5-qt5 SUSEQt5.12 - Build # 167 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/kf5-qt5%20SUSEQt5.12/167/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Sep 2019 08:37:53 + Build duration: 2 min 50 sec and counting CONSOLE OUTPUT

D24049: add tooltips to the intro page

tienisto updated this revision to Diff 66376. tienisto added a comment. remove unnecessary brackets in onEntered and onExited REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24049?vs=66374=66376 BRANCH intropage-tooltips (branched from master)

D24049: add tooltips to the intro page

tienisto created this revision. tienisto added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tienisto requested review of this revision. REVISION SUMMARY Add tooltips to the most used settings in the intro page TEST PLAN Move your cursor on one of

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack added inline comments. INLINE COMMENTS > ngraham wrote in Menu.qml:33 > Add icon Seems to be a bug with the Qt.labs module, but this menu is just an extra (that's why it's loaded by a Loader instead of instantiated directly) so I wouldn't worry about it too much. > ngraham wrote in

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66373. cblack added a comment. Add copyright to files that I touched a lot REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66353=66373 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

ognarb accepted this revision. ognarb added a comment. It's a huge improvement. You shouldn't forget to add your copyright to some files. REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg,

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Shipit! REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham, ndavis, ognarb Cc: ognarb, GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham,

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 361 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/361/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Sep 2019 13:29:05 + Build duration: 6 min 45 sec and counting CONSOLE OUTPUT [...truncated 2037

D24054: Set default visibility for per-process network sensors to true

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Following from the same idea, do we want a weight? REPOSITORY R106 KSysguard BRANCH default_visibility REVISION DETAIL https://phabricator.kde.org/D24054 To:

D24049: add tooltips to the intro page

tienisto updated this revision to Diff 66387. tienisto added a comment. using enums (ToolTipPosition) instead of booleans REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24049?vs=66376=66387 BRANCH intropage-tooltips (branched from master)

D24011: Provide a telemetrics kcm module for Plasma

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. So this needs UI changes to be shippable: 1. Don't ever use frames in QML, they look terrible. 2. Make the layout more like this:

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 166 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/166/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Sep 2019 13:29:05 + Build duration: 8 min 15 sec and counting CONSOLE OUTPUT [...truncated

D24049: add tooltips to the intro page

ngraham added a comment. In general +1 INLINE COMMENTS > SidebarMode.cpp:581 > > +d->toolTipManager = new ToolTipManager(d->searchModel, d->quickWidget, > false); > +d->subCategoryToolTipManager = new ToolTipManager(d->subCategoryModel, > d->quickWidget, false); Is there a

D24053: Properly handle ProcessAttribute enabled and default visibility

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R111 KSysguard Library BRANCH plugin_enable REVISION DETAIL https://phabricator.kde.org/D24053 To: ahiemstra, #plasma, davidedmundson Cc:

D24049: add tooltips to the intro page

This revision was automatically updated to reflect the committed changes. Closed by commit R124:559444be5f2e: add tooltips to the intro page (authored by tienisto, committed by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D24053: Properly handle ProcessAttribute enabled and default visibility

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Rather than enabling them always, use column and application visibility to determnine if

D24054: Set default visibility for per-process network sensors to true

ahiemstra created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Since it is a nice feature that provides useful information and should not be hidden. Depends D24053

D24049: add tooltips to the intro page

tienisto added inline comments. INLINE COMMENTS > ngraham wrote in SidebarMode.cpp:581 > Is there a strong reason to move these around? I want to have all the initializations of tooltip managers in one place. I couldn't add the third manager there because the placeHolderWidget is not

D24011: Provide a telemetrics kcm module for Plasma

ngraham added a comment. Additionally: - Make the KCM visible in System Settings, I would say as a new top-level category under Personalization - Make the name/title match between the .desktop file and the KAboutData - Make the comment/description match between the .desktop file and

D24036: Fix the last fix of the max y-range computation

This revision was automatically updated to reflect the committed changes. Closed by commit R102:c177c39ef878: Fix the last fix of the max y-range computation (authored by alexde, committed by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#532568 , @zzag wrote: > @jfranklin Ping me if you don't get any feedback in a day or two. Hey there @zzag, haven't seen any activity here. Just pinging you per your request. Thanks! REPOSITORY

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

ngraham added a comment. Thanks so much for the patch, Jason! Feel free to keep on submitting more if you encounter any further issues. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag, romangg Cc: ngraham, romangg,

D23783: [kcm] Fix i18n output file name and split texts

aspotashev added subscribers: ltoscano, aspotashev. aspotashev added a comment. @ltoscano The plus sign does not work. This string: text: i18n("Are you sure you want to disable all outputs? " + "This might render the device unusable.") is extracted like `Are you

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

This revision was automatically updated to reflect the committed changes. Closed by commit R133:90add6922411: Do not allow the greeter to send the same password multiple times (Fix GPG… (authored by jfranklin, committed by ngraham). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

D24068: docs: add contributing guide

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This adds a document providing information on how to contribute to KScreen. It includes

D24037: Add enforced mode size getter

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:293cb32c737a: Add enforced mode size getter (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#534126 , @romangg wrote: > Thanks for the patch Jason. So the `GSendStr(nullptr)` is called on `m_password.isNull()` because this aborts the current PAM session? If this is correct, patch looks good to me.

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

romangg added a comment. Ok, you need this for 5.17? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf,

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

ngraham added a comment. +1. Do you wanna commit this, or should I? @jfranklin can we use `Jason Franklin ` as your email address for the git authorship information? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma,

D23342: Add a per-process network information plugin

bcooksley added a comment. Please see https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/10/console This has now caused Dependency Builds to fail, which means CI for Plasma is now unmaintainable. Could we please get this fixed? REPOSITORY R106 KSysguard

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

hpereiradacosta added a comment. Problem with the new design if you ask me is that it does not convey the information that you can roll around past the maximum as in a circle anymore. All other widget styles (except now breeze), use a circle metaphor for a dial ... Personally I think the

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Or let's just get it in. It's a small change and we still have the beta phase to test it. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To:

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#534154 , @romangg wrote: > Or let's just get it in. It's a small change and we still have the beta phase to test it. Fantastic. Yep, sooner is better in our case. REPOSITORY R133 KScreenLocker

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

hpereiradacosta added a comment. on the other hand, after checking that the dials keep the old appearance when "wrapping" is turned on, and since dials are rather seldom used anyway, I have no strong feeling against the change (still prefer the old look though) REPOSITORY R31 Breeze

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#534169 , @ngraham wrote: > +1. Do you wanna commit this, or should I? Are you referring to me? I assume not, just making sure... > @jfranklin can we use `Jason Franklin ` as your email address

D24038: Improve output enablement recovery and config write

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:936d28ce8fca: Improve output enablement recovery and config write (authored by romangg). REPOSITORY R104 KScreen

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

romangg added a comment. Thanks for the patch Jason. So the `GSendStr(nullptr)` is called on `m_password.isNull()` because this aborts the current PAM session? If this is correct, patch looks good to me. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

zzag added a comment. In D23849#534126 , @romangg wrote: > Thanks for the patch Jason. So the `GSendStr(nullptr)` is called on `m_password.isNull()` because this aborts the current PAM session? If this is correct, patch looks good to me.

D23712: [Cuttlefish] Overhaul program, use Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R118:727fd286bca4: [Cuttlefish] Overhaul program, use Kirigami (authored by cblack). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66373=66409 REVISION

D24063: applets/kicker: Remove unused commands from Messages.sh

aspotashev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aspotashev requested review of this revision. REVISION SUMMARY "find . -name \*.rc -o -name \*.ui -o -name \*.kcfg" returns 0 files. TEST PLAN Run extract-messages.sh, compare the

D24068: docs: add contributing guide

romangg updated this revision to Diff 66422. romangg added a comment. - Add period - Change or to and REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=66421=66422 BRANCH contributingGuide REVISION DETAIL https://phabricator.kde.org/D24068

D24068: docs: add contributing guide

romangg updated this revision to Diff 66424. romangg added a comment. - Grammar fix REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=66422=66424 BRANCH contributingGuide REVISION DETAIL https://phabricator.kde.org/D24068 AFFECTED FILES

D24068: docs: add contributing guide

romangg added a comment. In D24068#534280 , @ngraham wrote: > Is this Conventional Commits spec something we think we want to use elsewhere? I'm sure I can get used to it, but the prefix thing seems kind of rigid and I'm wondering what it

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

davidedmundson added a comment. belated +1 REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag, romangg Cc: davidedmundson, ngraham, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 167 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/167/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Sep 2019 15:12:27 + Build duration: 8 hr 41 min and counting JUnit Tests Name: projectroot

D24068: docs: add contributing guide

ngraham added a comment. Is this Conventional Commits spec something we think we want to use elsewhere? I'm sure I can get used to it, but the prefix thing seems kind of rigid and I'm wondering what it really adds other than a bunch of process that will need to be explained over and over

KDE CI: Plasma » ksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Sep 2019 03:25:17 + Build duration: 9 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » ksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Sep 2019 20:52:03 + Build duration: 5 hr 56 min and counting CONSOLE OUTPUT

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. @aspotashev: please read the discussion in this review request... REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23783 To: romangg, #plasma, victorr, yurchor Cc: aspotashev, ltoscano, zzag, pino, plasma-devel, LeGast00n, The-Feren-OS-Dev,

KDE CI: Plasma » plasma-browser-integration » kf5-qt5 SUSEQt5.12 - Build # 168 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/kf5-qt5%20SUSEQt5.12/168/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Sep 2019 01:16:43 + Build duration: 6 min 4 sec and counting JUnit Tests

D24068: docs: add contributing guide

ngraham added a comment. In terms of changelogs, you can already use the FEATURE: and CHANGELOG: tags in your commit message. That's already there and similarly we're not actually using it. Might it make sense to develop better documentation around using those throughout all of KDE?