KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 417 - Failure!

2019-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/417/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 04 Oct 2019 08:45:59 + Build duration: 58 sec and counting CONSOLE OUTPUT [...truncated 127

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 128 - Failure!

2019-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/128/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 04 Oct 2019 08:45:59 + Build duration: 15 min and counting CONSOLE OUTPUT

D13881: oxygen-demo : add KMessage preview

2019-10-04 Thread René J . V . Bertin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R113:d299d6ebc195: add KMessage preview to the demo (authored by rjvbb). CHANGED PRIOR TO COMMIT

D24393: Switch from naked KConfig to KConfigXT

2019-10-04 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R119:6648a1a476a8: Switch from naked KConfig to KConfigXT (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24393?vs=67269=67307 REVISION

D24391: Silence warnings (noops + unused capture variable)

2019-10-04 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R119:9b3f36009fba: Silence warnings (noops + unused capture variable) (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24391?vs=67267=67305

D24392: Turn the config into the single source of truth

2019-10-04 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4c694f9752f3: Turn the config into the single source of truth (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24392?vs=67302=67306

D24394: Expose the settings object to QML

2019-10-04 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R119:bb2b300addfb: Expose the settings object to QML (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24394?vs=67303=67308 REVISION DETAIL

D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-04 Thread Yunhe Guo
guoyunhe added subscribers: ngraham, aacid. guoyunhe added a comment. In D24409#541894 , @davidedmundson wrote: > Ship it (if and only if the other patch is also accepted) The other patch is accepted by @ngraham . But @aacid has

D24379: [energy kcm] Fix Technology values

2019-10-04 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R102:b5a061ee9a14: [energy kcm] Fix Technology values (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24379?vs=67261=67312 REVISION DETAIL

D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-04 Thread David Edmundson
davidedmundson added a comment. Ship it (if and only if the other patch is also accepted) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24409 To: guoyunhe, #plasma_workspaces Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24379: [energy kcm] Fix Technology values

2019-10-04 Thread Méven Car
meven added inline comments. INLINE COMMENTS > batterymodel.cpp:31 > { > -qmlRegisterType(); > + > qmlRegisterUncreatableType("org.kde.kinfocenter.energy.private", > 1, 0, "Battery", > +QStringLiteral("Use Solid::Battery")); Used this nice documentation to choose the right

D24379: [energy kcm] Fix Technology values

2019-10-04 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. already a million times better REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D24379 To: meven, ngraham, ltoscano,

D24363: Fix several build system errors

2019-10-04 Thread Alexey Min
This revision was automatically updated to reflect the committed changes. Closed by commit R858:731b85008c21: Fix several build system errors (authored by alexeymin). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D24394: Expose the settings object to QML

2019-10-04 Thread Kevin Ottens
ervin added inline comments. INLINE COMMENTS > mart wrote in kcm.h:47 > generic api musings: > could this be upstreamed into ConfigModule directly? (since can't be a > virtual, a protected setter?) Yes, I got something like that in mind down the line. It's a bit early though, I'd like to see

D24394: Expose the settings object to QML

2019-10-04 Thread Kevin Ottens
ervin updated this revision to Diff 67303. ervin added a comment. Add missing copyright header change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24394?vs=67270=67303 REVISION DETAIL https://phabricator.kde.org/D24394 AFFECTED FILES

D24392: Turn the config into the single source of truth

2019-10-04 Thread Kevin Ottens
ervin updated this revision to Diff 67302. ervin added a comment. Add missing copyright header change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24392?vs=67268=67302 REVISION DETAIL https://phabricator.kde.org/D24392 AFFECTED FILES

D24394: Expose the settings object to QML

2019-10-04 Thread Kevin Ottens
ervin added a comment. Yes, I got something like that in mind for future commits. I need to first add a few things in KConfig though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24394 To: ervin, #plasma, mart Cc: plasma-devel, LeGast00n,

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 429 - Still Failing!

2019-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/429/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 05 Oct 2019 03:23:34 + Build duration: 4 min 12 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 167 - Unstable!

2019-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/167/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 05 Oct 2019 03:23:34 + Build duration: 4 min 28 sec and counting JUnit Tests Name:

D14830: Add "Configure Displays" context menu entry on the desktop

2019-10-04 Thread Björn Feber
GB_2 added a comment. Is there a reason this got abandoned? :/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14830 To: broulik, #plasma, #vdg, fischbach, harmathy, davidedmundson Cc: GB_2, gregormi, mart, davidedmundson, abetts, romangg, fabianr, ngraham,

D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-04 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY See also D24384 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D23378: Check if sddm user exists

2019-10-04 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R123:85055a98133e: Check if sddm user exists (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23378?vs=66544=67326 REVISION

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-04 Thread Nathaniel Graham
ngraham added a comment. In D24223#542008 , @enriqueme wrote: > Hi, I am a developer of LliureX project (www.lliurex.net sorry, not in english) a Linux distribution used by public schools at Valencia, Spain (aprox 120k computers). This year we

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 418 - Still Failing!

2019-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/418/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 04 Oct 2019 14:01:50 + Build duration: 3 min 50 sec and counting CONSOLE OUTPUT

D24414: No need to keep ibus 1.4.* compatibility anymore

2019-10-04 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 67325. apol added a comment. Remove unneeded if REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24414?vs=67323=67325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24414 AFFECTED FILES

D24414: No need to keep ibus 1.4.* compatibility anymore

2019-10-04 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY 1.5 was first released in July 2014, I don't see why keep it around. TEST PLAN Still builds REPOSITORY

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-04 Thread Enrique Medina Gremaldos
enriqueme added a comment. Hi, I am a developer of LliureX project (www.lliurex.net sorry, not in english) a Linux distribution used by public schools at Valencia, Spain (aprox 120k computers). This year we moved from Gnome to Kde! Ok, back to the topic, we have developed a wizard in

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 129 - Still Failing!

2019-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/129/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 04 Oct 2019 14:01:50 + Build duration: 39 sec and counting CONSOLE OUTPUT

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-04 Thread Nathaniel Graham
ngraham added a comment. Well this isn't a wizard, it's just in the LNF/Global Theme KCM, so it's not going to be very in-your-face. I can understand the concerns. However right now we do have a problem insofar as it's quite difficult for users to figure out how to change the layout

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-04 Thread Marco Martin
mart added a comment. also, some bits of history: kde2 had something along the lines in a startup wizard which could chose kde, windows, macos and irrc solaris (which was still a thing back then) in the end, was deemed to be a bad idea both the startup wizard and those other platform

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-04 Thread Nathaniel Graham
ngraham added a comment. In D24223#541957 , @mart wrote: > I'm actually not keen on the concept at all, about shipping what can only be badly done copycats of other platforms in lnf (or a separed layouts kcm.. which would be a big mistake doing

D24407: Increase UI commonality between KCM and applet

2019-10-04 Thread Nathaniel Graham
ngraham added subscribers: GB_2, ndavis. ngraham added a comment. In D24407#541824 , @mmustac wrote: > Not related to this patch, but... > While looking at these screenshots I find it not self-explaining but more confusing that both buttons

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-04 Thread Marco Martin
mart added a comment. I'm actually not keen on the concept at all, about shipping what can only be badly done copycats of other platforms in lnf (or a separed layouts kcm.. which would be a big mistake doing at all) this i think.. can only scream an impression of bad quality REPOSITORY

D24408: Use the right icon depending on the layout

2019-10-04 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R119:f9fef4eb5c8f: Use the right icon depending on the layout (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24408?vs=67296=67322 REVISION

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

2019-10-04 Thread Björn Feber
GB_2 added a comment. Relevant: https://bugs.kde.org/show_bug.cgi?id=351647 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma, mart, ngraham Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,