D24804: Fix regression in mobile wifi kcm

meven accepted this revision. meven added a comment. I wish I had caught this, thanks @nicolasfella REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24804 To: nicolasfella, meven, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24373: [KCM] Limit scale factor increment to 6.25% on X11

cullmann added a comment. On Wayland one seems to always scale up to the next full factor (e.g. 2) and then scale down the rendered stuff via gl to the selected factor (e.g 1.5). That leads to other issues but doesn't let rounding stuff creep into the rendering via Qt. For non IEEE

D24810: Ensure defintion of XDG_DATA_DIRS

tcberner created this revision. tcberner added reviewers: FreeBSD, dfaure, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcberner requested review of this revision. REVISION SUMMARY Similar to XDG_DATA_DIRS defaulting to KDE_INSTALL_FULL_DATAROOTDIR, and some

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6b4295b313af: [applets/taskmanager] Revert forceStripes checkbox string change (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68382. jgrulich added a comment. - Improvements based on review comments REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68218=68382 BRANCH new-app-dialog REVISION

D24804: Fix regression in mobile wifi kcm

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:fefb9ef507ef: Fix regression in mobile wifi kcm (authored by nicolasfella). REPOSITORY R116 Plasma Network

D24808: [mobile/wifi] Group networks by connection state

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH groups REVISION DETAIL

D24804: Fix regression in mobile wifi kcm

nicolasfella added inline comments. INLINE COMMENTS > meven wrote in main.qml:30 > PlasmNM.Handler must be kept, (used line 56) oops, fixed REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24804 To: nicolasfella, meven, jgrulich Cc:

D24808: [mobile/wifi] Group networks by connection state

jgrulich added inline comments. INLINE COMMENTS > main.qml:89 > > -header: Kirigami.ListSectionHeader { > -text: mobileProxyModel.showSavedMode ? i18n("Saved networks") : > i18n("Available networks") > +section.property: "ConnectionState" > +

D24732: Rewrite AppChooser dialog

ngraham added a comment. So close! You don't need to create a `Rectangle` to give the ScrollView a white background; just set `Component.onCompleted: background.visible = true` on the scrollview itself. Here's an example of how it's done in the Notifications KCM:

D24804: Fix regression in mobile wifi kcm

nicolasfella created this revision. nicolasfella added a reviewer: meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY D23578

D24810: Ensure defintion of XDG_DATA_DIRS

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Bug in the commit log: s/ also make XDG_DATA_DIRS/ also make XDG_CONFIG_DIRS/ INLINE COMMENTS > startplasma.cpp:195 > } > + // Additionally also set default value for

D24804: Fix regression in mobile wifi kcm

meven added inline comments. INLINE COMMENTS > main.qml:30 > > -PlasmaNM.Handler { > -id: handler PlasmNM.Handler must be kept, (used line 56) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24804 To: nicolasfella, meven,

D24009: RFC: Make Breeze Dark darker

filipf abandoned this revision. filipf added a comment. Gonna leave all color scheme updates to @ndavis and @cblack who have been working on a new palette for Breeze etc. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24009 To: filipf, cblack, ndavis, #vdg, ngraham,

D24798: Migrate QQC1 to QQC2

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. ++. The new table in the clock settings is much nicer anyway. :) See the following inline comments: INLINE COMMENTS > configTimeZones.qml:22 > import QtQuick 2.0 > -import

D24785: Store stashed model index as QPersistentModelIndex

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes a lot of sense. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D24785 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel,

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently it's a text box that doesn't give you any indication of what the units are.

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#550902 , @ngraham wrote: > So close! You don't need to create a `Rectangle` to give the ScrollView a white background; just set `Component.onCompleted: background.visible = true` on the scrollview itself.

D24814: [KCMs] Make spinboxes editable

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Otherwise they're annoying to use because you can only interact with them using a scroll

D24786: [GTK3] Add styles for libhandy widgets

ngraham added a comment. I don't see the harm. We can always adjust it later. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24786 To: cblack, #breeze, #vdg Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24816: [Applet] Make spinboxes editable

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Otherwise you can't enter numbers in them and it's really annoying TEST PLAN Now you can

D24815: [Weather] Make update time spinbox editable

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN Now you can enter text in it using the keyboard. To make this more predictible, the custom

D24720: [applets/systemtray] Rewrite popups with layouts

filipf added a comment. In D24720#550200 , @ngraham wrote: > Seems like the RTL problem may be that your RowLayouts that are within the parent ColumnLayout don't have `Layout.fillWidth: true` set. Does the problem go away if you set that?

D24798: Migrate QQC1 to QQC2

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change. REPOSITORY

D24265: support global edit mode

GB_2 added a comment. In D24265#549640 , @mart wrote: > i would prefer not to, but can be tried with eventually in the future Ok, we can do that in another patch. This is fine once you address my inline comment "Not done." and fix this:

D24373: [KCM] Limit scale factor increment to 6.25% on X11

MayeulC added a comment. @cullmann from what I understand, it is related to what you wrote in https://cullmann.io/posts/kde-qt-highdpi-scaling/ ? How is it only related to X11? Just a small note: we will probably see some platform that do not use IEEE 754 floating points appear in