D24996: Create directory when saving the menu file

wbauer added a comment. Alternatively, the directory could also be created in `TreeView::TreeView()`, but I think this place is more logical (and it would also work if `MenuFile` would be used in other places as well). REPOSITORY R103 KMenu Editor REVISION DETAIL

D24997: [Lock Screen] Don't use black shadows with black text

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY BUG: 413537 FIXED-IN: 5.17.2 REPOSITORY R120 Plasma Workspace BRANCH black-text-no-black-shadow (branched from master)

D24996: Create directory when saving the menu file

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks for the fix! REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D24996 To: wbauer, dfaure Cc: dfaure, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24998: Fix ksysguard acpi cooling devices

jjorge created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jjorge requested review of this revision. REVISION SUMMARY The cooling devices state never changed from zero. It was wrongly calculated as a fraction from 0 to 1, instead of a percentage.

D24986: [wallpapers/image] Randomise new batches of images in the slideshow

davidre added a comment. To clarify my comment refers to > The logic is fine but if we start with 0 wallpapers and then add 20 newones we don't shuffle anything. For the other cases shuffling the added images is probably the right thing REPOSITORY R120 Plasma Workspace BRANCH

D24996: Create directory when saving the menu file

wbauer created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. wbauer requested review of this revision. REVISION SUMMARY Commit 0bf70655 ported kmenuedit away from

D24998: Fix ksysguard acpi cooling devices

jjorge added a comment. How to test : just add an ACPI cooling device to ksysguard, it would always show 0% before this patch. To find one cooling device that actually changes, you can use the 'acpi -V' command REPOSITORY R106 KSysguard REVISION DETAIL

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin added a comment. Good start, there's one case still missing... which looks hard to reach, I wonder how to get there. INLINE COMMENTS > ComboBox.qml:92 > if (indexUnderMouse > -1) { > controlRoot.currentIndex = indexUnderMouse; >

D24997: [Lock Screen] Don't use black shadows with black text

broulik added inline comments. INLINE COMMENTS > LockScreenUi.qml:37 > readonly property bool softwareRendering: GraphicsInfo.api === > GraphicsInfo.Software > +readonly property bool lightBackground: > Math.max(PlasmaCore.ColorScope.backgroundColor.r, >

D24997: [Lock Screen] Don't use black shadows with black text

filipf added inline comments. INLINE COMMENTS > broulik wrote in LockScreenUi.qml:37 > Would it make more sense to use `hsvValue` or `hslLightness`? Maybe, I just copy pasted this from the wallpaper fader:

D24996: Create directory when saving the menu file

This revision was automatically updated to reflect the committed changes. Closed by commit R103:d7dbd84e96b8: Create directory when saving the menu file (authored by wbauer). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24996?vs=68865=68869 REVISION

D24997: [Lock Screen] Don't use black shadows with black text

filipf updated this revision to Diff 68868. filipf added a comment. also apply the same fix to the login screen REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24997?vs=68867=68868 BRANCH black-text-no-black-shadow (branched from master)

D24986: [wallpapers/image] Randomise new batches of images in the slideshow

davidre added a comment. Are you sure? Shouldn't we be hitting this case: https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/image.cpp#n773 ? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24986 To: davidedmundson, #plasma,

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Binding with combobox index was broken REPOSITORY R858 Qt Quick Controls 2:

D25002: disable bug report when there are signs of an update

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this actually improves UX more than anything. when there was an update it is fairly impossible to

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 90 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/90/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 28 Oct 2019 10:56:15 + Build duration: 2 min 53 sec and counting JUnit Tests Name:

D24893: [Lock Screen] Add option to hide clock when idle

mart added a comment. Instead of explicitly talking about clockwhat about a "Only show wallpaper when idle?" REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24893 To: broulik, #plasma, #vdg, ngraham Cc: mart, davidedmundson, ngraham, plasma-devel,

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 237 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/237/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Oct 2019 10:56:15 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 0

Monday meeting notes for 28/10/2019

Kai Uwe * Looked into extending the plasma-browser-integration "audio focus prevention circumention" * Need to revisit / rethink that from scratch * Fixed startplasma not running kapplymousetheme properly * Manjaro complained that mouse cursor in window title bar was not set correctly

D24985: [wallpapers/image] Seed random number generator

apol added a comment. Let's use KCoreAddons/KRandom? These things don't happen there. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24985 To: davidedmundson, #plasma, ngraham Cc: apol, anthonyfieroni, plasma-devel, LeGast00n,

D24997: [Lock & Login Screens] Don't use a black shadow with black text

filipf added a comment. Admittedly this doesn't look super fortuate either when the wallpaper is darker: F7677168: image.png But legibility is really poor unless we do something: F7677180: image.png

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

kmaterka added a comment. This is a proper solution to BUG 365105. Can someone review it? Is everything OK with this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks,

D25006: Checking dpi value being empty is not enought

gcraciunescu created this revision. gcraciunescu added a reviewer: filipf. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gcraciunescu requested review of this revision. REVISION SUMMARY We need to make sure the -dpi value is something valid. Right now we can pass

D24997: [Lock & Login Screens] Don't use a black shadow with black text

filipf added a comment. Yeah there is a conceptual issue here we need to look into solving. IMO we should just always have white UI elements and the background dimmed. As for solutions, I've already looked into hardcoding everything as white (+bg dimmed). It's easy to fix the wallpaper

D25004: Fix force font DPI UI logic

gcraciunescu created this revision. gcraciunescu added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gcraciunescu requested review of this revision. REVISION SUMMARY The kcm UI has right now a step size of 24 with a max size of 1000 and a

D24997: [Lock & Login Screens] Don't use a black shadow with black text

ngraham added a comment. I think we have a greater conceptual problem here. If the lock and login screens are able to display arbitrary text colors from the user's color scheme, we will never be rid of these kinds of problems. I see two practical solutions: - Hardcode white as the text

D24997: [Lock & Login Screens] Don't use a black shadow with black text

ngraham accepted this revision. ngraham added a comment. All right let's do this as a targeted fix for 5.17. REPOSITORY R120 Plasma Workspace BRANCH black-text-no-black-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D24997 To: filipf, #plasma, #vdg,

D24998: Fix ksysguard acpi cooling devices

This revision was automatically updated to reflect the committed changes. Closed by commit R106:86def1d13e84: Fix ksysguard acpi cooling devices (authored by jjorge, committed by ngraham). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24998?vs=68871=68895

D25004: Fix force font DPI UI logic

ngraham added a comment. Thanks for the patch! Can you provide your email address so we can land it with the correct authorship information? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25004 To: gcraciunescu, davidedmundson, #plasma Cc: ngraham,

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi added inline comments. INLINE COMMENTS > ervin wrote in ComboBox.qml:92 > What about that one? :-) Yes, this one breaks as well. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D25000 To: crossi, #plasma, ervin, mart, bport, broulik

D25002: disable bug report when there are signs of an update

sitter added inline comments. INLINE COMMENTS > sitter wrote in drkonqibackends.cpp:172 > I suppose, my plan was actually to list the changed files but I've seen > abandoned that idea because it's largely useless information. I'll change it > to a bool. *since abandoned REPOSITORY R871

D25002: disable bug report when there are signs of an update

sitter planned changes to this revision. sitter added inline comments. INLINE COMMENTS > apol wrote in drkonqibackends.cpp:172 > Maybe we don't need to store all of them? I only see it used as "isEmpty()". I suppose, my plan was actually to list the changed files but I've seen abandoned that

D25002: disable bug report when there are signs of an update

apol added inline comments. INLINE COMMENTS > drkonqibackends.cpp:172 > + > +a->m_deletedFiles = deletedPaths; > + Maybe we don't need to store all of them? I only see it used as "isEmpty()". REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D25002 To: sitter,

D25004: Fix force font DPI UI logic

gcraciunescu added a comment. You can use cr...@frugalware.org. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25004 To: gcraciunescu, davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D25004: Fix force font DPI UI logic

ngraham added a comment. Thanks again! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25004 To: gcraciunescu, davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D25006: Checking dpi value being empty is not enought

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > advancedconfig.cpp:193 > > if (!dpiValue.isEmpty()) { > + // minimal possible valid step from Force font DPI setings You can combine both of

D25006: Checking dpi value being empty is not enough

ngraham added a comment. Also this patch's title could use some changes. Please rewrite it in the form of a statement that explains the change or fix, not the problem. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D25006 To: gcraciunescu,

D25004: Fix force font DPI UI logic

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e37f9dba5b77: Fix force font DPI UI logic (authored by gcraciunescu, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24832: Re-add category display to app delegates

KonqiDragon added a comment. Could add the more appropriate icons for categories? I found some Breeze icons that should looks good with category name. Color Schemes: F7679052: 1024px-Breezeicons-categories-32-applications-graphics.svg.png

D25021: fix: use output hashMd5 for control files

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Control files are a relatively new concept and only used by the retention value for now.

D25026: feat(kcm): always use 0.25 slider scale steps

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY The number of sllider ticks is reduced, making the slider more easy to control. Fine-grained

D25027: feat(kcm): zoom preview automatically

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY On output size and position changes reset the relative output position in the overview

D25020: fix: create control files only when needed

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This way the control directory is only created when a control file becomes necessary. In case

D25006: Make sure -dpi value is valid

ngraham added a reviewer: davidedmundson. ngraham accepted this revision. ngraham added a subscriber: davidedmundson. ngraham added a comment. This revision is now accepted and ready to land. @davidedmundson, does this look good to you? REPOSITORY R123 SDDM Configuration Panel (KCM)

D25024: Use the same avatar size in lock, login and logout screens

filipf added a subscriber: davidedmundson. filipf added a comment. @davidedmundson I believe you wrote the code for the the avatar size in the lock and login screens (`property real faceSize: Math.min(width, height - usernameDelegate.height - units.smallSpacing`). Is it alright to

D24068: docs: add contributing guide

romangg updated this revision to Diff 68918. romangg added a comment. Add a minimal readme file REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=68917=68918 BRANCH contributing-guide REVISION DETAIL https://phabricator.kde.org/D24068 AFFECTED

D25006: Make sure -dpi value is valid

filipf accepted this revision. filipf added a comment. Tested the patch and it no longer accepts strings or values under 24. Thanks @gcraciunescu This should be landed on the 5.17 branch, but let's wait and see if @davidedmundson has any additional comments. REPOSITORY R123 SDDM

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jjorge requested review of this revision. REVISION SUMMARY Since kernel 2.6.24 in 2008, the /proc/acpi/battery interface is deprecated. There is for years no updated kernel which wouldn't

D25024: Use the same avatar size in lock, login and logout screens

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 5.17 branch REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25024 To: filipf, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel,

D24068: docs: add contributing guide

romangg updated this revision to Diff 68917. romangg added a comment. Remove scopes common and console. Small areas, do not warrant scope on themselves. If there is a change to one of them just don't use the optional scope. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham created this revision. ngraham added reviewers: Kirigami, mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, if you define `topContent` for your GlobalDrawer, it's added to the

D24994: [GTK3] Revert checkbox recolouring

This revision was automatically updated to reflect the committed changes. Closed by commit R98:b1649126c8c6: [GTK3] Revert checkbox recolouring (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24994?vs=68934=68936 REVISION DETAIL

D25024: Use the same avatar size in lock, login and logout screens

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Currently the avatar in the logout screen is noticeably smaller than the avatar in the lock and logout screens. This patch

KDE CI: Plasma » breeze-gtk » stable-kf5-qt5 FreeBSDQt5.13 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.13/9/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 29 Oct 2019 01:16:17 + Build duration: 37 min and counting

D24997: [Lock & Login Screens] Don't use a black shadow with black text

fvogt added a comment. In D24997#555258 , @ngraham wrote: > I think we have a greater conceptual problem here. If the lock and login screens are able to display arbitrary text colors from the user's color scheme, we will never be rid of these

D25006: Make sure -dpi value is valid

gcraciunescu updated this revision to Diff 68898. gcraciunescu retitled this revision from "Checking dpi value being empty is not enough" to "Make sure -dpi value is valid". gcraciunescu edited the summary of this revision. gcraciunescu added a comment. Addressed changes requested by ngraham.