davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Can you talk me through how this creates a loop?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25222
To: filipf,
davidedmundson added inline comments.
INLINE COMMENTS
> MediaControls.qml:98
> id: albumArt
> Layout.preferredWidth: height
> Layout.fillHeight: true
Aha, because of this!
A change in aspect ratio affects the width, which reloads the image, which
changes
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
After that it seems ok for me
INLINE COMMENTS
> globalaccel.cpp:25
> +kmenueditGroup = KConfigGroup(,
> QStringLiteral("Data_%1").arg(i));
> +if
filipf added a comment.
Yeah you guys are right. I tested this further and still got some binding
loop errors with paintedWidth/Height.
If you have a solution feel free to commandeer the revision to speed things
up, this seems like a very important bugfix.
REPOSITORY
R120 Plasma
