D25362: Don't add and remove player element if it is already in the page

broulik created this revision. broulik added reviewers: Plasma, fvogt, tasossahanidis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the player has genuinely been added to the website as visible

D24070: Don't use toolTipMainText to show info, rather use the second line

broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:72 > +if (powermanagementDisabled) { > +return i18n("Power management is disabled"); > +} This early return still hasn't been addressed. When I keep the screen on I still want to see my remaining

D25362: Don't add and remove player element if it is already in the page

tasossahanidis accepted this revision. tasossahanidis added a comment. This revision is now accepted and ready to land. I can confirm that the Wikipedia player works correctly again, as well as the websites outlined in the test cases (that I have access to) continue to function as expected.

D25362: Don't add and remove player element if it is already in the page

This revision was automatically updated to reflect the committed changes. Closed by commit R856:47a2790188bf: Dont add and remove player element if it is already in the page (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 69910. mthw added a comment. Done REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=69869=69910 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES

KDE CI: Plasma » kmenuedit » kf5-qt5 SUSEQt5.12 - Build # 35 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Nov 2019 10:15:49 + Build duration: 1 min 20 sec and counting CONSOLE OUTPUT [...truncated 327

KDE CI: Plasma » kmenuedit » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 10:15:49 + Build duration: 1 min 17 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kmenuedit » kf5-qt5 SUSEQt5.12 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Nov 2019 11:32:34 + Build duration: 2 min 7 sec and counting JUnit Tests Name: (root) Failed:

D25363: Fix one more buffer overread in ksysguard network helper

maltek created this revision. maltek added reviewers: ahiemstra, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. maltek requested review of this revision. REVISION SUMMARY fix one more bug in the ksysguard network helper found by my fuzzer. REPOSITORY R106

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

davidedmundson added a comment. We have all other scrollbar settings in: breeze -> settings -> scrollbars Which has the added advantage that it won't be shown if it's not supported, for example if you use Fusion. REPOSITORY R119 Plasma Desktop BRANCH

D25086: Port to KGlobalAccel

This revision was automatically updated to reflect the committed changes. Closed by commit R103:507bc58bf3e8: Port to KGlobalAccel (authored by davidre). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69577=69913 REVISION DETAIL

KDE CI: Plasma » kmenuedit » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 11:32:34 + Build duration: 1 min 2 sec and counting

monday meeting notes for 18/11/2019

Kai Uwe: plasma-browser-integration: * Improved error reporting * Startup error message (e.g. "native messaging host not found") is now also shown in popup. Previously only runtime errors (e.g. host crashed) were shown to the user * Merged audio playback issue fix/hack * Did a follow-up

D25363: Fix one more buffer overread in ksysguard network helper

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. I wonder whether this can actually happen, as that header is AFAICT added by the kernel and not from the network. The `Packet` constructor has both `dataLength` and

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.13 - Build # 73 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.13/73/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 10:29:50 + Build duration: 5 min 30 sec and counting CONSOLE OUTPUT

D25363: Fix one more buffer overread in ksysguard network helper

maltek abandoned this revision. maltek added a comment. Indeed, you're right. This bug was just an artifact of my fuzzing harness. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D25363 To: maltek, ahiemstra, fvogt Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

jgrulich added a comment. In D25279#562998 , @ngraham wrote: > Hmm, reading the code more closely, it looks like it should already work. In fact, when I remove all my changes... it does work! I could have sworn that it didn't work before

D25201: Don't set X-Plasma-MainScript for wallpaper plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cf54a3e77395: Dont set X-Plasma-MainScript for wallpaper plugins (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25201?vs=69411=69906

KDE CI: Plasma » kscreenlocker » kf5-qt5 SUSEQt5.12 - Build # 59 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kscreenlocker/job/kf5-qt5%20SUSEQt5.12/59/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Nov 2019 12:32:10 + Build duration: 4 min 20 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » kscreenlocker » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kscreenlocker/job/kf5-qt5%20FreeBSDQt5.13/39/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 12:32:11 + Build duration: 3 min 44 sec and counting JUnit Tests Name:

Software translations

Hello there, I was wondering if Plasma Mobile has an official site for translators to translate their ROM to our respective languages? If so, what is it call? Thank you for answering my question, David Rebolo Magariños

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe added a comment. Another approach is to shorten the texts: F7769821: image.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25354 To: guoyunhe, #plasma Cc: ngraham, plasma-devel, LeGast00n,

D25223: Avoid side effects during menu initialization

This revision was automatically updated to reflect the committed changes. Closed by commit R135:3c78453b: Avoid side effects during menu initialization (authored by kmaterka). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 434 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/434/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 Nov 2019 14:20:10 + Build duration: 48 min and counting JUnit Tests Name: (root) Failed: 0

Re: Plasma 5.17.3

How come Neon User Edition hasn't been updated yet? Are there packaging issues or did you guys just forget to push the packages? On 12/11/2019 13:40, Jonathan Riddell wrote: > Plasma 5.17.3 is now released > https://www.kde.org/announcements/plasma-5.17.3.php >

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe updated this revision to Diff 69922. guoyunhe edited the summary of this revision. guoyunhe added a comment. Shorten POTD provider names and remove descriptions that are never used anywhere. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D25368: connect groupbox toggles to change signal

broulik added a comment. Don't you have to connect to the `QGroupBox` children? Right now you only connect the `QGroupBox` itself (which can be checkable) but not the checkboxes within? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D25368

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY QtQuick Controls 2 ComboBox doesn't handle long option well. Short names can solve the issue of D25354

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

ngraham added a comment. In D25361#563993 , @davidedmundson wrote: > We have all other scrollbar settings in: > > breeze -> settings -> scrollbars > > Which has the added advantage that it won't be shown if it's not supported, for

D25368: connect groupbox toggles to change signal

sitter created this revision. sitter added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. sitter requested review of this revision. REVISION SUMMARY the bridge, ppp, and gsm settings contain

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.13/74/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 14:07:50 + Build duration: 29 min and counting JUnit Tests Name:

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

ngraham added a comment. +1 for simplifying the strings, but keep in mind that any change that alters strings, can't be a bugfix on the stable branch and needs to be master-only. Might be better to only made the code changes on the stable branch, and do the string changes in a separate

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe updated this revision to Diff 69929. guoyunhe added a comment. Move string changes to another patch REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25354?vs=69922=69929 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25354

D25369: Shorten POTD provider names and remove description that is not used anywhere

ngraham added a comment. For changed strings, you don't need to remove the existing translations; just change the English strings. For removed strings, it's fine to remove everything. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25369 To: guoyunhe,

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe updated this revision to Diff 69930. guoyunhe added a comment. Keep old translations REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25369?vs=69928=69930 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25369 AFFECTED FILES

D25369: Shorten POTD provider names and remove description that is not used anywhere

ngraham added a comment. Thanks! Can you add an explanation in the description section of this patch as to why you're removing the Description strings? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25369 To: guoyunhe, #plasma, ngraham Cc: plasma-devel,

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe added a comment. In D25369#564159 , @ngraham wrote: > Thanks! Can you add an explanation in the description section of this patch as to why you're removing the Description strings? Added. REPOSITORY R114 Plasma Addons

D25369: Shorten POTD provider names and remove description that is not used anywhere

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > noaaprovider.json:4 > "Icon": "", > -"Name": "NOAA Environmental Visualization Laboratory Picture of the > Day", > +"Name":

D25369: Shorten POTD provider names and remove description that is not used anywhere

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D25369 To: guoyunhe, #plasma, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe updated this revision to Diff 69931. guoyunhe added a comment. Fix typo REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25369?vs=69930=69931 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25369 AFFECTED FILES

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

ngraham updated this revision to Diff 69933. ngraham added a comment. Improve config file entry namewq REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25361?vs=69900=69933 BRANCH left-click-warps-scrollbar-settings-ui (branched from master)

D25369: Shorten POTD provider names and remove description that is not used anywhere

This revision was automatically updated to reflect the committed changes. Closed by commit R114:58b3995b813d: Shorten POTD provider names and remove description that is not used anywhere (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

ngraham added a comment. In D25361#564176 , @davidedmundson wrote: > Of those links, only the first discusses which kcm to put it in and the suggestion there is the style kcm... Maybe I misunderstood the discussion, sorry. The

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R114:e8402b9a3156: Fix POTD config ComboBox display issue in Lock Screen KCM (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe added a comment. In D25354#564187 , @ngraham wrote: > 5.17 branch please. Not sure if I did it correctly... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25354 To: guoyunhe, #plasma, ngraham

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

ngraham added a comment. Yep, now you just need to merge `Plasma/5.17` into `master. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 for the full set of recommended instructions for landing a change on the stable branch REPOSITORY R114 Plasma

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

davidedmundson added a comment. Of those links, only the first discusses which kcm to put it in and the suggestion there is the style kcm... REPOSITORY R119 Plasma Desktop BRANCH left-click-warps-scrollbar-settings-ui (branched from master) REVISION DETAIL

D25368: connect groupbox toggles to change signal

sitter added a comment. @broulik the children are handled by the other connections already (linedit, push button etc.) REPOSITORY R116 Plasma Network Management Applet BRANCH Plasma/5.17 REVISION DETAIL https://phabricator.kde.org/D25368 To: sitter, jgrulich Cc: broulik,

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 5.17 branch please. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D25354 To: guoyunhe, #plasma, ngraham Cc: ngraham, plasma-devel,

D25368: connect groupbox toggles to change signal

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c8775cb198f3: connect groupbox toggles to change signal (authored by sitter). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 114 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/114/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 17:18:00 + Build duration: 2 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 261 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/261/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Nov 2019 17:18:00 + Build duration: 3 min 11 sec and counting CONSOLE OUTPUT [...truncated 505

D25024: Use the same avatar size in lock, login and logout screens

filipf added a comment. @ngraham I can change this patch so only the logout avatar' size is increased and then land that on the 5.17 as there is no risk of breaking anything. I can then change the lock screen as well, but for 5.18. They won't be precisely the same size in 5.17 though.

D25024: Use the same avatar size in lock, login and logout screens

ngraham added a comment. Probably okay to make this master-only IMO. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25024 To: filipf, #plasma, #vdg, ngraham Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#561693 , @ngraham wrote: > It doesn't compile: > > /home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal error: kns3/downloaddialog.h: No such file or directory > 1 |

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This is a fix for D25043 . Using disabledTextColor results in bad text legibility with

D25309: [Notifications KCM] Fix keyboard navigation in apps list

This revision was automatically updated to reflect the committed changes. Closed by commit R119:659fe0a76f19: [Notifications KCM] Fix keyboard navigation in apps list (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25185: Icon: solve threading issue on when the source is http

This revision was automatically updated to reflect the committed changes. Closed by commit R169:5cc8be3cd1fd: Icon: solve threading issue on when the source is http (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69422=69957

D25381: Make QPushButton/QToolButton the same height as QLineEdit

ndavis added a comment. If we do make flat toolbuttons buttons (`autoRaise == true`) and non-flat buttons the same size, we will need to change the default icon size for all buttons to 22px, or we will have a ton of UI regressions. Any non-flat button with a fixed icon size is going to have

D25381: Make QPushButton/QToolButton the same height as QLineEdit

ngraham added a comment. +1 conceptually, this will be nice to finally have fixed. But might the opposite make more sense? If we make buttons shorter, we're slightly reducing their click targets, but if we make line edits taller, all we're doing it reducing unused whitespace.

D25381: Make QPushButton/QToolButton the same height as QLineEdit

GB_2 added a comment. Plus in the screenshot it looks like it's still not quite the same heihgt. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

GB_2 added a comment. In D25381#564370 , @ngraham wrote: > +1 conceptually, this will be nice to finally have fixed. > > But might the opposite make more sense? If we make buttons shorter, we're slightly reducing their click targets, but if

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69945. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of

D24224: Start of the accessibility KCM

tcanabrava added a comment. After squashing the commits to remove the broken history, arc diff opened a new revision. https://phabricator.kde.org/D25375 INLINE COMMENTS > ervin wrote in kcmaccessibilitymouse.kcfg:34 > Wouldn't an Enum be more suited here? This i a spinBox with a range

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. In D25381#564378 , @GB_2 wrote: > Plus in the screenshot it looks like it's still not quite the same height. Yes, still 1px taller :( REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 262 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/262/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Nov 2019 21:58:53 + Build duration: 3 min 5 sec and counting JUnit Tests Name: (root) Failed:

D24224: Start of the accessibility KCM

ngraham added a comment. So... fix it? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava, ngraham, bport, ervin Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. In D25381#564370 , @ngraham wrote: > +1 conceptually, this will be nice to finally have fixed. > > But might the opposite make more sense? If we make buttons shorter, we're slightly reducing their click targets, but

D25375: Start of the accessibility KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This rewrites the Accessibility KCM to use Qml and the new Managed Config classes. REPOSITORY R119 Plasma Desktop

D25375: Start of the accessibility KCM

ngraham added inline comments. INLINE COMMENTS > main.qml:42 > + > +ListView { > +id: listView Needs keyboard navigation. See https://cgit.kde.org/plasma-desktop.git/commit/?id=659fe0a76f19b60021733c4a74e451d4318a8359 for details regarding how. REPOSITORY R119

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Before we port this to Qml we need to simplify the code it's currently monolithycal, and need to be split into at least

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 115 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/115/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 21:58:53 + Build duration: 6 min 2 sec and counting JUnit Tests Name:

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY BUG 411811 REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D25381 AFFECTED FILES

D25385: Use icon name instead of pixmap in notification

nicolasfella updated this revision to Diff 69964. nicolasfella added a comment. - More REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25385?vs=69963=69964 BRANCH noti REVISION DETAIL https://phabricator.kde.org/D25385

D25383: Remove some unused includes

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R97 Bluedevil BRANCH incl REVISION DETAIL

D25385: Use icon name instead of pixmap in notification

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY It's both easier and better TEST PLAN builds

D25384: Remove some unused includes

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R119 Plasma Desktop BRANCH incl REVISION DETAIL