KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 09 Jan 2020 04:54:35 + Build duration: 11 min and counting CONSOLE OUTPUT

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. It might be worth comparing with what other platforms do: - Windows: old apps use real separated always-visible scrollbars; new apps use real overlay scrollbars that overlap content but disappear when not in use - macOS: all apps use real overlay scrollbars

D26525: Fix wallpaper destination path

trmdi updated this revision to Diff 73115. trmdi added a comment. - Improve code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26525?vs=73070=73115 BRANCH fix-wallpaper REVISION DETAIL https://phabricator.kde.org/D26525 AFFECTED FILES

D26530: ScrollView: Do not overlay scrollbars over contents

ndavis added a comment. +1 to not using overlay scrollbars on desktop and mimicking their look instead. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26530 To: ahiemstra, #plasma, #goal_consistency Cc: ndavis, IlyaBizyaev, ngraham,

D26537: [startkde] Drop hack to manually set XDG_DATA_DIRS to the install root

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY For normal distros it doesn't make sense, KDE_INSTALL_FULL_DATAROOTDIR

D26538: Don't anchor AbstractApplicationHeader blindly

apol created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY If we do it, then QtQuick.Layouts complains when it's placed inside because Layouts.fillWidth should be used instead. TEST PLAN

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 09 Jan 2020 04:54:35 + Build duration: 4 min 16 sec and counting CONSOLE OUTPUT

D26533: Add a logging category for the backend

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:14 > TransactionSet.cpp > +libdiscover_backend_debug.cpp > pkui.qrc Why adding it ? it's autogenerated so it's added by

D26489: Use qmlRegisterAnonymousType

meven added inline comments. INLINE COMMENTS > draghelper.cpp:32 > { > -qmlRegisterType("org.kde.milou", 1, 0, "MimeData"); > + qmlRegisterAnonymousType("org.kde.milou", 1); > } indentation REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26489 To: tcanabrava,

D26521: KCM/Component Make the email config default button work

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D26398 REVISION DETAIL https://phabricator.kde.org/D26521

D26523: KCM kded, fix immutability and reset/apply/default button state

bport created this revision. bport added reviewers: ervin, meven, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26523 AFFECTED FILES

Re: Plasma 5.18 repo freeze and announce prep

In case the link doesn't work (like here), scroll down to the "plasma-5_18.md" file in the "ommunity Notes/Plasma" folder... Am 08.01.20 um 16:09 schrieb Jonathan Riddell: 5.18 repo freeze was a while ago, new repos in 5.18 will be plasma-nano and plasma-phone-components.  These two will be

D26523: KCM kded, fix immutability and reset/apply/default button state

ervin added inline comments. INLINE COMMENTS > kcmkded.cpp:319 > + if (_lvStartup->topLevelItem( i )->flags() & Qt::ItemIsEnabled) > { > + _lvStartup->topLevelItem( i )->setCheckState( > StartupUse, Qt::Checked ); > + } I know you didn't write that

D26525: Fix wallpaper destination path

trmdi created this revision. trmdi added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Correct the destination path when downloading images. - Add the `KIO::Overwrite` for the file copy

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73063. meven added a comment. Only once commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73062=73063 BRANCH arcpatch-D26398 REVISION DETAIL https://phabricator.kde.org/D26398 AFFECTED FILES

D26522: [Colors KCM] Only move to next scheme if the selected one is marked for deletion

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY No need to select another scheme if the scheme that is to be removed is not selected. TEST PLAN Mark a scheme other than the

D25449: Start of the new Formats KCM

broulik added inline comments. INLINE COMMENTS > Messages.sh:2 > #! /usr/bin/env bash > -$EXTRACTRC *.ui >> rc.cpp > -$XGETTEXT *.cpp -o $podir/kcmformats.pot > -rm -f rc.cpp > - > +$EXTRACTRC `find . -name "*.qml"` >> rc.qml || exit 11 > +$XGETTEXT `find . -name "*.qml"` -o

D26395: [XembedSNIProxy] Hide container window when something shows it

kmaterka added a comment. What should be in FIXED-IN? AFAIK 5.18 is frozen. Should I commit it into master? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26395 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson Cc: plasma-devel,

D26395: [XembedSNIProxy] Hide container window when something shows it

davidedmundson added a comment. > What should be in FIXED-IN? AFAIK 5.18 is frozen. Should I commit it into master? 5.18 doesn't exist yet, let alone being frozen REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26395 To: kmaterka, #plasma_workspaces,

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

ngraham added a comment. Nice! It seems to have a CMake error though: CMake Error at kcms/kded/CMakeLists.txt:10 (qt5_add_dbus_interface): qt5_add_dbus_interface Function invoked with incorrect arguments for function named: QT5_ADD_DBUS_INTERFACE REPOSITORY R119 Plasma

D26261: Rewrite GTK KCM

gikari updated this revision to Diff 73059. gikari added a comment. Replace dbus signals with dbusinterface calls REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26261?vs=73015=73059 BRANCH set-theme-through-kded REVISION DETAIL

D26261: Rewrite GTK KCM

gikari updated this revision to Diff 73065. gikari added a comment. Simplify GTK3 Preview algorithm Unfortunately this can't be applied to GTK2 :( REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26261?vs=73060=73065 BRANCH

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

ngraham updated this revision to Diff 73067. ngraham marked an inline comment as done. ngraham added a comment. Don't auto-append paths when the paths list is empty REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26483?vs=73023=73067 BRANCH

Plasma 5.18 repo freeze and announce prep

5.18 repo freeze was a while ago, new repos in 5.18 will be plasma-nano and plasma-phone-components. These two will be marked (in some way) as not being LTS. If you have new features which deserve to be highlighted in the announce please add them to this file

D26261: Rewrite GTK KCM

gikari updated this revision to Diff 73060. gikari added a comment. Remove forgotten signal connections REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26261?vs=73059=73060 BRANCH set-theme-through-kded REVISION DETAIL

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73061. tcanabrava added a comment. - Correctly extract qml - Update documentation text - Remove deprecated calls - Correct placement of pointer and reference symbols - Rename variables on kconfigxt and use name and key - Correct constructor

D26395: [XembedSNIProxy] Hide container window when something shows it

This revision was automatically updated to reflect the committed changes. kmaterka marked 3 inline comments as done. Closed by commit R120:69786a1ff947: [XembedSNIProxy] Hide container window when something shows it (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73062. meven marked an inline comment as done. meven added a comment. Add Q_ASSERTs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73056=73062 BRANCH arcpatch-D26398 REVISION DETAIL

D26526: [Colors KCM] Correctly report whether saving is needed

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Previously the kcm always reported that a save is needed once a scheme had been marked for deletion. The correct way is to check

D26261: Rewrite GTK KCM

ngraham accepted this revision. ngraham added a comment. Works great for me. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-theme-through-kded REVISION DETAIL https://phabricator.kde.org/D26261 To: gikari, apol, #vdg, ngraham, cblack Cc: cblack, baberts, ngraham, plasma-devel,

D26395: [XembedSNIProxy] Hide container window when something shows it

kmaterka added a comment. In D26395#590409 , @davidedmundson wrote: > > What should be in FIXED-IN? AFAIK 5.18 is frozen. Should I commit it into master? > > 5.18 doesn't exist yet, let alone being frozen I guess I misunderstood

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

broulik updated this revision to Diff 73085. broulik added a comment. - Minor fixes - Fix Cmake REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26506?vs=73017=73085 REVISION DETAIL https://phabricator.kde.org/D26506 AFFECTED FILES

D26523: KCM kded, fix immutability and reset/apply/default button state

bport added a comment. Wait this code review is merged and will port it to KConfigXT https://phabricator.kde.org/D26506 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26523 To: bport, ervin, meven, crossi Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26514: Delay popup for containments

trmdi updated this revision to Diff 73080. trmdi added a comment. - Sync with the dependency REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26514?vs=73029=73080 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26514 AFFECTED FILES

D26514: Delay popup for containments

trmdi updated this revision to Diff 73081. trmdi added a comment. - Sync with the dependency REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26514?vs=73080=73081 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26514 AFFECTED FILES

D26528: [wallpapers/image] Add placeholder labels when wallpaper lists are empty

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, when there are no configured wallpaper slideshow paths or wallpapers in the

D26111: Runner: make recentdocument use KActivityStats data

meven updated this revision to Diff 73087. meven added a comment. Clean bad referrence REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=73086=73087 BRANCH arcpatch-D26111 REVISION DETAIL https://phabricator.kde.org/D26111 AFFECTED

D26111: Runner: make recentdocument use KActivityStats data

meven updated this revision to Diff 73086. meven added a comment. Instead of adding a runner update the documentrecent one REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=71865=73086 BRANCH arcpatch-D26111 REVISION DETAIL

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

ngraham added a comment. Thanks, much better, now I can test it out. Some initial thoughts: - Overall very nice! I like it. - Making the "Running" and "Not Running" labels colorize themselves and then transition to the normal color when toggles is flashy and cool, but I wonder if

D25941: Add a page to display ActionToolBar and some of its features

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:9f3a617da366: Add a page to display ActionToolBar and some of its features (authored by ahiemstra). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE

D26529: [wallpapers/image] Put spinbox labels inside the spinboxes

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY They look a little nicer this way, and can be localized more easily. TEST PLAN Before:

D26531: [Wallpaper] Show author as subtitle in configuration

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY If we have this feature now, let's use it and give the wallpaper authors the credit they

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

ngraham updated this revision to Diff 73088. ngraham added a comment. Fix the remaining FIXMEs REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=72816=73088 BRANCH arcpatch-D24070 REVISION DETAIL https://phabricator.kde.org/D24070

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

broulik updated this revision to Diff 73089. broulik added a comment. - Filter duplicates REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26506?vs=73085=73089 REVISION DETAIL https://phabricator.kde.org/D26506 AFFECTED FILES CMakeLists.txt

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This ensures the scrollbar of a ScrollView do not overlap the ScrollView's contents. It

D26530: ScrollView: Do not overlay scrollbars over contents

broulik added a comment. I thought back then we explicitly did not want that? Also, how does this behave on mobile, ie. "transient scrollbars"? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26530 To: ahiemstra, #plasma Cc: broulik,

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra added a comment. I think overlay scrollbars just cause more problems than they solve. Basically every application developer needs to account for the scrollbars, rather than just using ScrollView without bothering about it. Additionally, as mentioned, it is inconsistent with all

D26533: Add a logging category for the backend

meven created this revision. meven added reviewers: apol, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY To get rid of tons of logs like : using... PackageKit::Transaction(0x55db7f249ab0)

D26530: ScrollView: Do not overlay scrollbars over contents

broulik added a comment. > every application developer needs to account for the scrollbars Says who? If the standard qqc2 desktop style item delegate and kirigami list delegate take it into account for their padding //reliably// you get 99% covered. > I was assuming mobile was out

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a reviewer: Goal: Consistency. ngraham added a comment. From T9126 , the proposal is to use disappearing overlay scrollbars on mobile, and regular/old fashioned separated non-disappearing scrollbars on the desktop. This is what QWidgets apps

D26531: [Wallpaper] Show author as subtitle in configuration

ngraham added a comment. Might make sense to keep the "By" prefix, yeah. +1! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26531: [Wallpaper] Show author as subtitle in configuration

filipf added a comment. Good idea +1. I think an author's name is enough here since information is displayed in a similar way that songs info is ie. it should be obvious to everyone the second line lists the author. "By" can also be tricky to translate into other languages. In my

D26530: ScrollView: Do not overlay scrollbars over contents

IlyaBizyaev added a comment. Visually, this looks like a step back to me... Do you also envision Konsole using opaque overlay scrollbars again? The current scrollbar appearance is quite common on desktop (Telegram and GNOME apps come to mind), so it's not odd/out-of-place by any means.

D26531: [Wallpaper] Show author as subtitle in configuration

ngraham added a comment. All right, let's do this way then. However I see a problem with the delegate cell size: F7871404: Screenshot_20200108_154900.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To:

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In D26530#590649 , @IlyaBizyaev wrote: > Visually, this looks like a step back to me... Do you also envision Konsole using opaque overlay scrollbars again? Konsole doesn't use overlay style scrollbars; it simply

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In a nutshell: Overlay scroll bars //disappear//. Separated scrollbars //stay visible//. The QQC2 style scrollbars in question stay visible but try to use an overlay style anyway, and to make this work they overlap the scrollview's background but try to avoid

D26515: KCM/Component remove traces of Kdelibs4 migration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bde038c07839: KCM/Component remove traces of Kdelibs4 migration (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26515?vs=73034=73039

D26518: ModuleView: Hide button when KCModule don't need them

bport created this revision. bport added reviewers: ervin, meven, crossi, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D26518

D26398: [KCM/Activities] Use KConfigXT in ui

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. A few changes needed to make the code easier to understand in a few months time. Also there's a larger concern of a piece of code being prone to later bugs (although I'd expect it

D26515: KCM/Component remove traces of Kdelibs4 migration

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Compiles REPOSITORY R119 Plasma Desktop BRANCH clean-component REVISION DETAIL

D26516: [Icon Item] Check URL validity and scheme

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Creating a `KFileItemList` with a `KFileItem` with a URL that doesn't have a scheme triggers an

D26518: ModuleView: Hide button when KCModule don't need them

bport updated this revision to Diff 73043. bport added a comment. Set visibility for help too REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26518?vs=73041=73043 REVISION DETAIL https://phabricator.kde.org/D26518 AFFECTED FILES

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven updated this revision to Diff 73032. meven added a comment. Clean unrelated files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?vs=73031=73032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26478 AFFECTED FILES

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven updated this revision to Diff 73033. meven added a comment. Clean commit history REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?vs=73032=73033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26478 AFFECTED FILES

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 73035. meven added a comment. This revision is now accepted and ready to land. Make icon non-optionnal in Kicker::createActionItem, add a missing icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26386: Kicker/RecentDocuments: add icons to actions

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4dca72bdf59a: Kicker/RecentDocuments: add icons to actions (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=73035=73036

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidre added inline comments. INLINE COMMENTS > image.cpp:366 > if (m_slidePaths.isEmpty()) { > -m_slidePaths << > QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, > QStringLiteral("share/wallpapers"), QStandardPaths::LocateDirectory); > +m_slidePaths <<

D26037: feat(kded): add orientation sensor

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in orientation_sensor.cpp:29 > From what I can tell, we can call > > if (!sensor->connectToBackend()) { > m_available = false; > } > > in the constructor > > and then we have the option to call start/stop whenever. Yea, I

D26518: ModuleView: Hide button when KCModule don't need them

meven added inline comments. INLINE COMMENTS > ModuleView.cpp:398 > +d->mReset->setVisible(buttons & KCModule::Apply); > d->mHelp->setEnabled(buttons & KCModule::Help ); > emit moduleChanged( change ); `d->mHelp->setVisible(buttons & KCModule::Help )` ? REPOSITORY R124 System

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven updated this revision to Diff 73031. meven added a comment. KCM/Component remove traces of Kdelibs4 migration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?vs=72930=73031 BRANCH master REVISION DETAIL

D26389: DesktopPaths KCM: Move the settings logic to a KCoreConfigSkeleton class

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > desktoppathssettings.cpp:38 > +{ > +return QUrl::fromLocalFile(QDir::homePath() + > QStringLiteral("/Desktop")); > +} This doesn't

D26388: Get rid of KGlobalSettings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:29c01adcc4a5: Get rid of KGlobalSettings (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26388?vs=72676=73049 REVISION DETAIL

D26241: Remove Kirigami DelegateRecycler

This revision was automatically updated to reflect the committed changes. Closed by commit R120:56529e7be715: Remove Kirigami DelegateRecycler (authored by ervin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26241?vs=73046=73047 REVISION DETAIL

D26391: DesktopPaths KCM: Remove the moving directory logic

This revision was automatically updated to reflect the committed changes. Closed by commit R119:db1ebdc9090a: DesktopPaths KCM: Remove the moving directory logic (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26391?vs=72679=73052

D26242: Port the translations module to ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R120:34216709c060: Port the translations module to ManagedConfigModule (authored by ervin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26242?vs=72243=73048

D26389: DesktopPaths KCM: Move the settings logic to a KCoreConfigSkeleton class

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ea8009b35011: DesktopPaths KCM: Move the settings logic to a KCoreConfigSkeleton class (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26390: DesktopPaths KCM: Move the view logic in a ui file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f9fb111537f7: DesktopPaths KCM: Move the view logic in a ui file (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26390?vs=72678=73051

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73055. meven marked 2 inline comments as done. meven added a comment. In BlackListModel only acces concerned items isSaveNeeded and isDefault REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73054=73055

D26398: [KCM/Activities] Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > ervin wrote in BlacklistedApplicationsModel.cpp:179 > I personally like that construct, but AFAIK it's rather unusual in KDE code, > so maybe for the sake of the future developer use something more "classic". > Either: > > const auto name =

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 73058. tcanabrava added a comment. - Use QFileDialog to look for audio files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=73057=73058 BRANCH arcpatch-D25375 REVISION DETAIL

D26494: Runner/Windows make the window finding more reliable

meven added a comment. Instead we might want to keep a cache of windows and desktopNames and use KWindowSystem::desktopNamesChanged and windowAdded / windowRemoved signals. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26494 To: meven, #plasma, ngraham,

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73056. meven marked 2 inline comments as done. meven added a comment. Improve signals naming, and remove redundant ones REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73055=73056 BRANCH arcpatch-D26398

D25375: Start of the accessibility KCM

broulik added inline comments. INLINE COMMENTS > kcmaccess.cpp:141 > > -QString result; > -if ((modifiers & ScrollMask) != 0) > -if ((modifiers & LockMask) != 0) > -if ((modifiers & NumMask) != 0) > -result = i18n("Press %1 while NumLock, CapsLock

D26241: Remove Kirigami DelegateRecycler

ervin updated this revision to Diff 73046. ervin added a comment. Fix drag and drop issues after discussing with Marco REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26241?vs=72241=73046 REVISION DETAIL https://phabricator.kde.org/D26241

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73054. meven marked 2 inline comments as done. meven added a comment. Review, code style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72964=73054 BRANCH arcpatch-D26398 REVISION DETAIL

D26398: [KCM/Activities] Use KConfigXT in ui

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > BlacklistedApplicationsModel.cpp:191 > +emit > changed(d->pluginConfig->findItem("blockedApplications")->isSaveNeeded() && >

D26518: ModuleView: Hide button when KCModule don't need them

ervin added inline comments. INLINE COMMENTS > meven wrote in ModuleView.cpp:398 > `d->mHelp->setVisible(buttons & KCModule::Help )` ? Nope, see my comment on the other patch :-) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D26518 To: bport, ervin, meven,

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven planned changes to this revision. meven added a comment. In D26111#589209 , @ivan wrote: > > Why not change the recentdocuments runner? > > Will do REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26518: ModuleView: Hide button when KCModule don't need them

ervin accepted this revision. ervin added a comment. Doesn't quite make sense to both hide and disable, but no big deal. INLINE COMMENTS > ervin wrote in ModuleView.cpp:398 > Nope, see my comment on the other patch :-) Alright, I'll contradict myself, the doc claimed the contrary forever.

D25375: Start of the accessibility KCM

tcanabrava marked an inline comment as done. tcanabrava added a comment. In D25375#575980 , @ervin wrote: > I think we discussed this already, but I'm not sure so before it gets lost... :-) > > Please consider using both key and name for

D25375: Start of the accessibility KCM

tcanabrava marked 4 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:53 > title should already be translated; no need to put this in an `i18n()` call this was a ListElement Q_NOOP_TR issue REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 73057. tcanabrava marked 5 inline comments as done. tcanabrava added a comment. - ListElement does not handle i18n calls, use raw array - Dont complain about null background - Failing on Qt 5.14 - Add Key entries to the kconfigxt generator -