Re: Long press global shortcuts

2020-02-01 Thread Luca Weiss
On Freitag, 24. Jänner 2020 19:07:25 CET Aleix Pol wrote: > On Sun, Jan 12, 2020 at 6:11 PM Aleix Pol wrote: > > Hi, > > In a discussion some weeks ago, we came to the conclusion that it > > would make sense to support long press global shortcuts. > > > > The use-case we discussed back then was

D27093: Provide better name for GTK Settings Sync service

2020-02-01 Thread David Redondo
davidre added a comment. I would drop the KDE/Qt Part because the settings are not specific to them but general settings and this service is needed to apply those settings to some applications. So "Applies Settings to Gnome/GTK applications' REPOSITORY R99 KDE Gtk Configuration Tool

D27085: [SystemTray] Bunch of fixes and improvements in QML

2020-02-01 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Few unrelated fixes, bunched togheter: - move some code from main.qml to PlasmoidItem where it belongs -

D27086: [Applet]Supplementary add port check

2020-02-01 Thread George Vogiatzis
gvgeo created this revision. gvgeo added reviewers: drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Supplementary to the previous commit 2 More ports needs check. The issue is the same, maybe

D26992: [SystemTray] Use unified data model everywhere

2020-02-01 Thread Konrad Materka
kmaterka added a comment. ... and second one: D27088 . It contains model refactoring and sorting. After that two are accepped I will rebase this one. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To:

D27088: [SystemTray] Implement sorting in the model

2020-02-01 Thread Konrad Materka
kmaterka added a comment. Extracted from D26992 to make review easier REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27088 To: kmaterka, #plasma_workspaces, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27093: Provide better name for GTK Settings Sync service

2020-02-01 Thread Mikhail Zolotukhin
gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH good-service-name REVISION DETAIL https://phabricator.kde.org/D27093 AFFECTED FILES

D26992: [SystemTray] Use unified data model everywhere

2020-02-01 Thread Konrad Materka
kmaterka added a comment. First revision: D27085 . In contains some random improvements REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Nathaniel Graham
ngraham added a comment. In D27077#604428 , @cfeck wrote: > But the timeout isn't used to give apps more time needed to clean up before they confirm the session can be closed? If I understand it correctly, there should be two timeouts?

D27088: [SystemTray] Implement sorting in the model

2020-02-01 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Replace two wrapping PlasmaCore.SortFilterModel with custom sorting on model side. Extract common code to base

D27093: Provide better name for GTK Settings Sync service

2020-02-01 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > gtkconfig.json:3 > "KPlugin": { > -"Description": "GTK config management", > +"Description": "Automatically applies KDE/Qt appearance settings to > Gnome/GTK applications", > "Description[ca]": "Gestió de la

D27086: [Applet]Supplementary add port check

2020-02-01 Thread George Vogiatzis
gvgeo added a comment. previous commit is 8f0847af1d17 . REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27086 To: gvgeo, drosca, ngraham Cc: plasma-devel, Orage,

D26891: Upgrade theme to Breeze GTK on startup

2020-02-01 Thread Mikhail Zolotukhin
gikari added a comment. The differences between `gtkrc` and `gtkrc-2.0` at least is that the first one was used for `GTK1` and the second for `GTK2`. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To: gikari, fvogt Cc: ngraham, meven,

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Rik Mills
rikmills added a comment. In D27077#604505 , @broulik wrote: > Having Kickoff confirm shutdown could be superfluous as you already had to go through the trouble of opening it, going to "Leave", but for e.g. the lock logout entry or generic "

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Kai Uwe Broulik
broulik added a comment. Having Kickoff confirm shutdown could be superfluous as you already had to go through the trouble of opening it, going to "Leave", but for e.g. the lock logout entry or generic " Leave" in the desktop context menu I'd still want a confirmation. REPOSITORY R120

D27090: Replace config.h with target_compile_definitions

2020-02-01 Thread Mikhail Zolotukhin
gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY One line in CMakeLists.txt is simpler, than the whole generated file. TEST PLAN Relaunch `kded5`, open GTK Settings in Application

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Nathaniel Graham
ngraham added a comment. In D27077#604505 , @broulik wrote: > Having Kickoff confirm shutdown could be superfluous as you already had to go through the trouble of opening it, going to "Leave", but for e.g. the lock logout entry or generic "

D27093: Provide better name for GTK Settings Sync service

2020-02-01 Thread Nicolas Fella
nicolasfella added a comment. +1 (speaking as the one who introduced the name IIRC) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27093 To: gikari, #vdg Cc: nicolasfella, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,

D27085: [SystemTray] Bunch of fixes and improvements in QML

2020-02-01 Thread Konrad Materka
kmaterka added a comment. Unrelated changes extracted from D26992 to make review easier REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27085 To: kmaterka, #plasma_workspaces, #plasma Cc: plasma-devel, Orage, LeGast00n,

D27086: [Applet]Supplementary add port check

2020-02-01 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R115:ccdeb9327f17: [Applet]Supplementary add port check (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

2020-02-01 Thread Alexander Lohnau
alex updated this revision to Diff 74848. alex added a comment. Undo changes that were supposed to be in new diff REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74847=74848 REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

2020-02-01 Thread Alexander Lohnau
alex updated this revision to Diff 74847. alex added a comment. Refactoring, improve validation in kcm, optimize REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74830=74847 BRANCH charrunner_fix REVISION DETAIL

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread David Edmundson
davidedmundson added a comment. > But the timeout isn't used to give apps more time needed to clean up before they confirm the session can be closed? If I understand it correctly, there should be two timeouts? That's different Order is action invoked This confirmation /

D27096: Refactoring, improve validation in kcm, optimize

2020-02-01 Thread Alexander Lohnau
alex created this revision. alex added reviewers: davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The config keys are now in a separate file, instead of having them at two places.

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

2020-02-01 Thread Alexander Lohnau
alex updated this revision to Diff 74830. alex added a comment. Simplify and optimize REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74795=74830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

2020-02-01 Thread Alexander Lohnau
alex marked an inline comment as done. alex added a comment. Hello, thanks for the response. I addition to your requested change I have made some smaller improvements. But I have a question about the concept of this runner: Why is the data for every match session newly created ?

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Christoph Feck
cfeck added a comment. Why is there a timeout at all? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27077 To: ngraham, #vdg, #plasma Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26992: [SystemTray] Use unified data model everywhere

2020-02-01 Thread David Edmundson
davidedmundson added a comment. The patch is big, but it's manageable. Splitting is up to you, don't feel you have to. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik Cc:

D27084: Don't delay ksplash until the entire lideshow is loaded

2020-02-01 Thread David Redondo
davidre created this revision. davidre added reviewers: davidedmundson, broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Instead of loading the model and then showing the last shown image, we

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread David Edmundson
davidedmundson added a comment. The (broken) rationale is you can just bash the power button and walk away. Useful if you have a large lab of machines or something. In practice apps can then block logout afterwards. (And probably it's there because windows at the time worked like

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Christoph Feck
cfeck added a comment. But the timeout isn't used to give apps more time needed to clean up before they confirm the session can be closed? If I understand it correctly, there should be two timeouts? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27077