D27595: Watch for language change events, and forward those to the QML engine

vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This fixes a race condition on startup for the Kirigami translation catalog that happens as follows: - QML code triggers

Re: Plasma Sprint 2020 in Augsburg, Germany

Hi Kai, I have a few questions: 1. Is it OK to join the sprint for those who don't touch Plasma source code on a regular basis? Would this make the sponsored office space overcrowded? (Asking for myself. Of course I won't request travel support.) 2. May we please merge "Arrival/Leaving"

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. In D27577#616579 , @ngraham wrote: > The changes to labels in `Header.qml` seem unrelated. They are as related as the other 4 changes are. Either will make 5 different patches or 1. But I'm not going to change

D27563: [mobile/wifi] Use ScrollViewKCM

jgrulich added a comment. In D27563#615561 , @ngraham wrote: > What's the chance we could unify the mobile and desktop versions at some point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather than using the power of

D27577: [KCM]Fix content below scrollbars

ngraham added a comment. The changes to labels in `Header.qml` seem unrelated. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D24009: RFC: Make Breeze Dark darker

ngraham added a comment. Also is there a better place to discuss this? A Phab task maybe? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24009 To: filipf, cblack, ndavis, #vdg, ngraham, #plasma Cc: onvitaik, anthonyfieroni, plasma-devel, Orage, LeGast00n,

D24009: RFC: Make Breeze Dark darker

ngraham added a comment. If adding a color for the separators isn't an option, and adding an option isn't an option (heh), then could we add a simple algorithm to switch to light separators if the background color is set to a sufficiently dark color? REPOSITORY R31 Breeze REVISION DETAIL

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76201. gvgeo added a comment. Make scrollbars touch the side of the frame. Fit speaker test grid inside the scrollview area. Fix advanced content layout. Make Header always fit inside the scrollview area. REPOSITORY R115 Plasma Audio Volume Applet

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76202. gvgeo added a comment. typo REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76201=76202 BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577

D27606: Remove usage of KDBusConnectionPool

This revision was automatically updated to reflect the committed changes. Closed by commit R161:fa5b3bb382ac: Remove usage of KDBusConnectionPool (authored by vkrause). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27606?vs=76237=76248

D27595: Watch for language change events, and forward those to the QML engine

apol added a comment. I'm fine with this being done here for convenience, but it feels like it's something that should be in QQmlEngine itself. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27595 To: vkrause Cc: apol, plasma-devel, fbampaloukas, GB_2, domson,

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

bruns updated this revision to Diff 76251. bruns added a comment. move out of class REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27611?vs=76249=76251 REVISION DETAIL https://phabricator.kde.org/D27611 AFFECTED FILES

D27612: Remove unused functions

bruns updated this revision to Diff 76252. bruns added a comment. rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27612?vs=76250=76252 REVISION DETAIL https://phabricator.kde.org/D27612 AFFECTED FILES kcms/baloo/filteredfoldermodel.cpp

D27613: Remove bogus mount points check when starting baloo on save

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The check stops baloo if non of the included pathes is *currently* mounted, i.e. if a device

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

bruns updated this revision to Diff 76253. bruns added a comment. ignoreMountPoint -> ignoredMountPoint whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27611?vs=76251=76253 REVISION DETAIL https://phabricator.kde.org/D27611 AFFECTED

D27612: Remove unused functions

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY showMessage() is only declared, but never defined. includeFolders() and

D27606: Remove usage of KDBusConnectionPool

vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY As per T12722 this is no longer needed, QDBusConnection now behaves correctly in a

D24009: RFC: Make Breeze Dark darker

onvitaik added a comment. The problem, as I see it, with it looking "fairly light" is that all the button and frame borders are lighter than the background and almost as light as the text. These color changes just exacerbate this issue. On that note, light borders on dark buttons makes

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Instead of negating the logic values in several places, just invert the logic. REPOSITORY

D24009: RFC: Make Breeze Dark darker

ndavis added a comment. I think these 4 colors could be used for backgrounds in Breeze Dark: #1b1e20 #232629 #2a2e32 #31363b Coincidentally, these colors are very close in lightness to the colors used by VS Code (`#1e1e1e`, `#252526`, `#2d2d2d`, `#33`) REPOSITORY

D27608: Fix applet configuration ovelap with top line

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY For plasmoids configuration add top line as topMargin. TEST PLAN Open desktop configuration.

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

usta added a comment. 2 Question : 1- isnt that method should be const'ified ? 2- also its name will be much better isIgnoreableMountPoint (or something can be more understandable that it will just return true or false ) becase right now it looks like "ignore that mount point"

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

bruns added a comment. In D27611#616556 , @usta wrote: > 2 Question : > 1- isnt that method should be const'ified ? Its not a member function ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27611

D24009: RFC: Make Breeze Dark darker

ndavis added a comment. The problem with having dark separators is that they disappear if you set the background color to black. That isn't an unreasonable thing for a user to want to do. It's also arguable that it isn't unreasonable for a user to want dark separators, so they could be an

D24009: RFC: Make Breeze Dark darker

ngraham added a comment. @onvitaik I completely agree. You're gonna have to convince @ndavis and @filipf who prefer light outlines and separators though. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24009 To: filipf, cblack, ndavis, #vdg, ngraham, #plasma Cc: