D28042: [DrKonqi] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, sitter, apol. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern(), unless the pattern is

D27998: [KCMs/Workspace] Add option for dndToMove

bugseforuns added a comment. Will popup menu show up if "Move files if on the same device" is selected and files are dragged to another partition on the same device? If so, "Move files if on the same device" label is not accurate. REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. Differently sized icons are about to be restored in D28034 . > ...text indicator replaced with a 1px divider... Is it a good idea to tweak it or is it better to leave it like it is? The alternative is the first version

D27669: [kstyle] Tools area

davidre added a comment. In D27669#627464 , @ndavis wrote: > Do we need to add a Header color set to KColorScheme? How would that help? KIconLoader still wouldn't know which color to use, wouldn't it? REPOSITORY R31 Breeze REVISION

D27669: [kstyle] Tools area

cblack added a comment. In D27669#627440 , @ngraham wrote: > Hopefully we can improve KIconLoader to support this use case. If not, we can always fall back to using a color for the tools area that's a darkened version of the window background

D28026: further constrict line parsing of .so files

ngraham added a comment. Looks sane to me. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28026 To: sitter, cfeck, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D27669: [kstyle] Tools area

ngraham added a comment. Hopefully we can improve KIconLoader to support this use case. If not, we can always fall back to using a color for the tools area that's a darkened version of the window background color or something, and just set that same color for the titlebar with the default

D27998: [KCMs/Workspace] Add option for dndToMove

ngraham added a comment. In D27998#627401 , @bugseforuns wrote: > Will popup menu show up if "Move files if on the same device" is selected and files are dragged to another partition on the same device? > If so, "Move files if on the same

D27669: [kstyle] Tools area

ndavis added a comment. Do we need to add a Header color set to KColorScheme? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove,

D27669: [kstyle] Tools area

ngraham added a comment. Why does it have to grab the widget's palette? Can't it simply use the colors defined for active/inactive titlebar bg color in the color scheme? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc:

D27669: [kstyle] Tools area

davidre added a comment. In D27669#627444 , @ngraham wrote: > Why does it have to grab the widget's palette? Can't it simply use the colors defined for active/inactive titlebar bg color in the color scheme? Because the iconloader

D27669: [kstyle] Tools area

ndavis added a comment. In D27669#627465 , @davidre wrote: > In D27669#627464 , @ndavis wrote: > > > Do we need to add a Header color set to KColorScheme? > > > How would that help? KIconLoader

D28024: [Baloo KCM] Expose "Index hidden" config setting

ngraham added inline comments. INLINE COMMENTS > main.qml:59 > + > +ColumnLayout { > +QQC2.CheckBox { Instead adding these new layouts, you could just set the following on each checkbox that needs to be indented: Layout.leftMargin: !LayoutMirroring.enabled ?

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added a comment. Yes, it means "partition". REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998 To: trmdi, #vdg, #plasma, ngraham Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27998: [KCMs/Workspace] Add option for dndToMove

ngraham added a comment. What does? REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998 To: trmdi, #vdg, #plasma, ngraham Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added a comment. In D27998#627603 , @ngraham wrote: > What does? dnd from /dev/sda1 -> /dev/sda1 : move dnd from /dev/sda1 -> /dev/sda2 : show menu REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master)

D27998: [KCMs/Workspace] Add option for dndToMove

ngraham added a comment. Right. @bugseforuns's objection is that you used the word "device" to mean "partition" in the UI. REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998 To: trmdi, #vdg, #plasma,

D28024: [Baloo KCM] Expose "Index hidden" config setting

bruns added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:59 > Instead adding these new layouts, you could just set the following on each > checkbox that needs to be indented: > > Layout.leftMargin: !LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : > 0 >

D28035: [Applet] Port to ExpandableListItem

ngraham added a comment. Yes, that's the last one I need to port. I've already submitted patches to port the Printers, Bluetooth, and Networks applets, as they also have the same style. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D28035 To: ngraham, #vdg,

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D27572: [kcm] Drop 'Enable bluetooth integration' setting

This revision was automatically updated to reflect the committed changes. Closed by commit R97:2d92acae05f4: [kcm] Drop Enable bluetooth integration setting (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27572?vs=76167=77629

D27189: Created a top area based on widgets/toparea.svg

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f4195688e68e: Created a top area based on widgets/toparea.svg (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77514=77628

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:4382 > I'll dig in KIconLoader code a bit over the week-end to see what really > happens when calling setCustomPalette and resetPalette, to get a sense of how > resource consuming this is ... So,

D27669: [kstyle] Tools area

hpereiradacosta added a comment. For what its worth: what you would need to fix this properly, is a new QIcon::Mode for "in active tool area" that you would map the the right colors when generating a given pixmap from the svg inside kiconloader. Only then would you be able to cache for a

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

kmaterka added inline comments. INLINE COMMENTS > cblack wrote in ExpandedRepresentation.qml:261 > I can't seem to reproduce a binding loop here. I have not seen your code yet, I will check tomorrow. Probably because you have something like this: Layout.preferredWidth: parent.width / 2

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

kmaterka added inline comments. INLINE COMMENTS > kmaterka wrote in ExpandedRepresentation.qml:261 > I have not seen your code yet, I will check tomorrow. Probably because you > have something like this: > > Layout.preferredWidth: parent.width / 2 > Layout.preferredHeight: parent.height /

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack added inline comments. INLINE COMMENTS > ngraham wrote in ExpandedRepresentation.qml:261 > there's a massive binding loop somewhere here: > > > file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.mediacontroller/contents/ui/ExpandedRepresentation.qml:261:21: > QML

D27996: Fix undefined check in global drawer menu mode

This revision was automatically updated to reflect the committed changes. Closed by commit R169:4d84d3f1d93f: Fix undefined check in global drawer menu mode (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27996?vs=77465=77630

D27669: [kstyle] Tools area

hpereiradacosta added a comment. Generating the toolarea colors from the windows colors and making sure the WindowText color still works; is also a solution. But it requires to also change the decoration to use this generated color instead of that of a palette, and an option to go with it.

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

kmaterka added inline comments. INLINE COMMENTS > kmaterka wrote in ExpandedRepresentation.qml:261 > My last comment was not precise. Just check this > for all details :) As a general rule, you shouldn't refer to parents width in Layouts, including:

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added a comment. In D27998#627605 , @ngraham wrote: > Right. > > @bugseforuns's objection is that you used the word "device" to mean "partition" in the UI. Both Dolphin and Qt use this word. REPOSITORY R119 Plasma Desktop

D27998: [KCMs/Workspace] Add option for dndToMove

ngraham added inline comments. INLINE COMMENTS > trmdi wrote in main.qml:204 > If there is a new stuff below this, when you make it visible, the below stuff > will jump up. That already happens with the other labels though. Implementing this behavior here would make it inconsistent with the

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi updated this revision to Diff 77644. trmdi added a comment. Nate's comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27998?vs=77643=77644 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998

D27958: [SystemTray] Fix item size for very narrow panel

ngraham added a comment. After a few days of living with it, I've found that this patch causes the following issue with semi-random tray items getting smaller when a pop-up is opened: F8176616: vokoscreenNG-2020-03-14_23-35-16.webm Could you

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi updated this revision to Diff 77643. trmdi added a comment. Nate's comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27998?vs=77509=77643 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998

D27998: [KCMs/Workspace] Add option for dndToMove

ngraham added a comment. Where? Being wrong in multiple places doesn't make it right. ;) REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998 To: trmdi, #vdg, #plasma, ngraham Cc: bugseforuns, meven,

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added a comment. In D27998#627623 , @ngraham wrote: > Where? Being wrong in multiple places doesn't make it right. ;) On the left panel. REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master) REVISION

D27998: [KCMs/Workspace] Add option for dndToMove

ngraham added inline comments. INLINE COMMENTS > main.qml:204 > + > +QQC2.Label { > +Layout.fillWidth: true I would make this label non-visible when `dndToMoveEnabler.checked` is false, rather than changing its text. REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove

D27998: [KCMs/Workspace] Add option for dndToMove

ngraham added a comment. Hmm, that's true. How awkward. REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998 To: trmdi, #vdg, #plasma, ngraham Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n,

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:204 > I would make this label non-visible when `dndToMoveEnabler.checked` is false, > rather than changing its text. If there is a new stuff below this, when you make it visible, the below stuff will jump up. REPOSITORY

D28024: [Baloo KCM] Expose "Index hidden" config setting

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, let's go for it as-is. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28024 To: bruns, #baloo, #vdg, ngraham Cc: plasma-devel, Orage,

D27189: Created a top area based on widgets/toparea.svg

niccolove added a comment. Weird. I can't reproduce, neither in my compiled nor stable install: F8176254: Screenshot_20200314_233208.png But then again, apparently it's not master-y master, so maybe something changed? REPOSITORY R120 Plasma

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack added inline comments. INLINE COMMENTS > kmaterka wrote in ExpandedRepresentation.qml:261 > I have not seen your code yet, I will check tomorrow. Probably because you > have something like this: > > Layout.preferredWidth: parent.width / 2 > Layout.preferredHeight: parent.height / 2

D27189: Created a top area based on widgets/toparea.svg

ngraham added a comment. Just noticed that there are various system tray applets whose main content/toolbar areas need a bit more of a top margin now: F8176236: Screenshot_20200314_160647.png F8176238: Screenshot_20200314_160805.png

D27189: Created a top area based on widgets/toparea.svg

niccolove added a comment. I think I have the old network manager. I will submit patches. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n,

D28035: [Applet] Port to ExpandableListItem

ivan added a comment. I like it. Is the device notifier going to look like this as Vaaults tried to mimic that one? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D28035 To: ngraham, #vdg, #plasma, ivan Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,