D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Same error about not being able to find the module. Sorry for not being clear. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre, plasma-devel,

D28072: [GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#638514 , @ngraham wrote: > Same error about not being able to find the module. Sorry for not being clear. You can provide a full path to the library instead of letting GTK do name to library resolution.

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. Hmm, this isn't working for me. When I pin open the system tray popup and click on a Klipper history item, the popup stays open as expected, but the Klipper applet itself closes, so the pop-up is replaced with the applets list. Is this working for you?

D28454: [libnotificationmanager] forward notifications to lockscreen greeter

bshah created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY This is alternative to previous revision which talks to ksldapp and then ksldapp talks to the greeter over private wayland server

D28383: Add PageRouter component

cblack updated this revision to Diff 78946. cblack added a comment. Get arc to properly diff REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=78927=78946 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383 AFFECTED

D28383: Add PageRouter component

cblack updated this revision to Diff 78948. cblack added a comment. Add more documentation comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=78946=78948 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

bruns added a comment. @davidedmundson - is `QIcon(QImage(...)) `save? the AppstreamRunner suffers from the same problem, it uses `match->setIcon(/*wrapped*/QIcon::fromTheme())`. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28439 To: alex, apol,

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. The best would be to add theme path support to `PlasmaCore.IconItem`. I will take a look at this tomorrow. INLINE COMMENTS > davidre wrote in systemtraymodel.cpp:331 > This works now, but I don't know how to manage the KIconLoader. The > KIconEngines are managed

D28113: Fix initial loading of autostart program names

yuyichao added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28113 To: yuyichao, apol, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78852. davidre added a comment. - Also handle IconThemePath We need the KIconEngine thing like the dataengine did. To make it as not as complicated I moved the "name ? name : pixmap" into the model. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D28330: Color icons in titlebar if possible

davidre updated this revision to Diff 78859. davidre added a comment. Check if cast is successfull REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=78639=78859 BRANCH icons (branched from master) REVISION DETAIL

D28208: Move sni icon handling logic from data engine to applet

davidre added a comment. INLINE COMMENTS > systemtraymodel.cpp:331 > +if (!iconThemePath.isEmpty()) { > + loader = new KIconLoader(sourceName, {iconThemePath}); > + loader->addAppDir(sourceName, iconThemePath); This works now, but I don't know how to manage the

D28330: Color icons in titlebar if possible

davidre updated this revision to Diff 78860. davidre added a comment. forgot else REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=78859=78860 BRANCH icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D28330 AFFECTED FILES

D28428: [screenlocker] listen to notifications from the notification server

bshah created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY This will allow notification manager to forward the notifications that are meant to be shown on the lockscreen, currently it requires

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in CMakeLists.txt:43 > Do we rather want it in libexec since it's not meant to be run by the user? There's a bit of a challenge there. We need this executable to be found by the xdg generator. libexec seems to be all over

D28420: [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight

broulik created this revision. broulik added reviewers: Plasma, leinir, davidre. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY GHNS Quick Button signals `changedEntriesChanged` initially even if nothing

D28422: WIP: Use ecm_install_configured_files macro

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY DO NOT MERGE YET. Uploaded to show intended usage whilst discussing API. TEST PLAN N/A REPOSITORY R120

D28354: [applets/digital-clock] Fix calendar events not being shown at first

epopov updated this revision to Diff 78853. epopov added a comment. Rebase to `master` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28354?vs=78715=78853 REVISION DETAIL https://phabricator.kde.org/D28354 AFFECTED FILES

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 78855. meven marked 10 inline comments as done. meven added a comment. code style mostly, adress Kai review REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=78681=78855 BRANCH D26934 REVISION DETAIL

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY It should use 'kioclient5'. REPOSITORY R126 KDE CLI Utilities

D26934: KCM/Autostart Add a model to separate logic from UI

broulik added inline comments. INLINE COMMENTS > meven wrote in autostart.cpp:210 > ? rows inserted gives you a range of [first,last] which was added > meven wrote in autostart.cpp:182 > You mean I should use open/finished right ? Yes. It then also needs to set a transient parent and window

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

davidedmundson added a comment. looks good to me, but lets delay merging till the relevant other parts are ready. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28424 To: hchain, davidedmundson, broulik, dfaure, ngraham, meven Cc: plasma-devel, Orage,

Monday Meeting Notes Week 14 (2020-03-30)

Week 14 of 2020 Plasma meeting notes from 2020-03-30: Hope you're all doing well and staying at home. DavidRedondo * I am continuing work for coloring icons in the correct colors * Patch for breeze kdecoration now up on phab: https://phabricator.kde.org/D28330 * IconItem

D28330: Color icons in titlebar if possible

davidre added inline comments. INLINE COMMENTS > breezebutton.cpp:153 > +KIconLoader::global()->resetPalette(); > +} > KWin doesn't change the palette, it uses to global one to draw the icons for example when you right click on a window titlebar. REPOSITORY R31

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:43 > +if (CMAKE_SYSTEM_NAME STREQUAL "Linux") > +install(TARGETS kde-systemd-start-condition DESTINATION > ${KDE_INSTALL_BINDIR}) > +endif () Do we rather want it in libexec since it's not meant to be run by the user?

D26934: KCM/Autostart Add a model to separate logic from UI

meven added inline comments. INLINE COMMENTS > broulik wrote in autostart.cpp:210 > You probably want to loop > > for (int i = first; i <= last; ++i) { ? > broulik wrote in autostart.cpp:182 > In preparation for a move to QML, can we please not `exec()` You mean I should use open/finished

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

hchain created this revision. hchain added reviewers: davidedmundson, broulik, dfaure, ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hchain requested review of this revision. REVISION SUMMARY For systemd autostart generator will add a

D28427: [libnotificationmanager] forward notifications to lockscreen

bshah created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY This is currently WIP, and doesn't fully work, requires patches on both kscreenlocker and lockscreen theme. TEST PLAN tested that

D28286: [Task Manager] Port backend to ApplicationLauncherJob

broulik updated this revision to Diff 78842. broulik added a comment. This revision is now accepted and ready to land. - Adjust to API change in `KServiceAction` - Drop linkage of `KIOWidgets` in favor of `KIOGui` (though `KIOFileWidgets` probably implies it anyway) REPOSITORY R119

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

meven updated this revision to Diff 78866. meven marked 6 inline comments as done. meven added a comment. Remove unnecessary semilicons, formatting REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28331?vs=78663=78866 BRANCH arcpatch-D28331

D28347: Port services and shell runner away from KRun

broulik updated this revision to Diff 78840. broulik added a comment. - Adjust to API change in `KServiceAction` - Also don't use now deprecated `QUrl::queryItemValue` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28347?vs=78651=78840 REVISION

D28389: Add support for logging categories

romangg updated this revision to Diff 78881. romangg added a comment. Include the cpp files REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28389?vs=78765=78881 BRANCH logging-categories REVISION DETAIL https://phabricator.kde.org/D28389

D28389: Add support for logging categories

romangg added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:23 > Make sure the include() call is before the add_subdirectory(). > > That's why we usually put them together on top right under the find_package() > together with `include(ECMGenerateHeaders)`. Put the include on

D28386: fix(kded): watch config also when known config is applied

This revision was automatically updated to reflect the committed changes. Closed by commit R104:3dced489d7c1: fix(kded): watch config also when known config is applied (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28386?vs=78756=78882

D28435: [System Tray] Update effective status on model insertion

broulik created this revision. broulik added reviewers: Plasma, kmaterka, davidre, ahmadsamir. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Started Konversation, has proper effective status of passive again.

D28427: [libnotificationmanager] forward notifications to lockscreen

nicolasfella added a comment. So notifications are only forwarded if x-kde-show-on-lockscreen is set? I wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard to third-party apps. From a privacy POV I think a global dont-show-notis-on-lockscreen thing would make more

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. This needs a rebase on master, as it currently does not apply. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28438: Add per-partition total and all partitions sensors

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a "total" sensor for each partition that reports the total space for that

D27701: [ComboBox] Use transparent dimmer

broulik added a comment. Affects any `ComboBox` in a KCM for me, that isn't in a `Popup`: Fonts KCM, GTK config on Styles KCM (not the one in the fine tuning popup), the filter in colors KCM, ... REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D28354: [applets/digital-clock] Fix calendar events not being shown at first

broulik added inline comments. INLINE COMMENTS > CalendarView.qml:154 > > +function dateEquals(date1, date2) { > +var values1 = [ Can't you do `date1.getTime() == date2.getTime()` (`time` returns the msecs since epoch) REPOSITORY R120 Plasma Workspace

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex updated this revision to Diff 78906. alex added a comment. Remove unused includes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28439?vs=78905=78906 BRANCH bookmarks_change_icon_handling_in_matches REVISION DETAIL

D27669: [kstyle] Tools area

ngraham added a comment. Nice, that seems to have fixed the issue again. However I still see a significant performance regression though. Switching tabs in Kate is now quite slow, especially when there are many open and you use a keyboard shortcut to do so. I see the spinning busy

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Well this is kind of a problem then since we need to support development builds to a nonstandard install prefix. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc:

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638173 , @cblack wrote: > GTK™ isn't too fond of trying to load stuff from outside the standard directories. How can this be fixed? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors

D28428: [screenlocker] listen to notifications from the notification server

bshah updated this revision to Diff 78904. bshah added a comment. - properly wire up the protocol for ksldapp to greeter REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28428?vs=78883=78904 BRANCH bshah/ksld-notifications REVISION DETAIL

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex created this revision. alex added reviewers: apol, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Before: A pointer to the favicon gets written in the BookmarkMatch and using this

D28072: [GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#638170 , @ngraham wrote: > Hmm, when following those instructions, I get the following console error: > > Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module" > > > And the color

D28354: [applets/digital-clock] Fix calendar events not being shown at first

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a05dc73cf7fb: [applets/digital-clock] Fix calendar events not being shown at first (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Hmm, when following those instructions, I get the following console error: Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module" And the color scheme doesn't change. The `colorreload-gtk3-module` target did get built, and it installed a

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

davidedmundson added a comment. QIcon isn't thread safe. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28439 To: alex, apol, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28354: [applets/digital-clock] Fix calendar events not being shown at first

epopov added inline comments. INLINE COMMENTS > broulik wrote in CalendarView.qml:154 > Can't you do `date1.getTime() == date2.getTime()` (`time` returns the msecs > since epoch) How can I compare only the date using your expression? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28305: WIP: Systemd Startup

davidedmundson updated this revision to Diff 78917. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28305?vs=78541=78917 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28305 AFFECTED FILES

D28305: WIP: Systemd Startup

davidedmundson updated this revision to Diff 78922. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28305?vs=78917=78922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28305 AFFECTED FILES

D28428: [screenlocker] listen to notifications from the notification server

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. We've added a DBus interface to the screensaver host; ksmserver or kwin respectively. That receives the notification and then using a different API over wayland,

D28435: [System Tray] Update effective status on model insertion

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This fixes the same issue affecting Vaults too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28435 To: broulik, #plasma, kmaterka, davidre,

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven updated this revision to Diff 78913. meven marked 5 inline comments as done. meven added a comment. Adress review (formatting) and fix a couple of indentation issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=78522=78913 BRANCH

D27701: [ComboBox] Use transparent dimmer

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, this fixes those issues for me too. Seems to make sense. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27701 To: broulik,

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. It can, you just need to fix the merge conflicts manually. If it doesn't apply cleanly to master, that means it can't be landed on master. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc:

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex added a comment. In D28439#638188 , @davidedmundson wrote: > QIcon isn't thread safe. Sorry, I wasn't aware about that and haven't found anything when I had a quick look at the docs before submitting this patch. But if I may

D28427: [libnotificationmanager] forward notifications to lockscreen

ngraham added a comment. In D28427#637913 , @nicolasfella wrote: > So notifications are only forwarded if x-kde-show-on-lockscreen is set? I wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard to third-party apps.

D28422: WIP: Use ecm_install_configured_files macro

davidedmundson updated this revision to Diff 78912. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28422?vs=78854=78912 BRANCH configured_install REVISION DETAIL https://phabricator.kde.org/D28422

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

ngraham added a comment. Hmm, that's a good point. I hadn't realized that. Would it make sense for changing the timezone in the applet to actually change the whole system timezone too, rather than just the display in the applet? Is that something we can do? REPOSITORY R120 Plasma

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov added a comment. Can't be rebased on master REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27669: [kstyle] Tools area

abstractdevelop added a comment. Also should we implement this for GTK apps? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta,

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. You can add it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27669: [kstyle] Tools area

ngraham added a comment. Found an issue in Virtualbox: the menubar isn't considered a part of the Tools Area: F8206280: Screenshot_20200330_113752.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack,

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

bruns added a comment. Also keep code lines at < 80 characters REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28196 To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov updated this revision to Diff 78926. epopov added a comment. Rebase on **master** REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28408?vs=78827=78926 REVISION DETAIL https://phabricator.kde.org/D28408 AFFECTED FILES

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This should be 3 submission: 1. early return/indentation changes (preparation) 2. always read default profile from FF config, do not write "dbfile" to runner config 3. fix

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

bruns added a comment. In D28439#638216 , @alex wrote: > In D28439#638188 , @davidedmundson wrote: > > > QIcon isn't thread safe. > > > Sorry, I wasn't aware about that and haven't found

D27669: [kstyle] Tools area

cblack added a comment. In D27669#638328 , @abstractdevelop wrote: > Also should we implement this for GTK apps? Pretty much already there :P F8206301: image.png But yes, I'm already

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

bruns added a comment. Can you split out the early-return part for the QSQLite driver and submit it as a preparation patch? It adds quite some noise to the diff due to the whitespace changes (though I fully agree it is the better coding pattern). REPOSITORY R120 Plasma Workspace

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

bruns added a comment. Regarding the summary: 1. Wrap the lines at <80 characters 2. Describe the screenshot textually REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28196 To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma Cc:

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov added a comment. In **Plasma/5.18** branch there was a `Containment.onAppletAdded` handler that took the `applet` as a parameter, but can't find this handler in **master** branch. Unfortunately, I don’t have enough knowledge of Plasma API to know if I can add this handler manually.

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. @ndavis like this? F8206344: Screenshot_20200330_123644.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin,

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

bport added a comment. Some coding style nitpicking INLINE COMMENTS > export_scheme_dialog.cpp:46 > int item=0; > -Q_FOREACH(QString component, mComponents) > +for (const QString : qAsConst(mComponents)) > { { on same line > export_scheme_dialog.cpp:74 > +const auto

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

This revision was automatically updated to reflect the committed changes. Closed by commit R126:30a713025624: [kioclient] Fix kioclient5 --commands usage messages (authored by ahmadsamir). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D28314: Allow setting separate corner radii for ShadowedRectangle

broulik added a comment. Cool INLINE COMMENTS > shadowedrectangle.h:157 > +private: > +float m_topLeft = -1.0; > +float m_topRight = -1.0; How about using NaN to define "not set"? though you can't have negative radius, so probably fine REPOSITORY R169 Kirigami REVISION DETAIL

D25462: [Colors / Desktop Theme KCM] Use Kirigami.SearchField

broulik updated this revision to Diff 78891. broulik retitled this revision from "[Colors KCM] Use Kirigami.SearchField" to "[Colors / Desktop Theme KCM] Use Kirigami.SearchField". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a

D28433: Apply the correct palette to icons

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Our icons can be recolored. However there is a difference between custom colors on widgets and icons. We will respect the

D28428: [screenlocker] listen to notifications from the notification server

nicolasfella added inline comments. INLINE COMMENTS > interface.cpp:213 > > +void Interface::Notify(const QString& app_name, uint replaces_id, const > QString& app_icon, > + const QString& summary, const QString& body, const > QStringList& actions, conding style: &

D28427: [libnotificationmanager] forward notifications to lockscreen

bshah updated this revision to Diff 78884. bshah added a comment. - adapt to changes in the kscreenlocker REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28427?vs=78871=78884 BRANCH bshah/ksld-notify REVISION DETAIL

D28428: [screenlocker] listen to notifications from the notification server

bshah updated this revision to Diff 78883. bshah added a comment. - add argument for the notification id in dbus service - add wayland protocol stanza for passing notification data to greeter REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

bruns added a comment. In D28439#638188 , @davidedmundson wrote: > QIcon isn't thread safe. I think this is related to https://phabricator.kde.org/D5889?id=14601 ? I think we are save here, as the QIcon is created from an image

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but nonetheless there is no effect. :( REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham,

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78928. cblack added a comment. Change how cache invalidation works REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78813=78928 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669

D27669: [kstyle] Tools area

cblack added a comment. In D27669#638327 , @ngraham wrote: > Found an issue in Virtualbox: the menubar isn't considered a part of the Tools Area: > > F8206280: Screenshot_20200330_113752.png

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex added a comment. In D28439#638357 , @bruns wrote: > In D28439#638188 , @davidedmundson wrote: > > > QIcon isn't thread safe. > > > I think this is related to

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638356 , @ngraham wrote: > The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but nonetheless there is no effect. :( Is the GTK application throwing the same error, that the module is

D28383: Add PageRouter component

cblack updated this revision to Diff 78927. cblack added a comment. Add caching REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=78747=78927 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383 AFFECTED FILES

D27669: [kstyle] Tools area

cblack added a comment. In D27669#638175 , @ngraham wrote: > Nice, that seems to have fixed the issue again. > > However I still see a significant performance regression though. Switching tabs in Kate is now quite slow, especially when there

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638170 , @ngraham wrote: > Hmm, when following those instructions, I get the following console error: > > Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module" > > > And the color