D28705: Don't consider player gone when it only got temporarily added by us

broulik added a comment. It worked on Chrome, and the properties can be accessed from the same context. It's just that the mutation.removedNodes loop above which is in content script cannot access those JS properties, so I had to change it, so it can. REPOSITORY R856 Plasma Browser

D28705: Don't consider player gone when it only got temporarily added by us

fvogt added a comment. So was the case handled by line 805 completely broken? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28705 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28706: Restore old Audio prototype after exportFunction

broulik abandoned this revision. broulik added a comment. Superseded by D28709 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28706 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, Orage, LeGast00n,

D28705: Don't consider player gone when it only got temporarily added by us

fvogt added a comment. In D28705#644982 , @broulik wrote: > It worked on Chrome, and the properties can be accessed from the same context. > It's just that the mutation.removedNodes loop above which is in content script cannot access those

D28711: WIP: OpenStore Integration

bhdouglass created this revision. bhdouglass added a reviewer: apol. bhdouglass added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bhdouglass requested review of this revision. REVISION SUMMARY This is a rough, work in progress

D28709: Implement executeScript for Firefox

fvogt added a comment. I'm not sure about the `// Firefox enforces Content-Security-Policy also for scripts injected by the content-script` part, but I'm not sure how to test it. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt,

D28709: Implement executeScript for Firefox

broulik added a comment. Try whether it works on Spotify web player and nextcloud - they have a content security policy which prevents adding custom script tags REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc:

D28707: Show purpose context menu only when enabled

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Check whether the extension is supported and enabled. Unfortunately, I removed

D28709: Implement executeScript for Firefox

fvogt created this revision. fvogt added reviewers: Plasma, broulik. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY window.eval is exactly what we need, so we can drop the Firefox specific replacements like calls to exportFunction. TEST PLAN

D28709: Implement executeScript for Firefox

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thank you so much! I tested with all the players from D24870 and it works really well. REPOSITORY R856 Plasma Browser Integration BRANCH

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:90ac7c210411: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog (authored by ahmadsamir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

ahmadsamir updated this revision to Diff 79736. ahmadsamir added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27808?vs=78519=79736 BRANCH l-kfontchooserdialog (branched from master) REVISION DETAIL

D28706: Restore old Audio prototype after exportFunction

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. I can't find a better way to do this either... Some notes: - `window.eval` works as expected so if not entirely unlucky (old firefox?) this can be replaced by using `executeScript`

D28709: Implement executeScript for Firefox

fvogt updated this revision to Diff 79729. fvogt added a comment. Use full URL in comment REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28709?vs=79728=79729 BRANCH ffeval REVISION DETAIL https://phabricator.kde.org/D28709

D28709: Implement executeScript for Firefox

broulik added a comment. At a glance this seems to be working marvellously. Even media session API works in Spotify now REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n,

D28705: Don't consider player gone when it only got temporarily added by us

broulik added a comment. Yeah, wondering the same... maybe it didn't. Anyway this also fixes Spotify's previous/next buttons not working since when the player is gone we clear media session actions (not sure if that is someting we should do though) REPOSITORY R856 Plasma Browser

D28709: Implement executeScript for Firefox

fvogt added a comment. Note: Remains to be tested on non-firefox and old firefox ESR. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28706: Restore old Audio prototype after exportFunction

fvogt added a comment. D28709 conflicts/supersedes this now. `window.Audio.prototype != Audio` is a separate issue though, which might still need fixing. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28706

D28710: [RFC] Make accidental panel and panel widget deletion more difficult

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We make it very easy to delete panels and panel widgets--perhaps a bit too easy. User

D28714: Refactor enableBluetooth function

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY The code has quite some boilerplate and high

D28383: Add PageRouter component

cblack updated this revision to Diff 79746. cblack added a comment. Address feedback (both human and compiler), improve examples, port to QQmlParserStatus REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79745=79746 BRANCH cblack/pagerouter

D28709: Implement executeScript for Firefox

fvogt added a comment. I just tried this with google translate on FF ESR 68(.1.0 IIRC) and it worked, but there was an error about the content security policy having blocked an eval. The error is gone if the extension is disabled. So this needs a test with spotify/nextcloud. Do you have

D28383: Add PageRouter component

cblack updated this revision to Diff 79745. cblack added a comment. Fix Doxygen errors REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79498=79745 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383 AFFECTED FILES

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Looking good. I see two remaining visual issues: 1. There's an extra one-pixel line above the section header text that touches the bottom line of the applet's header:

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex added a comment. In D28057#645164 , @ngraham wrote: > I would give each view mode its own config value and adjust the code with conditionals; that's not a problem. There are no backwards compatibility concerns here if you do that,

D28710: [RFC] Make accidental panel and panel widget deletion more difficult

ngraham updated this revision to Diff 79739. ngraham added a subscriber: broulik. ngraham added a comment. Fix the FIXMEs (thanks for the help @broulik) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28710?vs=79730=79739 BRANCH

D28713: Return buffer to pipewire when returning early from recordFrame

cblack created this revision. cblack added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Even when something goes wrong, the buffer should be returned to pipewire for recycling on

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex added a comment. In D28057#645140 , @ngraham wrote: > I still don't think we need three values in the config file for only two view modes. well ... I can use only one value in config file, but then the user loses the

D28715: Add libunity-dev to INSTALLATION instructions for Kubuntu and KDE Neon

jonathanchun added a comment. Badge Counters won't work via the Unity Launcher API without libunity-dev installed. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D28715 To: jonathanchun Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28715: Add libunity-dev to INSTALLATION instructions for Kubuntu and KDE Neon

jonathanchun created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jonathanchun requested review of this revision. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D28715 AFFECTED FILES INSTALLATION.md To: jonathanchun Cc:

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham added a comment. I would give each view mode its own config value and adjust the code with conditionals; that's not a problem. There are no backwards compatibility concerns here if you do that, except for people currently using list view with gigantic icons, which will become small,

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I still don't think we need three values in the config file for only two view modes. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28057 To:

D28688: Document Kirigami::Icon

cblack updated this revision to Diff 79744. cblack added a comment. Fix Doxygen issues REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28688?vs=79669=79744 BRANCH cblack/document-icon (branched from master) REVISION DETAIL

D28383: Add PageRouter component

cblack updated this revision to Diff 79748. cblack added a comment. Improve documentation REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79746=79748 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383 AFFECTED FILES

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/15/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 10 Apr 2020 04:24:29 + Build duration: 26 sec and counting CONSOLE OUTPUT

D26185: Also disable automatic scaling on Qt >= 5.14

fvogt added a comment. That sounds like a Qt bug, which fails to use the `QT_SCREEN_SCALE_FACTORS` value for pixmaps for some reason. Is it a multi-monitor setup? Can you open a new issue with details and a screenshot? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich updated this revision to Diff 79684. jgrulich edited the summary of this revision. jgrulich added a comment. Allow to disable only PipeWire, while keeping rest of Wayland support REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28693: Replace old notification when new notification for connection appears

broulik added a comment. +1 I've been wanting to do exactly this forever INLINE COMMENTS > notification.cpp:431 > + > +if (m_notifications.contains(connectionId)) { > +notify = m_notifications[connectionId]; Avoid double look-up. `QHash` gives you a null value when not existing,

D28686: [Battery Monitor] Choose better wording

broulik added a comment. "Life remaining" sounds as if it blows up any minute. Perhaps "Remaining time"? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich added a comment. In D28677#644196 , @davidedmundson wrote: > > Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet. > > I don't follow, why don't we just disable the screencasting

D28684: Kate Runner: Implement drag and drop for sessions

broulik added a comment. What's your usecase for this? Not sure I like making assumptions on how and where those sessions are stored. I'd rather have a way to tell Kate to create a desktop file for them, or a button in its UI or something. REPOSITORY R114 Plasma Addons REVISION DETAIL

D28688: Document Kirigami::Icon

broulik added a comment. Generally +1 on better docs INLINE COMMENTS > icon.h:53 > +/** > + * The name of a fallback icon to load from the icon theme when the > `source` > + * cannot be found. Mention `Default is "unknown"` > icon.h:58 > + * > + * @note This will only

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. Thanks for your work REPOSITORY R119 Plasma Desktop BRANCH l-kfontchooserdialog (branched from master) REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma,

D28684: Kate Runner: Implement drag and drop for sessions

alex added a comment. The usecase is that you can pin the sessions to the taskbar. For instance if you have a quicklaunch widget in your panel for your favorite applications. And yeah I get the point about including this logic into Kate itself. REPOSITORY R114 Plasma Addons REVISION

D28696: Use std::any_of

davidre added inline comments. INLINE COMMENTS > notification.cpp:578 > +const auto ac = NetworkManager::activeConnections(); > +if (std::any_of(ac.constBegin(), ac.constEnd(), [](const auto > connection) { > + return connection->state() == >

D28696: Use std::any_of

davidre added inline comments. INLINE COMMENTS > CMakeLists.txt:11 > > +set(CMAKE_CXX_STANDARD 14) > + CXX_STANDARD_REQUIRED, too? REPOSITORY R116 Plasma Network Management Applet BRANCH anyof REVISION DETAIL https://phabricator.kde.org/D28696 To: nicolasfella, #plasma, jgrulich Cc:

D28698: Save unneeded DBus roundtrip

broulik added a comment. Isn't that `Handler` also used from the plasmoid and KCM, which is in a separate process from kded? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28698 To: nicolasfella, #plasma, jgrulich Cc: broulik,

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. Actually it was me who pushed this, Lukáš just did some changes to it. Here are some details: https://cgit.kde.org/plasma-nm.git/commit/?id=81839a1566d0c0209a308d71b03837f996a19c96 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D28698: Save unneeded DBus roundtrip

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. In D28698#644705 , @davidedmundson wrote: > > (the ugly notification which pops on the top of screen) when Plasma notifications are not

D28664: [OverlaySheet] add bottomMargin property

mart added a comment. In D28664#643921 , @ngraham wrote: > Thanks for the patch, but why would you need the bottom margin to be customizable? Shouldn't the default be to simply center the sheet vertically when it's not as tall as the window, as

D28698: Save unneeded DBus roundtrip

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY When the module is loaded the handler is

D28698: Save unneeded DBus roundtrip

davidedmundson added a comment. > (the ugly notification which pops on the top of screen) when Plasma notifications are not ready yet Plasma ships a trick for that which means that we always get plasma notifications when plasma is installed regardless of if it's running. REPOSITORY

D28696: Use std::any_of

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Makes for more idiomatic code. Bumps the

D28692: Don't leak DrKonqi dialog / fix crash on wayland

davidedmundson added inline comments. INLINE COMMENTS > anthonyfieroni wrote in main.cpp:67 > Adding a qApp as a parent here? I can't, qwidgets only take qwidgets as parents. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28692 To: davidedmundson, #plasma Cc:

D28698: Save unneeded DBus roundtrip

nicolasfella added a comment. Yes, but I don't see this being a problem REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28698 To: nicolasfella, #plasma, jgrulich Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28686: [Battery Monitor] Choose better wording

shubham updated this revision to Diff 79686. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28686?vs=79662=79686 REVISION DETAIL https://phabricator.kde.org/D28686 AFFECTED FILES applets/batterymonitor/package/contents/ui/logic.js To: shubham,

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. In D28698#644695 , @broulik wrote: > Isn't that `Handler` also used from the plasmoid and KCM, which is in a separate process from kded? It is. REPOSITORY R116 Plasma Network Management Applet REVISION

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. In D28698#644698 , @nicolasfella wrote: > Yes, but I don't see this being a problem I think this was done this way to make the kded module used only when either the applet or KCM is running. It was Lukáš Tinkl

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. I see that we already initialize the secret agent right when the kded module is loaded, but I see a potential problem in showing a notification using a fallback backend (the ugly notification which pops on the top of screen) when Plasma notifications are not ready

D28698: Save unneeded DBus roundtrip

nicolasfella added a comment. I see, that makes sense REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28698 To: nicolasfella, #plasma, jgrulich Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28693: Replace old notification when new notification for connection appears

nicolasfella updated this revision to Diff 79696. nicolasfella added a comment. - update REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28693?vs=79678=79696 BRANCH reuse REVISION DETAIL https://phabricator.kde.org/D28693

D28692: Don't leak DrKonqi dialog / fix crash on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R871:b2ebd8f2ca33: Dont leak DrKonqi dialog / fix crash on wayland (authored by davidedmundson). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28692?vs=79675=79695

D28512: Port Konsole and Kate runners and dataengine away from KToolInvocation

This revision was automatically updated to reflect the committed changes. Closed by commit R114:a2ebeeb65717: Port Konsole and Kate runners and dataengine away from KToolInvocation (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D28691: [kded] Clean up notification handling

This revision was automatically updated to reflect the committed changes. Closed by commit R116:0eeb2605df8e: [kded] Clean up notification handling (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28690: Add unit tests for PagePool/PagePoolAction

This revision was automatically updated to reflect the committed changes. Closed by commit R169:acd93a6e6369: Add unit tests for PagePool/PagePoolAction (authored by masonm). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28690?vs=79672=79702 REVISION

Re: guide to build plasma mobile for pinephone

Hey On Thu, Apr 09, 2020 at 11:06:43AM +0530, Surendra Kumar wrote: > Hi, > > I would like to support in plasma development. > > Can someone point to the build scripts that help in building the plasma > mobile for pinephone from source ? Currently images for pinephone are built using the debos

D28693: Replace old notification when new notification for connection appears

This revision was automatically updated to reflect the committed changes. Closed by commit R116:9e032bf51078: Replace old notification when new notification for connection appears (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28616: Split KWin startup out of KSMServer

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f6e34fe0d652: Merge branch broulik/ksmserver_no_wm (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28616?vs=79558=79705#toc REPOSITORY R120 Plasma Workspace CHANGES

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

heikobecker abandoned this revision. heikobecker added a comment. Already done in 3fb633159ca4a1db166d5c54bbc025f71aba1652 . REPOSITORY R1028 Plasma Pass REVISION DETAIL https://phabricator.kde.org/D28398 To:

D28693: Replace old notification when new notification for connection appears

nicolasfella updated this revision to Diff 79697. nicolasfella added a comment. fix REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28693?vs=79696=79697 BRANCH reuse REVISION DETAIL https://phabricator.kde.org/D28693 AFFECTED

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/24/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 09 Apr 2020 12:52:55 + Build duration: 1 min 39 sec and counting CONSOLE OUTPUT

D28705: Don't consider player gone when it only got temporarily added by us

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We temporarily add players created by JS to the DOM so we can access them from the

D28678: adjust smb kcm size to be sufficient vis a vis headers

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I really wish that KCMshell didn't add its own scrollview, so we didn't end up with issues like this. The KCM itself should be responsible for its own layouting needs. Then again I

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. I did. I followed your test plan exactly. :/ REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28706: Restore old Audio prototype after exportFunction

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `exportFunction` doesn't carry over a prototype, nor can I assign a non-function

D28686: [Battery Monitor] Choose better wording

ngraham accepted this revision. ngraham added 1 blocking reviewer(s): broulik. ngraham added a comment. LGTM. @broulik? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n,

D28671: Improved gallery listing

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:2967cd140966: Improved gallery listing (authored by cblack). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28671?vs=79650=79715 REVISION DETAIL

D28664: [OverlaySheet] add bottomMargin property

ngraham added a comment. I think having the overlaysheet glued to the bottom is fine for a very tall sheet that's scrollable or almost scrollable. But when it's not very tall, having it vertically centered makes more sense IMO. A short sheet glued to the bottom looks very weird to me.

D28696: Use std::any_of

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b9d6a4009345: Use std::any_of (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28696?vs=79687=79710#toc REPOSITORY R116 Plasma Network Management Applet CHANGES

D28703: Make KAccess a regular startup application

broulik created this revision. broulik added reviewers: Plasma, Plasma Accessibility. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Also ports it away from `KToolInvocation`. I don't really see why it would

D28698: Save unneeded DBus roundtrip

This revision was automatically updated to reflect the committed changes. Closed by commit R116:eec18ad4f337: Save unneeded DBus roundtrip (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28698?vs=79689=79711

D28688: Document Kirigami::Icon

cblack planned changes to this revision. cblack added a comment. Those `@include`s aren't resolving properly, will fix REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28688 To: cblack, #kirigami Cc: broulik, nicolasfella, plasma-devel, fbampaloukas, GB_2, domson,

D28703: Make KAccess a regular startup application

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please double check wayland startup is ok. The kcminit had a X-KDE-OnlyShowOnQtPlatforms=xcb; guard Orca situation should be fine

D25569: Also overwrite document.createElement using exportFunction

This revision was automatically updated to reflect the committed changes. Closed by commit R856:c2fba76125f4: Also overwrite document.createElement using exportFunction (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25569?vs=70439=79717#toc REPOSITORY R856

D28383: Add PageRouter component

cblack planned changes to this revision. cblack added a comment. `@include` not resolving, will fix REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28383 To: cblack, #kirigami, mart, davidedmundson Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2,