D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29687 To: ahmadsamir, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf,

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in iconapplet.cpp:435 > But why would `serviceByStorageId` work then? > Looks like this needs to be `KService::Ptr(new KService(m_localPath))` then? According to the kservice docs KService::serviceByStorageId() param is "the

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir updated this revision to Diff 82943. ahmadsamir added a comment. Address comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29687?vs=82714=82943 BRANCH l-krun-port (branched from master) REVISION DETAIL

D28873: Add SwipeNavigator component

mart added a comment. yes, that screenshot is really broken. to me is important that the tabbar tries to take all the space available before doing any eliding. Probably whether starting to elide a lot and make the tabs actually scrollable, will depend case by case depending fro mthe app

D29726: BookmarksRunner: Change caching databases

alex added inline comments. INLINE COMMENTS > meven wrote in fetchsqlite.cpp:87 > We might want to reuse database connection as long as the databaseFile did > not change I will do that in a follow up patch :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.14 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.14/8/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 15 May 2020 14:51:41 + Build duration: 59 sec and counting CONSOLE OUTPUT [...truncated 258

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

This revision was automatically updated to reflect the committed changes. Closed by commit R126:424217083a8c: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob (authored by broulik). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 15 May 2020 14:51:41 + Build duration: 52 sec and counting CONSOLE OUTPUT [...truncated

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

mart added a comment. In D29462#668542 , @mart wrote: > the different Units.qml depend from the style, QT_QUICK_CONTROLS_STYLE > all of them, including those in plasma-framework should be updated at once @Zren can you do diffs for the

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

broulik added inline comments. INLINE COMMENTS > ahmadsamir wrote in iconapplet.cpp:435 > I tried that first, and it doesn't work; those .desktop files are in a > ~/.local/share/plasma_icons, ksycoca doesn't know about that location. But why would `serviceByStorageId` work then? Looks like

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in iconapplet.cpp:435 > but "desktop file path" is what we're doing. what I believe is happening that > you're actually launching the original file, not the one the icon uses. I tried with: KService::Ptr service =

D29694: Introduce Avatar component

mart added a comment. I would like this class to be splitted in Templates/controls, so different styles could make it look slightly sifferent (or anyways easier for the app developer to make one that looks just slightly different) the root component should be a Control, with

D29726: BookmarksRunner: Change caching databases

alex updated this revision to Diff 82946. alex added a comment. Use enum for caching return type REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29726?vs=82790=82946 BRANCH avid_unnecessary_copying (branched from master) REVISION DETAIL

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

broulik updated this revision to Diff 82950. broulik added a comment. - Drop manual startup stuff - Drop C stuff REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29621?vs=82500=82950 REVISION DETAIL https://phabricator.kde.org/D29621 AFFECTED

D29765: Add a blurless SDDM theme

mart added a comment. In D29765#671426 , @filipf wrote: > > I'm not keen on duplicating the entire theme for a single option. > > I would also prefer to just have it as an option, but turning off blur requires several workarounds to ensure

D27595: Watch for language change events, and forward those to the QML engine

broulik added a comment. Is there no better way to do this? e.g. the KWin Rules KCM spends 20% of its startup time in "retranslate" :/ REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27595 To: vkrause, mart Cc: davidedmundson, broulik, rikmills, ngraham, apol,

D29726: BookmarksRunner: Change caching databases

alex added inline comments. INLINE COMMENTS > meven wrote in chrome.cpp:55 > Might as well check the returned value for error If this fails only the icons are affected and the default icon will be displayed, this case will be handled in the FetchSqlite class > meven wrote in

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

broulik added inline comments. INLINE COMMENTS > ahmadsamir wrote in iconapplet.cpp:435 > According to the kservice docs KService::serviceByStorageId() param is > "the storage id or desktop-file path of the service", so I guess that's why > it works. but "desktop file path" is what

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.14 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.14/37/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 15 May 2020 15:29:41 + Build duration: 4 min 30 sec and counting JUnit

D29694: Introduce Avatar component

cblack updated this revision to Diff 82961. cblack added a comment. Unsplit template and control for documentation purposes REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29694?vs=82957=82961 BRANCH cblack/avatar (branched from master) REVISION DETAIL

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

Zren added a comment. > The `plasma-framework` patch is D29463 Ran my KirigamiDevicePixelRatioTest.qml with `QT_QUICK_CONTROLS_STYLE=Plasma`, `/usr/.../styles/org.kde.desktop`, `/usr/.../styles/org.kde.desktop.plasma`, and `/usr/.../Kirigami.2`.

D29784: Hardcode less colorSets

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Now the tiny toolbar above the sidebar is a different color from the one beside it: F8323489: Screenshot_20200515_105617.png It's

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 82965. cblack added a comment. Improve the small toolbar REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=82962=82965 BRANCH cblack/lateral (branched from master) REVISION DETAIL

D29726: BookmarksRunner: Change caching databases

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me REPOSITORY R120 Plasma Workspace BRANCH avid_unnecessary_copying (branched from master) REVISION DETAIL https://phabricator.kde.org/D29726 To: alex, #plasma,

D29726: BookmarksRunner: Change caching databases

alex updated this revision to Diff 82954. alex added a comment. Adjust docstring for Browser::updateCacheFile REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29726?vs=82946=82954 BRANCH avid_unnecessary_copying (branched from master) REVISION

D29694: Introduce Avatar component

cblack updated this revision to Diff 82957. cblack marked 3 inline comments as done. cblack added a comment. Split into a template; make borders customisable REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29694?vs=82783=82957 BRANCH cblack/avatar

D29694: Introduce Avatar component

cblack added inline comments. INLINE COMMENTS > mart wrote in Avatar.qml:52 > enum values should be written and explained here F8323278: ksnip_20200515-114734.png Unfortunately; splitting into a template throws documentation out of the window; which is

D29784: Hardcode less colorSets

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY We were overriding them on the background only and it would play weird with the feature where the

D28873: Add SwipeNavigator component

ngraham added a comment. Looking fine. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol,

D29694: Introduce Avatar component

cblack added inline comments. INLINE COMMENTS > mart wrote in kirigamiplugin.cpp:259 > I don't like this, as even tough is called "private" is really public api as > there isn't really any way to make a c++ type not accessible. > nothing in that c++ class seems really to be necessary to be c++

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 82962. cblack added a comment. Rebase on master REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=80804=82962 BRANCH cblack/lateral (branched from master) REVISION DETAIL https://phabricator.kde.org/D28873

D29784: Hardcode less colorSets

ngraham added a comment. Fixed the Kirigami half of this in D29785 . Just address the inline comment and then this is good to go! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29784 To: apol, #plasma, ngraham

D29765: Add a blurless SDDM theme

ngraham added a comment. I agree, I think we need to come up with some infrastructure to allow SDDM themes to display user-visible settings. Even though this new theme is mostly symlinks, duplicating `main.qml` is uglier and less nice maintenance-wise then putting conditions in it. Also

D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. So much better REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29770 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, Orage,

D29785: Always use Window colorset for AbstractApplicationHeader

ngraham created this revision. ngraham added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY ...Otherwise when an `AbstractApplicationHeader` is used on a page that overrides the

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Thanks for your work. Will re-review soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon updated this revision to Diff 82966. kurmikon added a comment. Diff updated to a better version. So, I'm explaining what happens here. A RowLayout is placed where the old slider was. This contains a new slider and an additional spinbox. The spinbox gets float values by the

D29781: Fix importing key-direction from *.ovpn files

ouwerkerk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. ouwerkerk requested review of this revision. REVISION SUMMARY It is possible for key-direction to be specified *after* . Previously the code always

D29780: Detach sensor shell agent from terminal

jpalecek created this revision. jpalecek added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. jpalecek requested review of this revision. REVISION SUMMARY When I run ksysgruard from a terminal, I found out it doesn't connect to remote hosts' sensors (tried with localhost,

D29765: Add a blurless SDDM theme

filipf abandoned this revision. filipf added a comment. Yeah on second thought this is ugly from a maintenance POV. We'd need a GUI sheet that exposes theme.conf and then blur would be one option. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29765 To:

D29603: Adds custom spacing between task manager icons

martellini updated this revision to Diff 82986. martellini added a comment. - Separates the Spacing setting from the others REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29603?vs=82983=82986 BRANCH adjustable-spacing-between-icons (branched from

D29603: Adds custom spacing between task manager icons

martellini added a comment. It should be a little better now, but I left out 2 of the things we said: - I didn't remove the icon size setting from the configuration of the vertical task manager because maybe someone likes small icons when the panel is by the side - I left the spacing

D29603: Adds custom spacing between task manager icons

martellini updated this revision to Diff 82983. martellini added a comment. - Makes icon scale linearly to the size of the taksbar - Improved the spacing configuration of the taskbar icons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29744: [Kicker] Fix jump list actions in RunnerMatchesModel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9e545131faa9: [Kicker] Fix jump list actions in RunnerMatchesModel (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29765: Add a blurless SDDM theme

broulik added a comment. Can we perhaps add infrastructure so that a theme can provide options? For instance, the look and feel package can add options to the lock screen KCM which we use for e.g. "always show clock" and "show media controls". I'm not keen on duplicating the entire theme

D29771: [Notifications] Don't take updated time into account for sorting

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Notification spec says, when replacing a notification: > The server must atomically (ie with

D29760: Replace MapProxySource with some javascript code

This revision was automatically updated to reflect the committed changes. Closed by commit R111:1d8f9a9024c0: Replace MapProxySource with some javascript code (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D29140: Show POTD in lock screen

guoyunhe added a comment. Maybe it is some unknown Qt bug. You can try set wallpaper as Flickr POTD and check if you have `~/.cache/plasmashell/plasma_engine_potd/flickr` saved. Anyway, for photos, JPEG makes more sense than PNG. For the leaks, I really have no idea. (also asked some

D29765: Add a blurless SDDM theme

filipf added a comment. In D29765#671401 , @broulik wrote: > Can we perhaps add infrastructure so that a theme can provide options? > For instance, the look and feel package can add options to the lock screen KCM which we use for e.g. "always

D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This refactors the free space notifier module to use a critical (i.e. persistent and always

D29760: Replace MapProxySource with some javascript code

broulik added inline comments. INLINE COMMENTS > SensorFace.qml:49 > +result = [] > +for (var sensor of root.controller.highPrioritySensorIds) { > +result.push(root.controller.sensorColors[sensor]) To match "Map"proxy source could have done ;) const

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.14 - Build # 36 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.14/36/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 15 May 2020 09:36:48 + Build duration: 30 sec and counting CONSOLE OUTPUT