Review Request: Code review for the newspaper containment

2011-06-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101543/ --- Review request for Plasma. Summary --- While tracking down some

Review Request: Add some introspection to the Plasma::AbstractRunner

2012-01-17 Thread Aleix Pol Gonzalez
to access some Runner description features. Diffs - plasma/abstractrunner.h 9e30d46 Diff: http://git.reviewboard.kde.org/r/103718/diff/diff Testing --- Tried it locally on a test application I've created, there's not much to test. Thanks, Aleix Pol Gonzalez

Review Request: Add accepted signal to TextField

2012-01-26 Thread Aleix Pol Gonzalez
--- Tested locally in a small application. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add accepted signal to TextField

2012-01-26 Thread Aleix Pol Gonzalez
8654033 Diff: http://git.reviewboard.kde.org/r/103795/diff/diff Testing --- Tested locally in a small application. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Improve the QML RunnerModel

2012-01-27 Thread Aleix Pol Gonzalez
/qmlrunner.ogv Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Improve the QML RunnerModel

2012-01-29 Thread Aleix Pol Gonzalez
--- On Jan. 27, 2012, 6:06 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103806/ --- (Updated Jan. 27

Re: Review Request: Improve the QML RunnerModel

2012-02-07 Thread Aleix Pol Gonzalez
-qml (proof of concept for a KRunner implemented in QtQuick). here's a video, so that you know what's going on: http://www.proli.net/meu/netrunner/qmlrunner.ogv Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: Improve the QML RunnerModel

2012-02-11 Thread Aleix Pol Gonzalez
in QtQuick). here's a video, so that you know what's going on: http://www.proli.net/meu/netrunner/qmlrunner.ogv Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Use the same text color as C++ Plasma::LineEdit

2012-06-06 Thread Aleix Pol Gonzalez
http://git.reviewboard.kde.org/r/105159/#comment11398 Wouldn't textColor be better than buttonTextColor? The TextField doesn't have the a button background! - Aleix Pol Gonzalez On June 6, 2012, 10:55 a.m., Aurélien Gâteau wrote

Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support

2012-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105673/#review16243 --- I don't see the patch...? - Aleix Pol Gonzalez On July 22

Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support

2012-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105673/#review16244 --- I don't see the patch...? - Aleix Pol Gonzalez On July 22

Review Request: Don't warn when using a page without toolbar

2012-07-31 Thread Aleix Pol Gonzalez
--- Changed it and ran discover again, everything worked fine. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Polishing ScrollBar

2012-07-31 Thread Aleix Pol Gonzalez
Diff: http://git.reviewboard.kde.org/r/105808/diff/ Testing --- Played around with http://proli.net/meu/kde/testcase.qml Also made sure it fixes my issue in ktp-text-ui Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel

Review Request: Mouse hover effect on ListItem

2012-08-08 Thread Aleix Pol Gonzalez
/ListItem.qml 8511a26 Diff: http://git.reviewboard.kde.org/r/105939/diff/ Testing --- played with muon discover a bit Screenshots --- a hovered item http://git.reviewboard.kde.org/r/105939/s/668/ Thanks, Aleix Pol Gonzalez

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/#review17153 --- On Aug. 9, 2012, 12:08 a.m., Aleix Pol Gonzalez wrote

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Aleix Pol Gonzalez
. 9, 2012, 12:08 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/ --- (Updated Aug. 9, 2012

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/105939/#review17158 --- On Aug. 9, 2012, 12:08 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Aleix Pol Gonzalez
becomes necessary Aleix Pol Gonzalez wrote: a) If ListItem.enabled is false, then the mouse area will be disabled. So there will be not such effect. b) why? the behavior should be the same, no? Marco Martin wrote: there isn't the concept of mouseover there, since you don't see

Review Request: Improve ProgressBar display

2012-08-10 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/105966/s/669/ after http://git.reviewboard.kde.org/r/105966/s/670/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Improve ProgressBar display

2012-08-10 Thread Aleix Pol Gonzalez
/kdeqmlviewer + http://proli.net/meu/kde/testprogress.qml Screenshots --- before http://git.reviewboard.kde.org/r/105966/s/669/ after http://git.reviewboard.kde.org/r/105966/s/670/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list

Re: Review Request: Improve ProgressBar display

2012-08-10 Thread Aleix Pol Gonzalez
+ http://proli.net/meu/kde/testprogress.qml Screenshots (updated) --- before http://git.reviewboard.kde.org/r/105966/s/669/ after http://git.reviewboard.kde.org/r/105966/s/671/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list

Re: Review Request: Improve ProgressBar display

2012-08-15 Thread Aleix Pol Gonzalez
: http://git.reviewboard.kde.org/r/105966/#review17495 --- On Aug. 10, 2012, 4:12 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http

Review Request: Make it possible to have a QAbstractItemModel as a property

2012-08-29 Thread Aleix Pol Gonzalez
/declarativeimports/core/datamodel.h cf82648 plasma/declarativeimports/core/datamodel.cpp 00108b1 Diff: http://git.reviewboard.kde.org/r/106267/diff/ Testing --- Plasma::SortFilterModel didn't stop working. Thanks, Aleix Pol Gonzalez ___ Plasma

Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aleix Pol Gonzalez
is interested I can provide it too. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aleix Pol Gonzalez
--- On Aug. 30, 2012, 8:17 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aleix Pol Gonzalez
tested it with a QML example I had with KPeople. If anybody is interested I can provide it too. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
it with a QML example I had with KPeople. If anybody is interested I can provide it too. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
--- On Aug. 31, 2012, 7:53 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18325 --- On Aug. 31, 2012, 7:53 a.m., Aleix Pol Gonzalez wrote

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
tested it with a QML example I had with KPeople. If anybody is interested I can provide it too. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make it possible to use Tree models from QML

2012-08-31 Thread Aleix Pol Gonzalez
has a good idea? SimplifierProxyModel? ListProxyModel? - Aleix Pol Gonzalez On Aug. 31, 2012, 3:45 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272

Re: Review Request: Make it possible to use Tree models from QML

2012-09-03 Thread Aleix Pol Gonzalez
visualdatamodel can't be used in conjunction with other proxies, since doesn't inherit from qaim Aleix Pol Gonzalez wrote: I already tried that, but I didn't like it because it provides an API that suggests that mapFrom/ToSource will work. Also reducing those won't help much

Re: Review Request: Make it possible to use Tree models from QML

2012-09-03 Thread Aleix Pol Gonzalez
-CREATION Diff: http://git.reviewboard.kde.org/r/106272/diff/ Testing --- There's a passing unit test, albeit limited. I also tested it with a QML example I had with KPeople. If anybody is interested I can provide it too. Thanks, Aleix Pol Gonzalez

Review Request: Make it possible to configure a wallpaper from the viewer

2012-09-18 Thread Aleix Pol Gonzalez
/main.cpp ea3c5d4 plasma/generic/tools/wallpaperviewer/wallpaperwidget.h 0f387a5 Diff: http://git.reviewboard.kde.org/r/106495/diff/ Testing --- I ran it and seemed to work Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel

Re: Review Request: add preview thumbnail at color wallpaper config dialog

2012-10-02 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/106626/#comment15723 Shouldn't the ItemsView be in some kind of common place? I probably should be using it in Animated Wallpapers as well... - Aleix Pol Gonzalez On Oct. 2, 2012, 11:48 a.m., Reza Shah wrote

Re: Review Request: add preview thumbnail at color wallpaper config dialog

2012-10-02 Thread Aleix Pol Gonzalez
On Oct. 2, 2012, 2:20 p.m., Aleix Pol Gonzalez wrote: plasma/generic/wallpapers/color/itemsview.h, line 1 http://git.reviewboard.kde.org/r/106626/diff/2/?file=88122#file88122line1 Shouldn't the ItemsView be in some kind of common place? I probably should be using

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-03 Thread Aleix Pol Gonzalez
/plasmacomponents/qml/Button.qml http://git.reviewboard.kde.org/r/106717/#comment15779 unneeded change :) - Aleix Pol Gonzalez On Oct. 3, 2012, 10:01 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply

Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Aleix Pol Gonzalez
/ Testing --- just messed with it for a while. Screenshots --- result http://git.reviewboard.kde.org/r/106768/s/758/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Aleix Pol Gonzalez
/106768/#review20087 --- On Oct. 8, 2012, 3:43 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106768

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Aleix Pol Gonzalez
screen estate. Marco Martin wrote: another idea would be just show the screen saver part only when the screensaver radio is selected (i kept it a bit that way before merging btw, seemed a bit flashy..) Aleix Pol Gonzalez wrote: I agree. On the other hand, showing new dialogs it's

Review Request: Add tooltips to the screensavers KCM

2012-10-15 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/106876/s/778/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Port QDialog to KDialog

2012-11-06 Thread Aleix Pol Gonzalez
the opposite direction we want to go with KF5? - Aleix Pol Gonzalez On Nov. 6, 2012, 8:33 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107230

Review Request: Reduce verbosity when running a QML-based plasmoid

2012-11-08 Thread Aleix Pol Gonzalez
was flooded by those. Diffs - plasma/widgets/declarativewidget.cpp 3176073 Diff: http://git.reviewboard.kde.org/r/107261/diff/ Testing --- I ran org.kde.graphsplasmoid before patching and I got many warnings. After patching I didn't get those. Thanks, Aleix Pol Gonzalez

Review Request: Remove unneeded code

2012-11-16 Thread Aleix Pol Gonzalez
--- AFAIK, this code is not doing much, so it can be removed. Diffs - lib/bodega/installjobsmodel.h b5452d4 lib/bodega/installjobsmodel.cpp f69ba16 Diff: http://git.reviewboard.kde.org/r/107342/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Review Request: Reduce runtime warnings

2012-11-19 Thread Aleix Pol Gonzalez
bd55c6a Diff: http://git.reviewboard.kde.org/r/107379/diff/ Testing --- Installed and ran again Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: adjust qml wallpaper setting dialog and make it's color button remember previous value

2012-11-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107532/#review22819 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 30, 2012, 1

Re: Review Request: show notification summary for last popup notification

2012-12-16 Thread Aleix Pol Gonzalez
, since the sender is in there. I have no idea if it's the same case for other programs, though.. - Aleix Pol Gonzalez On Dec. 15, 2012, 9:17 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: show notification summary for last popup notification

2012-12-16 Thread Aleix Pol Gonzalez
On Dec. 16, 2012, 10:09 p.m., Kai Uwe Broulik wrote: plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, line 181 http://git.reviewboard.kde.org/r/107743/diff/1/?file=99464#file99464line181 Seems to have no effect here, and font shouldn't be bold since it

Review Request: Don't add qml elements twice to the scene, reduce warnings

2013-01-02 Thread Aleix Pol Gonzalez
. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix initial size when --size is passed

2013-01-02 Thread Aleix Pol Gonzalez
and saw that it works. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

2013-01-03 Thread Aleix Pol Gonzalez
? setMaximum/MinimumSize shouldn't be used like that either... Have you considered using the designer to make the ui, instead? - Aleix Pol Gonzalez On Jan. 3, 2013, 2:15 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically

Review Request: Translate \n into br/ for error messages

2013-01-03 Thread Aleix Pol Gonzalez
. Then ran a plasmoid that has an error message from the plasmoidviewer. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Use \n to split QML errors

2013-01-03 Thread Aleix Pol Gonzalez
32ee191 Diff: http://git.reviewboard.kde.org/r/108124/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

2013-01-03 Thread Aleix Pol Gonzalez
:) the code is looking much nicer now. Removing code feels right. ^^ Especially if you're not dropping functionality - Aleix Pol Gonzalez On Jan. 3, 2013, 8:13 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail

Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

2013-01-06 Thread Aleix Pol Gonzalez
the parenthesis but I'd say it's good to have the label, since when there's some text you can't read the placeholder. I think the code is better now and it should get in, I'll mark as Ship It although I understand I don't have much of a say in this code. :) - Aleix Pol Gonzalez On Jan. 5, 2013, 4:18 p.m

Re: Review Request: Show album art in krunner results.

2013-01-10 Thread Aleix Pol Gonzalez
On Jan. 10, 2013, 10:12 p.m., Vishesh Handa wrote: runners/audioplayercontrol/audioplayercontrolrunner.cpp, line 510 http://git.reviewboard.kde.org/r/108316/diff/1/?file=106229#file106229line510 How about using 'toUrl().toLocalFile()' instead? That will remove the file prefix.

Re: Review Request: Show album art in krunner results.

2013-01-10 Thread Aleix Pol Gonzalez
. Emil Sedgh wrote: Done, thank you. Aleix Pol Gonzalez wrote: In this case it's better to use pathOrUrl, in case it's actually a url. Or that can't happen? Ugh I see that you're passing to QIcon that won't handle that. Sorry. - Aleix

Review Request 108797: Small adjustments in KSMServer UI, fixed error that wouldn't reproduce in default plasma themes

2013-02-05 Thread Aleix Pol Gonzalez
Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-06 Thread Aleix Pol Gonzalez
. Diffs - plasma/declarativeimports/core/iconitem.cpp 765e7ed Diff: http://git.reviewboard.kde.org/r/108825/diff/ Testing --- After patching, ran discover again, without all the qWarnings. Thanks, Aleix Pol Gonzalez ___ Plasma-devel

Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/#review26828 --- On Feb. 7, 2013, 1:22 a.m., Aleix Pol Gonzalez wrote

Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-07 Thread Aleix Pol Gonzalez
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! Marco Martin wrote: ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable Aleix Pol Gonzalez wrote: Uh ok

Review Request 108863: Consider an empty (0x0) IconItem a valid item

2013-02-08 Thread Aleix Pol Gonzalez
/declarativeimports/core/iconitem.cpp a7e80e0 Diff: http://git.reviewboard.kde.org/r/108863/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108863: Consider an empty (0x0) IconItem a valid item

2013-02-08 Thread Aleix Pol Gonzalez
) - plasma/declarativeimports/core/iconitem.cpp a7e80e0 Diff: http://git.reviewboard.kde.org/r/108863/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 108922: Fix off-by-one error in RunnerModel

2013-02-15 Thread Aleix Pol Gonzalez
if you could run some interesting session with the ModelTest to catch this kind of issues ASAP, no? :) - Aleix Pol Gonzalez On Feb. 12, 2013, 3:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 108992: Simple optimizations in SignalPlotter

2013-02-17 Thread Aleix Pol Gonzalez
improvement. Mostly otherwise. Also I'd like to know how you measured this 5% of improvement, which either way I'm unsure if it's worth it considering that this patch makes everything global, now. - Aleix Pol Gonzalez On Feb. 17, 2013, 12:57 p.m., Raul Fernandes wrote

Review Request 109641: Fix border detection in Plasma dialogs

2013-03-21 Thread Aleix Pol Gonzalez
fine. Diffs - plasma/dialog.cpp 038444c Diff: http://git.reviewboard.kde.org/r/109641/diff/ Testing --- Played with it, together with the ktp-chat plasmoid Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-21 Thread Aleix Pol Gonzalez
e11269e Diff: http://git.reviewboard.kde.org/r/109648/diff/ Testing --- I was reproducing the problem regularly since a couple of days, then now I cannot reproduce anymore. There's no testing per se, though... Thanks, Aleix Pol Gonzalez ___ Plasma

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109648/#review29651 --- On March 21, 2013, 5:37 p.m., Aleix Pol Gonzalez wrote

Review Request 109699: Simplify the behavior of the main UI file in the chat plasmoid

2013-03-24 Thread Aleix Pol Gonzalez
sizes with plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess I have to debug other code to get around that. At least now it doesn't get as squeezed. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma

Review Request 109712: Make it possible to use action groups with QMenuItem

2013-03-25 Thread Aleix Pol Gonzalez
/declarativeimports/plasmacomponents/qmenuitem.cpp e8d590d Diff: http://git.reviewboard.kde.org/r/109712/diff/ Testing --- I have some code using it locally in muon. It works fine. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma

Re: Review Request 109712: Make it possible to use action groups with QMenuItem

2013-03-26 Thread Aleix Pol Gonzalez
169fd35 plasma/declarativeimports/plasmacomponents/qmenuitem.h 0f43418 plasma/declarativeimports/plasmacomponents/qmenuitem.cpp e8d590d Diff: http://git.reviewboard.kde.org/r/109712/diff/ Testing --- I have some code using it locally in muon. It works fine. Thanks, Aleix Pol Gonzalez

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-28 Thread Aleix Pol Gonzalez
se, though... Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 109947: KTp Chat plasmoid: Improve integration with hiding panels

2013-04-10 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/109947/diff/ Testing --- Self-conversation, as usual. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110382: Fix a crash that happens when you close some apps

2013-05-10 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/110382/#comment24040 note indentation is wrong here I've been using this patch since I commented in this bug, it's working fine (no crashes). - Aleix Pol Gonzalez On May 10, 2013, 12:57 p.m., Anne-Marie Mahfouf wrote

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/ --- (Updated May 14, 2013, 10:35 p.m.) Review request for kde-workspace and

Re: Review Request 101543: Code review for the newspaper containment

2013-07-29 Thread Aleix Pol Gonzalez
/appletscontainer.cpp 1ba4d83 Diff: http://git.reviewboard.kde.org/r/101543/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-06 Thread Aleix Pol Gonzalez
On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.h, line 112 http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112 This looks like it should be const I suspect it wasn't because KCoreConfigSeleton::findItem

Review Request 113086: KDeclarative cleanup

2013-10-03 Thread Aleix Pol Gonzalez
the module to its tier yet) Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41215 --- On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
, visit: http://git.reviewboard.kde.org/r/113086/#review41220 --- On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
as PlasmaWidgets I'm unsure what to do with those. (can do in a further commit, we're not moving the module to its tier yet) Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 113179: Make the runners compile again

2013-10-08 Thread Aleix Pol Gonzalez
, including kde-workspace. Couldn't test it, there's no tests for it or even an application to test it :/. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Aleix Pol Gonzalez
d5142a2 Diff: http://git.reviewboard.kde.org/r/113179/diff/ Testing --- Everything builds, including kde-workspace. Couldn't test it, there's no tests for it or even an application to test it :/. Thanks, Aleix Pol Gonzalez ___ Plasma-devel

Review Request 113345: Stop using Qt5Transitional in Plasma Frameworks

2013-10-18 Thread Aleix Pol Gonzalez
/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113345: Stop using Qt5Transitional in Plasma Frameworks

2013-10-21 Thread Aleix Pol Gonzalez
/scriptengines/javascript/CMakeLists.txt b339bbc Diff: http://git.reviewboard.kde.org/r/113345/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

2013-11-18 Thread Aleix Pol Gonzalez
/shellcorona.cpp 2519e29 Diff: http://git.reviewboard.kde.org/r/113920/diff/ Testing --- Builds, tests pass. I'm unsure what else to test. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

2013-11-19 Thread Aleix Pol Gonzalez
/appinterface.cpp 63196f9 src/shell/scripting/scriptengine.cpp 1250c20 src/shell/shellcorona.cpp 2519e29 Diff: http://git.reviewboard.kde.org/r/113920/diff/ Testing --- Builds, tests pass. I'm unsure what else to test. Thanks, Aleix Pol Gonzalez

Re: Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

2013-11-19 Thread Aleix Pol Gonzalez
/appinterface.cpp 63196f9 src/shell/scripting/scriptengine.cpp 1250c20 src/shell/shellcorona.cpp 2519e29 Diff: http://git.reviewboard.kde.org/r/113920/diff/ Testing --- Builds, tests pass. I'm unsure what else to test. Thanks, Aleix Pol Gonzalez

Review Request 114362: Properly place the panels in a multiscreen environment

2013-12-09 Thread Aleix Pol Gonzalez
--- Works on my system with 2 screens. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114362: Properly place the panels in a multiscreen environment

2013-12-09 Thread Aleix Pol Gonzalez
) - src/shell/panelview.cpp 2c80783 Diff: http://git.reviewboard.kde.org/r/114362/diff/ Testing --- Works on my system with 2 screens. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 114362: Properly place the panels in a multiscreen environment

2013-12-09 Thread Aleix Pol Gonzalez
- src/shell/panelview.cpp 2c80783 Diff: http://git.reviewboard.kde.org/r/114362/diff/ Testing --- Works on my system with 2 screens. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 114382: Reduce plasma warnings

2013-12-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114382/#review45485 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 10, 2013, 3

Re: Review Request 114683: Clean up target_link_libraries for KF5Plasma

2013-12-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114683/#review46193 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 27, 2013

Re: Review Request 114925: Add a new component ModelMenu

2014-01-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114925/#review47104 --- Maybe call it ModelContextMenu? - Aleix Pol Gonzalez

Review Request 115027: Port the share DataEngine from Kross to KJsEmbed

2014-01-15 Thread Aleix Pol Gonzalez
/share/shareservice.cpp 272a467 Diff: https://git.reviewboard.kde.org/r/115027/diff/ Testing --- I uploaded a paste with the half-ported plasmoid. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 115027: Port the share DataEngine from Kross to KJsEmbed

2014-01-21 Thread Aleix Pol Gonzalez
fc528f8 plasma/generic/dataengines/share/shareservice.h 9983292 plasma/generic/dataengines/share/shareservice.cpp 272a467 Diff: https://git.reviewboard.kde.org/r/115027/diff/ Testing --- I uploaded a paste with the half-ported plasmoid. Thanks, Aleix Pol Gonzalez

Review Request 115348: Create a MimeDatabase component that maps QMimeDatabase

2014-01-27 Thread Aleix Pol Gonzalez
/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp d3f8149 Diff: https://git.reviewboard.kde.org/r/115348/diff/ Testing --- Works on my WIP changes for the QuickShare (was pastebin) plasmoid. Thanks, Aleix Pol Gonzalez ___ Plasma-devel

Re: Review Request 115348: Create a MimeDatabase component that maps QMimeDatabase

2014-01-28 Thread Aleix Pol Gonzalez
) plasmoid. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 115475: Split KRunner out of plasma-framework

2014-02-04 Thread Aleix Pol Gonzalez
/115475/diff/ Testing --- Everything still builds. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-19 Thread Aleix Pol Gonzalez
to be this way. - Aleix Pol Gonzalez On Feb. 13, 2014, 10:14 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695

  1   2   3   4   5   6   7   8   9   10   >