D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-20 Thread Andrew Crouthamel
acrouthamel added a comment. Super nice, thanks! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10091: Combine source and version into a single piece of metadata

2018-02-21 Thread Andrew Crouthamel
acrouthamel added a comment. I would also change `Also available in` to `Also available:`, since adding the version number in front of the sentence doesn't flow correctly in English. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10091 To: ngraham,

D10756: Reduce sidebar width

2018-02-22 Thread Andrew Crouthamel
acrouthamel added a comment. I like it! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10756 To: ngraham, #discover_software_store, apol Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9414: Implement OSD to select action when unknown monitors is connected

2018-02-25 Thread Andrew Crouthamel
acrouthamel added a comment. Could this be implemented for bug 390096 ? Having the display button open this OSD would be an improvement over the current operation, in my opinion. REPOSITORY R104 KScreen REVISION DETAIL

D15011: [Kickoff] Make the search field always look like a search field

2018-08-31 Thread Andrew Crouthamel
acrouthamel added a comment. In D15011#314963 , @filipf wrote: > To add more to the analysis, since Kickoff is a plasmoid, what seemed like a good idea to me was to have a look at how other plasmoids are designed (especially with relevance to

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

2018-09-08 Thread Andrew Crouthamel
acrouthamel added a comment. Any movement on this? It would be great to use the dictionary in krunner. Still broken in 5.13.4. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14064 To: McPain, broulik Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

[ksystraycmd] [Bug 344168] there is no ksystray for plasma5

2018-09-04 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=344168 Andrew Crouthamel changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution

D15093: Add WireGuard capability.

2018-08-30 Thread Andrew Crouthamel
acrouthamel added a comment. Awesome feature, thank you for working on this! REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgrulich, pino Cc: acrouthamel, K900, anthonyfieroni, pino, lbeltrame, ngraham,

D15418: Dim application icon when it is not playing anything

2018-09-11 Thread Andrew Crouthamel
acrouthamel added a comment. I like it. I agree though to maybe make them a bit lighter. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D6313: WIP: Support device pixel ratio in icon loader and engine

2018-03-13 Thread Andrew Crouthamel
acrouthamel added a comment. Hey there, any movement on this? I've been submitting some patches to fix icon scaling in apps and have noticed how they switch from monochrome to colored (hires) versions when fixed. Getting the underlying issue fixed would be great as more people buy

D11876: Display star ratings

2018-04-04 Thread Andrew Crouthamel
acrouthamel added a comment. Yeah I like it without since they are already on separate cards. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store, #vdg Cc: ragreen, acrouthamel, plasma-devel, Pitel,

D11876: Display star ratings

2018-04-04 Thread Andrew Crouthamel
acrouthamel added a comment. I like the bigger stars, but then again I seem to increase font size and whatnot for a lot of things. REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store, #vdg Cc: fabianr, ragreen, acrouthamel, plasma-devel, Pitel,

D11631: Fix pixelated icon scaling for HiDPI screens

2018-03-24 Thread Andrew Crouthamel
acrouthamel added a comment. In D11631#232788 , @rkflx wrote: > @acrouthamel Awesome, you made it! Thanks to you and @broulik :) REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D11631 To: acrouthamel,

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. I'm just saying if you prefer colored over symbolic line art, that is something for #Breeze or #vdg to work out. Not that they are really taking advantage of anything. The bug

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. @ngraham and @hein, while I agree that in some instances I like the colored hi-res icons showing, this issue causes a mixture of icons to be displayed depending on the app. The examples here show a nice homogeneous selection of icons that change from A to B, so

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. I think both of us missed this part at the bottom of @broulik's description: > This way you designers can now create dedicated 2x SVGs for those usecases, ie. we can have a 16px icon as well as a 16px@2x icon rather than it just taking the 32px icon which

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. In D6313#238697 , @rkflx wrote: > In D6313#238605 , @acrouthamel wrote: > > > @2x-compatible > > > How will this work for 4x / 2.7x / 1.4x / etc. scaling? Of course

D11876: Display star ratings

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. Nice placement too. I really, really like how this looks. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store Cc: acrouthamel, plasma-devel, ragreen, Pitel, ZrenBot,

D11876: Display star ratings

2018-04-01 Thread Andrew Crouthamel
acrouthamel added a comment. Awesome patch! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store Cc: acrouthamel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-03 Thread Andrew Crouthamel
acrouthamel added a comment. @ngraham, in the initial description @broulik forced a @2x folder via symlink to test. Otherwise no change will be observed. :) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-03 Thread Andrew Crouthamel
acrouthamel added a comment. In D6313#239212 , @cfeck wrote: > In other words, the icon theme designer can now decide if he makes HiDPI only bigger or more detailed by symlinking to either the less detailed or the more detailed svg, without

D6313: Support Icon Scale from Icon naming specification 0.13

2018-03-16 Thread Andrew Crouthamel
acrouthamel added a comment. Thanks for working on this again, it really helps. :) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck,

D11631: Fixes pixelated icon scaling for HiDPI screens This enables HiDPI pixmaps in the main window. This commit also replaces QPixmap and KIconLoader with QIcon to load properly scaled icons in the

2018-03-23 Thread Andrew Crouthamel
acrouthamel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. acrouthamel requested review of this revision. TEST PLAN Open icon selection in main window. Expand tree menu and ensure selection works. REPOSITORY

D11003: Fix the Add Source dialog

2018-03-04 Thread Andrew Crouthamel
acrouthamel added a comment. Nice and clean! I like the change. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11003 To: ngraham, #discover_software_store, apol Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D15093: Add WireGuard capability.

2018-09-02 Thread Andrew Crouthamel
acrouthamel added a comment. In D15093#319245 , @andersonbruce wrote: > I'm not sure if the author or the reviewer is supposed to check the "Done" box on the inline comments but I think that I have addressed all the various comments made,

D15644: Bug 395349

2018-09-21 Thread Andrew Crouthamel
acrouthamel added a comment. Yeah I think that is a mistake. D42047 which precedes the current diff, makes much more sense. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

[Breeze] [Bug 367818] Password textfield is not visible when using dm-crypt

2018-09-26 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=367818 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew

[Powerdevil] [Bug 364138] Power Management Problem Kubuntu 16.04

2018-09-26 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=364138 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew

[Powerdevil] [Bug 370966] Battery not recognized

2018-09-26 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=370966 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew

[Breeze] [Bug 364313] Umbrello crash

2018-09-26 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=364313 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew

[plasmashell] [Bug 360339] Plasma Crash on startup

2018-09-26 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=360339 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Andrew Crouthamel
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f57460a61643: Add tooltips to krunner configure and close buttons (authored by slenz, committed by acrouthamel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Andrew Crouthamel
acrouthamel added a comment. In D15749#331860 , @ngraham wrote: > would you like to do the honors and land this for him, @acrouthamel? Yes boss... Always roping me into something new. :) REPOSITORY R120 Plasma Workspace REVISION

[Breeze] [Bug 346369] the password feild is not set to empty after wrong password attempt

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=346369 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #4 from Andrew

[Powerdevil] [Bug 334411] Screen Energy Saving timeout on dual-monitor system starting one after another with timeout delay

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=334411 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew

[Powerdevil] [Bug 341619] Screen Brightness does not change

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=341619 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew

[Plasma Workspace Wallpapers] [Bug 347532] preferencias de escritorio no permite establecer fondo de pantalla ni individual ni en presentacion solo las del sistenma

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=347532 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #5 from Andrew

[Powerdevil] [Bug 349226] battery updated not updated after suspend to memory

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=349226 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #5 from Andrew

[Breeze] [Bug 356902] Starters are visually indistinguishable from listed tasks in the task manager widget on breeze light

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=356902 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Andrew Crouthamel
acrouthamel accepted this revision. acrouthamel added a comment. Ooh my first time being added as reviewer. ;) REPOSITORY R120 Plasma Workspace BRANCH krunner-tootlips (branched from master) REVISION DETAIL https://phabricator.kde.org/D15749 To: slenz, #vdg, acrouthamel, ngraham Cc:

[Breeze] [Bug 350682] Double-click on GTK widgets initiates window movement, breaks control of the widget

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=350682 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #11 from Andrew

D15093: Add WireGuard capability.

2018-09-16 Thread Andrew Crouthamel
acrouthamel added a comment. Thank you @andersonbruce for all of your work on this, and quickly working on feedback changes! This will be a great addition. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma,

D15418: Dim application icon when it is not playing anything

2018-09-13 Thread Andrew Crouthamel
acrouthamel added a comment. In D15418#325344 , @broulik wrote: > All of that is reserved for being "Muted". Just because it doesn't play something doesn't mean it couldn't start producing sound any moment. > We shouldn't use anything that

D15418: Dim application icon when it is not playing anything

2018-09-13 Thread Andrew Crouthamel
acrouthamel added a comment. How about changing the volume icon for the non-playing application to `audio-volume-muted.svg`? Then, when it is playing audio, it reverts to low/high icons as usual, based on slider location. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

2018-09-27 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=349750 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #11 from Andrew

[kio-extras] [Bug 375826] Copying files to a remote SFTP folder opens a popup "Could not change permissions.."

2018-09-27 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=375826 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #2 from Andrew