D4220: Add a basic SNI for keyboard layout

bam added a comment. We are going to revert this in favor of https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/181: it supports all the existing functional here plus missing one (problem with short layout names was solved): - flags and/or short text for the layouts If

D4135: Split implementation of keyboard layout handling into a dedicated class

bam added inline comments. INLINE COMMENTS > keyboard_input.cpp:709 > m_modifiersChangedSpy->updateModifiers(modifiers()); > +m_keyboardLayout->checkLayoutChange(); > } I'm not quite follow the check here and whole processModifiers() method: it's occurs after client gets the modifiers

D4135: Split implementation of keyboard layout handling into a dedicated class

bam added inline comments. INLINE COMMENTS > bam wrote in keyboard_input.cpp:709 > I'm not quite follow the check here and whole processModifiers() method: > it's occurs after client gets the modifiers event, right? > But at this moment, the modifiers are already updated on server, isn't it? >

D4220: Add a basic SNI for keyboard layout

bam added a comment. Not a revert but rather rollback of SNI part: https://invent.kde.org/plasma/kwin/-/merge_requests/560 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4220 To: graesslin, #plasma_on_wayland, #kwin, davidedmundson Cc: bam, davidedmundson, luebking,

D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

bam added inline comments. INLINE COMMENTS > workspaceoptions_plasmasettings.kcfg:15 > + > + Display visual feedback for status changes > + true Also maybe worth to add: `Show a popup for status changes such as brightness or volume` At least it was in original patch. REPOSITORY

D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

bam added inline comments. INLINE COMMENTS > workspaceoptions_plasmasettings.kcfg:14 > + > + > + Display visual feedback for status changes Could we share it with the consumer of this setting itself in P-W? Currently it uses legacy way to access it's setting and thus can become out

D6628: Fix and normalize license in .desktop files

bam added a comment. > Starting version 2.0, it is no longer valid to use the + operator in a license identifier should we address it? https://en.wikipedia.org/wiki/Software_Package_Data_Exchange#Deprecated_syntax REPOSITORY R119 Plasma Desktop REVISION DETAIL

D6628: Fix and normalize license in .desktop files

bam added a comment. Thanks for clarifying. In D6628#676721 , @mak wrote: > So, this change looks fine to me now, as it is :-) And yet it was changed again! :-D

D22846: Port KeyboardLayout component to use generated DBus interface

bam added a comment. Does it mean we now have to manually synchronize DBus API here in .xml and on KWin side? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22846 To: davidedmundson, #plasma, broulik Cc: bam, plasma-devel, Orage, LeGast00n,

D22846: Port KeyboardLayout component to use generated DBus interface

bam added a comment. I wonder if we could "share" that .xml between server and client somehow.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22846 To: davidedmundson, #plasma, broulik Cc: meven, bam, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26719: [Battery Monitor] Glow icon on hover

bam added a comment. Nice. Could the same technique be applied for keyboardlayout applet? Currently, it glows a bit on hover when showing a flag icon only. No such affect when in text label mode. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26719 To:

make IDEs aware of the headers

Hi all, let me introduce my finding we probably want for all KDE's CMake-based projects eventually. The idea is, wherever we add a source files to a project, we should also add a headers alongside: |add_library(my_lib [STATIC|SHARED|MODULE] [source.cpp source.h ...]) add_executable(my_exe

Re: make IDEs aware of the headers

nuar 2023, 16:40:27 CET schrieb Andrey Butirsky: Other IDEs should benefit too. KDevelop (and I think Kate too) displays headers in "Project" view without this. I am not convinced of this amount of work (and cluttering of our CMake files) to workaround IDE/editor deficiencies. W