D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack added a comment. As requested by @apol, here is a screenshot of the menu with the new styling (I'm using a custom colorscheme currently, which is why the menu appears black in this screenshot). F6889655: image.png INLINE COMMENTS > filipf wrote

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59809. cblack removed a subscriber: ngraham. cblack added a comment. Remove unneeded property. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59808=59809 BRANCH better-session-menu (branched from

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59806. cblack added a comment. Menu border, less hardcoding, and moving the menu style into a seperate file to reduce duplicated code. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59803=59806

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59808. cblack added a comment. Tweak border coloration (steal it from Kirigami) and remove whitespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59806=59808 BRANCH better-session-menu (branched

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59803. cblack added a comment. Less harcoding & style keyboard button as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59771=59803 BRANCH better-session-menu (branched from master) REVISION

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack added a comment. @filipf Don't know but the answer is probably a no. INLINE COMMENTS > ngraham wrote in BreezeMenuStyle.qml:6 > Why does this have to be QQC1? 1. Styles are a QQC1 thing (QQC2 components can't take them) 2. The PlasmaComponents.ToolButton's `menu` property won't

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-14 Thread Carson Black
cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Components that used QQC1 in `sddm-theme/` (excluding the symlinked `components` folder) have

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59842. cblack added a comment. Looks like this change managed to hide from Arcanist's gaze. Should have been there in the first place. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=59841=59842

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack updated this revision to Diff 59880. cblack added a comment. Updates based off of feedback, and adding the standard menu fade animation to the QQC2 menus. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=59842=59880 BRANCH

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in SessionButton.qml:27 > Why the wrapper? QML files can only have one root, and the ToolButton's `menu` property doesn't accept QQC2 menus, meaning they have to be separated. REPOSITORY R120 Plasma Workspace REVISION

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > cblack wrote in SessionButton.qml:23 > The `menu` property seems to be removed in PC3 Additionally, `ToolButton` still seems to use QQC1 even in PC3.

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in SessionButton.qml:23 > Note that (confusingly) Plasma components 2 is QQC1 > Plasma components3 is QQC2 > > It might fix the menu issue The `menu` property seems to be removed in PC3 REPOSITORY R120 Plasma Workspace

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack updated this revision to Diff 59884. cblack added a comment. Use PC3 components in the kb & session buttons instead of PC2 components REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=59880=59884 BRANCH sddm-qqc2-port (branched

D21877: Hide tooltip when PrivateActionToolButton is pressed

2019-06-17 Thread Carson Black
cblack created this revision. cblack added reviewers: Plasma, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The tooltip used to remain even as the button was pressed, now it doesn't/shouldn't.

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-22 Thread Carson Black
cblack updated this revision to Diff 60379. cblack added a comment. - Change toolBtn to be more descriptive based on file the id was in - Styling changes on menus (they now have shadows) - Menu item highlight is tweaked as per T11124 (can revert if

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-22 Thread Carson Black
cblack added a comment. In D21815#482624 , @filipf wrote: > For positioning the menu maybe you could have a look at how it was done in Kickoff config window:

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-20 Thread Carson Black
cblack updated this revision to Diff 60136. cblack added a comment. - Remove Item {} root and embed QQC2.Menu {} in PlasmaComponents.ToolButton{} - If toolbutton is larger than largest menu item, resize menu to size of toolbutton - Other minor things REPOSITORY R120 Plasma Workspace

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-20 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > filipf wrote in SessionButton.qml:47 > While we're doing this, can you perhaps make the menu pop up *above* the > button? It seems that changing the `y` value doesn't affect its y position for whatever reason. REPOSITORY R120 Plasma Workspace

D22452: Fix text color in non-selected tabs in Firefox

2019-07-14 Thread Carson Black
cblack added a comment. I would probably replace `color: #eff0f1;` -> `color: t_color(text);` `background-color: #475057;` -> `background-color: t_color(background);` in `_firefox.scss` to not hardcode the colors REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack updated this revision to Diff 61756. cblack added a comment. This is why you shouldn't forget to test - default logo is now no longer pitifully small REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61755=61756 BRANCH

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack added a comment. In D22458#495455 , @ngraham wrote: > An interesting idea. Are you in contact with any distros that have requested this or would make use of it? This was created directly because an LCP (artwork dude) at openSUSE

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack updated this revision to Diff 61761. cblack added a comment. Logo has text now REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61756=61761 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack updated this revision to Diff 61774. cblack added a comment. Use units.longDuration REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61761=61774 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The Breeze SDDM theme now shows a logo that can be configured by distro vendors or curious users.

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-23 Thread Carson Black
cblack added a comment. In D20746#455012 , @ngraham wrote: > -snip- > Can you describe what it is that makes you want this functionality in the IOTM rather than just using the regular task manager and enabling this feature? The

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-22 Thread Carson Black
cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch removes the visible: property that hides the option to show only tasks that are minimized to users of the icons only task

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-16 Thread Carson Black
cblack updated this revision to Diff 61859. cblack added a comment. Remove sourceSize.width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61825=61859 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

2019-07-16 Thread Carson Black
cblack added a comment. Doesn't really matter to me ¯\_(ツ)_/¯ If other people want it off by default, I'll update the default theme.conf REPOSITORY R120 Plasma Workspace BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack,

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-13 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:80bcaaf483da: [GTK3 - Chrome/ium] Tweak tab stylings (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23080?vs=63661=63663 REVISION

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-13 Thread Carson Black
cblack updated this revision to Diff 63676. cblack added a comment. Tweak colors some more REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23079?vs=63515=63676 BRANCH firefox-csd-fix (branched from master) REVISION DETAIL

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62847. cblack added a comment. Incorporate feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62819=62847 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22845: [GTK3] Convert all colors to use GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62858. cblack added a comment. Fix some issues with incorrect colors being used REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62825=62858 BRANCH colordefs (branched from master) REVISION DETAIL

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62859. cblack added a comment. Dump the rest of the colors. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62847=62859 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Carson Black
cblack added a comment. In D22844#504691 , @davidre wrote: > It seems the header with the new flag is missing from the diff. I put it alongside the content in the existing `exportColors` flag because there's no reason to make a flag for

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-02 Thread Carson Black
cblack updated this revision to Diff 63009. cblack added a comment. Colors are now applied from the active colorscheme every time REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63001=63009 BRANCH kcm-colors-gtk (branched from master)

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-02 Thread Carson Black
cblack updated this revision to Diff 63001. cblack added a comment. Make GTK colors its own KRDB flag REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62859=63001 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-02 Thread Carson Black
cblack updated this revision to Diff 63010. cblack added a comment. Fix WM colors on first go round REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63009=63010 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-03 Thread Carson Black
cblack updated this revision to Diff 63025. cblack added a comment. Deduplicate colors exporting code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63010=63025 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-08-18 Thread Carson Black
cblack abandoned this revision. cblack added a comment. Change made here is being made in D23242 . Abandoning this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20746 To: cblack, #plasma, hein, #vdg Cc: broulik,

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black
cblack updated this revision to Diff 63515. cblack added a comment. Add background color to make SSD decorations more legible with patch REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23079?vs=63514=63515 BRANCH firefox-csd-fix (branched from

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black
cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This fixes the CSD colors of Firefox to be more legible, but not without some caveats due to upstream

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-10 Thread Carson Black
cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Tabs have had their colors changed to make it easier to tell which is active. REPOSITORY R98

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-11 Thread Carson Black
cblack updated this revision to Diff 63559. cblack added a comment. Add some extra colors + backdrop colors REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23080?vs=63516=63559 BRANCH chromium-tweaks (branched from master) REVISION DETAIL

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-13 Thread Carson Black
cblack updated this revision to Diff 63661. cblack added a comment. Change around the colors a bit REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23080?vs=63559=63661 BRANCH chromium-tweaks (branched from master) REVISION DETAIL

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-13 Thread Carson Black
cblack added a comment. I'm aware of the visibility issues of the window buttons on Breeze light CSD, however fixing those would require changes outside of the scope of this patch. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23080 To: cblack, #breeze,

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-08-17 Thread Carson Black
cblack updated this revision to Diff 63936. cblack added a comment. The new highlight style has been yeeted in favor of the current one REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=60379=63936 BRANCH arcpatch-D21815 REVISION DETAIL

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-08-21 Thread Carson Black
cblack updated this revision to Diff 64261. cblack added a comment. Unscrew indentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=64260=64261 BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/D21815 AFFECTED

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-08-21 Thread Carson Black
cblack updated this revision to Diff 64260. cblack added a comment. Add font.pointSize: config.fontSize REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=63936=64260 BRANCH arcpatch-D21815 REVISION DETAIL

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

2019-08-26 Thread Carson Black
cblack updated this revision to Diff 64698. cblack added a comment. DRY that code REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23451?vs=64606=64698 BRANCH window-button-symbolics (branched from master) REVISION DETAIL

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

2019-08-26 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:fa8e67c617f3: [GTK3] Recolor CSD titlebuttons according to users color scheme (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-03 Thread Carson Black
cblack updated this revision to Diff 65356. cblack added a comment. Removed checkbox for unused feature REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65355=65356 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-03 Thread Carson Black
cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Cuttlefish's UI got an overhaul. - Won't break if window width is different than expected. - Plasma components have been

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-29 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:7b3d0777ea6c: [GTK3] Have checkboxes and radiobuttons respect the users color scheme. (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D23560: [GTK3] Make CSD window decorations 18px instead of 16px

2019-08-29 Thread Carson Black
cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY As mentioned by @ndavis in D23547 , window buttons should be

D23560: [GTK3] Make CSD window decorations 18px instead of 16px

2019-08-29 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:523249683744: [GTK3] Make CSD window decorations 18px instead of 16px (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

2019-08-25 Thread Carson Black
cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Window titlebuttons on CSD windows now respect the user's colorscheme, preventing colorschemes

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack updated this revision to Diff 64900. cblack added a comment. Update based off of feedback REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64894=64900 BRANCH checks-and-radios (branched from master) REVISION DETAIL

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack updated this revision to Diff 64894. cblack added a comment. Change from hover color to focus color REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64893=64894 BRANCH checks-and-radios (branched from master) REVISION DETAIL

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Checkboxes and radiobuttons are now recolored according to the user's colour tastes. REPOSITORY

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack updated this revision to Diff 64906. cblack added a comment. Use provided SVGs REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64900=64906 BRANCH checks-and-radios (branched from master) REVISION DETAIL

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack updated this revision to Diff 64909. cblack added a comment. Fix the rest of those SVGs REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64906=64909 BRANCH checks-and-radios (branched from master) REVISION DETAIL

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack added a comment. In D23547#521615 , @ndavis wrote: > I should have been more clear, but I meant all of the checkbox and radio button SVGs. The SVGs I provided just did the most difficult changes and could be reused to create the other

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Carson Black
cblack updated this revision to Diff 65417. cblack added a comment. Give screenie button some text REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65401=65417 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Carson Black
cblack updated this revision to Diff 65483. cblack added a comment. Update based off of feedback REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65417=65483 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-04 Thread Carson Black
cblack updated this revision to Diff 65400. cblack marked an inline comment as done. cblack added a comment. Add changes based off of feedback, screenshot functionality REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65356=65400 BRANCH

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-04 Thread Carson Black
cblack updated this revision to Diff 65401. cblack added a comment. Wrap those strings with i18n() REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65400=65401 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Carson Black
cblack updated this revision to Diff 65505. cblack added a comment. Updates based off of feedback REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65483=65505 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-11 Thread Carson Black
cblack updated this revision to Diff 65874. cblack added a comment. Add colorscheme changer REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65530=65874 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-11 Thread Carson Black
cblack updated this revision to Diff 65875. cblack added a comment. Add option to take screenshot of both light/dark at once REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65874=65875 BRANCH modernization (branched from master) REVISION

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-11 Thread Carson Black
cblack updated this revision to Diff 65878. cblack added a comment. Return of the sidebar REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65877=65878 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-11 Thread Carson Black
cblack updated this revision to Diff 65876. cblack added a comment. Reorder menu items REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65875=65876 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-11 Thread Carson Black
cblack updated this revision to Diff 65877. cblack added a comment. Wording change REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65876=65877 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-11 Thread Carson Black
cblack updated this revision to Diff 65893. cblack added a comment. Sidebar updates REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65878=65893 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-11 Thread Carson Black
cblack updated this revision to Diff 65894. cblack added a comment. Port to QQmlApplicationEngine REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65893=65894 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-11 Thread Carson Black
cblack updated this revision to Diff 65895. cblack added a comment. Passive notification on clipboard copy REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65894=65895 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-12 Thread Carson Black
cblack updated this revision to Diff 65929. cblack added a comment. Substitute cuttlefish.close() for Qt.quit() REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65895=65929 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-14 Thread Carson Black
cblack updated this revision to Diff 66064. cblack added a comment. Padding and focus fixes REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65929=66064 BRANCH modernization (branched from master) REVISION DETAIL

D24009: RFC: Make Breeze Dark darker

2019-09-16 Thread Carson Black
cblack added a comment. Looks like an improvement to me. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24009 To: filipf, cblack, ndavis, #vdg, ngraham, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-09-16 Thread Carson Black
cblack added a comment. @davidedmundson any objections? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/D21815 To: cblack, #plasma, #vdg, davidedmundson, filipf Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n,

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-14 Thread Carson Black
cblack updated this revision to Diff 66092. cblack added a comment. Wrap text, add custom message handler to get rid of Qt SVG renderer spam REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66089=66092 BRANCH modernization (branched from

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-14 Thread Carson Black
cblack updated this revision to Diff 66093. cblack added a comment. Clean up commented code, colorscheme -> color scheme REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66092=66093 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-14 Thread Carson Black
cblack updated this revision to Diff 66070. cblack added a comment. Add global menu bar for users with a global menu bar. REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66064=66070 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-14 Thread Carson Black
cblack added a comment. In D23712#531076 , @ngraham wrote: > Ctrl+Q still doesn't work. QML shortcut type seems to not be firing regardless of where it's placed in the program. REPOSITORY R118 Plasma SDK REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-14 Thread Carson Black
cblack updated this revision to Diff 66088. cblack added a comment. Shortcut fixemups REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66087=66088 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-14 Thread Carson Black
cblack updated this revision to Diff 66089. cblack added a comment. Add a space REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66088=66089 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-14 Thread Carson Black
cblack updated this revision to Diff 66087. cblack added a comment. Begone, modality and hello remembering sizes REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66070=66087 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-14 Thread Carson Black
cblack added a comment. In D23712#531391 , @ngraham wrote: > Whoa, I just noticed someehing really weird happening: when I click on any of the comboboxes in the toolbar, the whole UI now darkens except for the combobox's popup. This effect

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Carson Black
cblack updated this revision to Diff 65530. cblack added a comment. Add 22 size to preview, and hardcode sizes since they shouldn't need to respect any settings. REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65505=65530 BRANCH

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Carson Black
cblack added a comment. In D23712#526852 , @ndavis wrote: > In D23712#526826 , @trickyricky26 wrote: > > > I love this patch, however I am curious as to why you moved the sidebar to the bottom. >

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Carson Black
cblack marked 18 inline comments as done. cblack added inline comments. INLINE COMMENTS > ngraham wrote in view.cpp:41 > Probably makes sense to reduce this to 600 if we can get the layout to adjust > adequately. There's already icon names that are too long for the minimum 800 width window,

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-17 Thread Carson Black
cblack added a comment. In D23712#532224 , @ngraham wrote: > Awesome. > > Didn't the main icon grid used to have a white background? I kind of liked that. Speaking of the icon grid, I'm somehow only not noticing that it's not sorted in any

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-17 Thread Carson Black
cblack added a comment. In D23712#533514 , @ngraham wrote: > I'm not sure it's working Should be working now REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-17 Thread Carson Black
cblack updated this revision to Diff 66346. cblack added a comment. Fix sorting, remove hardcoded icons REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66180=66346 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-17 Thread Carson Black
cblack updated this revision to Diff 66353. cblack added a comment. Background color of icons grid now uses view background color again REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66346=66353 BRANCH modernization (branched from master)

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-18 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > ngraham wrote in Menu.qml:33 > Add icon Seems to be a bug with the Qt.labs module, but this menu is just an extra (that's why it's loaded by a Loader instead of instantiated directly) so I wouldn't worry about it too much. > ngraham wrote in

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-18 Thread Carson Black
cblack updated this revision to Diff 66373. cblack added a comment. Add copyright to files that I touched a lot REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66353=66373 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-18 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R118:727fd286bca4: [Cuttlefish] Overhaul program, use Kirigami (authored by cblack). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66373=66409 REVISION

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Carson Black
cblack updated this revision to Diff 66177. cblack added a comment. Whole buncha stuff REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66093=66177 BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Carson Black
cblack updated this revision to Diff 66179. cblack added a comment. Shrink sidebar REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66178=66179 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Carson Black
cblack updated this revision to Diff 66178. cblack added a comment. Spacing fixes REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66177=66178 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712

  1   2   >