[Breeze] [Bug 375909] New: Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

https://bugs.kde.org/show_bug.cgi?id=375909 Bug ID: 375909 Summary: Breeze SDDM wallpaper was reset in KDE Neon 5.9 update Product: Breeze Version: 5.9.0 Platform: Neon Packages OS: Linux Status: UNCONFIRMED

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

https://bugs.kde.org/show_bug.cgi?id=375909 --- Comment #2 from Chris Holland --- Huh you're right David. Just checked that it's still blue by opening a new session. I didn't actually check to see if the theme.conf.user and wallpaper was deleted. Guess they might have just bee

[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

Zren added a comment. Any reason for not using if (...) { } else if (...) { } else { } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4551 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vishalrao Cc: Zren, d

[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

Zren added a comment. Ah, just noticed the title (bytes => bits), and I agree it should remain bytes, or at least be optional. > I proposed bits per second for network monitor only since users internet speeds are advertised/shown as "Mbps" or "Kbps" or the like. Do the math (divide

[Differential] [Updated] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. F2562978: 2017-02-23___17-03-39.png Looks like the icon is really small in plasmoidviewer? Just wondering why you used a IconItem+MouseArea pattern for the button instead of `PlasmaComponents.ToolButton`? The positioning

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. What DPI are you using SubDiff? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4751 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, drosca, Zren Cc: plasma-devel, progwo

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added inline comments. INLINE COMMENTS > drosca wrote in ListItemBase.qml:283 > Please move literal to right side of comparison: `PulseObject.ports.length > > 0` or even in this case you can just write `PulseObject.ports.length`. > > But actually make it `Ports.length` as said in previous

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added inline comments. INLINE COMMENTS > subdiff wrote in ListItemBase.qml:283 > > Please move literal to right side > > I like to read my inequalities from lower value to higher one. Easier to read > the code this way. Besides style is there something else speaking against > that? What @

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. I'm using the default DPI of 96. `PlasmaExtras.Heading { level: 5 }` is what's controlling the RowLayout height. Level 5 is just the `theme.defaultFont.pointSize` https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmaextracomponents/qml/Headi

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. I mentioned earlier: > Using Layout.maximumHeight: parent.height on the ToolButton will make it 18px tall, but will also make the icon tiny by default (because it keeps the padding). We can bypass this by anchoring a child IconItem. You need to anchor an IconIt

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. I did, there wasn't any change from when I tested it with `Layout.maximumHeight`, because there's padding around the icon. Huh, I didn't post a screenshot, here: F2657863: 2017-02-27___14-51-23.png https://github.com/KDE/

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. Ah! Sorry bout that, `/usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Controls/Styles/Plasma/ToolButtonStyle.qml` is different from what it shows in git. I copied the git source to that file, and while there was a bit of complaining about the stringlist => string bit, it

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. Oh crap. I just realized the stringlist => string error caused the svg not to load at all. Which means it wouldn't detect the margins from the svg. Essentially causing it to not add any "padding". If I copy "use anchors instead of fillHeight …"

[Differential] [Request, 10 lines] D4845: Fix context menu button's icon size when on default DPI

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ToolButton pads the contexts of the label+icon based on the desktop theme's svg margins. Causing the icon to only be 12px, which is scaled down a

[Differential] [Updated] D4845: Fix context menu button's icon size when on default DPI

Zren edited the summary of this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, subdiff, drosca, broulik Cc: plasma-devel, progwolff, lesliezhai,

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added inline comments. INLINE COMMENTS > drosca wrote in ListItemBase.qml:122 > Do we really need this (we certainly don't need the `parent.flat` part)? It > doesn't seem to change the icon at all. Not really. Just wanted to have consistent code with ToolButtonStyle, but I already had to

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added inline comments. INLINE COMMENTS > Zren wrote in ListItemBase.qml:122 > Not really. Just wanted to have consistent code with ToolButtonStyle, but I > already had to change `control` => `parent` so might as well remove it. > ToolButton is basically a `flat: true` Button so that part w

[Differential] [Updated, 10 lines] D4845: Fix context menu button's icon size when on default DPI

Zren updated this revision to Diff 11969. Zren added a comment. Remove `|| !parent.flat` REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4845?vs=11964&id=11969 REVISION DETAIL https://phabricator.kde.org/D4845 AFFECTED FILES applet/c

[Differential] [Updated] D4845: Fix context menu button's icon size when on default DPI

Zren marked 3 inline comments as done. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, subdiff, drosca, broulik Cc: plasma-devel, progwolff, lesliezhai, al

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added a comment. That's a good idea @broulik . Slider height for the Desktop themes I have installed (I used this script ): - air: 20px - Arctica: 24px - Arezzo: 24px - arquetype-dark: 24px - Bise: 24px - b

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added a comment. @davidedmundson: Yes. I usually test in plasmoidviewer since it's the same (except for emoji rendering ). I get the same effect because you're still trying to stuff a 16px icon into a 12px hole at 1x DPI (96). The origina

D4845: Fix context menu button's icon size when on default DPI

Zren added a comment. Ah, the `contextMenu.show(x, y)` changed to `contextMenu.show()`. I've got to comment out `roundToIconSize: false` in the mute "button" to test now since that probably requires a new version of frameworks. I changed the `slider.height` to `Layout.preferredHeight:

D4845: Fix context menu button's icon size when on default DPI

Zren updated this revision to Diff 12221. Zren added a comment. Fix merge conflict based on removal of x/y parameters in contextmenu.show() Change height from slider.height to units.iconSizes.small REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.

D4845: Fix context menu button's icon size when on default DPI

This revision was automatically updated to reflect the committed changes. Closed by commit R115:4d4867b89996: Fix context menu button's icon size when on default DPI (authored by Zren). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4845?vs=

Listening to a notification button's "onClick" in the notifications DataEngine

It seems the ActionInvoked and NotificationClosed signal isn't exposed anywhere. The signals are defined here: https://github.com/KDE/plasma-workspace/blob/master/dataengines/notifications/notificationsengine.h#L84 And the signals are called here: https://github.com/KDE/plasma-workspace/blob/mast

D5086: Applet: Add Raise maximum volume action to context menu

Zren added a comment. Looks good. F3126554: 2017-03-22___20-56-01.png There's one issue I want to point out that I dealt with, is that other instances of the widget won't be in the "raised" state (eg: other screens). Example: https://stream

T5412: Improve Plasma PA usability

Zren added a comment. Breeze's 16px small microphone-sensitivity-[low/medium/high] icons do not follow the color scheme. The 16px `-muted`, which is a softlink to the `mic-off.svg` icon is okay. This is because the `style="color:#4d4d4d;..."` which overrides the `fill:currentColor`. We'll ne

D5144: Change the volume icon/mute button into a ToolButton

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds a hover effect so the user knows it's a button. Unlike the application-menu button, I didn't add the smallSpacing around it so it'

T5412: Improve Plasma PA usability

Zren added a comment. I made https://phabricator.kde.org/D5144 which turns the volume icon/mute button into a ToolButton. TASK DETAIL https://phabricator.kde.org/T5412 To: Zren Cc: davidk, vpilo, Zren, broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, progwolff, lesliezhai, ali-moham

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Yeah, it's probably dpi scaling. And I didn't want to mess with the height of the ListItemBase. On further testing, it seems adding smallSpacing margins isn't as bad as I thought. Back and Forth Gif: https://streamable.com/0ld55 F3154040: 2017-03-23___11-12

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Ah, ignore the `visible: false` in that, was testing which variables ToolButton uses (iconSource. iconName). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5144 To: Zren, #plasma, subdiff, drosca Cc: subdiff, drosca, plasma-

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Another thing we could do to keep things small vertically is set `spacing: 0` in the `ColumnLayout { id: column }`. F3154383: 2017-03-23___11-50-47.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://pha

D5144: Change the volume icon/mute button into a ToolButton

Zren updated this revision to Diff 12746. Zren added a comment. Create a reusuble SmallToolButton class. Add smallSpacing around the mute button. Remove spacing between the two rows to counter the increase in height. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Before tackling the implicitWidth/height stuff, I noticed that my microphone's Heading label was getting moved on the first click. Adding `height: contextMenuButton.height` fixes it but that doesn't feel right. https://streamable.com/07hc0 REPOSITORY R115 Plasma

D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In TiledMenu, I need access to the localized home directories so I can link to the right folders in the bottom left area above the power icon.

D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths

Zren added a comment. Thought you might want that, but wasn't sure how to expose QStandardPaths to QML. Got an example handy? All I can find is: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmacomponents/enums.h https://github.com/KDE/plasma-framework/

D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths

Zren added a comment. Oh neat! Hmm experimental Qt 5.8 library is fine, but would it be installed by default on say KDE Neon or would it need a package to be manually installed? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5170 To: Zren, hein Cc: broulik,

D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths

Zren added a comment. And yes I know KDE Neon is Qt 5.7.1 at the moment, I meant to ask wither it's part of the standard install of Qt. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5170 To: Zren, hein Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-m

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. > I've seen that, but that is unrelated to this change, so please move it into separate review. Sorry. I hit a wall on that bug and it drove me crazy. I just found out that changing `spacing: 0` to `spacing: 1` will cause things to layout correctly the first time.

D5144: Change the volume icon/mute button into a ToolButton

Zren updated this revision to Diff 13070. Zren edited the summary of this revision. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5144?vs=12746&id=13070 REVISION DETAIL https://phabricator.kde.org/D5144 AFFECTED FILES applet/contents/u

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Should I go ahead and commit this? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5144 To: Zren, #plasma, subdiff, drosca Cc: mart, subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D5144: Change the volume icon/mute button into a ToolButton

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2ac365e96b70: Change the volume icon/mute button into a ToolButton (authored by Zren). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5144?vs=130

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

Zren created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I recently noticed that `Kirigami.Units.devicePixelRatio` was `1.3` even though I was at the default 96dpi when writing a widget's conf

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

Zren added a comment. > The `plasma-framework` patch is D29463 Ran my KirigamiDevicePixelRatioTest.qml with `QT_QUICK_CONTROLS_STYLE=Plasma`, `/usr/.../styles/org.kde.desktop`, `/usr/.../styles/org.kde.desktop.plasma`, and `/usr/.../Kirigami.2`.

D14105: Use a broom-style icon for clearing clipboard and notification history

Zren added a comment. Should the context menu also use this icon? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D14234: [Folder View] Improve file name text rendering

Zren added a comment. I tested the `x: -main.x % 1` code. Before: F6120560: 2018-07-19___13-46-20.png After: F6120562: 2018-07-19___13-47-29.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. Awesome! The KPackage patch will end up in... Frameworks 5.51? And the Plasma 5.14.0 release is set to depend on Frameworks... 5.45 (according to `plasma-workspace`'s `CMakeList.txt`). So we'll need to wait for the 5.14 tag to appear (Oct 4th), but to be safe, w

D15862: option to specify icons spacing for systray

Zren added inline comments. INLINE COMMENTS > main.qml:310 > id: tasksRow > -spacing: 0 > +spacing: plasmoid.configuration.iconsSpacing > height: parent.height - (vertical && expander.visible ? > expander.height : 0) Hmm. We might want to scale by DPI. While th

D15862: option to specify icons spacing for systray

Zren added inline comments. INLINE COMMENTS > Zren wrote in main.qml:310 > Hmm. We might want to scale by DPI. While the default 0px will not be > affected by DPI, if a Look And Feel sets it to 10px, it would look different > for users with 1x DPI and 2x DPI. > > Eg: > > spacing: plasmoid.c

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. Finally got around to updating this patch and formally testing with `kdesrc-build` (sort of) in Neon Unstable which has Frameworks 5.51. F6306500: screen-2018-10-05_16.35.50.mp4 Updated diff incoming as soon as I figure ou

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren updated this revision to Diff 42950. Zren added a comment. - Got rid of the signal+slot that emits KNewStuff changes since wallpaperComboBox is automagically updated. - Reordered the command arguments so the variable is last in `wallpaperplugin.knsrc`. - Put the `plasmoids.knsrc` and

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5e1b650859fe: Add wallpaperplugin.knsrc + QML function to open GHNS dialog (authored by Zren). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12040?vs=4295

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:347f43c42b70: Add "Get Wallpaper Plugins..." button to Config Desktop dialog (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12041?vs=3224

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. Sorry, just merged both to master. Thanks davidedmundson for the patches that updated the ComboBox. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12040 To: Zren, #plasma, davidedmundson Cc: ngraham, cfeck, mart, davidedmundson, plasm

D16327: Update libdbusmenuqt folder

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I needed to add `include(ECMQtDeclareLoggingCategory)` to the root `CMakeLists.txt` to get it to compile. https://github.com/KDE/pla

D16328: Saner config defaults

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Make sure the buttons have a dedicated place, filling the entire height of the panel rather than only 50%. We could probably limit the si

D16329: Add a ReadMe with install from Git instructions and bugzilla links

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY TODO: Figure out all the build dependencies. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabric

D16327: Update libdbusmenuqt folder

Zren added a comment. Yeah, I'm not 100% sure why the Active Window Control widget needs it. I assume it should be dynamically linking to the `/usr/lib/x86_64-linux-gnu/libdbusmenu-qt.so.2`, but I wanted to update all the common code first before making major refactoring. REPOSITORY R884

D16327: Update libdbusmenuqt folder

Zren added a comment. KNotifications provides an example of linking to `dbusmenu-qt5`: https://github.com/KDE/knotifications/blob/master/src/CMakeLists.txt#L46-L49 However REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D16327 To

D16394: Hide Buttons With Empty Text (Gtk Separators)

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Fixes issue #146 on GitHub: https://github.com/kotelnik/plasma-applet-active-window-control/issues/146 This is the same method the

D16327: Update libdbusmenuqt folder

Zren added a comment. For now, I'm going to merge this so I can keep the widget in sync with the global menu widget. We can revisit linking to a shared library later on. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D16327 To: Zren C

D16327: Update libdbusmenuqt folder

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R884:bb680e8dbfc2: Update libdbusmenuqt folder (authored by Zren). REPOSITORY R884 Active Window Control Applet for Pla

D16394: Hide Buttons With Empty Text (Gtk Separators)

This revision was automatically updated to reflect the committed changes. Closed by commit R884:942169541d33: Hide Buttons With Empty Text (Gtk Separators) (authored by Zren). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16394

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

https://bugs.kde.org/show_bug.cgi?id=304696 Chris Holland changed: What|Removed |Added CC||zrenf...@gmail.com --- Comment #14 from Chris

D16516: [cuttlefish] Auto-focus on search textfield when app opens

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. TEST PLAN Manually edited `/usr/share/plasma/packages/org.kde.plasma.cuttlefish/contents/ui/Tools.qml`, then launched cuttlefish. REPOSITORY R118 Plas

D16516: [cuttlefish] Auto-focus on search textfield when app opens

This revision was automatically updated to reflect the committed changes. Closed by commit R118:542388f984cf: [cuttlefish] Auto-focus on search textfield when app opens (authored by Zren). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16516?vs=7&id=444

D16516: [cuttlefish] Auto-focus on search textfield when app opens

Zren added a comment. In D16516#350641 , @ngraham wrote: > YES lol, that annoyed you too eh? It's been bugging me for ages. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D16516 To: Zren, ngraham Cc: ngraham,

D16516: [cuttlefish] Auto-focus on search textfield when app opens

Zren added a comment. - https://doc.qt.io/qt-5.11/qml-qtquick-shortcut.html - http://doc.qt.io/qt-5/qkeysequence.html#StandardKey-enum - http://doc.qt.io/archives/qt-4.8/qkeysequence.html#standard-shortcuts - `QKeySequence::Quit` - http://doc.qt.io/qt-5/qml-qtqml-qt.html#quit-method

D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY QML `Shortcut` requires Qt 5.5, so we bumped QtQuick to 2.5. https://doc.qt.io/qt-5.11/qml-qtquick-shortcut.html As discussed in

D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app

This revision was automatically updated to reflect the committed changes. Closed by commit R118:47e4fa8e5366: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app (authored by Zren). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16521?vs=44472&id=44

D15888: new icons (Breeze style)

Zren added a comment. We're currently trying to draw the C++ Breeze/forks window decorations in T9899 (and https://bugs.kde.org/show_bug.cgi?id=399757), which would make these SVGs obsolete. However we can merge these in the short term until that code is r

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Even when a user scours the system settings + desktop config looking how to disable this button, the user will have no indication this fe

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

Zren added a comment. That still requires the user to drag a button, which isn't exactly obvious or a normal behaviour, just to discover what it is. It doesn't look like a desktop widget, not that the user would recognize it as one, as KDE by default does not display any desktop widgets the

D18018: [Digital Clock] Add ability to change first day of week

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY CCBUG: 390330 The Qt enum can have Sunday value of 0 or 7, so we start the enum at -1 to represent the locale's default value.

D18019: [Digital Clock] Add ability to set a custom date format string

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Adds a new `dateFormatStr` config key which is used when the `dateFormat` "StringEnum" is set to `custom`. Shows a link to the Qt time

D18018: [Digital Clock] Add ability to change first day of week

Zren added a comment. In D18018#387920 , @davidedmundson wrote: > Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide? https://bugs.kde.org/show_bug.cgi?id=390330#c5 > Just c

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added inline comments. INLINE COMMENTS > configAppearance.qml:145 > +'name': "custom" > } > ] Does this also need a `i18nc("custom date format", "Custom")` translation context? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. In D18019#388811 , @ndavis wrote: > I'm leaning towards no, but a second link to text formatting documentation might be a good idea. Adding a second link is pretty easy, though I wrote this before I noticed your edi

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. In D18019#388829 , @ndavis wrote: > Shouldn't the documentation explain that apostrophes need to be used or is the fact that they need to be used unusual and specific to this clock widget? The time format docs mentio

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. The "show date" / "show seconds" toggles only affect the current widget instance as well. It would be nice if plasma had a `plasmoid.globalConfiguration.dateFormatStr` API which all widget instances (on all panels/screens) were bound to, so the user only had to configur

D18019: [Digital Clock] Add ability to set a custom date format string

Zren updated this revision to Diff 49137. Zren edited the summary of this revision. Zren added a comment. Translate the "Time Format Documentation" link. Add a link to QML's Text RichText docs under the "Color Format Documentation" label (translated). Place the 2 links below the text field

D18168: [WIP] [Digital Clock] Embed date formatting variable documentation

Zren created this revision. Zren added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Assuming D18019 is merged, this would: - Provides an

D18019: [Digital Clock] Add ability to set a custom date format string

Zren updated this revision to Diff 49332. Zren edited the summary of this revision. Zren edited the test plan for this revision. Zren added a comment. - Rename config key from `dateFormatStr` and config TextField `dateFormatTextField` to `customDateFormat`. - Remove the "Color Format Documen

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. > D18155 Looking at the alternative patch, I've renamed the config key variable to `customDateFormat`. Most of the differences stem from not using a "variant" data type for `DigitalClock.qml`'s `dateFormat` variable. The `string

D18019: [Digital Clock] Add ability to set a custom date format string

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:235fa8107dab: [Digital Clock] Add ability to set a custom date format string (authored by Zren). REPOSITORY R120 Pla

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. There was a few +1s, but I wasn't exactly sure who specifically "approves" this for a merge to `plasma-workspace` or `digital-clock` specifically. My bad, I shouldn't of left this feature to the last minute and felt rushed to get it in. I'll try to avoid the time before

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

Zren added a comment. I forgot to merge this after david's patch was merged. I just tested this in the Neon Beta ISO to confirm the fix still works. In D16093#359639 , @ngraham wrote: > Hmm, this does not actually work for me. Seems like it

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

This revision was automatically updated to reflect the committed changes. Closed by commit R114:80bd32b12a01: Consistent arrow key handling in the Informative Alt+Tab skin (authored by Zren). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16093?vs=43263&

D18696: Update `libdbusmenuqt` and the AppMenu plugin

Zren added inline comments. INLINE COMMENTS > CMakeLists.txt:27 > > -# add_subdirectory(test) > +add_subdirectory(test) We do not bundle the libdbusmenuqt test directory in this repo. So you need to comment this line out otherwise it will not build with the test directory missing. REPOSITOR

D18936: [weather] Fix weather Notices tab not showing

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY `Toronto, ON` in the `Env Canada` ion currently has a weather warning. The weather widget's code currently has a bug that will only show

D18936: [weather] Fix weather Notices tab not showing

Zren added a comment. I just noticed that the "Warnings Issued" text is left aligned. Might as well center align it while we're at it. Add this as a child of `PlasmaExtras.Heading` to debug: Rectangle { anchors.fill: parent; border.color: "#f00"; border.width: 1; color: "transpare

D18936: [weather] Fix weather Notices tab not showing

Zren updated this revision to Diff 51449. Zren edited the summary of this revision. Zren added a comment. Add `Layout.alignment: Qt.AlignHCenter` to the `PlasmaExtras.Heading` F6608836: 2019-02-11___17-47-22.png REPOSITORY R114 Plasma Addons CHANG

D18936: [weather] Fix weather Notices tab not showing

Zren added a comment. Note: Env Canada lists all their Warnings + Watches for all of Canada at https://weather.gc.ca/warnings/index_e.html should anyone need to test in the future. Is there any other Ion besides EnvCanada that currently displays "Warnings"? I can definitely push to

D18936: [weather] Fix weather Notices tab not showing

Zren added a comment. Ah, `NoticesView.qml` in Plasma 5.12 was slightly different. - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/

D18936: [weather] Fix weather Notices tab not showing

This revision was automatically updated to reflect the committed changes. Closed by commit R114:46204a5e2a84: [weather] Fix weather Notices tab not showing (authored by Zren). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18936?vs=51449&id=51455#toc REPOSITORY R114 Plasma Addons CHAN

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY If `plasmoid.nativeInterface.source != ""`, we copy it to `plasmoid.configuration.source` + same with all other properties besides `nee

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

Zren added a comment. In D18961#410792 , @kossebau wrote: > > we no longer have to install the widget to .../share/plasma/plasmoids/ > > No experience here, but do we not still need to install the QML extension plugins to have the applet work

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

Zren created this revision. Zren added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY In 12h system locales (eg: en_US), checked=1 is cast as Qt::PartiallyChecked=1 which defaults to the syst

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

Zren closed this revision. Zren added a comment. Shoot, I accidentally forgot the Phab Rev link in the commit message (though I remembered the bugzilla tags). I've setup a `.git/hook/prepare-commit-msg` -like thing for Sublime Text to p

D19174: [weather] envcan: Document urls for example data + list all warnings

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I can place this in the `ion_envcan.h` or the `ion_envcan.cpp`. It's not worth backporting so it'll get merged to master. REPOSITORY R

  1   2   3   >