plasma-desktop-5.10.5/kcms/kfontinst/kcmfontinst/FontList.cpp:1415: suspicious if ?

2017-08-26 Thread David Binderman
Hello there, plasma-desktop-5.10.5/kcms/kfontinst/kcmfontinst/FontList.cpp:1415]: (style) Same expression on both sides of '||'. Source code is if(!Misc::app(KFI_VIEWER).isEmpty() || !Misc::app(KFI_VIEWER).isEmpty()) Suggest code rework. Regards David Binderman

plasma-desktop-5.12.0 bug report

2018-02-08 Thread David Binderman
quot;==mime || "application/x-font-otf"==mime || "application/x-font-type1"==mime; x-font-type1 gets mentioned twice. Suggest code rework. Regards David Binderman

Re: plasma-desktop-5.12.0 bug report

2018-02-09 Thread David Binderman
Hello there, >however, please consider to use bugzilla at bugs.kde.orgproduct: plasmashell Done. https://bugs.kde.org/show_bug.cgi?id=390087 Regards David Binderman On giovedì 8 febbraio 2018 10:07:23 CET David Binderman wrote: > Hello there, > >

plasma-desktop-5.12.3 bug report

2018-03-07 Thread David Binderman
ice::ERR_GET_BUTTONS; } One if statement tidies things up, the other doesn't. Suggest code rework. It would also be more efficient if the sanity check for bt were moved to just after where it is set up. Regards David Binderman