Review Request: Update UI for settings of Speak Time in digital clock.

2011-10-25 Thread David Edmundson
I'm changing it). It simply reverts back to being set to Never the first time they open the config, allowing them to set something else. Screenshots --- http://git.reviewboard.kde.org/r/102944/s/314/ Thanks, David Edmundson ___ Plasma

Re: Re: Thoughts about statusbar

2011-10-25 Thread David Edmundson
On Tue, Oct 25, 2011 at 3:35 PM, Alex Fiestas afies...@kde.org wrote: On Tuesday, October 25, 2011 11:57:33 AM Aaron J. Seigo wrote: yes; as well as sometimes just saying that information is not worth it. the kmail example is a great one. i do not care what column and line i am on and spell

Re: Thoughts about statusbar

2011-10-25 Thread David Edmundson
2011/10/25 Aurélien Gâteau aurelien.gat...@canonical.com: Le 25/10/2011 11:32, Martin Gräßlin a écrit : On Tuesday 25 October 2011 15:37:20 David Edmundson wrote: On Tue, Oct 25, 2011 at 3:35 PM, Alex Fiestasafies...@kde.org  wrote: On Tuesday, October 25, 2011 11:57:33 AM Aaron J. Seigo

Re: Thoughts about statusbar

2011-10-25 Thread David Edmundson
KOrganizer: Has a statusbar. Seemingly not used. Get rid of it. If it's used for errors KMessageBox would be better I meant KMessageWidget. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Thoughts about statusbar

2011-10-25 Thread David Edmundson
guidelines, anyone who happened to miss PlanetKDE that week will have never see them. David Edmundson In fact with Plasma Active we are already doing a top-down approach on the app from the workspace. We just never did on the desktop, because we trust the application developers to do

Re: IconTasks taskmanager changes

2011-10-27 Thread David Edmundson
not running, but Icon Tasks does. So there is a regression in icon tasks , but it appears to be the complete opposite to what is currently being discussed. David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-15 Thread David Edmundson
not tested that and could be wrong.) - David Edmundson On March 13, 2012, 11:59 a.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226

Review Request: Misc Fixes in Plasma Components Gallery

2012-03-15 Thread David Edmundson
://git.reviewboard.kde.org/r/104296/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

QML Plasmoids and complex configs

2012-03-17 Thread David Edmundson
, and possibly I'm looking in the wrong places, but if I'm struggling to find an official word of this is how you should be writing plasmoids that will work 2 years from now, so will lots of people - and that's something that needs to be addressed, even if only in a blog post. David Edmundson

Review Request: Add missing property alias animation in Slider Plasma Component

2012-03-17 Thread David Edmundson
!) Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix padding in ToolButton and TabButton

2012-03-17 Thread David Edmundson
http://git.reviewboard.kde.org/r/104319/s/477/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Pedantic Nitpicking Issues in KRunner

2012-03-17 Thread David Edmundson
where decisions maybe haven't been thought about. * List of available plugins cannot be navigated with arrow keys. * If you have the options dialog open, and click on the ? it closes the options being shown, but doesn't show the help. David Edmundson

Re: Review Request: Add missing property alias animation in Slider Plasma Component

2012-03-18 Thread David Edmundson
--- On March 17, 2012, 7:27 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104318

Re: Review Request: Add missing property alias animation in Slider Plasma Component

2012-03-19 Thread David Edmundson
On March 18, 2012, 7:57 p.m., Aaron J. Seigo wrote: what is the use case for knowing if it is animated or not? this seems like an internal implementation detail? David Edmundson wrote: I assume it's more for setting whether it animates or not. (when the user clicks on the slider

Review Request: Misc minor fixes in KRunner.

2012-03-27 Thread David Edmundson
/nepomuksearch/plasma-runner-nepomuksearch.desktop 0319463 plasma/generic/runners/places/plasma-runner-places.desktop b82fa14 plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop f234b4f Diff: http://git.reviewboard.kde.org/r/104431/diff/ Testing --- Thanks, David

Re: Review Request: Misc minor fixes in KRunner.

2012-04-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104431/#review12204 --- On March 28, 2012, 1:56 a.m., David Edmundson wrote

Re: mpris2 engine and nowplaying QML applet

2012-04-29 Thread David Edmundson
Could you make sure to update this wiki page on QML porting progress: http://community.kde.org/Plasma/PlasmoidScripting#Porting_Plasmoids_to_QML Don't want anyone duplicating your work by mistake. Dave ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: mpris2 engine and nowplaying QML applet

2012-05-03 Thread David Edmundson
On Mon, Apr 30, 2012 at 2:24 PM, Alex Merry k...@randomguy3.me.uk wrote: On 27/04/12 23:52, Alex Merry wrote: This is following up my previous email about the mpris2 engine, and asking for a formal review. I've lost track of how the review procedure has changed since the move to git, and I

Re: mpris2 engine and nowplaying QML applet

2012-05-05 Thread David Edmundson
On Sat, May 5, 2012 at 2:29 PM, Alex Merry k...@randomguy3.me.uk wrote: On 03/05/12 22:18, David Edmundson wrote: Now Playing QML Review:     all code should be in - contents/ui, not at the top level dir. Done     Do you really want it set to keep-aspect ratio? It's not a great default

Re: mpris2 engine and nowplaying QML applet

2012-05-10 Thread David Edmundson
On Thu, May 10, 2012 at 11:09 AM, Alex Merry k...@randomguy3.me.uk wrote: On 05/05/12 19:00, David Edmundson wrote: Has anyone reviewed the Mpris-dataengine? If not I'll do that this evening. Are you still intending to do this?  I was originally planning to commit the dataengine and applet

Re: Workspace Next Sprint Organization

2012-05-16 Thread David Edmundson
On Wed, May 16, 2012 at 2:06 PM, Marco Martin notm...@gmail.com wrote: On Wednesday 16 May 2012, Alex Fiestas wrote: On Wednesday, May 16, 2012 12:54:16 PM Aaron J. Seigo wrote: there was something started quite some time ago by .. i forget who? .. here: According to the history of the page,

Plasma Applet Testing for 4.9

2012-05-16 Thread David Edmundson
plans Obviously raising a lot of bugs on it's own isn't very useful. I'll be spending some of my time helping fix things afterwards, but it really needs involvement from a lot of people available on the testing weekends to fix issues as quickly as they're opened. David Edmundson

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-20 Thread David Edmundson
from QML unless told. See devicenotifier for an example. - David Edmundson On May 15, 2012, 7:02 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-20 Thread David Edmundson
On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: Ehm, sorry for nitpicking but why is shipping allowed? It (probably) can't be closed by pressing CTRL+Q and the glow hover is missing... There is an import to import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets which seems

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-02 Thread David Edmundson
/remoteinstallerdialog.cpp http://git.reviewboard.kde.org/r/105032/#comment11351 for single characters use ' ' rather than . That way Qt knows to search for a character (rather than a string which just happens to be one letter long) and uses a faster replace method. - David Edmundson On June 1, 2012

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-03 Thread David Edmundson
On June 2, 2012, 3:14 p.m., David Edmundson wrote: publisher/remoteinstaller/remoteinstallerdialog.cpp, line 53 http://git.reviewboard.kde.org/r/105032/diff/3/?file=66057#file66057line53 This looks like it leaks. QScopedPointer perhaps? Giorgos Tsiapaliwkas wrote

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-03 Thread David Edmundson
username, const QString hostname,const QString source, QWidget* parent): QObject(parent), m_widget(parent) { ... } . - David Edmundson On June 3, 2012, 9:32 a.m., Giorgos Tsiapaliwkas wrote

Re: Review Request: JJ bug 224062 - add switch user check to kickoff leave model

2012-06-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104879/#review14405 --- Ship it! Ship It! - David Edmundson On May 16, 2012, 3:05

Re: Bugsplashing

2012-06-04 Thread David Edmundson
QML plasmoids, and that is the part I'm leading. One of the items is to go through and remove any now-invalid bugs, which should hopefully help these efforts. David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Plasmoid-TreeView problem

2012-06-04 Thread David Edmundson
On Mon, Jun 4, 2012 at 1:37 PM, Akos Toth zuiada...@gmail.com wrote: Hi I created a plasmoid, that shows my BZFlag friends (people I liked to play with). When I place the plasmoid on the workspace, after I added some of my friends, I'm trying scoll on treeview, the content is not changing,

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-05 Thread David Edmundson
) give you a ship it. - David Edmundson On June 4, 2012, 4:54 p.m., Giorgos Tsiapaliwkas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032

Re: Mouse wheel on Slider QML component

2012-06-07 Thread David Edmundson
On Thu, Jun 7, 2012 at 9:51 PM, Viranch Mehta viranch.me...@gmail.com wrote: Hi, I wanted to know if the Slider (from QML components) can be moved using the mouse wheels. If not, is it possible to implement it atm? Qt 4.x does not have a wheel event on MouseArea therefore it's not possible to

Re: Review Request: Fix text colors on TabButton and ToolButton

2012-06-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105163/#review14504 --- Ship it! Ship It! - David Edmundson On June 6, 2012, 2:28

Re: Workspace Next Sprint Organization

2012-06-08 Thread David Edmundson
On Fri, Jun 8, 2012 at 6:39 PM, Kevin Ottens er...@kde.org wrote: On Friday 08 June 2012 18:22:51 Alex Fiestas wrote: On Friday, June 08, 2012 05:41:25 PM Kevin Ottens wrote:  - A dozen white boxes (ideally roughly the cereal box size, can be  slightly bigger I doub't we can find this

Re: Travel to Sprint tomorrow

2012-06-10 Thread David Edmundson
I'm arriving at 5pm. Marco, we can meet if you want. Otherwise head on without me. I'll wear my KDE T-shirt to make identification easier. My phone number is +447593244223 ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request: Fix value not being updated when dragging slider, also fix animation when using keys.

2012-06-13 Thread David Edmundson
on battery plasmoid. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix the minimum size of some applets

2012-06-13 Thread David Edmundson
(...) } Also Battery applet is (now) set to a minimum size of 32x32 on the desktop. Would be good to have some consistency. applets/systemloadviewer/systemloadviewer.cpp http://git.reviewboard.kde.org/r/105234/#comment11589 This isn't right. Look down a few lines. It gets set again. - David

Re: Review Request: Fix the minimum size of some applets

2012-06-13 Thread David Edmundson
deleted the other patches. (if you just show revision 3, you'll only see this) applets/pastebin/pastebin.cpp http://git.reviewboard.kde.org/r/105234/#comment11597 Where did you get the number 33 from? - David Edmundson On June 13, 2012, 3:42 p.m., Maarten De Meyer wrote

Re: Quality Team: LCD weather station and calendar (in panel) are really broken

2012-06-14 Thread David Edmundson
the perfect way of increasing communication between everyone so we all know what's going on. Especially once we've entered such a beta phase. David Edmundson -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Quality Team: LCD weather station and calendar (in panel) are really broken

2012-06-14 Thread David Edmundson
On Thu, Jun 14, 2012 at 7:31 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, June 14, 2012 16:58:55 David Edmundson wrote: so much resistance. Reviews are slow, often they happen the same day, sometimes they don't. i would like them to be faster as well. when i keep on top of them

Re: No remaining time option in battery monitor?

2012-06-14 Thread David Edmundson
On Thu, Jun 14, 2012 at 11:54 PM, Viranch Mehta viranch.me...@gmail.com wrote: Hi, I just noticed there is no option of remaining time in the latest stable released version of the c++ battery applet (4.8.4). Have we discarded it? I want to know this so I can know whether I should keep this

Re: Review Request: Make sure vertical slider's handle have the same shadow as the horizontal one

2012-06-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105269/#review14777 --- Ship it! Ship It! - David Edmundson On June 16, 2012, 12

Re: Review Request: Make sure the views don't get overscrolled when clicking the scrollbar arrows

2012-06-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105268/#review14778 --- Ship it! Ship It! - David Edmundson On June 15, 2012, 11

Review Request: Add a keyboard shortcut to stop the current activity

2012-06-16 Thread David Edmundson
) --- Pressed shortcut, tested current activity closed, and that I could not close the last activity. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Support for multiple batteries in battery monitor applet

2012-06-17 Thread David Edmundson
On June 16, 2012, 6:40 p.m., Marco Martin wrote: i think the change is on the right path, but should wait for the unfreeze, since is not a trivial fix Given this patch is untested (due to Viranch having only one battery) and that we will have a lot of angry users complaining that the

Review Request: Use common plasma components Tooltip in battery monitor

2012-06-17 Thread David Edmundson
/applets/batterymonitor/contents/ui/IconButton.qml d4454c6 plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a Diff: http://git.reviewboard.kde.org/r/105283/diff/ Testing --- Checked applet looked ok. Thanks, David Edmundson

Re: blogs from the sprint?

2012-06-19 Thread David Edmundson
Other items from the sprint. Clarification on terminology. http://community.kde.org/Plasma/Terminology This is the list of processed tasks that we decided were important for moving workspaces forward. http://community.kde.org/Plasma/Workspace_Sprint/Kanban Some parts, such as the review of the

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-20 Thread David Edmundson
e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/#review14839 --- On June 17, 2012, 7:52 p.m., David Edmundson wrote: --- This is an automatically generated e-mail

Re: Team meeting today

2012-06-21 Thread David Edmundson
free to add more here, but it probably implies you should add it in bugzilla too. David Edmundson * we respect maintainer decisions * and, respect the elders! * think about the bigger project, if an issue of disagreement risks of damaging/slowing down the project, is maybe the time to step back

Re: Team meeting today

2012-06-21 Thread David Edmundson
On Thu, Jun 21, 2012 at 1:47 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, June 21, 2012 13:23:02 David Edmundson wrote: I made a similar form for Plasma is available here: http://community.kde.org/Plasma/Maintainership please fill-in as appropriate. there are 51 plasmoids

Re: Review Request: DBus-interface for changing wallpapers

2012-06-22 Thread David Edmundson
} to your target_link_libraries in CMakeLists.txt - David Edmundson On June 22, 2012, 2:07 a.m., Varun Herale wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319

Re: Plasma Bug Workflow BOF

2012-06-22 Thread David Edmundson
On Fri, Jun 22, 2012 at 3:49 PM, Myriam Schweingruber myr...@kde.org wrote: Hi Mark, On Fri, Jun 22, 2012 at 4:26 PM, Mark mark...@gmail.com wrote: On Fri, Jun 22, 2012 at 3:11 PM, Myriam Schweingruber myr...@kde.org wrote: Hi Thijs, On Fri, Jun 22, 2012 at 10:22 AM, Thijs Heus

Re: Review Request: Add missing email addresses back into add widget tooltip.

2012-06-23 Thread David Edmundson
links do nothing but emit a signal when clicked in the label add: onLinkActivated: { plasmoid.openUrl(link); } libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h http://git.reviewboard.kde.org/r/105312/#comment11836 Good spot! - David Edmundson On June

Re: Review Request: DBus-interface for changing wallpapers

2012-06-23 Thread David Edmundson
second setting of currentContainment-setWallpaper - David Edmundson On June 22, 2012, 2:36 p.m., Varun Herale wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319

Re: Review Request: DBus-interface for changing wallpapers

2012-06-24 Thread David Edmundson
On June 24, 2012, 1:41 a.m., David Edmundson wrote: I think you've overcomplicated this: Everything after currentContainment could be replaced with simply: --- currentContainment-setWallpaper(name, mode); if (!path.isEmpty()) { currentContainment-wallpaper

Re: Plasma applets inside QML applet

2012-06-24 Thread David Edmundson
On Sun, Jun 24, 2012 at 11:05 AM, Marco Martin notm...@gmail.com wrote: On Saturday 23 June 2012, Dmitry wrote: Hello! I'm developing an applet in QML. I need to load an external applet and to place it into my applet like  containment applet, like panel or system tray. But at the same time

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15058 --- Ship it! - David Edmundson On June 22, 2012, 10:04 p.m

Re: Review Request: DBus-interface for changing wallpapers

2012-06-24 Thread David Edmundson
ship it till after the feature freeze ends for 4.9. (unless someone else gives you permission) - David Edmundson On June 24, 2012, 3:47 p.m., Varun Herale wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Where I can find api documents of qml?

2012-06-27 Thread David Edmundson
On Wed, Jun 27, 2012 at 12:53 PM, qasdfgtyuiop qasdfgtyu...@gmail.com wrote: I want to insert some icon in my qml widget, and using javascript to access calendar.  But I can not find the document related to this. Where can I find a document of plasma qml? I have seen these pages but find

Re: Where I can find api documents of qml?

2012-06-27 Thread David Edmundson
On Wed, Jun 27, 2012 at 1:26 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Wed, Jun 27, 2012 at 12:53 PM, qasdfgtyuiop qasdfgtyu...@gmail.com wrote: I want to insert some icon in my qml widget, and using javascript to access calendar.  But I can not find the document related

Re: Where I can find api documents of qml?

2012-06-28 Thread David Edmundson
On Thu, Jun 28, 2012 at 8:42 AM, qasdfgtyuiop qasdfgtyu...@gmail.com wrote: The problem has been solved.  Thank you. It's not really resolved the original problem of any missing docs. qasdfgtyuiop, if you encounter issues like this where you can't find the documentation and someone helps you

Re: Where I can find api documents of qml?

2012-06-28 Thread David Edmundson
On Thu, Jun 28, 2012 at 10:30 AM, gaoxiang qasdfgtyu...@gmail.com wrote: Ok, after I finish my program, I will look at the problem I met and write something Awesome Thanks. On Thursday 28 June 2012 10:09:19 David Edmundson wrote: On Thu, Jun 28, 2012 at 8:42 AM, qasdfgtyuiop qasdfgtyu

Re: Re: Plasma Bug Workflow BOF

2012-06-28 Thread David Edmundson
On Mon, Jun 25, 2012 at 8:18 AM, Sebastian Kügler se...@kde.org wrote: On Friday, June 22, 2012 15:11:42 Myriam Schweingruber wrote: What needs to be understood is that all code can have bugs, that is only natural and nobody will deny that. But that also means that we should thrive to make the

Re: Review Request: Improve ProgressBar display

2012-08-15 Thread David Edmundson
/ProgressBar.qml http://git.reviewboard.kde.org/r/105966/#comment13690 You've kept the trigger for width changing, but not height. That doesn't sound right. - David Edmundson On Aug. 10, 2012, 4:12 p.m., Aleix Pol Gonzalez wrote

Re: Back to basics

2012-08-17 Thread David Edmundson
Some of the stuff discussed here overlaps with the Extra Mile project being run by Aurelien, myself and KDE Quality team. The idea is we make a big list of very minor small annoying bugs, and encourage people to help file these, and in the meantime we blog trying to encourage developers not to

[RFC] Merging LightDM into KDE Workspaces

2012-08-20 Thread David Edmundson
://www.sharpley.org.uk/lightdm-google-authentication, http://www.sharpley.org.uk/blog/an-update-on-lightdm-kde [4] http://static.davidedmundson.co.uk/lightdm_design_rationale.html Regards David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread David Edmundson
Sure makes sense. Forwarded. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread David Edmundson
On Wed, Aug 22, 2012 at 2:06 PM, Daniel Nicoletti dantt...@gmail.com wrote: Though I have nothing against this move, I'd like to ask a dumb question (well maybe not that dumb): Since lightDM-kde greeter is (AFAIK) pretty much just an interface for lightDM, and since I myself find the user

Re: Review Request: Activities KCM

2012-08-22 Thread David Edmundson
/workspace/settings/CMakeLists.txt http://git.reviewboard.kde.org/r/106130/#comment14121 capital letter in class filename isn't typically usual, and doesn't match any other cpp in kactivities repo. - David Edmundson On Aug. 22, 2012, 10:04 p.m., Ivan Čukić wrote

Re: Review Request: Weather Forecast QML port

2012-08-26 Thread David Edmundson
://git.reviewboard.kde.org/r/106225/#comment14300 You don't need this. In your QML you can call plasmoid.openUrl() - David Edmundson On Aug. 26, 2012, 7:59 p.m., Luis Gabriel Lima wrote: --- This is an automatically generated e-mail

Re: Review Request: Dictionary Runner

2012-08-28 Thread David Edmundson
translates it differently in one of the 3 places, it breaks. - David Edmundson On Aug. 18, 2012, 3:57 a.m., Jason A. Donenfeld wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106068

Re: Review Request: Weather Forecast QML port

2012-08-29 Thread David Edmundson
On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: applets/weather/package/contents/ui/FiveDaysView.qml, line 70 http://git.reviewboard.kde.org/r/106225/diff/1/?file=81340#file81340line70 you don't need this.. just use color: theColour alpha: theAlpha

Re: Ordering items in QML Column

2012-09-07 Thread David Edmundson
On Fri, Sep 7, 2012 at 4:36 PM, Michał 'rysiek' Woźniak rys...@fwioo.pl wrote: Hi there, Is there a way to re-order items in QML Column element? I can, of course, remove all items and add them in a new order, but that seems a very inelegant solution. In the docs there is no info on any

Re: Review Request: Weather Forecast QML port

2012-09-07 Thread David Edmundson
On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: applets/weather/package/contents/ui/Notice.qml, line 27 http://git.reviewboard.kde.org/r/106225/diff/1/?file=81341#file81341line27 Unless there's a good reason, use PlasmaComponents.Label rather than Text. Otherwise font size

Re: Review Request: Weather Forecast QML port

2012-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18666 --- Ship it! Fine with me. - David Edmundson On Aug. 30, 2012

Re: Changes to Plasma Weather - Git revision 5a09cd815edd7723800c0ba43a8be9f67d28e011

2012-09-11 Thread David Edmundson
On Tue, Sep 11, 2012 at 1:05 PM, Shawn Starr shawn.st...@rogers.com wrote: On Tuesday, September 11, 2012 08:30:50 AM Luís Gabriel wrote: You can see some screenshots here: https://git.reviewboard.kde.org/r/106225/ There was no changes in the UI, it was just rewritten in QML. Cheers, --

Re: Poll - Rethinking battery remaining time option

2012-09-12 Thread David Edmundson
On Wed, Sep 12, 2012 at 1:41 PM, Sebastian Kügler se...@kde.org wrote: On Wednesday, September 12, 2012 14:30:08 Marco Martin wrote: I'm for keeping the config option as least possible damage, i think it has been discussed to death (including why user polls for features don't work) +1 I

Re: Re: Status of QML Porting

2012-09-15 Thread David Edmundson
Alex, I noticed you just assigned timer to yourself. I remember reading that David Bettio had updating that (and Calendar) as his GSOC project: http://blog.uninstall.it/2012/06/24/my-gsoc-project-port-plasma-calendar-and-other-widgets-to-qml/ I think he passed GSOC so both of those should be

Re: Re: Status of QML Porting

2012-09-15 Thread David Edmundson
Checking against what I have on my system, that list is also missing: bball battery binary clock blackboard bubbemon calculator charselect comic (I stopped at this point) Is this list a deliberate subset? If so what is the criteria? and I'll add anything missing.

Re: Status of QML Porting

2012-09-16 Thread David Edmundson
On Sat, Sep 15, 2012 at 11:16 AM, Marco Martin notm...@gmail.com wrote: On Saturday 15 September 2012, David Edmundson wrote: Checking against what I have on my system, that list is also missing: bball battery binary clock blackboard bubbemon calculator charselect comic (I stopped

Review Request: smooth scroll by mousewheel in SystemSettings

2012-09-21 Thread David Edmundson
/icons/CategorizedView.h f2b064f systemsettings/icons/CategorizedView.cpp 1a2a1d9 Diff: http://git.reviewboard.kde.org/r/106523/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request: smooth scroll by mousewheel in SystemSettings

2012-09-22 Thread David Edmundson
/#review19265 --- On Sept. 21, 2012, 11:26 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106523

Re: Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper configuration screen

2012-09-22 Thread David Edmundson
if you work round a bug you should explicitly state what bug you are working around. That way people know when it is ok to remove it. - David Edmundson On Sept. 23, 2012, 12:37 a.m., Reza Shah wrote: --- This is an automatically generated

Re: Fit Grid elements in Item

2012-09-24 Thread David Edmundson
On Mon, Sep 24, 2012 at 4:05 AM, Luiz Romário Santana Rios luizroma...@gmail.com wrote: Hello. I'm trying to port the Calculator plasmoid to QML, but I'm stuck trying to make the buttons fit their parent item. I'm doing this: Item { anchors { top: resultArea.bottom

Re: Fit Grid elements in Item

2012-09-24 Thread David Edmundson
On Mon, Sep 24, 2012 at 1:16 PM, Sebastian Kügler se...@kde.org wrote: On Monday, September 24, 2012 11:45:22 David Edmundson wrote: Although you've told the grid to anchor on the right hand side, you've also (implicitly) told it it needs to be 4 buttons wide, and each button is hardcoded

Re: Behavior on systray icon clicking

2012-09-25 Thread David Edmundson
Back to the topic of the KTp plasmoid. The original goals of that plasmoid was not to be a silly shortcut to the contact list anyway. It's purpose /was/ to provide access to change your online-ness. I'd like to see it go back to what it was designed to do, rather than it's current state and the

Re: share-like-connect in 4.10

2012-10-03 Thread David Edmundson
On Wed, Oct 3, 2012 at 4:22 PM, Marco Martin notm...@gmail.com wrote: On Wednesday 03 October 2012, Alex Fiestas wrote: On Wednesday 03 October 2012 13:49:28 Marco Martin wrote: 4. more plugins yep, those are the two most relevant points (many plugins btw will depend from the web

Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-03 Thread David Edmundson
--- Edited Widget gallery to have width: minimumWidth on a button. It looked ok. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: share-like-connect in 4.10

2012-10-03 Thread David Edmundson
On Wed, Oct 3, 2012 at 11:25 PM, Aaron J. Seigo ase...@kde.org wrote: On Wednesday, October 3, 2012 19:24:56 David Edmundson wrote: On Wed, Oct 3, 2012 at 4:22 PM, Marco Martin notm...@gmail.com wrote: - blog about it already done. several times. we need to do it more. - make releases

Re: Re: un-NIH-ing accounts?

2012-10-07 Thread David Edmundson
On Mon, Oct 8, 2012 at 1:50 AM, Alex Fiestas afies...@kde.org wrote: On Monday 08 October 2012 01:46:40 Aaron J. Seigo wrote: On Sunday, October 7, 2012 23:10:47 Mark wrote: This page has a bit more info then the google code link (and the packages):

Re: Review Request: Translate strings in Global Keyboard Shortcuts component KDE Keyboard Layout Switcher

2012-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106424/#review20131 --- Ship it! Ship It! - David Edmundson On Sept. 11, 2012, 1

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20150 --- Ship it! Looks good to me. - David Edmundson On Oct. 10

Re: Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

2012-10-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106978/#review20642 --- There does not seem to be a diff attached. - David Edmundson

Re: slc repo as dependency

2012-10-23 Thread David Edmundson
It would need to be moved from playground if kde-workspace was to depend on it. The procedure I've had to go through is: - open a sysadmin request to move repo to kdereview stating you want to move to review, and the intended final destination - post to kde-devel to inform people about the

Re: kickoff qml

2012-10-23 Thread David Edmundson
On Mon, Oct 22, 2012 at 10:16 AM, Marco Martin notm...@gmail.com wrote: Hi all, one thing i would like to have merged for 4.10 is the qml port of kickoff. i have been looking at it past few days, and it seems to have most of the features, even tough is still quite rough, i'm not 100% sure it

Re: kickoff qml

2012-10-24 Thread David Edmundson
Using bugzilla to track something not in master is not a good idea. It makes it impossible to identify what bugs are actually present in the product being shipped. Which is why I asked :) David ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
/r/107026/#review20823 --- On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 http://git.reviewboard.kde.org/r/107026/diff/1/?file=92249#file92249line109 Why remove this fade in animation? David Edmundson wrote: Because

Re: Review Request: Fix bold text in battery-monitor tooltip

2012-11-02 Thread David Edmundson
it from me too (with Sebas's comment fixed of course) - David Edmundson On Nov. 1, 2012, 10:26 p.m., Michele Gastaldo wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107173

  1   2   3   4   5   6   7   8   9   10   >