D6764: Add font size setting to the digital clock plasmoid

januz created this revision. januz added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch adds a new setting to the digital clock plasmoid to change the font size for horizontal panels and desktop. It also sets a default (14) with a new

D6764: Add font size setting to the digital clock plasmoid

januz edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6764: Add font size setting to the digital clock plasmoid

januz updated this revision to Diff 17043. januz added a comment. - Use pixelSize with units.devicePixelRatio - Update the default value CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6764?vs=16852=17043 REVISION DETAIL https://phabricator.kde.org/D6764 AFFECTED FILES

D6764: Add font size setting to the digital clock plasmoid

januz updated this revision to Diff 17044. januz added a comment. - Use pixelSize with units.devicePixelRatio to set the size - Update the default value to fit with the default panel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6764?vs=17043=17044 REVISION DETAIL

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. @Zren Thanks! I've updated the rev @mart I can see some parts of the code look a little too hacky but the new setting is nothing fancy, and I've been using for about 3 weeks without issues. It also fixes these two bugs: https://bugs.kde.org/show_bug.cgi?id=191889 and

D8232: Add option to center shadow

januz added a comment. Personally, I'm in the centered shadows camp. I have windows set up to have no borders and they always seem to visually blend into each other in a similar way to what @rkflx describes. I don't understand the reasoning behind light coming from the top-left, it seems

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. //PING// Hey guys, the beta is starting next week. Any chance we can still land this or https://phabricator.kde.org/D6813 for 5.11? REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: ngraham, Zren, mart, plasma-devel, ZrenBot,

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. > I think this explains why you haven't had a review, this existing code is already sketchy as-is :/ > But we should be trying to fix that not just all of us ignoring it. Sorry about that. No problem, I can understand the dread of piling stuff on code that

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. So, I've been fighting with this for a few weekends already and I just can't get it to work reliably with a relative scale. The spacing goes all wonk and sometimes the labels' font size don't change the way you expect them to (probably because of the maze of

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. Thanks for the replies guys. @davidedmundson Good point! I'll keep a close eye on the current code while I work on this. REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-devel,

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. In https://phabricator.kde.org/D6764#172831, @mmustac wrote: > I think this describes the main problem for most users (including me) very good: > KDE Forum: Padding in plasma panels Actually I posted

D6764: Use a smaller font size for digital clock plasmoid

januz updated this revision to Diff 23975. januz added a comment. Use relative scaling. The 0.71 factor looks funny but it aligns with the icons the best. Also reverted the change for clock+date. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D6764: Use a smaller font size for digital clock plasmoid

januz updated this revision to Diff 23992. januz added a comment. Added a comment for magic numbers REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6764?vs=23975=23992 BRANCH clock3 REVISION DETAIL https://phabricator.kde.org/D6764 AFFECTED

D6764: Use a smaller font size for digital clock plasmoid

januz added a comment. I don't have commit rights (AFAIK :P), please push it. Name: Diego Gangl Email: di...@sinestesia.co REPOSITORY R120 Plasma Workspace BRANCH clock3 REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg, romangg Cc: romangg, mmustac

D9255: [Notifications] Add visible menu button to thumbnail strip

januz added a comment. +1 for this patch. The three-line buttons happen in many other places too (dolphin, window title bars, firefox, chrome, etc.). Users quickly learn that pattern and recognize it as the "menu button" so I don't think that would be a problem. A possible tweak for

D6764: Use a smaller font size for digital clock plasmoid

januz updated this revision to Diff 23742. januz added a comment. Add units.smallSpacing to single line height REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6764?vs=23710=23742 BRANCH clock3 REVISION DETAIL https://phabricator.kde.org/D6764

D6764: Use a smaller font size for digital clock plasmoid

januz added a comment. In https://phabricator.kde.org/D6764#178028, @romangg wrote: > Why did you change the 0.56 * main.height value in case a date is shown? Reduces the clock size in two line mode and in this mode it was not too big. main.height is relative to the panel size.

D6764: Add font size setting to the digital clock plasmoid

januz updated this revision to Diff 23710. januz added a comment. Reducing the scope of this patch a bit, it now sets the clock fontsize to a fixed value. This prevents all the layout issues from relative scales. The code changes now are minimal, so it won't add pile more complexity on the

D6764: Use a smaller font size for digital clock plasmoid

januz retitled this revision from "Add font size setting to the digital clock plasmoid" to "Use a smaller font size for digital clock plasmoid". januz edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma,

D13481: Recommend window border size "None"

januz added a comment. +1 I've been using borderless windows all the time since I came back to ~~KDE~~ Plasma and haven't had any workflow issues. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13481 To: romangg, #plasma, #vdg Cc: januz, ngraham, davidedmundson,

D9542: Improve display of technical app info

januz added a comment. +1 Definitely an improvement. What do you think about grouping the homepage with the rest of the info at the top? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9542 To: ngraham, apol, #vdg, #discover_software_store Cc:

D9549: Horizontally center shadows and make them bigger

januz added a comment. I knew it would look better, but not //this// much better! Please accept this change REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: januz, rpelorosso, apol,

D9638: [effects] add 'Slide Desktops' effect

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9974: Improve header and metadata display

januz added a comment. +1 Looks way more organized, and it's easier to grasp what application you're seeing and what it does on a quick glance. Minor nitpick: I'd add more margin around the summary text (to separate it better from screenshots and the summary link). REPOSITORY R134

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff,

D10170: Added optional transparency/blur to menu frames

januz added a comment. +1 I wouldn't have this as a default for Breeze, but it looks really cool. I'm sure it'd be a popular option, specially among those trying to mimic macOS. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta,

D10438: increase left/right margin of menuitems

januz added a comment. IMO, the last version looks better than the current menu. That said, I think the top/bottom paddings are still too tight, I would try adding 2-3px for each. It's true that there's a question of taste but more whitespace is generally a good thing (unless you go

D10429: Disable the title bar separator by default

januz added a comment. I can't +1 this hard enough. There's no point in having a line separating the titlebar from the window. For users that want their titlebars the same color as the window it just gets in the way, and for users that want a clear separation it adds nothing (since there's