Re: New idea for plasmoid locking and floating plasmoids.

2009-11-21 Thread Hugo Pereira Da Costa
Or could there be way to move plasmoids on "Alt+mouse-left-button", resize on "Alt+mouse-right-button" disregarding lock-state ? Just like for kwin does for frameless windows ? Just asking ... Hugo >> I've a little proposal for the plasmoid locking on the desktop. >> >> Here is the problem: >>

Re: mouse plugins config

2009-11-22 Thread Hugo Pereira Da Costa
Hi Chani, just a naive question, why do you use a "sunken" frame to display the triggers ? As far as I know this is the only place where things are presented this way (usually config have either Tabs, group boxes, or are plain flat). Is there a specific reason here ? so I've been working on my

Re: mouse plugins config

2009-11-23 Thread Hugo Pereira Da Costa
On 11/23/2009 01:15 PM, Chani wrote: On November 22, 2009 21:47:35 Hugo Pereira Da Costa wrote: Hi Chani, just a naive question, why do you use a "sunken" frame to display the triggers ? As far as I know this is the only place where things are presented this way (usually config h

Re: mouse plugins config

2009-11-23 Thread Hugo Pereira Da Costa
On 11/23/2009 10:26 PM, Ben Cooksley wrote: > On Tue, Nov 24, 2009 at 9:49 AM, Hugo Pereira Da Costa > wrote: > >> On 11/23/2009 01:15 PM, Chani wrote: >> >> On November 22, 2009 21:47:35 Hugo Pereira Da Costa wrote: >> >> >> Hi Chani, >&

Re: t4 wiki page

2009-11-25 Thread Hugo Pereira Da Costa
On 11/25/2009 05:13 PM, Nuno Pinheiro wrote: > On Wednesday, 25 de November de 2009 18:59:20 Aaron J. Seigo wrote: > >> On November 25, 2009, Nuno Pinheiro wrote: >> >>> think apart from the typical plasma crew we will have 1 or 2 more people >>> just from oxygen, >>> >> that wo

Re: QCompleter on Plasma::LineEdit not working properly

2010-01-19 Thread Hugo Pereira Da Costa
Hi, for a "shot in the dark" could you try with another style than oxygen (if its the one your using) or using oxygen by disabling the "animations" in the oxygen style configuration dialog ("configure" in systemsettings->appearance->style, next to the combobox) ? It might be responsible for the

Re: QCompleter on Plasma::LineEdit not working properly

2010-01-19 Thread Hugo Pereira Da Costa
On 01/19/2010 11:09 AM, Cyrill Helg wrote: > Hi > > I tried it, but still the same behaviour. Btw, it locks after 2 chars and > completes only on the first char (popup shown at wrong place..). > > > Glad to be off the hook then. > On Tuesday 19 January 2010 17:00:25 Hug

mouse actions

2010-01-28 Thread Hugo Pereira Da Costa
Hi, for the record, I just committed and backported a patch to the oxygen style that fixes the background issue found in kde4.4 rc1 and rc2 for (notably) the mouse-actions configuration dialog. A screenshot of fixed mouse action dialog can be found at: http://www.flickr.com/photos/42123...@n03/

Re: Review Request: monochrome battery in panel

2010-04-13 Thread Hugo Pereira Da Costa
On 04/12/2010 04:52 PM, nuno pinheiro wrote: > A Segunda, 12 de Abril de 2010 18:14:21 Marco Martin você escreveu: > >> --- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.kde.org/r/3574/ >> ---

Review Request: 'fix' layout of notifications config page

2010-06-07 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4246/ --- Review request for Plasma. Summary --- In the current "notifications" confi

Re: Review Request: 'fix' layout of notifications config page

2010-06-07 Thread Hugo Pereira Da Costa
To reply, visit: http://reviewboard.kde.org/r/4246/#review6020 ----------- On 2010-06-06 21:07:54, Hugo Pereira Da Costa wrote: > > --- > This is an automatically

Re: Review Request: 'fix' layout of notifications config page

2010-06-07 Thread Hugo Pereira Da Costa
w to try and > > persuade the conservative and self-confident KDE community. > > Hugo Pereira Da Costa wrote: > mmm. It is not consistent with the "share" tab of all the plasmoids I > looked at. Or did I miss something ? Also, what should then be the alignment >

Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing

2013-08-28 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112329/#review38810 --- Ship it! Ship It! - Hugo Pereira Da Costa On Aug. 28, 2013

Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing

2013-08-28 Thread Hugo Pereira Da Costa
> On Aug. 28, 2013, 8:46 p.m., Hugo Pereira Da Costa wrote: > > Ship It! perfectly sane on my side (in fact there must be other places in the long long oxygenstyle code, where similar tests would help) - Hugo --- T

Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing

2013-08-29 Thread Hugo Pereira Da Costa
sure what's the status of this branch, though) and KDE/4.11 since it is considered a bug. Hugo - Hugo Pereira Da Costa On Aug. 28, 2013, 9:36 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Hugo Pereira Da Costa
rmal that they don't show up in oxygen-demo. Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ... - Hugo Pereira Da Costa On Aug.

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Hugo Pereira Da Costa
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Hugo Pereira Da Costa
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-08-31 Thread Hugo Pereira Da Costa
way, you don't lookup the property if the widget is defined, and You don't lookup the property multiple times. This comes at the price of some code duplication, but it is a small block of code, so I'd deem that acceptable. Oppinion ? - Hugo Pereira Da Co

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-09-07 Thread Hugo Pereira Da Costa
ttp://git.reviewboard.kde.org/r/112375/#comment29126> These changes (612 to 619) are unrelated. Right ? This is just coding style. I guess I'm ok with it, but I might change it back in the future to the (somewhat personal, I agree) coding style of the rest of the file - Hugo Perei

Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-06 Thread Hugo Pereira Da Costa
= (!widget) && option && ...; can you confirm ? - Hugo Pereira Da Costa On Dec. 4, 2013, 11:24 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-08 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/#review45340 --- Ship it! Ship It! - Hugo Pereira Da Costa On Dec. 6, 2013

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-07 Thread Hugo Pereira Da Costa
flat ? Does it happend with all KCMs ? (I'll double check asap but right now my systemsettings is crashing because my kauth is fubared. Links against incorrect pluggin, and qt4 and blows) - Hugo Pereira Da Costa On March 7, 2014, 11:40 a.m., Martin Gräßlin

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Hugo Pereira Da Costa
> On March 7, 2014, 3:15 p.m., Hugo Pereira Da Costa wrote: > > Hi Martin, > > Any idea why the background behind the shells is flat ? Does it happend > > with all KCMs ? > > (I'll double check asap but right now my systemsettings is crashing because > &

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Hugo Pereira Da Costa
> On March 7, 2014, 3:15 p.m., Hugo Pereira Da Costa wrote: > > Hi Martin, > > Any idea why the background behind the shells is flat ? Does it happend > > with all KCMs ? > > (I'll double check asap but right now my systemsettings is crashing because > &

Re: Review Request 117773: make kwin-decoration co-installable, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5

2014-04-28 Thread Hugo Pereira Da Costa
org/r/117773/ > --- > > (Updated April 25, 2014, 2:40 p.m.) > > > Review request for Plasma, Martin Gräßlin and Hugo Pereira Da Costa. > > > Repository: oxygen > > > Description > --- > > make kwin-decoration co-installable with kdelibs4 equiv

Re: Review Request 117773: make kwin-decoration co-installable, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5

2014-04-28 Thread Hugo Pereira Da Costa
> (Updated April 25, 2014, 2:40 p.m.) > > > Review request for Plasma, Martin Gräßlin and Hugo Pereira Da Costa. > > > Repository: oxygen > > > Description > --- > > make kwin-decoration co-installable with kdelibs4 equivalents, remove unused > kconf

Re: Review Request 117773: make kwin-decoration co-installable, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5

2014-04-29 Thread Hugo Pereira Da Costa
> On April 28, 2014, 5 p.m., Aleix Pol Gonzalez wrote: > > Does this demo really need to be installed? > > Hugo Pereira Da Costa wrote: > To be honest, I guess, no ... > Relic from debug days. (also I still uses every now and then, and right > now it expo

Re: Ship with Aurorae and Qtcurve or not...

2014-06-19 Thread Hugo Pereira Da Costa
On 06/17/2014 10:56 AM, Marco Martin wrote: On Thu, May 29, 2014 at 3:09 PM, Marco Martin > wrote: On Thursday 15 May 2014 11:39:00 Jens Reuterberg wrote: > Ok so after the feedback from the Beta Release an issue that we knew was > coming have happened.

Re: Review Request 125522: Use NETRootInfo to initiate wm move operation

2015-11-05 Thread Hugo Pereira Da Costa
-- On Oct. 8, 2015, 6:52 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125522/ > --- > > (Updated Oct. 8, 2015, 6:52 p.m.)

Re: Review Request 125522: Use NETRootInfo to initiate wm move operation

2015-11-05 Thread Hugo Pereira Da Costa
with an ifdef. > > No clue which of the two should win in a merge. Therefore I can't merge > > 5.4->master. Maybe someone could fix that please. > > Hugo Pereira Da Costa wrote: > Second commit wins. What do I need to do to fix ? Cherry-pick it in 5.

Re: Review Request 126174: [Task Manager] Add support for Jump Lists

2015-11-26 Thread Hugo Pereira Da Costa
> On Nov. 26, 2015, 2:08 p.m., Eike Hein wrote: > > Perhaps there should be a title action, similar to the Recent Documents one? > > Sebastian Kügler wrote: > For which purpose? (I think the distinction between jump list and 'task > option' is purely technical, no user benefit in cluttering

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Hugo Pereira Da Costa
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 127301: Disable window move on Wayland due to lack of Qt features and some cleanup

2016-03-07 Thread Hugo Pereira Da Costa
line removed) Appart from that, ship it ! Also: would you be kind enough to submit the same to oxygen ? (code is pretty much identical) kstyle/breezewindowmanager.cpp <https://git.reviewboard.kde.org/r/127301/#comment63577> Unrelated change it seems :) - Hugo Pereira Da Costa On

Re: Review Request 127352: [kstyle] Implement window shadows on Wayland

2016-03-13 Thread Hugo Pereira Da Costa
__ kstyle/breezeshadowhelper.cpp (line 435) <https://git.reviewboard.kde.org/r/127352/#comment63733> // (and elsewhere in case I missed some) - Hugo Pereira Da Costa On March 12, 2016, 8:28 a.m., Martin Gräßlin wrote: > >

Re: Review Request 127352: [kstyle] Implement window shadows on Wayland

2016-03-13 Thread Hugo Pereira Da Costa
> On March 13, 2016, 10:22 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezeshadowhelper.h, line 172 > > <https://git.reviewboard.kde.org/r/127352/diff/1/?file=449772#file449772line172> > > > > other class members start with "_" rather

Re: Review Request 127352: [kstyle] Implement window shadows on Wayland

2016-03-16 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127352/#review93589 --- Ship it! Ship It! - Hugo Pereira Da Costa On March 16

Re: Review Request 127390: [kstyle] Implement window shadows on Wayland

2016-03-16 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127390/#review93590 --- Ship it! Ship It! - Hugo Pereira Da Costa On March 16

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Hugo Pereira Da Costa
he other way around: if( isQtQuickControl()) { ... return true; } else return false; - Hugo Pereira Da Costa On March 22, 2016, 2:35 p.m., David Rosca wrote: > > --- > This is an automatic

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Hugo Pereira Da Costa
> On March 22, 2016, 2:54 p.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 5059 > > <https://git.reviewboard.kde.org/r/127460/diff/3/?file=453756#file453756line5059> > > > > For clarity I would rather put it the other way around: >

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/#review93869 --- Ship it! Ship It! - Hugo Pereira Da Costa On March 22

Re: Review Request 127463: Expand size of CT_ItemViewItem also with QtQuickControls

2016-03-22 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127463/#review93871 --- Ship it! Ship It! - Hugo Pereira Da Costa On March 22

Re: Review Request 127464: Fix 1px offset in QtQuickControls TabView frame

2016-03-22 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127464/#review93872 --- Ship it! Ship It! - Hugo Pereira Da Costa On March 22

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
> On March 26, 2016, 10:14 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 3388 > > <https://git.reviewboard.kde.org/r/127494/diff/1/?file=454100#file454100line3388> > > > > mmm. But is it not rather a qtc bug that states are set in an

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
This just tend to make the breeze code bloated and hard to maintain. Besides it doesn't fix the "other" styles (there is oxygen, but there are others). What are the chances to get these fixed upstream (eg: sunken !? checked) ? - Hugo Pereira Da Costa On March 25, 2016, 8

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
> On March 26, 2016, 10:14 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 3388 > > <https://git.reviewboard.kde.org/r/127494/diff/1/?file=454100#file454100line3388> > > > > mmm. But is it not rather a qtc bug that states are set in an

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
> On March 26, 2016, 10:14 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 3388 > > <https://git.reviewboard.kde.org/r/127494/diff/1/?file=454100#file454100line3388> > > > > mmm. But is it not rather a qtc bug that states are set in an

Re: Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

2016-03-26 Thread Hugo Pereira Da Costa
l see later if this breaks other things. - Hugo Pereira Da Costa On March 26, 2016, 10:41 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: RFC: Removing of decorations

2012-03-12 Thread Hugo Pereira Da Costa
On 03/10/2012 07:51 AM, Martin Gräßlin wrote: Hi all, I was considering to clean up the window decorations in KWin. Currently we ship: * Oxygen (default) * Aurorae (theme engine) * b2 * laptop * Plastik At least for Plastik we know that it is currently broken with Compositing and nobody is goin

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-26 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#review61017 --- Ship it! Ship It! - Hugo Pereira Da Costa On June 16

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-26 Thread Hugo Pereira Da Costa
> On June 16, 2014, 6:57 a.m., Martin Gräßlin wrote: > > looks good to me, +1. Please add Hugo Pereira Da Costa to the Review > > Request, though. > > > > The review request made me wonder whether we still need to find XLib in > > Oxygen, though. The part

Re: Review Request 119062: Add a script to enforce window decorations for GTK windows

2014-07-01 Thread Hugo Pereira Da Costa
ecking the NET_SUPPORTED atom on rootWindow and install either the GTK shadow or the kwin shadow, depending on whether the above atom is found in the supported list or not) Maybe we could do the same (e.g. KDE_NET_WM_SUPPORTS_CSD) for the CSD shadows. - Hugo Pereira Da Costa On July 1, 2014

Re: Review Request 119062: Add a script to enforce window decorations for GTK windows

2014-07-02 Thread Hugo Pereira Da Costa
> On July 1, 2014, 6:04 p.m., Hugo Pereira Da Costa wrote: > > @Martin > > yes we can (tm). But then I'll get complains (got some already in the past) > > from people using oxygen-gtk on gnome (or other DEs). > > so there needs to be a way to communicat

Re: Review Request 119062: Add a script to enforce window decorations for GTK windows

2014-07-02 Thread Hugo Pereira Da Costa
> On July 1, 2014, 6:04 p.m., Hugo Pereira Da Costa wrote: > > @Martin > > yes we can (tm). But then I'll get complains (got some already in the past) > > from people using oxygen-gtk on gnome (or other DEs). > > so there needs to be a way to communicat

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-18 Thread Hugo Pereira Da Costa
> On June 26, 2014, 11:49 a.m., Hugo Pereira Da Costa wrote: > > Ship It! Ping ? Should I commit this myself ? - Hugo --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#re

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-22 Thread Hugo Pereira Da Costa
> On June 16, 2014, 6:57 a.m., Martin Gräßlin wrote: > > looks good to me, +1. Please add Hugo Pereira Da Costa to the Review > > Request, though. > > > > The review request made me wonder whether we still need to find XLib in > > Oxygen, though. The part

[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)

2014-09-10 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=158379 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pere...@free.fr --- Comment #9

[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)

2014-09-10 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=158379 --- Comment #10 from Hugo Pereira Da Costa --- Hi, After experimenting a bit, and just to make sure that we are talking about the same thing: http://wstaw.org/m/2014/09/10/plasma-desktopgs4453.png http://wstaw.org/m/2014/09/10/plasma-desktopMf4453

[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)

2014-09-11 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=158379 --- Comment #11 from Hugo Pereira Da Costa --- Git commit c71ed504dad4f92979e905067b22cafc015b8afd by Hugo Pereira Da Costa. Committed on 11/09/2014 at 21:18. Pushed by hpereiradacosta into branch 'master'. - Use QGridLayout for setting up V

Re: Review Request 120225: Draw lineedit frames as long as there is just enough space

2014-09-15 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120225/#review66615 --- Ship it! Ship It! - Hugo Pereira Da Costa On Sept. 15

Re: Review Request 120225: Draw lineedit frames as long as there is just enough space

2014-09-15 Thread Hugo Pereira Da Costa
> On Sept. 15, 2014, 9:51 p.m., Hugo Pereira Da Costa wrote: > > Ship It! Side note: there might be a similar issue for editable comboboxes. Can double check if you don't find time to. - Hugo --- This is an automatical

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread Hugo Pereira Da Costa
question is, how do I test it, and use it, to fix oxygen and breeze I have qt-5.4 here, X system, but whether I enable or not the option and the QT_DEVICE_PIXEL_RATIO env variable, nothing changes in oxygen-demo5 appearance. What do I miss ? - Hugo Pereira Da Costa On Sept. 16, 2014, 2:33 p.m

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread Hugo Pereira Da Costa
l try compile a more recent Qt5 version (which branch do you use ? stable ?) and then I'll go debug breeze and oxygen (I'm actually eager to) - Hugo Pereira Da Costa On Sept. 16, 2014, 2:33 p.m., David Edmundson wrote: > > ---

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread Hugo Pereira Da Costa
> On Sept. 16, 2014, 4:01 p.m., Hugo Pereira Da Costa wrote: > > ok, ship it, then :) > > in the meanwhile I'll try compile a more recent Qt5 version (which branch > > do you use ? stable ?) > > and then I'll go debug breeze and oxygen (I'm act

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-18 Thread Hugo Pereira Da Costa
> On Sept. 16, 2014, 4:01 p.m., Hugo Pereira Da Costa wrote: > > ok, ship it, then :) > > in the meanwhile I'll try compile a more recent Qt5 version (which branch > > do you use ? stable ?) > > and then I'll go debug breeze and oxygen (I'm act

[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)

2014-09-21 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=158379 Hugo Pereira Da Costa changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED

Re: Review Request 120222: When the button is being pressed draw background like it has focus

2014-09-23 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120222/#review67267 --- Ship it! ... sorry for the delay - Hugo Pereira Da Costa

[Breeze] [Bug 339849] Can't set breeze dark color scheme

2014-10-15 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=339849 Hugo Pereira Da Costa changed: What|Removed |Added Latest Commit|http://commits.kde.org/bree |http://commits.kde.org/bree

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-04 Thread Hugo Pereira Da Costa
at compile time ? - Hugo Pereira Da Costa On Nov. 3, 2014, 2:24 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-04 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/#review69805 --- Ship it! no objection then ! - Hugo Pereira Da Costa On

Re: Review Request 121259: [oxygen] fix kde4 build/configure/cmake stage

2014-11-26 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121259/#review70981 --- Ship it! Ship It! - Hugo Pereira Da Costa On Nov. 26

Re: Review Request 121259: [oxygen] fix kde4 build/configure/cmake stage

2014-11-26 Thread Hugo Pereira Da Costa
> On Nov. 26, 2014, 8:19 p.m., Hugo Pereira Da Costa wrote: > > Ship It! oops, too late. Thanks for the fix ! - Hugo --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121259/#re

[kwin] [Bug 341117] Breeze/Plastik (Not Oxygen) themes: First titlebar click ignored.

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=341117 Hugo Pereira Da Costa changed: What|Removed |Added Product|Breeze |kwin Target Milestone

Re: Review Request 121311: Remove mnemonic underlines when alt-tabbing

2014-12-01 Thread Hugo Pereira Da Costa
) bug 341006 to the review - Hugo Pereira Da Costa On Dec. 1, 2014, 2:33 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Breeze] [Bug 340343] Open/Save File dialog - Highlight problem on headers

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340343 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pere...@free.fr --- Comment #2

[Breeze] [Bug 340343] Open/Save File dialog - Highlight problem on headers

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340343 Hugo Pereira Da Costa changed: What|Removed |Added Component|general |QStyle -- You are receiving this mail

[Breeze] [Bug 340343] Open/Save File dialog - Highlight problem on headers

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340343 Hugo Pereira Da Costa changed: What|Removed |Added Latest Commit||http://commits.kde.org/bree

[Breeze] [Bug 340343] Open/Save File dialog - Highlight problem on headers

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340343 Hugo Pereira Da Costa changed: What|Removed |Added Latest Commit|http://commits.kde.org/bree |http://commits.kde.org/bree

Re: Review Request 121466: Oxygen QStyle: Add an option to enable/disable drawing darker frames round the selection highlight

2014-12-16 Thread Hugo Pereira Da Costa
. Adding more options, design changes etc will just make it harder to maintain. In the end unless there is some real use case and/or bug to be fixed I would rather not commit the change ... Hugo - Hugo Pereira Da Costa On Dec. 12, 2014, 3:03 p.m., David Edmundson wrote

[Breeze] [Bug 338979] Breeze window decoration adds spacing around the windeco

2014-12-17 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=338979 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pere...@free.fr --- Comment #9

[Breeze] [Bug 338979] Breeze window decoration adds spacing around the windeco

2014-12-17 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=338979 Hugo Pereira Da Costa changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

[Breeze] [Bug 342864] Close button doesn't obey Fitts law

2015-01-19 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=342864 Hugo Pereira Da Costa changed: What|Removed |Added Component|general |window decoration CC

[Breeze] [Bug 342824] Almost no padding for window icon in maximized window decoration

2015-01-19 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=342824 Hugo Pereira Da Costa changed: What|Removed |Added CC||aa...@kde.org --- Comment #4 from Hugo

[Breeze] [Bug 342824] Almost no padding for window icon in maximized window decoration

2015-01-19 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=342824 Hugo Pereira Da Costa changed: What|Removed |Added Assignee|plasma-devel@kde.org|hugo.pere...@free.fr

[kwin] [Bug 340917] Titlebar buttons and actions not responding right after changing focus by clicking titlebar

2015-01-19 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340917 Hugo Pereira Da Costa changed: What|Removed |Added Component|general |aurorae CC

[Breeze] [Bug 342570] kde4breeze copies contents of systemwide kdeglobals

2015-01-19 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=342570 Hugo Pereira Da Costa changed: What|Removed |Added Assignee|plasma-devel@kde.org|hugo.pere...@free.fr

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2015-01-19 Thread Hugo Pereira Da Costa
This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120957/ > ----------- > > (Updated Nov. 4, 2014, 3:11 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: oxyge

[Breeze] [Bug 340580] KDE Apps' toolbars and dialog options don't have icons just empty spaces.

2015-01-20 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340580 Hugo Pereira Da Costa changed: What|Removed |Added Resolution|--- |FIXED CC

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread Hugo Pereira Da Costa
can you double-check ? I'll add it to the review. - Hugo Pereira Da Costa On Jan. 21, 2015, 3:34 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread Hugo Pereira Da Costa
> On Jan. 21, 2015, 3:38 p.m., Hugo Pereira Da Costa wrote: > > the delete call was introduces by D. Faure, at > > 2ffe20e1bfe93c921c5372b4d21447b1de308d4b > > with log message: > > > > Fix crash on exit in all QCommandLineParser-based programs. > >

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread Hugo Pereira Da Costa
> On Jan. 21, 2015, 3:38 p.m., Hugo Pereira Da Costa wrote: > > the delete call was introduces by D. Faure, at > > 2ffe20e1bfe93c921c5372b4d21447b1de308d4b > > with log message: > > > > Fix crash on exit in all QCommandLineParser-based programs. > >

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread Hugo Pereira Da Costa
-DUSE_KDE4=1) This probably requires runtime checked connect, and a proper Q_SLOT You can use #if OXYGEN_USE_KDE4, if you want to conditionally use runtime or compiletime connect depending on Qt version. - Hugo Pereira Da Costa On Jan. 21, 2015, 4:57 p.m., David Edmundson wrote

Re: Review Request 122328: Fix apply button in breeze window decoration config

2015-01-30 Thread Hugo Pereira Da Costa
y fix the issue ? - Hugo Pereira Da Costa On Jan. 30, 2015, 11:42 a.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 122328: Fix apply button in breeze window decoration config

2015-01-30 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122328/#review75041 --- Ship it! Ship It! - Hugo Pereira Da Costa On Jan. 30

Re: Review Request 122328: Fix apply button in breeze window decoration config

2015-01-30 Thread Hugo Pereira Da Costa
On 01/30/2015 12:58 PM, Pinak Ahuja wrote: I might be wrong, but shouldn't the changed signal have a bool parameter? The changed() without a parameter refers to a slot(can we emit a slot? I'm new to this). I didn't compile and check if the behaviour was fixed in the master branch without this

Re: Review Request 122328: Fix apply button in breeze window decoration config

2015-01-30 Thread Hugo Pereira Da Costa
> On Jan. 30, 2015, 12:01 p.m., Hugo Pereira Da Costa wrote: > > Ship It! PS: do you have commit access ? Otherwise I can commit for you. - Hugo --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 122328: Fix apply button in breeze window decoration config

2015-01-30 Thread Hugo Pereira Da Costa
and push it. I'll investigate the issue in Plasma/5.2 separately. Best regards, Hugo On 30 Jan 2015 17:38, "Hugo Pereira Da Costa" <mailto:hugo.pere...@free.fr>> wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.or

[Breeze] [Bug 343428] Checkbox on hover highlights are potentially confusing

2015-02-02 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=343428 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pere...@free.fr

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

2015-02-02 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=343555 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pere...@free.fr --- Comment #6

Re: Review Request 122500: Don't delete widgets we don't own when changing styles

2015-02-09 Thread Hugo Pereira Da Costa
ttps://git.reviewboard.kde.org/r/122500/#comment52340> Shouldn't this be "as this isn't a QWidget" (since 'this' actually is a qobject) - Hugo Pereira Da Costa On Feb. 9, 2015, 2:33 p.m., David Edmundson wrote: > >

  1   2   3   4   5   >