On lundi 16 août 2010 21:02:04 Brian David Pritchett wrote:
SVN commit 1164453 by pritchett:
Added akonadi storage plugin loading.
M +31 -21datacontainer.cpp
M +2 -2 private/datacontainer_p.h
Hi,
could you verify these commit please ?
plasma-desktop doesn't start here (I have
On lundi 14 mars 2011 14:25:10 Sebastian Kügler wrote:
Hi all,
Ok for me.
Regards
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Seigo
Rob Scheepmaker
Dan Meltzer
Laurent Montel
I can't see there being an issue with any of them, but legally we need
their written permission.
If you're on this list, please can you reply saying that to agree to
relicense any GPL code in libplasma of yours to LGPL (v2+)?
Alex
For me
://pim.kde.org/
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org
https://bugs.kde.org/show_bug.cgi?id=344168
Laurent Montel mon...@kde.org changed:
What|Removed |Added
CC||mon...@kde.org
--- Comment #3
https://bugs.kde.org/show_bug.cgi?id=344168
--- Comment #5 from Laurent Montel mon...@kde.org ---
I activated it in konversation but same problem.
But each time that I start plasma5 there is a dialogbox which asked to search
an engine for systray.
It tries to search but didn't find.
So what
https://bugs.kde.org/show_bug.cgi?id=344168
--- Comment #7 from Laurent Montel mon...@kde.org ---
Created attachment 91093
-- https://bugs.kde.org/attachment.cgi?id=91093action=edit
dialog box which asks statusnotieritem engine
Sorry it's in french but it asks an engine for statusnotifieritem
https://bugs.kde.org/show_bug.cgi?id=344168
--- Comment #9 from Laurent Montel mon...@kde.org ---
Indeed it was dbusmenu-qt5 which was missing.
It works fine now. Thanks.
Too bad that kdesrc-build doesn't install it by default.
Thanks
Regards
--
You are receiving this mail because:
You
tps://git.reviewboard.kde.org/r/125618/#comment60058>
you use dynamic_cast so you need to test pointer otherwise it can return
null
- Laurent Montel
On oct. 13, 2015, 2:20 matin, Christian Butcher wrote:
>
> ---
> This is a
Can we autogenerate it in kf5 ?
- Laurent Montel
On oct. 26, 2015, 8:22 après-midi, Martin Klapetek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.revi
sorry about it.
- Laurent Montel
On août 30, 2015, 6:07 matin, Andrew Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124991
Hi,
Before store.kde.org, kdepim ues knewstuff to get data from server.
We had for example kmail header theme on old server.
But now in new server I can't see them.
Do you have an idea why we don't get them now ?
Thanks for info.
Regards
--
Laurent Montel | laurent.mon...@kdab.com
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129736/#review101714
---
Ship it!
Seems ok.
Ship it.
Regards
- Laurent Montel
tps://git.reviewboard.kde.org/r/129736/#comment68106>
2015?
- Laurent Montel
On Dec. 31, 2016, 5:04 p.m., Roman Standzikowski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
mlaurent added reviewers: afiestas, sebas, davidedmundson.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8431
To: mlaurent, afiestas, sebas, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
compile
REPOSITORY
R110 KScreen Library
BRANCH
use_nullptr
REVISION DETAIL
https://phabricator.kde.org/D8432
AFFECTED FILES
mlaurent added a reviewer: davidedmundson.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D8432
To: mlaurent, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Default action when we plug unknown monitor
REPOSITORY
R104 KScreen
BRANCH
customize_connect_unknown_monitor
REVISION DETAIL
mlaurent created this revision.
mlaurent added a project: Plasma.
REVISION SUMMARY
Default action when we plug unknown monitor
REPOSITORY
R104 KScreen
BRANCH
customize_connect_unknown_monitor
REVISION DETAIL
https://phabricator.kde.org/D8444
AFFECTED FILES
kcm/src/kcm_kscreen.cpp
mlaurent added a comment.
@sebas: What do you want as widget design ?
Is it ok to add plasma dependancy in kscreen ?
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham,
mlaurent added a comment.
(I was in vacation.)
Ok so I need to create an osd plasma for it.
I can trash this current patch.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham,
mlaurent added a comment.
Ping ?
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
seems good for me
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9300
To: amantia, #plasma, mwolff, hein, broulik, mlaurent
Cc:
mlaurent added inline comments.
INLINE COMMENTS
> screenmapper.cpp:202
> +KConfigGroup group(config, QLatin1String("ScreenMapping"));
> +QStringList mapping =
> group.readEntry(QLatin1String("screenMapping"), QStringList{});
> +setScreenMapping(mapping);
mlaurent added inline comments.
INLINE COMMENTS
> screenmapper.cpp:101
> const auto screenPathWithScheme = screenUrl.url();
> -const bool isEmpty = (path.isEmpty() || screenUrl.path() == "/");
> +const bool isEmpty = (screenUrl.isEmpty() || screenUrl.path() == "/");
> //
mlaurent added a comment.
Seems ok for me.
REVISION DETAIL
https://phabricator.kde.org/D9323
To: amantia, #plasma, mwolff, hein
Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
mlaurent added inline comments.
INLINE COMMENTS
> foldermodeltest.cpp:34
>
> +static QUrl stringToUrl(const QString ) {
> +return QUrl::fromUserInput(path, {}, QUrl::AssumeLocalFile);
new line after ')'
> positionertest.cpp:38
>
> +static QUrl stringToUrl(const QString ) {
> +
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
compile
REPOSITORY
R119 Plasma Desktop
BRANCH
rename_as_autotest
REVISION DETAIL
https://phabricator.kde.org/D8553
AFFECTED FILES
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8553
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:7c602a831f5d: Use nullptr. Initialize pointer (authored
by mlaurent).
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8432?vs=21172=21566
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:357bb3ab75c9: Its autotests not tests (authored by
mlaurent).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8553?vs=21558=21565#toc
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST
mlaurent added a comment.
This one too ?:)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8515
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bf0a2b81426e: Emit signal when we change PerStripe
(authored by mlaurent).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8516?vs=21421=21550#toc
REPOSITORY
R119 Plasma Desktop
CHANGES
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
> use unique keyword override
=
TEST PLAN
compile
REPOSITORY
R119 Plasma Desktop
BRANCH
use_override
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9a5e9be03fe6: Dont loop twice here (authored by
mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8515?vs=21422=21552
REVISION DETAIL
mlaurent added a comment.
Ping ?:)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8516
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8517
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0adccf18e3d0: We use Q_DECL_OVERRIDE or override.
(authored by mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8549?vs=21551=21553
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:27fb7629ce1d: Test enable status change and perStripe
change (authored by mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8517?vs=21426=21549
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8474
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
compile/test
REPOSITORY
R119 Plasma Desktop
BRANCH
reserve_info
REVISION DETAIL
https://phabricator.kde.org/D8474
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a4205b4ef4e0: Reserve size in container (authored by
mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8474?vs=21310=21311
REVISION DETAIL
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8475
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Remove extra ';'
Use override everywhere as we already use it in some part of code
Fix potential crash when we delete a pointer
TEST
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8473
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
BRANCH
optimize_search_indexforurl
REVISION DETAIL
https://phabricator.kde.org/D8475
AFFECTED FILES
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
BRANCH
remove_check
REVISION DETAIL
https://phabricator.kde.org/D8478
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3b3c83c14971: Use directly hasLinkType() (authored by
mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8477?vs=21317=21320
REVISION DETAIL
mlaurent added inline comments.
INLINE COMMENTS
> broulik wrote in foldermodel.h:256
> Did you check whether QML can cope with `const &`? The `urls` is used in an
> `onMove` QML handler (I recall it not handling `const *` well)
I didn't see an error here, but perhaps I didn't test action which
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
BRANCH
use_hasLinkType
REVISION DETAIL
https://phabricator.kde.org/D8477
AFFECTED FILES
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8477
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9f99b4a3c7e8: We already depend against 5.34 (authored by
mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8478?vs=21319=21321
REVISION DETAIL
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8476
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
BRANCH
port_to_new_connect_api
REVISION DETAIL
https://phabricator.kde.org/D8476
AFFECTED FILES
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8478
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent updated this revision to Diff 21324.
mlaurent added a comment.
- Perhaps that qml doesn't support const QUrl &
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8476?vs=21315=21324
BRANCH
port_to_new_connect_api
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:aac3db7a4d3c: Avoid to make loop twice. Return -1 if we
dont find it (authored by mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
mlaurent updated this revision to Diff 21348.
mlaurent added a comment.
- Perhaps gcc/clang can optimize it.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8473?vs=21309=21348
BRANCH
modernize_folderplugin
REVISION DETAIL
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8488
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
compile
REPOSITORY
R119 Plasma Desktop
BRANCH
clean_forward_declaration
REVISION DETAIL
https://phabricator.kde.org/D8488
AFFECTED FILES
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
compile
REPOSITORY
R119 Plasma Desktop
BRANCH
clean_includes
REVISION DETAIL
https://phabricator.kde.org/D8489
AFFECTED FILES
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8489
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent added inline comments.
INLINE COMMENTS
> broulik wrote in mimetypesmodel.cpp:109
> Isn't the compiler smart ehough?
Really I don't know if compiler is able to resolve it when it's not a const
variable.
If you told me that gcc/clang is able to do it ok :)
I can trust you if you told me
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:12a1360101cf: Clean includes (authored by mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8489?vs=21350=21354
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b95bdf216b8f: Modernize code. Use nullptr where its
possible (authored by mlaurent).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8473?vs=21348=21356#toc
REPOSITORY
R119 Plasma Desktop
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b706bc73fa63: qPort to new connect api + use
constref (authored by mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8476?vs=21324=21357
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9d0b117f6fed: Clean forward declaration (authored by
mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8488?vs=21349=21355
REVISION DETAIL
mlaurent requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8447
To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot,
renatoo, olivierjg
Cc: plasma-devel,
mlaurent added a comment.
missing copyright in new file too.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8447
To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot,
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
mlaurent added a comment.
Wierd why it created a new review ???
This one is more recent.
I will close 8442
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
mlaurent abandoned this revision.
mlaurent added a comment.
https://phabricator.kde.org/D8444 was opened.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8442
To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas,
mlaurent added a comment.
Add in toplevel:
if(BUILD_TESTING)
add_definitions(-DBUILD_TESTING)
endif(BUILD_TESTING)
+
create a folderplugin_private_export.h as
#ifndef KSIEVEUIPRIVATE_EXPORT_H
#define KSIEVEUIPRIVATE_EXPORT_H
#include "ksieveui_export.h"
/*
mlaurent added a subscriber: dvratil.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent
Cc: dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
mlaurent updated this revision to Diff 21283.
mlaurent added a comment.
- Update extend to left
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8444?vs=21231=21283
BRANCH
customize_connect_unknown_monitor
REVISION DETAIL
mlaurent added inline comments.
INLINE COMMENTS
> folderplugin_private_export.h:1
> +#ifndef FOLDERPLUGIN_PRIVATE_EXPORT_H
> +#define FOLDERPLUGIN_PRIVATE_EXPORT_H
Missing copyright
> foldermodeltest.cpp:1
> +#include "foldermodeltest.h"
> +#include "foldermodel.h"
Missing copyright
>
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D8447
To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot,
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
mlaurent marked an inline comment as done.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
mlaurent updated this revision to Diff 21288.
mlaurent added a comment.
- Don't use Q_FOREACH as it will be deprecated in the future
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8444?vs=21283=21288
BRANCH
customize_connect_unknown_monitor
REVISION
mlaurent retitled this revision from "WIP: Define default Action when we plug
unknown monitor" to "Define default Action when we plug unknown monitor".
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham,
mlaurent edited the test plan for this revision.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
mlaurent edited the test plan for this revision.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
mlaurent edited the test plan for this revision.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
mlaurent edited the test plan for this revision.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
mlaurent added inline comments.
INLINE COMMENTS
> foldermodel.h:192
> +ScreenMapper* screenMapper() const;
> +void setScreenMapper(ScreenMapper* screenMapper);
> +
Coding style "space before *"
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
mlaurent updated this revision to Diff 21422.
mlaurent added a comment.
- Avoid twice loop here too
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8515?vs=21418=21422
BRANCH
dont_loop_twice
REVISION DETAIL
https://phabricator.kde.org/D8515
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8514
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
compile
REPOSITORY
R119 Plasma Desktop
BRANCH
use_const_method
REVISION DETAIL
https://phabricator.kde.org/D8514
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d5456864596f: Constify method (authored by
mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8514?vs=21417=21420
REVISION DETAIL
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
compile + launch autotest
REPOSITORY
R119 Plasma Desktop
BRANCH
add_more_autotest
REVISION DETAIL
https://phabricator.kde.org/D8517
mlaurent updated this revision to Diff 21424.
mlaurent added a comment.
- Start to create autotest for viewpropertiesmenu
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8517?vs=21423=21424
BRANCH
add_more_autotest
REVISION DETAIL
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
BRANCH
use_emit_keyword
REVISION DETAIL
https://phabricator.kde.org/D8513
AFFECTED FILES
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
BRANCH
fix_missing_emit_signal
REVISION DETAIL
https://phabricator.kde.org/D8516
AFFECTED FILES
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8516
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8513
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8515
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:25d2652a7bd2: Use emit as all other code use emit and not
Q_EMIT (authored by mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8513?vs=21416=21419
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c681a2f6ef63: Add unit tests for Folder View (authored by
mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8447?vs=21377=21415
REVISION DETAIL
mlaurent updated this revision to Diff 21426.
mlaurent added a comment.
- Add more autotest
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8517?vs=21424=21426
BRANCH
add_more_autotest
REVISION DETAIL
https://phabricator.kde.org/D8517
AFFECTED
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R104 KScreen
BRANCH
use_nullptr (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D8380
AFFECTED FILES
mlaurent updated this revision to Diff 21009.
mlaurent added a comment.
- Remove unused variable
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8380?vs=21007=21009
BRANCH
remove_unsed_variable
REVISION DETAIL
https://phabricator.kde.org/D8380
1 - 100 of 195 matches
Mail list logo