D5471: Prefer `plasmashell --version` to get Plasma version

2017-04-16 Thread Nathaniel Graham
ngraham added a comment. Thanks! I've implemented the requested changes. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D5471 To: ngraham, #plasma Cc: ltoscano, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5471: Prefer `plasmashell --version` to get Plasma version

2017-04-16 Thread Nathaniel Graham
ngraham retitled this revision from "https://bugs.kde.org/show_bug.cgi?id=377994; to "Prefer `plasmashell --version` to get Plasma version". ngraham edited the summary of this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D5471 To: ngraham, #plasma Cc:

D5471: https://bugs.kde.org/show_bug.cgi?id=377994

2017-04-16 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Makes `/usr/bin/plasmashell --version` the canonical source of truth for the Plasma version. Resolves

D5471: Prefer `plasmashell --version` to get Plasma version

2017-04-16 Thread Nathaniel Graham
ngraham added a comment. Gotcha. I'll contact the openSUSE KDE packagers and see what they have to say. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D5471 To: ngraham, #plasma Cc: fvogt, sitter, ltoscano, plasma-devel, spstarr, progwolff, lesliezhai,

D5471: Prefer `plasmashell --version` to get Plasma version

2017-04-16 Thread Nathaniel Graham
ngraham added a comment. Started a mailing list thread and filed https://bugzilla.opensuse.org/show_bug.cgi?id=1034345 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D5471 To: ngraham, #plasma Cc: fvogt, sitter, ltoscano, plasma-devel, spstarr, progwolff,

D7355: Properly change buttons hit area to enforce Fitts law when windows are quick-tiled and or vertically/horizontally maximiezed. At the same time, do not draw the window round corners.

2017-08-16 Thread Nathaniel Graham
ngraham added a comment. Yes, Hugo mentioned those current limitations in his comment at https://bugs.kde.org/show_bug.cgi?id=383434. Ideally we would want to resolve those, I think, but this is definitely progress and better than the status quo! REPOSITORY R31 Breeze REVISION DETAIL

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-08-19 Thread Nathaniel Graham
ngraham created this revision. ngraham added a project: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This diff will //very slightly// increase the text contrast in the default Breeze color scheme, while

D7355: Properly change buttons hit area to enforce Fitts law when windows are quick-tiled and or vertically/horizontally maximiezed. At the same time, do not draw the window round corners.

2017-08-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Now that I think about it, this is fine as-is. You actually //can// resize a tiled window (unlike a maximized window), so the cursor is giving you accurate information. If you click, the

D6813: Use customized font size for Digital Clock applet

2017-08-20 Thread Nathaniel Graham
ngraham added a comment. Any reasons not to land this or https://phabricator.kde.org/D6764? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6813 To: guoyunhe, #plasma_workspaces Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D6764: Add font size setting to the digital clock plasmoid

2017-08-20 Thread Nathaniel Graham
ngraham added a comment. Any reasons not to land this or https://phabricator.kde.org/D6813? REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-08-20 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-08-20 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-08-20 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D7957: Turn on frames around dock widgets and side panels by default

2017-09-23 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Breeze, VDG. ngraham added a project: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 384999 Draw borders around dock widgets and side panels by

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7957: Turn on frames around dock widgets and side panels by default

2017-09-23 Thread Nathaniel Graham
ngraham added a comment. I can remove the side panel change from this patch so we can focus on the usability issues resulting from having Dock frames disabled. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp,

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham
ngraham updated this revision to Diff 19839. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7957?vs=19836=19839 REVISION DETAIL https://phabricator.kde.org/D7957 AFFECTED FILES kstyle/breeze.kcfg To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp,

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham
ngraham retitled this revision from "Turn on frames around dock widgets and side panels by default" to "Turn on frames around dock widgets by default". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham
ngraham added a comment. As a 24 year Mac refugee, I agree with you that Finder's Tags implementation is excellent, and I think we should copy it. But the macOS Finder approach (everything scrollable in the same sidebar) is what was rejected in https://phabricator.kde.org/D7700. But getting

D7957: Turn on frames around dock widgets by default

2017-09-23 Thread Nathaniel Graham
ngraham added a comment. As I am pointing out, without frames the splitter is invisible, which is a clear usability issue. It also presents an aesthetic issue since when content on either side of the splitter is cut off, it looks like a visual glitch: F3923285: Cut off for no clear

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham added a comment. Excellent. Let's continue that discussion in a bug report I just filed to avoid losing it once I can commit the patch (hopefully later tonight): https://bugs.kde.org/show_bug.cgi?id=384936 REPOSITORY R134 Discover Software Store REVISION DETAIL

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham added a comment. I strongly believe that having a visible launch button is critical. The launch button may be meaningless fluff for me, and you, and other developers, but developers don't need to use GUI software center apps. We're not the intended audience. Discover targets

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham added a comment. I quite agree that we should make launching programs more discoverable in other ways--especially launching new programs ("I just installed this thingy; now where is it!?"). I've recently been thinking about that myself, in fact. In Ubuntu Unity, newly-installed

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham added a comment. Yes, I think that makes sense, but it wouldn't be quite enough, since Plasma ships with three UI options for the launcher button, and Application Dashboard is only one of them. Each one I think needs to prominently highlight recently-installed applications.

D7905: Remove launch feature from hamburger button

2017-09-20 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. ngraham added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 384914 Make the Launch

D7904: "Close Description" tooltip should instead say "Back"

2017-09-20 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. ngraham added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 384912 Change back button

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-20 Thread Nathaniel Graham
ngraham retitled this revision from "Remove launch feature from hamburger button" to "Remove launch feature from hamburger button and restore to the toolbar". REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7905 To: ngraham, apol,

D7906: Locate the Back button correctly in the toolbar

2017-09-20 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. ngraham added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 384913 Pad the Back

D7906: Locate the Back button correctly in the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. I suspected as much. Abandoning. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7906 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7904: "Close Description" tooltip should instead say "Back"

2017-09-21 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:4d9461f73b6c: Close Description tooltip should instead say Back (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7905 To: ngraham, apol, #discover_software_store Cc: colomar, jensreuterberg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-10-06 Thread Nathaniel Graham
ngraham planned changes to this revision. ngraham added a comment. I'll see if I can re-work the patch to add separators when frames are off, rather than turning on all frames by default. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg

D8232: Add option to center shadow

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. > ! In https://phabricator.kde.org/D8232#155370, @rpelorosso wrote: > For me, the screenshot you present just feels unbalanced, and trying to focus on the window content makes me feel dizzy. +1, me too. REPOSITORY R31 Breeze REVISION DETAIL

D8232: Add option to center shadow

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. FWIW, I gave some substantive, non-aesthetic reasons to at least center the shadow up-thread at https://phabricator.kde.org/D8232#155293 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc:

D8232: Add option to center shadow

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. Check out the large centered shadows in ElementaryOS. They're goregeous: F5430019: photos.jpg REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc:

D8232: Add option to center shadow

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. I completely agree, @rkflx. For just this reason, 10 years ago Apple changed the window shadows to be super super gigantic: https://arstechnica.com/gadgets/2007/10/mac-os-x-10-5/3/ F5429828: leopard-window.png It was a

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. Thanks for the patch! Can you change the bugzilla link to "BUG: 385794"? That special keyword makes the bug get marked as resolved once this goes in. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8324 To: Zren, ivan Cc: ngraham,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-16 Thread Nathaniel Graham
ngraham added a comment. I agree with @elvisangelaccio that we should just have a simple "Copy to clipboard" button--probably down at the bottom, aligned with the other buttons (on the left side seems right to me). It seems a bit silly to have a menu button with only two menu items in it,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-16 Thread Nathaniel Graham
ngraham added a comment. Also, please add "BUG: 366266" to the Summary so that https://bugs.kde.org/show_bug.cgi?id=366266 gets closed automatically when this goes in. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: sebas,

D8277: Background color for sidebar headers

2017-10-13 Thread Nathaniel Graham
ngraham added a comment. That begs the question: why even have headers, if they're unimportant, deliberately low-contrast, and duplicate existing status information shown elsewhere? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff,

D8277: Background color for sidebar headers

2017-10-13 Thread Nathaniel Graham
ngraham added a comment. I like it, FWIW. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8232: Add option to center shadow

2017-10-13 Thread Nathaniel Graham
ngraham added a comment. I want this. REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg Cc: ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. I agree that this should be a change, not a new option. Personally, in addition to aesthetics, I like the change because it fixes the following visual glitches: - Having a small shadow on the left side looks like a visual bug when you tile windows to sides of

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. Frankly the term "login manager" won't mean much to most people either, but I agree that we shouldn't hardcode the name of a particular one in the UI, since this is a modular component. "Configure Login Manager" sounds good to me. REPOSITORY R123 SDDM

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D8265 To: aspotashev, plasma-devel, davidedmundson, ngraham Cc: ngraham, davidedmundson, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. Hmm, probably should have waited until David could sign off too, since he had an outstanding request-for-changes review. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D8265 To: aspotashev, plasma-devel,

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. Oh right of course, because the title becomes the commit message. I'll remember in the future. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D8265 To: aspotashev, plasma-devel, davidedmundson, ngraham Cc: rkflx,

D5250: cursors: Make build scripts more generic; build more sizes

2017-09-07 Thread Nathaniel Graham
ngraham added a reviewer: subdiff. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5250 To: jamesl, #plasma, subdiff Cc: kvermette, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-08-27 Thread Nathaniel Graham
ngraham added a comment. OK, let's continue the discussion in the bug report. As I've mentioned, the additional high-contrast theme is unsatisfactory because it is radically different from Breeze, and quite unappealing. I believe iImproving the amount of text contrast by default would make

D5471: Prefer `plasmashell --version` to get Plasma version

2017-08-17 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Not needed. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D5471 To: ngraham, #plasma Cc: fvogt, sitter, ltoscano, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-09-03 Thread Nathaniel Graham
ngraham added a reviewer: VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-10-11 Thread Nathaniel Graham
ngraham added a comment. What's the status of this patch? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5928 To: subdiff, #kwin Cc: ngraham, leezu, behrmann, cfeck, graesslin, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, alexeymin, progwolff, lesliezhai,

D7913: Don't include the control over the bottom decoration

2017-09-27 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I tested this and it didn't actually fix 384913. There was no change when I recompiled Discover against a patched Kirigami. REPOSITORY R169 Kirigami REVISION DETAIL

D7913: Don't include the control over the bottom decoration

2017-09-27 Thread Nathaniel Graham
ngraham added a comment. Oh okay. Wonder what I did wrong. Will investigate. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7913 To: apol, #kirigami, mart, ngraham Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-17 Thread Nathaniel Graham
ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-17 Thread Nathaniel Graham
ngraham added a reviewer: KDE Applications. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, #kde_applications Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-17 Thread Nathaniel Graham
ngraham added a comment. Thanks. Would the "Plasma" review group be appropriate? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

2017-10-18 Thread Nathaniel Graham
ngraham added a comment. @ivan, does this look good? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8324 To: Zren, ivan Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8232: Add option to center shadow

2017-10-18 Thread Nathaniel Graham
ngraham added a comment. Sorry guys, didn't mean to offend. Though I currently favor the centered approach, I'm absolutely willing to be convinced out of it, if VDG can come up with a non-centered shadow that looks good and resolves the issues with insufficient depth and contrast on

D8232: Add option to center shadow

2017-10-18 Thread Nathaniel Graham
ngraham added a comment. More evidence for the superiority of the centered approach. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc: januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham,

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-20 Thread Nathaniel Graham
ngraham added a comment. I provided quite a few such studies and articles that support my view in https://bugs.kde.org/show_bug.cgi?id=381288: https://www.nngroup.com/articles/low-contrast/ http://universalusability.com/access_by_design/text/contrast.html

D7047: Wallpaper blur background filling effect feature

2017-10-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Personally I approve, in and of itself the feature looks fine. I think we should consider the UI though, as adding more background effects exacerbates an existing problem. But I won't

D8361: Add option to change Oxygen's windows decoration shadow intensity

2017-10-23 Thread Nathaniel Graham
ngraham added reviewers: broulik, aacid. ngraham added a subscriber: aacid. ngraham added a comment. https://phabricator.kde.org/tag/vdg/ is pretty quiet lately. Not much movement may mean that nobody is very excited, but it also means that nobody has a serious objection. :) Let's add a few

D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found

2017-11-15 Thread Nathaniel Graham
ngraham added a comment. Yeah, putting workarounds everywhere isn't so appealing. My preference would be for a Qt fix, otherwise we'll be playing whack-a-mole here forever. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5109 To: broulik, #plasma, hein Cc:

D8793: Fix using avatars from the gallery and from local files

2017-11-14 Thread Nathaniel Graham
ngraham added a comment. @davidedmundson, does your approval still hold with the new change to clean up /tmp? REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D8793 To: ngraham, apol, #plasma, mlaurent, davidedmundson Cc: plasma-devel, ZrenBot,

D8793: Fix using avatars from the gallery and from local files

2017-11-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 22374. ngraham added a comment. Consider any source file in /tmp/ to be a temp file that we should clear, so we don't leak files when run by kcmshell5 (or anything similar) REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D8793: Fix using avatars from the gallery and from local files

2017-11-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 22375. ngraham added a comment. Restricted Application added a subscriber: Dolphin. Rely on KF 5.40 and simplify the code a ton REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8793?vs=22374=22375 BRANCH

D8793: Fix using avatars from the gallery and from local files

2017-11-14 Thread Nathaniel Graham
ngraham removed a subscriber: Dolphin. REPOSITORY R128 User Manager BRANCH arcpatch-D8793_2 REVISION DETAIL https://phabricator.kde.org/D8793 To: ngraham, apol, #plasma, mlaurent, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8793: Fix using avatars from the gallery and from local files

2017-11-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 22377. ngraham added a comment. Restore correct diff REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8793?vs=22375=22377 BRANCH arcpatch-D8793_2 REVISION DETAIL https://phabricator.kde.org/D8793 AFFECTED

D9026: Sort list of installed apps alphabetically

2017-11-27 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sort list of installed apps alphrbetically, because sorting by rating count doesn't make much sense when

D9026: Sort list of installed apps alphabetically

2017-11-27 Thread Nathaniel Graham
ngraham edited the test plan for this revision. ngraham added a reviewer: Discover Software Store. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9026 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D9026: Sort list of installed apps alphabetically

2017-11-27 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9026 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6764: Add font size setting to the digital clock plasmoid

2017-11-28 Thread Nathaniel Graham
ngraham added a comment. Exactly: the default size is too big. I think if we just make the default size smaller, the complaints will go away. REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: mmustac, IlyaBizyaev, davidedmundson, ngraham, Zren, mart,

D6764: Add font size setting to the digital clock plasmoid

2017-11-26 Thread Nathaniel Graham
ngraham added a comment. Given how often this codebase's unmaintainability comes up, I think that would be very welcome! REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff,

D8939: Offset the scrollbar by the header size

2017-11-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic, that's perfect! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D8939 To: apol, #kirigami, mart, ngraham, abetts Cc: colomar,

D7246: Tooltips in Breeze theme

2017-11-22 Thread Nathaniel Graham
ngraham added a comment. Probably redo the patch so that it can apply to any theme. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

2017-11-22 Thread Nathaniel Graham
ngraham added a comment. After a lot of design work in https://phabricator.kde.org/tag/vdg/, we all agreed on the following: F5502756: photo_2017-11-22_08-59-07.jpg REPOSITORY R119 Plasma Desktop REVISION DETAIL

D7246: Tooltips in Breeze theme

2017-11-22 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

2017-11-22 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D8798#170879, @jriddell wrote: > on kcm touchpad I still get "No touchpad found" (on my KDE Slimbook), this isn't a surprise as your patch doesn't touch the touchpad kcm. Should it? That would be probably be handled by a

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

2017-11-23 Thread Nathaniel Graham
ngraham added a comment. Visually, it looks great to me! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8798: Add xf86-input-libinput support for X11 mouse backend.

2017-11-29 Thread Nathaniel Graham
ngraham added a comment. Or maybe just, "Pointer Acceleration:"? REPOSITORY R119 Plasma Desktop BRANCH mouse REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma, jriddell Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8798: Add xf86-input-libinput support for X11 mouse backend.

2017-11-29 Thread Nathaniel Graham
ngraham added a comment. On Ubuntu: sudo apt install xserver-xorg-input-libinput sudo apt remove xserver-xorg-input-mouse xserver-xorg-input-evdev xserver-xorg-input-[anything else] [reboot] Package names may be slightly different on non-Ubuntu distros. REPOSITORY R119

D9045: Better UI for the "Create a new vault" button

2017-11-29 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D9045 To: ivan, #plasma, cryptodude, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8787: Fix PWD dialog

2017-11-29 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787 To: cryptodude, #plasma, ivan Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9045: Better UI for the "Create a new vault" button

2017-11-29 Thread Nathaniel Graham
ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D9045 To: ivan, #plasma, cryptodude, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9045: Better UI for the "Create a new vault" button

2017-11-29 Thread Nathaniel Graham
ngraham added a comment. There's a visual glitch. The text escapes the boundaries of the button: F5518635: escaped.png I would still prefer this to always look like a button, like the Bluetooth widget. REPOSITORY R845 Plasma Vault REVISION

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

2017-11-29 Thread Nathaniel Graham
ngraham added a comment. On most touch platforms, only the last character in password prompts is revealed, one-at-a-time. It might make more sense to implement that than to keep the reveal button. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D9045: Better UI for the "Create a new vault" button

2017-11-30 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OK, if it's just me, then +1. I'll have to look into what's up with my Neon dev VM. REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL https://phabricator.kde.org/D9045

D8816: Show root items in kicker menu

2017-11-30 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8816 To: lopatin, #plasma Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-11-29 Thread Nathaniel Graham
ngraham added a comment. @broulik, any plans for this? REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8754: Baloo KCM text improvements

2017-11-27 Thread Nathaniel Graham
ngraham abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8754 To: ngraham, #vdg, #plasma, abetts Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D6764: Add font size setting to the digital clock plasmoid

2017-11-27 Thread Nathaniel Graham
ngraham added a comment. It also might be worth stepping back and asking why people want a size adjustment setting in the first place. I'm willing to bet that most of the time, it's because they think the default size is too big (because it is really big--way bigger than any of the other

D9178: Fix regression from KWin 5.9 regarding quick tiling

2017-12-04 Thread Nathaniel Graham
ngraham added a comment. Restricted Application edited projects, added Plasma; removed KWin. And now posting that comment appears to have done the same thing. Bizarre. REPOSITORY R108 KWin BRANCH fix-quick-tiling-maximize REVISION DETAIL https://phabricator.kde.org/D9178 To:

D9178: Fix regression from KWin 5.9 regarding quick tiling

2017-12-04 Thread Nathaniel Graham
ngraham added a comment. Restricted Application edited projects, added KWin; removed Plasma. I didn't; I just subscribed myself by clicking on the "Subscribe" button. No idea why that would remove Plasma... REPOSITORY R108 KWin BRANCH fix-quick-tiling-maximize REVISION DETAIL

D6764: Use a smaller font size for digital clock plasmoid

2017-12-15 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg, romangg Cc: romangg, mmustac, IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff, lesliezhai,

D9324: [Air theme] Add task bar progress graphic

2017-12-14 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-12-14 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-12-14 Thread Nathaniel Graham
ngraham added a comment. I found at least one user during my triaging of Task Manager bug who was sufficiently motivated to file a bug that this would resolve: https://bugs.kde.org/show_bug.cgi?id=361984 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-12-15 Thread Nathaniel Graham
ngraham added a reviewer: VDG. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma, #vdg Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

  1   2   3   4   5   6   7   8   9   10   >