D7014: Middle click on QSystemTrayIcon сauses context menu

McPain edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7014 To: McPain Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7014: Middle click on QSystemTrayIcon сauses context menu

McPain created this revision. McPain created this object with visibility "All Users". Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=382855 REPOSITORY R135 Integration for Qt

D7246: Tooltips in Breeze theme

McPain created this revision. McPain added projects: Plasma, Breeze. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=383040 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES

D7246: Tooltips

McPain updated this revision to Diff 22886. REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=22872=22886 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt

D7246: Tooltips

McPain retitled this revision from "Tooltips in Breeze theme" to "Tooltips". McPain changed the repository for this revision from R31 Breeze to R129 Window Decoration Library. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze,

D7246: Tooltips

McPain updated this revision to Diff 22872. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=17995=22872 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decorationbutton.cpp src/decorationbutton.h To: McPain,

D7246: Tooltips in Breeze theme

McPain added a comment. In https://phabricator.kde.org/D7246#158488, @ngraham wrote: > @McPain, any update? Not now. I don't get what to do: rewrite entire patch or write it for oxygen? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain,

D7246: Tooltips

McPain updated this revision to Diff 23866. REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23862=23866 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES kdecoration-5.11.3/CMakeLists.txt

D7246: Tooltips

McPain updated this revision to Diff 23857. REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23854=23857 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES kdecoration-5.11.3/CMakeLists.txt

D7246: Tooltips

McPain updated this revision to Diff 23854. McPain added a comment. Removed "bool trap" REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23794=23854 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES

D7246: Tooltips

McPain updated this revision to Diff 23862. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23857=23862 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES kdecoration-5.11.3/CMakeLists.txt kdecoration-5.11.3/src/CMakeLists.txt

D7246: Tooltips

McPain added a comment. One more question: can this cause a memory leak? void Workspace::showTooltip(const QString& text, const QPoint , bool show){ show ? QToolTip::showText(pos, text) : QToolTip::hideText(); } REPOSITORY R129 Window Decoration Library REVISION

D7246: Tooltips

McPain updated this revision to Diff 23794. McPain added a comment. Moved QToolTip::showText to KWin REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=22886=23794 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES

D7246: Tooltips

McPain edited the summary of this revision. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9506: milti-screen sleep fix

McPain planned changes to this revision. McPain added a comment. UPD: As the secondary monitor switches off, windows on it doesn't move to the primary REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: ngraham,

D7246: Tooltips

McPain updated this revision to Diff 25145. McPain marked 4 inline comments as done. McPain added a comment. const QString & cleanup CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25084=25145 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES

D7246: Tooltips

McPain updated this revision to Diff 25083. McPain marked 11 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23866=25083 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decoration.cpp

D9506: milti-screen sleep fix

McPain added a comment. In https://phabricator.kde.org/D9506#188239, @anthonyfieroni wrote: > @McPain can you provide some debug info from qCDebug(KSCREEN_XRANDR), i don't have multi screen setup but we can make better fix. https://pastebin.com/5gkn1qJU Standby

D7246: Tooltips

McPain updated this revision to Diff 25084. McPain added a comment. fix build CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25083=25084 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decoration.cpp

D9506: milti-screen sleep fix

McPain added a comment. In https://phabricator.kde.org/D9506#188118, @sebas wrote: > And I'm not sure they should. There's a difference between a monitor going to sleep and a configuration change of a multi screen setup. > > Can you please merge this quickly? I'd like to give it some

D9506: milti-screen sleep fix

McPain added a comment. I noticed that "shutdown" sequence is not the same as "standby" one. Shutdown for secondary: disconnect -> remove crtc -> connect -> assign crtc Standby for secondary: disconnect -> connect (why?) -> remove crtc -> assign crtc REPOSITORY R110 KScreen

D9506: milti-screen sleep fix

McPain added a comment. In https://phabricator.kde.org/D9506#193271, @sebas wrote: > Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review. Yesterday I

D9506: milti-screen sleep fix

McPain added a comment. UPD: I found monitor combination that makes KScreen works: AOC(hdmi)-iiyama(D-SUB) If I swap monitors, KSCeen doesn't work (noticed it past friday evening) REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas,

D9506: milti-screen sleep fix

McPain abandoned this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7246: Tooltips

McPain updated this revision to Diff 25539. McPain added a comment. Fix autotests build CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25145=25539 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt autotests/mockclient.cpp

D10338: Don't show tooltips for inactive windows

McPain accepted this revision. McPain added a comment. This revision is now accepted and ready to land. This commit looks good and it works just as planned REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10338 To: broulik, #plasma, graesslin,

D7246: Tooltips

McPain added inline comments. INLINE COMMENTS > graesslin wrote in decoratedclientprivate.h:79-80 > If we add pure virtuals we need to increase the so version of the private > libraru. I need to avoid sover increasing, right? REPOSITORY R129 Window Decoration Library REVISION DETAIL

D9506: milti-screen sleep fix

McPain created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 379474 REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 AFFECTED FILES

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39901. McPain marked 3 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39897=39901 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain created this revision. McPain added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 397537 Earlier plasmashell assumed that you'll get free space info immediately

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39897. McPain added a comment. Removed useless debug string REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39896=39897 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310535 , @davidedmundson wrote: > Thanks for looking into this. > > Whilst this looks fine, we have a more standard abstraction layer for async IO via KIO. > There's a FileSystemFreeSpaceJob which

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310633 , @broulik wrote: > Also beware that `bool SolidDeviceEngine::updateSourceEvent` is currently supposed to return `true` Who will use that `true`? I didn't found any places where that value is

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310633 , @broulik wrote: > Might not be an issue as you call `setData` anyway but just something I want you to keep in mind for testing. I REVISION DETAIL https://phabricator.kde.org/D14895 To:

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310633 , @broulik wrote: > Might not be an issue as you call `setData` anyway but just something I want you to keep in mind for testing. something like setData(udi, I18N_NOOP("Free Space"),

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39929. McPain added a comment. Used KIO::FileSystemFreeSpaceJob CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39901=39929 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > anthonyfieroni wrote in soliddeviceengine.cpp:564 > You can remove it, see below. What if it creates another job working on the same path? The purpose is "check if nobody is working on path", not "save the timer pointer" > anthonyfieroni wrote

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39933. McPain marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39929=39933 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39934. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39933=39934 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/soliddevice/soliddeviceengine.cpp

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in soliddeviceengine.cpp:560 > Sure, it /might/ work, but you're still fetching a random window N seconds > after a user event. > > I don't see how we can know that will result in correct behaviour. Any ideas how to do it

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in soliddeviceengine.cpp:555 > not sure you need this timer > > 1. You should still get the job finishing with error ERR_SERVER_TIMEOUT. > (untested, but the protocol manager in the client does have some stuff doing > this)

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in soliddeviceengine.cpp:555 > I think you can just move the notification to > > connect(job, ::FileSystemFreeSpaceJob::result, ...) { > > if (job->error() == ERR_SERVER_TIMEOUT) { > > > > } > } > > but I haven't

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. ping? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14064 To: McPain, broulik Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

McPain added a comment. In D15247#320523 , @ngraham wrote: > Thanks, the patch applies now. > > Can you verify that this works for you? When I apply the patch (and reboot for good measure), I still don't see tooltips for items whose names

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a subscriber: ngraham. McPain added a comment. In D14895#320987 , @ngraham wrote: > +1 for the concept. No opinion about the notification, but I think it's fine. Removing myself as a reviewer since I don't feel qualified to offer a

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain created this revision. McPain added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 398356 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15333

D15247: Show tooltips in krunner

McPain added a comment. In D15247#319839 , @ngraham wrote: > The patch does not apply because of an extraneous `milou` in the path for your diff: > > Consider setting up `arc`; it makes the patch submission process so much simpler and less

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. Just in case, I don't have commit access REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 40973. McPain marked 12 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=40923=40973 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt

D15423: System settings: make date/time format preview consistent

McPain added a comment. Before: F6252186: изображение.png After: F6252262: изображение.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: ngraham,

D15423: System settings: make date/time format preview consistent

McPain created this revision. McPain added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 398493 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. In D14064#322643 , @davidedmundson wrote: > Urgh. Just read the code. > > We don't reset when we type a new letter. To do so would have a jumpy ui. Instead we reset when we get results back. > > That leaves a

D14063: KRunner Dictionary can't find anything

McPain created this revision. McPain added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=390776 REPOSITORY R114

D14064: Dictionary haven't enough time to complete query before resetting by milou

McPain created this revision. McPain added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=390776 REPOSITORY R112

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. In D14064#291125 , @broulik wrote: > I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I

D16038: Allow dictionary runner to search multiple times

McPain created this revision. McPain added a reviewer: jriddell. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY Any time we search a word definition we add a source to our match engine but we never remove it.

D15247: Show tooltips in krunner

McPain added a comment. Anybody? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

McPain added a comment. Any ideas how to fix the bugs I mentioned above? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D15247: Show tooltips in krunner

McPain added a comment. Found out that sometimes displayed text appears to be elided (not always reproducible) Resolution: 1920x1080, dpi: 142 F6324374: Screenshot_20181012_165807.png REPOSITORY R112 Milou REVISION DETAIL

D15247: Show tooltips in krunner

McPain added a comment. Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386 } REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: ngraham,

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 40923. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39934=40923 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/soliddevice/soliddeviceengine.cpp

D15247: Show tooltips in krunner

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY In case of something long in krunner you can't read the whole string because of one line restriction and fixed krunner width.

D15247: Show tooltips in krunner

McPain updated this revision to Diff 40956. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15247?vs=40924=40956 REVISION DETAIL https://phabricator.kde.org/D15247 AFFECTED FILES lib/qml/ResultDelegate.qml To: McPain, #plasma, broulik, ngraham Cc: ngraham, plasma-devel, ragreen,

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain added inline comments. INLINE COMMENTS > main.qml:138 > > -readonly property int thickness: > Math.ceil(Math.min(parent.width, parent.height) / units.iconSizes.small) > We need to make thickness independent from length. REVISION DETAIL

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:111 > Please explain the rationale behind this. > > Especially the spacer.width being divided by 2 in the second part of the > statement. > Especially the spacer.width being divided by 2 in the second part of the

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain updated this revision to Diff 42413. McPain added a comment. (height * 2) + spacer.height -> (height - spacer.height) / 2 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15333?vs=41157=42413 REVISION DETAIL https://phabricator.kde.org/D15333 AFFECTED FILES

D18182: Fix new file creation leading to dupe items on a fresh view

McPain added inline comments. INLINE COMMENTS > fvogt wrote in foldermodel.cpp:154 > It doesn't use Qt::QueuedConnection explicitly - is the comment wrong or is > it done implicitly? According to e94888701 and

D17217: Implement free memory notifier

McPain added a comment. In D17217#378768 , @davidedmundson wrote: > > Thanks. Any examples in KDE? I can't implement this from scratch right now. > > There is not, it would requires writing new C code. > It's something I can help with.

D18182: Fix new file creation leading to dupe items on a fresh view

McPain requested changes to this revision. McPain added a comment. This revision now requires changes to proceed. That's what I got with this patch. F6563817: изображение.png Please remove Qt::QueuedConnection from both connections. Additionally,

D17508: Simplify perStripe definition

McPain created this revision. McPain added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY We can get rid of double-checking of > gridView.flow == GridView.FlowLeftToRight because

D17217: Implement free memory notifier

McPain added a comment. Anybody? REVISION DETAIL https://phabricator.kde.org/D17217 To: McPain, broulik, #vdg, ngraham Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17707: FolderView: set sort mode to unserted after catching insert signal

McPain created this revision. McPain added reviewers: hein, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY When new item is created, the initMaps() is called. Positioner will init his maps

D17809: Check icon positions after move

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 402574 When we're moving a bunch of icons to the area which is already busy, we didn't check whether we're moving icons to

D17809: Check icon positions after move

McPain updated this revision to Diff 48238. McPain added a comment. Fixed condition mistake CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17809?vs=48220=48238 REVISION DETAIL https://phabricator.kde.org/D17809 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp

D17809: Check icon positions after move

McPain added inline comments. INLINE COMMENTS > positioner.cpp:418 > + */ > +while ((!isBlank(to) && from != to) || toIndices.contains(to)) { > to++; AFAIK, the first part of condition is "check if `to` is blank and if it's not, check whether we're not

D17217: Implement free memory notifier

McPain added a comment. In D17217#367842 , @davidedmundson wrote: > There's also an alternative that I'd like to suggest: > According to https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt there's a system called "memory pressure"

D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY If ksysguard was invoked from freememorynotifier directly, every process is displayed with its own kill button. In most

D17217: Implement free memory notifier

McPain updated this revision to Diff 46892. McPain added a comment. Default limit: 25% -> 10% Fix typos Auto detect swap, removed "includeSwap" setting KSysGuard: show kill button (implemented in D17366 ) CHANGES SINCE LAST UPDATE

D15423: System settings: make date/time format preview consistent

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmformats.cpp:322 > I don't understand, why is this sometimes empty? Sorry for delayed reply. In KCMFormats::initCombo we add locales to combo boxes. First we add a QString() for "No change" option and then we add all

D17217: Implement free memory notifier

McPain added a comment. In D17217#367545 , @abetts wrote: > Is having this feature an optional feature? Can it be turned off? I'll make the notification "disableable" tomorrow REPOSITORY R120 Plasma Workspace REVISION DETAIL

D17217: Implement free memory notifier

McPain added a comment. In D17217#367525 , @ngraham wrote: > Thanks for all the work! > > ...But is this actually useful or actionable for the majority of users? Free space is a fairly understandable concept: if you run out, you need to

D17217: Implement free memory notifier

McPain created this revision. McPain added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY FreeMemoryNotifier will warn when free RAM is running out. By default, it is 25% without swap

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain added inline comments. INLINE COMMENTS > mart wrote in main.qml:111 > can you put this in the commit description as well? How to get commit access? REVISION DETAIL https://phabricator.kde.org/D15333 To: McPain, #plasma, ngraham Cc: mart, davidedmundson, cfeck, plasma-devel, ragreen,

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

McPain added a comment. In D17689#379900 , @hein wrote: > Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, but I'll try to make sense of this in early 2019. ping? REPOSITORY R119 Plasma Desktop REVISION

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

McPain added a comment. In D17689#391265 , @hein wrote: > Here's my take: https://phabricator.kde.org/D18182 is this intentional you mentioned *this* review, not https://phabricator.kde.org/D17707? REPOSITORY R119 Plasma Desktop

D18182: Fix new file creation leading to dupe items on a fresh view

McPain accepted this revision. McPain added a comment. This revision is now accepted and ready to land. It works, thanks. Removed D17689 and D17707 patches so I close then REPOSITORY R119 Plasma Desktop BRANCH

D17689: Positioner: call initMaps even if m_enabled == false

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY see BUG: 401023 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17689 AFFECTED FILES

D18979: foldermodel: store information about screen used

McPain added a comment. In D18979#441799 , @hein wrote: > Thanks! Do you need help landing this? Any instructions about "how to commit an accepted revision?" REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18979: foldermodel: store information about screen used

McPain added a comment. In D18979#428230 , @hein wrote: > Can you explain more what this is trying to achieve / what it solves with an example? https://bugsfiles.kde.org/attachment.cgi?id=117630 REPOSITORY R119 Plasma Desktop

D18979: foldermodel: store information about screen used

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 401464 According to FolderModel::filterAcceptsRow code, it is possible that folderview is used by containment but not

D18979: foldermodel: store information about screen used

McPain requested review of this revision. McPain added a comment. Seems like I can't use distinct screen mapping for each activity yet REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18979 To: McPain, broulik, sebas Cc: plasma-devel, jraleigh, GB_2, ragreen,

D18182: Fix new file creation leading to dupe items on a fresh view

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in foldermodel.cpp:170 > Also I don't think I understand this: > > - Delay this via queued connection, such that the row is available and can be > mapped > > at the point of rowsInserted() the row should be available, If not

D18182: Fix new file creation leading to dupe items on a fresh view

McPain added a comment. Somebody review this for me, please, I'm too far away from actually testing it REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18182 To: hein, #plasma, McPain Cc: davidedmundson, fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D21497: fill layouts from X server when there are no layouts in config

McPain added a comment. In D21497#472546 , @ngraham wrote: > Looks good and works for me, though I'm not super familiar with this code so I'd appreciate a review from @hein or @broulik. I'll land this tomorrow if everything will be still

D15247: Show tooltips in krunner

McPain added a comment. In D15247#472461 , @ngraham wrote: > IMO what's seen in your screenshot is not useful behavior. If the full text fits in the regular UI, there's no need to show a tooltip; it's just redundant. I see. Somehow

D21497: fill layouts from X server when there are no layouts in config

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a14258a0cd60: fill layouts from X server when there are no layouts in config (authored by McPain). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58932. McPain set the repository for this revision to R119 Plasma Desktop. McPain added a comment. updated paths REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58911=58932 REVISION DETAIL

D15247: Show tooltips in krunner

McPain added a comment. In D15247#472255 , @ngraham wrote: > I am still not actually getting any tooltips when I hover over an elided entry. > > F6860589: Screenshot_20190530_114108.png strange

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58950. McPain added a comment. foreach -> for use const CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58932=58950 REVISION DETAIL https://phabricator.kde.org/D21497 AFFECTED FILES kcms/keyboard/keyboard_config.cpp

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58951. McPain added a comment. style: for CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58950=58951 REVISION DETAIL https://phabricator.kde.org/D21497 AFFECTED FILES kcms/keyboard/keyboard_config.cpp

  1   2   >