Review Request 126630: Do not unconditionally enable logging

2016-01-05 Thread Peter Wu
brightness levels again. (Result: no log spam!) Thanks, Peter Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126630: Do not unconditionally enable logging

2016-01-05 Thread Peter Wu
. (Result: `RRNotify_OutputProperty` messages in `journalctl`) 4. Add the following lines to qtlogging.ini: ``` kscreen.debug=false kscreen.xrandr.debug=false kscreen.xcb.helper.debug=false ``` 5. killall kscreen_backend_launcher 6. Change brightness levels again. (Result: no log spam!) Thanks, Peter

Re: Review Request 126630: Do not unconditionally enable logging

2016-01-06 Thread Peter Wu
matically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126630/#review90638 --- On Jan. 5, 2016, 1:08 p.m., Peter Wu wrote: > > --- > This is an automat

Re: Review Request 126630: Do not unconditionally enable logging

2016-03-29 Thread Peter Wu
marked as submitted. Review request for Plasma, Solid, Daniel Vrátil, and Sebastian Kügler. Changes --- Submitted with commit 649dda5e8c8f683f1650b4cf609fe094d22e3290 by Albert Astals Cid on behalf of Peter Wu to branch Plasma/5.6. Repository: libkscreen Description --- Logging

Re: Review Request 128761: Fix crash on exit

2016-10-04 Thread Peter Wu
- Peter --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/#review98712 --- On Aug. 27, 2016, 11:12 a.m., Peter

Re: Review Request 128760: Fix crash on exit

2016-09-21 Thread Peter Wu
ail. To reply, visit: https://git.reviewboard.kde.org/r/128760/#review99244 --- On Aug. 27, 2016, 11:04 a.m., Peter Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128760: Fix crash on exit

2016-09-21 Thread Peter Wu
marked as submitted. Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da Costa. Changes --- Submitted with commit 23e54baa3cf1258b5d105c22609103d13868583f by Hugo Pereira Da Costa on behalf of Peter Wu to branch Plasma/5.7. Bugs: 356940 https://bugs.kde.org

Re: Review Request 128760: Fix crash on exit

2016-09-16 Thread Peter Wu
fix. Correct and test patch in this way > > > > QPointer style = new Style; > > > > Below unchanged, so when QPointer got delete it hold nullptr by itself > > and delete will be safe. > > Peter Wu wrote: > This does not work since the int

Re: Review Request 128760: Fix crash on exit

2016-08-27 Thread Peter Wu
no longer crashes. Tested with Qt 5.7.0. Thanks, Peter Wu

Re: Review Request 128761: Fix crash on exit

2016-08-27 Thread Peter Wu
` (an invalid option that triggers `exit(1)`) and observe a heap-use-after free similar to the one reported in the bug. Apply this patch, rebuild oxygen and notice that the crash is fixed. Also tested with "Testcase (ASAN)" from bug 356940, crash is also gone. Thanks, Peter Wu

Re: Review Request 128761: Fix crash on exit

2016-08-27 Thread Peter Wu
it.reviewboard.kde.org/r/128761/#review98709 --- On Aug. 27, 2016, 11:12 a.m., Peter Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Peter Wu
that required the use of this? It is not documented by Qt. - Peter --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/#review98667 ---------

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Peter Wu
fix. Correct and test patch in this way > > > > QPointer style = new Style; > > > > Below unchanged, so when QPointer got delete it hold nullptr by itself > > and delete will be safe. > > Peter Wu wrote: > This does not work since the int

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Peter Wu
fix. Correct and test patch in this way > > > > QPointer style = new Style; > > > > Below unchanged, so when QPointer got delete it hold nullptr by itself > > and delete will be safe. > > Peter Wu wrote: > This does not work since the int

Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-25 Thread Peter Wu
breakpoint on Breeze::StylePlugin::create that the second instance is called through QProxyStyle. Thanks, Peter Wu

Re: Review Request 128761: Fix crash when using QProxyStyle and exit()

2016-08-25 Thread Peter Wu
LD_LIBRARY_PATH=... QT_PLUGIN_PATH=... wireshark -o` (an invalid option that triggers `exit(1)`) and observe a heap-use-after free similar to the one reported in the bug. Apply this patch, rebuild oxygen and notice that the crash is fixed. Thanks, Peter Wu

Review Request 128761: Fix crash when using QProxyStyle and exit()

2016-08-25 Thread Peter Wu
LD_LIBRARY_PATH=... QT_PLUGIN_PATH=... wireshark -o` (an invalid option that triggers `exit(1)`) and observe a heap-use-after free similar to the one reported in the bug. Apply this patch, rebuild oxygen and notice that the crash is fixed. Thanks, Peter Wu

Re: Review Request 128761: Fix crash on exit

2016-10-11 Thread Peter Wu
similar to the one reported in the bug. Apply this patch, rebuild oxygen and notice that the crash is fixed. Also tested with "Testcase (ASAN)" from bug 356940, crash is also gone. Thanks, Peter Wu