Re: kcm-touchpad in plasma 5.2?

Hi Jonathan, On Thu, Dec 11, 2014 at 3:28 PM, Jonathan Riddell j...@jriddell.org wrote: Morning, I'm looking at the requirements for Plasma to become a complete desktop and touchpad configuration is currently missing. You've done the port of kcm-touchpad to KF5, do you think it should be

Re: Review Request 122331: Add libinput support to kcm-touchpad

/122331/#review75195 --- On Jan. 30, 2015, 7:41 p.m., Rajeesh K Nambiar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331

Re: Touchpad KCM - was - Re: Plasma 5.2 bits for kdereview

On Thu, Jan 1, 2015 at 8:39 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Thu, Jan 1, 2015 at 4:50 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 19 de desembre de 2014, a les 17:27:01, Jonathan Riddell va escriure: Touchpad KCM, ported to KF5 by Rajeesh K Nambiar

Re: Review Request 122331: Add libinput support to kcm-touchpad

/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/ Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

. - Rajeesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75896 --- On Jan. 30, 2015, 7:41 p.m., Rajeesh K Nambiar

Re: Review Request 122331: Add libinput support to kcm-touchpad

On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: Built my X with libinput support. Without this patch I get an erro, with this I get at least some options, though quite a few seemed disabled as they're just not available in libinput. Rajeesh K Nambiar wrote: Indeed

Re: Review Request 122331: Add libinput support to kcm-touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75939 --- On Feb. 12, 2015, 6:34 p.m., Rajeesh K Nambiar wrote: --- This is an automatically

Review Request 122331: Add libinput support to kcm-touchpad

, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: Built my X with libinput support. Without this patch I get an erro, with this I get at least some options, though quite a few seemed disabled as they're just not available in libinput. Rajeesh K Nambiar wrote: Indeed

Re: Re: kcm-touchpad in plasma 5.2?

On Sat, Jan 3, 2015 at 7:56 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Sat, Jan 3, 2015 at 7:07 PM, Rajeesh K Nambiar rajeeshknamb...@gmail.com wrote: On Thu, Dec 11, 2014 at 4:30 PM, David Edmundson da...@davidedmundson.co.uk wrote: In general this looks OK, there's some

Re: Re: kcm-touchpad in plasma 5.2?

On Thu, Dec 11, 2014 at 4:30 PM, David Edmundson da...@davidedmundson.co.uk wrote: In general this looks OK, there's some useful features and I can see myself using this. I'd very much like it to become part of Plasma. I gave it a review and made some notes below. Thanks for the review. I

Re: Review Request 122899: Set directory mimetype for smb protocol

:18 p.m., Rajeesh K Nambiar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/ --- (Updated March 10, 2015, 10:18 p.m

Re: Review Request 122899: Set directory mimetype for smb protocol

-d247-4686-a44b-73b6043cbb57__smb-folder-before.png samba folder after https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list

Review Request 122899: Set directory mimetype for smb protocol

://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 345547] Caps Lock warning is always on with Breeze SDDM theme

https://bugs.kde.org/show_bug.cgi?id=345547 Rajeesh K Nambiar rajeeshknamb...@gmail.com changed: What|Removed |Added CC||rajeeshknamb

Re: Review Request 122319: Set global shortcuts for touchpad enable/disable/toggle

Diffs - src/kded/kdedactions.cpp ca32834 Diff: https://git.reviewboard.kde.org/r/122319/diff/ Testing --- Build Fedora RPMS against Plasma 5.2, default global shortcuts for touchpad are set. Thanks, Rajeesh K Nambiar ___ Plasma-devel

Review Request 122319: Set global shortcuts for touchpad enable/disable/toggle

/diff/ Testing --- Build Fedora RPMS against Plasma 5.2, default global shortcuts for touchpad are set. Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122319: Set global shortcuts for touchpad enable/disable/toggle

://git.reviewboard.kde.org/r/122319/#review75010 --- On Jan. 29, 2015, 10:56 p.m., Rajeesh K Nambiar wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123621: Fix reverse scroll setting in Mouse KCM

with dolphin, konsole etc) and gtk+ apps like firefox here - using synaptics driver. Also see the discussion in bug report https://bugs.kde.org/show_bug.cgi?id=342929 where only KDE4 apps are reported to be affected. Could you share more details? - Rajeesh K Nambiar On May 4, 2015, 9:10 a.m., Yue Liu

Review Request 124172: Fix touchpad backend initialization

://bugzilla.redhat.com/show_bug.cgi?id=1199825 This missed 5.3.2 by a whisker :-( Diffs - kcms/touchpad/src/backends/x11/xlibbackend.cpp 2acb162 Diff: https://git.reviewboard.kde.org/r/124172/diff/ Testing --- Built Fedora 22 RPMS, locally tested. Thanks, Rajeesh K Nambiar

Re: Review Request 124172: Fix touchpad backend initialization

: https://git.reviewboard.kde.org/r/124172/diff/ Testing --- Built Fedora 22 RPMS, locally tested. Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124172: Fix touchpad backend initialization

marked as submitted. Review request for Plasma and Martin Gräßlin. Changes --- Submitted with commit 3f2e6bd31e0cd7355f95450cdc185e4d37ed2c16 by Rajeesh K Nambiar to branch master. Bugs: 344958 and 349214 https://bugs.kde.org/show_bug.cgi?id=344958 https://bugs.kde.org

Re: Review Request 124294: [kcms/touchpad] Only create X11 backend if we are on X11 platform

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124294/#review82233 --- Ship it! Ship It! - Rajeesh K Nambiar On July 8, 2015, 12

[Differential] [Request, 1 line] D2754: Touchpad KDED: fix metadata warning

knambiar created this revision. knambiar added a reviewer: Plasma. knambiar set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Get rid of kded warning:

[Differential] [Commented On] D2754: Touchpad KDED: fix metadata warning

knambiar added a comment. Thanks for the review, but actually I am not convinced that this gets rid of the warning message. Sifting through the KF5 porting notes, I am not sure how this should be handled -- kded tries to load the plugin with just "name" and if not found it looks for

[Differential] [Commented On] D3617: [Touchpad KCM] New KWin Wayland version

knambiar added a comment. A query about the dbus calls in findTouchpads(). INLINE COMMENTS > kwinwaylandbackend.cpp:72 > +QStringList devicesSysNames; > +QVariant reply = m_deviceManager->property("devicesSysNames"); > +if (reply.isValid()) { Just wondering whether these calls

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

knambiar added a comment. Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng,

D2754: Touchpad KDED: fix metadata warning

knambiar added a comment. In https://phabricator.kde.org/D2754#143319, @aacid wrote: > So what's the status of this? needs landing? needs help? Thanks for offering the help, Albert! Trouble here is that the error is not reproducible. The last message in my logs is from Sep 04

D2754: Touchpad KDED: fix metadata warning

knambiar updated this revision to Diff 19300. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2754?vs=6670=19300 REVISION DETAIL https://phabricator.kde.org/D2754 AFFECTED FILES kcms/touchpad/src/kded/kded_touchpad.desktop To: knambiar, #plasma,

D13141: Touchpad KCM Redesign Using Kirigami

knambiar added a comment. > - "Two tap right, three middle" -> "Tap twice for right-click; three times for middle-click" > - "Two tap middle, three right" -> "Tap twice for middle-click; three times for right-click" May be clearer to use: “Two tap right, three middle” → “Tap two

D10498: Workaround the touchpad toggle button not working

knambiar added a comment. +1. I've also spent some time debugging this issue, and was perplexed why the property change event doesn't propagate. This fix should be backported if possible. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D10498 REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a comment. > Got to Know a lot about how X works with input handling. XD I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D REPOSITORY R119 Plasma Desktop REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a subscriber: jriddell. knambiar added a comment. >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D > > Hey, I would be happy to take that responsibility. Fantastic.

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a comment. > Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product. @atulbi Congratulations, you’re now the

D19011: Thunderbolt KCM and KDED module

knambiar added a comment. > How about "Trusted" for remembered devices that are authorized, and "Prohibited" for remembered devices that are not authorized? > > "Remembered" would work only if it's clear what's being remembered (i.e. the settings). Maybe it could say "Settings

D21915: Fix crash in the touchpad kded

knambiar added a comment. In D21915#482145 , @aacid wrote: > The other question is if "enabled" was ever the correct atom to check for > > libinput Tapping Enabled I'm fairly sure we were checking for `libinput Tapping Enabled` atom

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

knambiar added a comment. The `Scale` slider UI position is different in X11 and Wayland. Is this intentional? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin Cc: knambiar, broulik, filipf, plasma-devel, LeGast00n, jraleigh,